Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/#review51045 --- Ship it! Ship It! - David Robinson On Aug. 19, 2014, 10:51 p.m.,

Review Request 24871: Converting perform_maintenance_hosts into host_drain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/ --- Review request for Aurora, Joe Smith and Mark Chu-Carroll. Bugs: AURORA-43

Re: Review Request 24662: Implementing job update "get" thrift APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24662/ --- (Updated Aug. 19, 2014, 6:56 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 24662: Implementing job update "get" thrift APIs.

> On Aug. 19, 2014, 6:37 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 1284 > > > > > > Push the requireNonNull out to the first line to avoid e

Re: Review Request 24662: Implementing job update "get" thrift APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24662/#review51008 --- Ship it! src/main/java/org/apache/aurora/scheduler/thrift/Schedule

Re: Review Request 24835: Implementing pause/resume/abort APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24835/ --- (Updated Aug. 19, 2014, 6:33 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 24752: combine finalization_wait when combining tasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24752/#review50997 --- src/main/python/apache/thermos/config/schema_helpers.py

Re: Review Request 24827: Add a pubsub event adapter to the JobUpdateController.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24827/ --- (Updated Aug. 19, 2014, 5:43 p.m.) Review request for Aurora and Maxim Khutorne

Re: Review Request 24827: Add a pubsub event adapter to the JobUpdateController.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24827/ --- (Updated Aug. 19, 2014, 5:49 p.m.) Review request for Aurora and Maxim Khutorne

Re: Review Request 24827: Add a pubsub event adapter to the JobUpdateController.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24827/#review50995 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 19, 2014, 5:43 p.m

Re: Review Request 24852: Add command output tests for "job create", "job killall", "job kill"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24852/#review50994 --- Ship it! Ship It! - David McLaughlin On Aug. 19, 2014, 3:22 p.m.

Re: Review Request 24835: Implementing pause/resume/abort APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24835/#review50992 --- Ship it! LGTM mod separation of concerns on JobUpdateStore.Mutable.

Re: Review Request 24852: Add command output tests for "job create", "job killall", "job kill"

> On Aug. 19, 2014, 3:47 p.m., Maxim Khutornenko wrote: > > src/test/python/apache/aurora/client/cli/test_create.py, lines 233-234 > > > > > > This is the existing test, right? Diff shows it in green for some > > reas

Re: Review Request 24852: Add command output tests for "job create", "job killall", "job kill"

> On Aug. 19, 2014, 11:47 a.m., Maxim Khutornenko wrote: > > src/test/python/apache/aurora/client/cli/test_create.py, lines 233-234 > > > > > > This is the existing test, right? Diff shows it in green for some > > rea

Re: Review Request 24827: Add a pubsub event adapter to the JobUpdateController.

> On Aug. 19, 2014, 3:58 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, > > line 74 > > > > > > A TODO to follow up on "deleted" flag removal? Removed no

Re: Review Request 24852: Add command output tests for "job create", "job killall", "job kill"

> On Aug. 19, 2014, 3:47 p.m., Maxim Khutornenko wrote: > > src/test/python/apache/aurora/client/cli/test_create.py, lines 233-234 > > > > > > This is the existing test, right? Diff shows it in green for some > > reas

Re: Review Request 24852: Add command output tests for "job create", "job killall", "job kill"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24852/#review50981 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 19, 2014, 3:22 p.m

Re: Review Request 24852: Add command output tests for "job create", "job killall", "job kill"

> On Aug. 19, 2014, 11:47 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 119-121 > > > > > > General question: what happens to a message returned by the response in > > case

Re: Review Request 24827: Add a pubsub event adapter to the JobUpdateController.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24827/#review50976 --- src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControll

Re: Review Request 24852: Add command output tests for "job create", "job killall", "job kill"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24852/#review50974 --- src/main/python/apache/aurora/client/cli/jobs.py

Review Request 24852: Add command output tests for "job create", "job killall", "job kill"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24852/ --- Review request for Aurora, David McLaughlin and Maxim Khutornenko. Bugs: aurora