Re: Review Request 25529: Add a controller for job updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25529/ --- (Updated Sept. 16, 2014, 12:39 a.m.) Review request for Aurora, Joshua Cohen, K

Re: Review Request 25529: Add a controller for job updates.

> On Sept. 15, 2014, 11:13 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterFactory.java, > > line 61 > > > > > > TODO to use AssistedInject to generate this factory here

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 16, 2014, 12:32 a.m.) Review request for Aurora, Joshua Cohen, K

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 16, 2014, 12:30 a.m.) Review request for Aurora, Joshua Cohen, K

Re: Review Request 25529: Add a controller for job updates.

> On Sept. 15, 2014, 11:13 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 1368 > > > > > > If I'm reading correctly there's no need to make thi

Re: Review Request 25671: Instruct thrift to generate private fields in java.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25671/#review53435 --- Ship it! Ship It! - Zameer Manji On Sept. 15, 2014, 4:02 p.m., B

Re: Review Request 25529: Add a controller for job updates.

> On Sept. 15, 2014, 11:01 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 1368 > > > > > > Is this a leftover from some intermediate work? Not

Re: Review Request 25671: Instruct thrift to generate private fields in java.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25671/#review53432 --- Ship it! Ship It! - Kevin Sweeney On Sept. 15, 2014, 4:02 p.m.,

Re: Review Request 25529: Add a controller for job updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25529/#review53389 --- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInt

Review Request 25671: Instruct thrift to generate private fields in java.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25671/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description -

Re: Review Request 25529: Add a controller for job updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25529/#review53425 --- Ship it! Looks good to me, just a few minor questions/nits: src/m

Re: Review Request 25673: Fixing broken test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25673/#review53428 --- Ship it! Ship It! - Bill Farner On Sept. 15, 2014, 10:56 p.m., M

Re: Review Request 25673: Fixing broken test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25673/#review53427 --- Ship it! Ship It! - Joe Smith On Sept. 15, 2014, 3:56 p.m., Maxi

Review Request 25673: Fixing broken test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25673/ --- Review request for Aurora, Joe Smith and Bill Farner. Repository: aurora Desc

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review53422 --- Ship it! Thanks for adding those subset-related comments, clearer n

Re: Review Request 25255: Implement server-driven update commands.

As I said - the version with the sub-actions fouls up parameter checking. (That's the "action" parameter option. It doesn't matter whether it's "--action=start" or "--start"; in fact, the --action at least lets the parameter parser do a little bit of checking.) It's possible to add another layer o

Re: Review Request 25667: Removing host_drain delay.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25667/#review53419 --- Ship it! Ship It! - Joe Smith On Sept. 15, 2014, 3:04 p.m., Maxi

Review Request 25667: Removing host_drain delay.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25667/ --- Review request for Aurora and Joe Smith. Bugs: AURORA-714 https://issues.ap

Re: Review Request 25255: Implement server-driven update commands.

I guess there is also the option you originally proposed: "aurora job update --start|--pause|--resume|--abort". If you don't like the option syntax, would it be too much work to support double "verb" (or rather double "noun") syntax, like "aurora job update start"? On Mon, Sep 15, 2014 at 2:07 PM

Re: Review Request 25255: Implement server-driven update commands.

The choices are: (1) Action parameter: "aurora job update --action=start/pause/resume/abort". Pros: it's part of the "job" noun and the familiar "update" verb. Cons: - the action parameter is ugly, - we lose automatic parameter checking, since the different actions take different parameters. - it'

Re: Review Request 25529: Add a controller for job updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25529/ --- (Updated Sept. 15, 2014, 7:40 p.m.) Review request for Aurora, Joshua Cohen, Ke

Re: Review Request 25653: Added store APIs to query for IJobUpdate and IJobUpdateConfiguration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25653/ --- (Updated Sept. 15, 2014, 7:16 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 25175: Fix possible deadlock in TaskRunner.collect_updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25175/#review53385 --- Ship it! Please circle back and add test coverage - Kevin Sweeney

Re: Review Request 25653: Added store APIs to query for IJobUpdate and IJobUpdateConfiguration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25653/#review53379 --- Ship it! src/main/java/org/apache/aurora/scheduler/storage/JobUpda

Re: Review Request 25259: Add update information to the scheduler UI

> On Sept. 12, 2014, 11:47 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html, > > line 17 > > > > > > I'd love to see UTC here as well. > > David McLaughlin wrote: >

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 15, 2014, 6:53 p.m.) Review request for Aurora, Joshua Cohen, Ke

Re: Review Request 25259: Add update information to the scheduler UI

> On Sept. 12, 2014, 11:47 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js, line > > 54 > > > > > > I'd like to see the paused states disambiguated. I could imagine a

Review Request 25653: Added store APIs to query for IJobUpdate and IJobUpdateConfiguration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25653/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 25255: Implement server-driven update commands.

In the world of 'nouns' and 'verbs', i imagine a user would think "i want to update my job", not "i want to start an update". So if the goal of organizing commands by nouns is to make it intuitive, i think "update start" is less natural than "job update". -=Bill On Mon, Sep 15, 2014 at 10:25 AM,

Re: Review Request 25175: Fix possible deadlock in TaskRunner.collect_updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25175/#review53367 --- Ship it! Ship It! - Joe Smith On Sept. 15, 2014, 11:08 a.m., Bri

Re: Review Request 25175: Fix possible deadlock in TaskRunner.collect_updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25175/ --- (Updated Sept. 15, 2014, 6:08 p.m.) Review request for Aurora and Kevin Sweeney

Re: Review Request 25175: Fix possible deadlock in TaskRunner.collect_updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25175/ --- (Updated Sept. 15, 2014, 6:07 p.m.) Review request for Aurora. Bugs: AURORA-6

Re: Review Request 25175: Fix possible deadlock in TaskRunner.collect_updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25175/ --- (Updated Sept. 15, 2014, 5:52 p.m.) Review request for Aurora. Changes --

Re: Review Request 25255: Implement server-driven update commands.

> On Sept. 15, 2014, 12:04 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/standalone_client.py, line 121 > > > > > > I am still not sure why we are going with the top level noun for job >

Re: Review Request 25255: Implement server-driven update commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25255/#review53347 --- src/main/python/apache/aurora/client/cli/standalone_client.py

Re: Review Request 25255: Implement server-driven update commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25255/#review53330 --- ping? THis is ready for another look. - Mark Chu-Carroll On Sept.

Re: Review Request 25543: Update to pants 0.0.23.

> On Sept. 12, 2014, 6:54 p.m., Brian Wickman wrote: > > I noticed you just commented out some of the timeout= keywords -- do you > > plan to remove those or just leave them as annotations? Leave them as annotations. I'm not really clear on why the timeout was removed, but the fact that we bel