----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25255/#review53347 -----------------------------------------------------------
src/main/python/apache/aurora/client/cli/standalone_client.py <https://reviews.apache.org/r/25255/#comment92980> I am still not sure why we are going with the top level noun for job updates. It's quite strange to see create/restart under "job" but "update" living on its own. Is this only to avoid collision with the existing client update? If so, it's only there until we iron out the async updates. We could clearly mark new server side update options as "BETA" in command help to avoid any confusion. I think the long term consistency here is more important than temporary ambiguity. - Maxim Khutornenko On Sept. 11, 2014, 2:55 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25255/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2014, 2:55 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > This change contains the basic commands needed to work with the > scheduler-driven updater. (It does not yet cover querying for the status > of the update; that will come in a subsequent change.) > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/BUILD > ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 > src/main/python/apache/aurora/client/cli/context.py > 51c7d24dca664e476e62f1864d095416dfab70e4 > src/main/python/apache/aurora/client/cli/jobs.py > ebc22aaa5a8aed311897b3ce9632b6f7175b6080 > src/main/python/apache/aurora/client/cli/standalone_client.py > b7c8de66d6e4664b536911f826e36a984e8d0fef > src/main/python/apache/aurora/client/cli/update.py PRE-CREATION > src/test/python/apache/aurora/client/cli/BUILD > e1f9ebf96774b8f5c75de8570c6ba87d953ab649 > src/test/python/apache/aurora/client/cli/test_restart.py > a1e7a5a94a2d336239df98e2600658b97c546901 > src/test/python/apache/aurora/client/cli/test_supdate.py PRE-CREATION > src/test/python/apache/aurora/client/cli/util.py > 95a2123e127c9811fd2305e71cfc5c7c4376f904 > > Diff: https://reviews.apache.org/r/25255/diff/ > > > Testing > ------- > > New suite of tests for the new command; all unit tests pass. > > > Thanks, > > Mark Chu-Carroll > >
