Re: Review Request 25872: Instrument task scheduling code to give visibility into failed searches and backoffs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25872/#review54138 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 20, 2014, 3:06 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25872/ --- (Updated Sept. 20, 2014, 3:06 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- I'd like to use this data to investigate potential changes to the backoff strategy used in TaskGroups. I have a hunch that tasks are usually either scheduled on the first try, or after the 10th. If that is true, we can make difficult-to-schedule tasks much less expensive. Diffs - src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java f64497fcf082defd4a6a0935febce8ed90c7e078 src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f Diff: https://reviews.apache.org/r/25872/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 24752: combine finalization_wait when combining tasks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24752/#review54144 --- Ship it! Sorry for taking so long to get to this review. The code looks good and I'll merge to master. This comes with a catch -- a catch that we should document and file some tickets against. The current state of affairs is that the default finalization is 30 seconds. Thermos supports something called the preemption notice which roughly translates to how long we'll allow this task to finalize before we kill everything no matter what. The idea of preemption notice is that you may have somebody who needs the resources with a higher priority, but is only willing to wait a fixed amount of time for its predecessor to clean up. (More altruistic preemptors will make this value high if they don't need the resources immediately, e.g. a high priority batch job, but a revenue-critical task could very well make this 0 seconds and give you no opportunity to finalize.) We never integrated preemption notice into Aurora because the use-case never materialized (also, for many, preemption is fairly rare.) Instead Thermos just uses a default of 60 seconds. This means that no matter how big you make the finalization wait, it can never be longer than 60 seconds before Thermos kills everything, so keep that in mind before you use this feature heavily. - Brian Wickman On Aug. 28, 2014, 3:27 p.m., Matthew Jeffryes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24752/ --- (Updated Aug. 28, 2014, 3:27 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Repository: aurora Description --- Problem: combine_task and concat_task helpers lose the finalization_wait information from all but the first task Resolution: use sum/max of finialization_wait values in concat_task/combine_task Diffs - src/main/python/apache/thermos/config/schema_helpers.py 3feef02 src/test/python/apache/thermos/config/test_schema.py 85b04c0 Diff: https://reviews.apache.org/r/24752/diff/ Testing --- ./pants src/test/python:all -vxs Thanks, Matthew Jeffryes
Re: Review Request 25857: Disable updater by default in prod.
On Sept. 20, 2014, 2:14 a.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, line 286 https://reviews.apache.org/r/25857/diff/2/?file=698339#file698339line286 I see why you went this route, but it's a precedent i'd rather not set. How about a guice-bound `@EnableUpdater Boolean`. Then, create a new test class that does nothing but create necessary mocks to construct an instance of SchedulerThriftInterface and test the flag. This will result in a much larger diff for something that is only used temporarily and will go away once all updater kinks are worked out. I'd rather go with a smaller diff and document it as testing anti-pattern not to be used for anything permanent. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/#review54071 --- On Sept. 19, 2014, 11:10 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/ --- (Updated Sept. 19, 2014, 11:10 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-732 https://issues.apache.org/jira/browse/AURORA-732 Repository: aurora Description --- Added command line arg to control startJobUpdate. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 83ac034cff009530e5e16c0613b9d085f3b908d8 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 336cada625b85618486660fc24f3e83a312609f8 Diff: https://reviews.apache.org/r/25857/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 25872: Instrument task scheduling code to give visibility into failed searches and backoffs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25872/#review54145 --- Ship it! src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java https://reviews.apache.org/r/25872/#comment94139 typo in attemptsFired - Kevin Sweeney On Sept. 19, 2014, 8:06 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25872/ --- (Updated Sept. 19, 2014, 8:06 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- I'd like to use this data to investigate potential changes to the backoff strategy used in TaskGroups. I have a hunch that tasks are usually either scheduled on the first try, or after the 10th. If that is true, we can make difficult-to-schedule tasks much less expensive. Diffs - src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java f64497fcf082defd4a6a0935febce8ed90c7e078 src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f Diff: https://reviews.apache.org/r/25872/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Review Request 25897: Adding timing stats to DB stores.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25897/ --- Review request for Aurora and Bill Farner. Repository: aurora Description --- Adding timing stats to DB stores. Diffs - src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 4db336cbcb8c93fa165907039bc78adf73466bda src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 4b4f1279b2ef0182529c164f4d276d90142d6cf6 src/main/java/org/apache/aurora/scheduler/storage/db/DbQuotaStore.java 412b3e733aa2b152e0c47f20b6c2321c12d9a32d src/main/java/org/apache/aurora/scheduler/storage/db/DbSchedulerStore.java fc7913e6057b56af37a19d8b099dbb0c3f81575b Diff: https://reviews.apache.org/r/25897/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 24173: AURORA-607:release script is broken
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24173/ --- (Updated Sept. 22, 2014, 5:46 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: aurora-607 https://issues.apache.org/jira/browse/aurora-607 Repository: aurora Description --- Updates release script to promote a voted on rc to an official release. Diffs (updated) - build-support/release/release d94f3ba737ad221ee15f9ff7050065d58d073b5c Diff: https://reviews.apache.org/r/24173/diff/ Testing --- ./build-support/release/release -r 2 I have not tested the actual promotion of the rc to release, as this is the first official ASF release of Apache Aurora I saved that for Kevin to do Steps to publish the 0.5.0 release with this script: * git checkout 0.5.0-rc2 * apply this patch * comment out dirty tree exit condition, line 89 of ./build-support/release/release * test with: ./build-support/release/release -r 2 * rm -rf dist * publish with: ./build-support/release/release -r 2 -p Thanks, Jake Farrell
Review Request 25898: AURORA-736 - Update committer docs with steps for adding a gpg key
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25898/ --- Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner. Bugs: AURORA-736 https://issues.apache.org/jira/browse/AURORA-736 Repository: aurora Description --- AURORA-736 - Update committer docs with steps for adding a gpg key Diffs - docs/committers.md 3f68f89f921e1e17e6eb53ef13c550b3e52fce96 Diff: https://reviews.apache.org/r/25898/diff/ Testing --- Thanks, Jake Farrell
Re: Review Request 25898: AURORA-736 - Update committer docs with steps for adding a gpg key
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25898/#review54152 --- docs/committers.md https://reviews.apache.org/r/25898/#comment94151 add a mention of git config user.signingkey here too? - Kevin Sweeney On Sept. 22, 2014, 11:19 a.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25898/ --- (Updated Sept. 22, 2014, 11:19 a.m.) Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner. Bugs: AURORA-736 https://issues.apache.org/jira/browse/AURORA-736 Repository: aurora Description --- AURORA-736 - Update committer docs with steps for adding a gpg key Diffs - docs/committers.md 3f68f89f921e1e17e6eb53ef13c550b3e52fce96 Diff: https://reviews.apache.org/r/25898/diff/ Testing --- Thanks, Jake Farrell
Re: Review Request 25859: Fix some bugs in the Update UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/ --- (Updated Sept. 22, 2014, 6:24 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Fix tests. Repository: aurora Description --- Angular has a thing where if you have asynchronous data *and* you bind it to isolated scope in a directive, you need to explicitly watch the values for changes. This was also the weird behaviour I saw before with SmartTable. I changed the ordering of update summaries to be reverse sorted by last event time. Going to be required for a future (show me all in-flight updates) feature. I also fixed a couple of problems with: progress stats, a missing terminal state and the instance summary not updating when polling. Diffs (updated) - src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js bcb094adbafdf223eda49c012005994937d5dcf6 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 8b7fc0627597d53a788868d0ae16c0c063f36338 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8a719f85b0a095a93b723c04b0a5e8306093c572 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml ad877ed168f80cc56561dffd028cff300336ea55 src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 1cbb7ab9ce4333a1f2f76a7de1940dedb8dc8ecd Diff: https://reviews.apache.org/r/25859/diff/ Testing --- ./gradlew jsHint Thanks, David McLaughlin
Re: Review Request 25859: Fix some bugs in the Update UI
On Sept. 20, 2014, 1:02 a.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml, line 275 https://reviews.apache.org/r/25859/diff/1/?file=698458#file698458line275 This will fail unit tests as is. Thanks. Fixed. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/#review54066 --- On Sept. 20, 2014, 12:28 a.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/ --- (Updated Sept. 20, 2014, 12:28 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Angular has a thing where if you have asynchronous data *and* you bind it to isolated scope in a directive, you need to explicitly watch the values for changes. This was also the weird behaviour I saw before with SmartTable. I changed the ordering of update summaries to be reverse sorted by last event time. Going to be required for a future (show me all in-flight updates) feature. I also fixed a couple of problems with: progress stats, a missing terminal state and the instance summary not updating when polling. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js bcb094adbafdf223eda49c012005994937d5dcf6 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 8b7fc0627597d53a788868d0ae16c0c063f36338 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8a719f85b0a095a93b723c04b0a5e8306093c572 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml ad877ed168f80cc56561dffd028cff300336ea55 Diff: https://reviews.apache.org/r/25859/diff/ Testing --- ./gradlew jsHint Thanks, David McLaughlin
Re: Review Request 25857: Disable updater by default in prod.
On Sept. 20, 2014, 2:14 a.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, line 286 https://reviews.apache.org/r/25857/diff/2/?file=698339#file698339line286 I see why you went this route, but it's a precedent i'd rather not set. How about a guice-bound `@EnableUpdater Boolean`. Then, create a new test class that does nothing but create necessary mocks to construct an instance of SchedulerThriftInterface and test the flag. Maxim Khutornenko wrote: This will result in a much larger diff for something that is only used temporarily and will go away once all updater kinks are worked out. I'd rather go with a smaller diff and document it as testing anti-pattern not to be used for anything permanent. A fair argument, but i'm still a big anti-fan of using reflection like this. I'd much rather the field be public than have false encapsulation. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/#review54071 --- On Sept. 19, 2014, 11:10 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/ --- (Updated Sept. 19, 2014, 11:10 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-732 https://issues.apache.org/jira/browse/AURORA-732 Repository: aurora Description --- Added command line arg to control startJobUpdate. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 83ac034cff009530e5e16c0613b9d085f3b908d8 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 336cada625b85618486660fc24f3e83a312609f8 Diff: https://reviews.apache.org/r/25857/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 25859: Fix some bugs in the Update UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/#review54159 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 22, 2014, 6:24 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/ --- (Updated Sept. 22, 2014, 6:24 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Angular has a thing where if you have asynchronous data *and* you bind it to isolated scope in a directive, you need to explicitly watch the values for changes. This was also the weird behaviour I saw before with SmartTable. I changed the ordering of update summaries to be reverse sorted by last event time. Going to be required for a future (show me all in-flight updates) feature. I also fixed a couple of problems with: progress stats, a missing terminal state and the instance summary not updating when polling. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js bcb094adbafdf223eda49c012005994937d5dcf6 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 8b7fc0627597d53a788868d0ae16c0c063f36338 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8a719f85b0a095a93b723c04b0a5e8306093c572 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml ad877ed168f80cc56561dffd028cff300336ea55 src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 1cbb7ab9ce4333a1f2f76a7de1940dedb8dc8ecd Diff: https://reviews.apache.org/r/25859/diff/ Testing --- ./gradlew jsHint Thanks, David McLaughlin
Re: Review Request 25872: Instrument task scheduling code to give visibility into failed searches and backoffs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25872/ --- (Updated Sept. 22, 2014, 6:42 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- I'd like to use this data to investigate potential changes to the backoff strategy used in TaskGroups. I have a hunch that tasks are usually either scheduled on the first try, or after the 10th. If that is true, we can make difficult-to-schedule tasks much less expensive. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java f64497fcf082defd4a6a0935febce8ed90c7e078 src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f Diff: https://reviews.apache.org/r/25872/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 25872: Instrument task scheduling code to give visibility into failed searches and backoffs.
On Sept. 22, 2014, 5:34 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java, line 180 https://reviews.apache.org/r/25872/diff/1/?file=698588#file698588line180 typo in attemptsFired Thanks, fixed. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25872/#review54145 --- On Sept. 20, 2014, 3:06 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25872/ --- (Updated Sept. 20, 2014, 3:06 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- I'd like to use this data to investigate potential changes to the backoff strategy used in TaskGroups. I have a hunch that tasks are usually either scheduled on the first try, or after the 10th. If that is true, we can make difficult-to-schedule tasks much less expensive. Diffs - src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java f64497fcf082defd4a6a0935febce8ed90c7e078 src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f Diff: https://reviews.apache.org/r/25872/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/ --- (Updated Sept. 22, 2014, 11:52 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Maxim's feedback Repository: aurora Description --- Use Guice AssistedInject to construct StreamManager Refactor other component in log to be Guice-constructed. More info: https://github.com/google/guice/wiki/AssistedInject Diffs (updated) - build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883 src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064 src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa Diff: https://reviews.apache.org/r/25870/diff/ Testing --- ./gradlew -Pq build Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars) Thanks, Kevin Sweeney
Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager
On Sept. 22, 2014, 11 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java, line 127 https://reviews.apache.org/r/25870/diff/1/?file=698533#file698533line127 What's the context around replacing MessageDigest with HashFunction? Is it perf gain? Any details on how better it is? It delegates to the same underlying code, it's just the Guava interface for it (type-safe construction, immutable function object). See http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/hash/Hashing.html#md5() On Sept. 22, 2014, 11 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java, lines 86-87 https://reviews.apache.org/r/25870/diff/1/?file=698533#file698533line86 Static imports? Done. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/#review54150 --- On Sept. 22, 2014, 11:52 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/ --- (Updated Sept. 22, 2014, 11:52 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Use Guice AssistedInject to construct StreamManager Refactor other component in log to be Guice-constructed. More info: https://github.com/google/guice/wiki/AssistedInject Diffs - build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883 src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064 src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa Diff: https://reviews.apache.org/r/25870/diff/ Testing --- ./gradlew -Pq build Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars) Thanks, Kevin Sweeney
Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/#review54171 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 22, 2014, 6:52 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/ --- (Updated Sept. 22, 2014, 6:52 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Use Guice AssistedInject to construct StreamManager Refactor other component in log to be Guice-constructed. More info: https://github.com/google/guice/wiki/AssistedInject Diffs - build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883 src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064 src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa Diff: https://reviews.apache.org/r/25870/diff/ Testing --- ./gradlew -Pq build Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars) Thanks, Kevin Sweeney
Re: Review Request 25898: AURORA-736 - Update committer docs with steps for adding a gpg key
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25898/#review54195 --- Ship it! Ship It! docs/committers.md https://reviews.apache.org/r/25898/#comment94190 s/Adding/Add/ docs/committers.md https://reviews.apache.org/r/25898/#comment94191 s/Adding/Add/ - Kevin Sweeney On Sept. 22, 2014, 2:01 p.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25898/ --- (Updated Sept. 22, 2014, 2:01 p.m.) Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner. Bugs: AURORA-736 https://issues.apache.org/jira/browse/AURORA-736 Repository: aurora Description --- AURORA-736 - Update committer docs with steps for adding a gpg key Diffs - docs/committers.md 3f68f89f921e1e17e6eb53ef13c550b3e52fce96 Diff: https://reviews.apache.org/r/25898/diff/ Testing --- Thanks, Jake Farrell
Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/ --- (Updated Sept. 22, 2014, 4:07 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Use interface instead of impl as return type Repository: aurora Description --- Use Guice AssistedInject to construct StreamManager Refactor other component in log to be Guice-constructed. More info: https://github.com/google/guice/wiki/AssistedInject Diffs (updated) - build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883 src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064 src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa Diff: https://reviews.apache.org/r/25870/diff/ Testing --- ./gradlew -Pq build Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars) Thanks, Kevin Sweeney
Review Request 25913: HTML Grid Fixes in Scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/ --- Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Repository: aurora Description --- HTML Grid Fixes in Scheduler UI. Got rid of custom self-closing (void) tags: https://github.com/angular/angular.js/issues/1953. Got rid of nested container-fluids (caused inconsistent margins on role/env pages). Got rid of redundant nested if/else on errors. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 5c4fe96e9c6cb816e497f9dc145f99b6568de887 src/main/resources/org/apache/aurora/scheduler/http/ui/error.html 5b03acaf593ee9d0c32e70f7178fb0e54162c7b8 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html ca1a0f666a1eea7c225f017918f4755c28c57502 src/main/resources/org/apache/aurora/scheduler/http/ui/role.html c3a2fd9f12fe6b99a5253f123002a7a02e51a9ec src/main/resources/org/apache/aurora/scheduler/http/ui/update.html b6cf4f0ed44f33bd5048c5ba9267eabb837dab84 Diff: https://reviews.apache.org/r/25913/diff/ Testing --- Manual testing. These are effectively code cleanup no-ops. The main goal is to avoid people cargo-culting existing bad practices in the name of consistency (which I did with the time-display directives). Thanks, David McLaughlin
Re: Review Request 25913: HTML Grid Fixes in Scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/ --- (Updated Sept. 22, 2014, 11:23 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Changes --- Added JIRA. Bugs: AURORA-436 https://issues.apache.org/jira/browse/AURORA-436 Repository: aurora Description --- HTML Grid Fixes in Scheduler UI. Got rid of custom self-closing (void) tags: https://github.com/angular/angular.js/issues/1953. Got rid of nested container-fluids (caused inconsistent margins on role/env pages). Got rid of redundant nested if/else on errors. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 5c4fe96e9c6cb816e497f9dc145f99b6568de887 src/main/resources/org/apache/aurora/scheduler/http/ui/error.html 5b03acaf593ee9d0c32e70f7178fb0e54162c7b8 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html ca1a0f666a1eea7c225f017918f4755c28c57502 src/main/resources/org/apache/aurora/scheduler/http/ui/role.html c3a2fd9f12fe6b99a5253f123002a7a02e51a9ec src/main/resources/org/apache/aurora/scheduler/http/ui/update.html b6cf4f0ed44f33bd5048c5ba9267eabb837dab84 Diff: https://reviews.apache.org/r/25913/diff/ Testing --- Manual testing. These are effectively code cleanup no-ops. The main goal is to avoid people cargo-culting existing bad practices in the name of consistency (which I did with the time-display directives). Thanks, David McLaughlin
Review Request 25914: use javax.inject.Qualifier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/ --- Review request for Aurora. Repository: aurora Description --- use javax.inject.Qualifier instead of @BindingAnnotation See https://github.com/google/guice/wiki/JSR330 Diffs - src/main/java/org/apache/aurora/GuiceUtils.java a27243c6b93330bf8415a140ad7052e6144a1fef src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java e72961abf6509fbd3ee7e3c73ea61a4c2536bb80 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 4088559c39014befaddb0b29dad45fac9f4545c4 src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 1a65a3418c1bf8276f78a2d3aad532b4768a010c src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java fd08be11381255f1aca640db9c6276eaddeb7b91 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 05417ca29714a18b0f3f8e062ae005d04671051e src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 085454c63a3023e28ae1d148c64d25cfed99c4f1 src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 779e925e4d9e7889e8cfd369cea9a8e5da3554d2 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java c4435cb74925c9ed04a37820b22c3ecdfcad49d4 src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java fc3eaf6ba461dbfc371afc6ccf5afbd34760f2c5 src/main/java/org/apache/aurora/scheduler/storage/Storage.java f83a71a877a317810cd166c74ca468dd17c50d07 src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java 4bfb44d43224e8bb99efcd3051d7f01ee636c2a3 src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java 6f94af50a9992dd5efd9f28c0d39ae808a3f3e87 src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java ce42ad20e8839698583e04f1780c59197a9f0be8 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 186bc46d74c562603d5e0a724b0fe2ff5b69131d src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52ff46447c4b73f2b126ac297f2a74b731373267 Diff: https://reviews.apache.org/r/25914/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 25914: use javax.inject.Qualifier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/ --- (Updated Sept. 22, 2014, 4:35 p.m.) Review request for Aurora. Changes --- Fix import order for test sources Repository: aurora Description --- use javax.inject.Qualifier instead of @BindingAnnotation See https://github.com/google/guice/wiki/JSR330 Diffs (updated) - src/main/java/org/apache/aurora/GuiceUtils.java a27243c6b93330bf8415a140ad7052e6144a1fef src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java e72961abf6509fbd3ee7e3c73ea61a4c2536bb80 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 4088559c39014befaddb0b29dad45fac9f4545c4 src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 1a65a3418c1bf8276f78a2d3aad532b4768a010c src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java fd08be11381255f1aca640db9c6276eaddeb7b91 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 05417ca29714a18b0f3f8e062ae005d04671051e src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 085454c63a3023e28ae1d148c64d25cfed99c4f1 src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 779e925e4d9e7889e8cfd369cea9a8e5da3554d2 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java c4435cb74925c9ed04a37820b22c3ecdfcad49d4 src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java fc3eaf6ba461dbfc371afc6ccf5afbd34760f2c5 src/main/java/org/apache/aurora/scheduler/storage/Storage.java f83a71a877a317810cd166c74ca468dd17c50d07 src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java 4bfb44d43224e8bb99efcd3051d7f01ee636c2a3 src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java 6f94af50a9992dd5efd9f28c0d39ae808a3f3e87 src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java ce42ad20e8839698583e04f1780c59197a9f0be8 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 186bc46d74c562603d5e0a724b0fe2ff5b69131d src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 49770e5f87f047502e4f5653b908657a40d8683f src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java d07220ae3e83c5dae43dd6280fa65c1f9a94f075 src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52ff46447c4b73f2b126ac297f2a74b731373267 Diff: https://reviews.apache.org/r/25914/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 25914: use javax.inject.Qualifier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/#review54206 --- Ship it! Ship It! - Zameer Manji On Sept. 22, 2014, 4:35 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/ --- (Updated Sept. 22, 2014, 4:35 p.m.) Review request for Aurora. Repository: aurora Description --- use javax.inject.Qualifier instead of @BindingAnnotation See https://github.com/google/guice/wiki/JSR330 Diffs - src/main/java/org/apache/aurora/GuiceUtils.java a27243c6b93330bf8415a140ad7052e6144a1fef src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java e72961abf6509fbd3ee7e3c73ea61a4c2536bb80 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 4088559c39014befaddb0b29dad45fac9f4545c4 src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 1a65a3418c1bf8276f78a2d3aad532b4768a010c src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java fd08be11381255f1aca640db9c6276eaddeb7b91 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 05417ca29714a18b0f3f8e062ae005d04671051e src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 085454c63a3023e28ae1d148c64d25cfed99c4f1 src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 779e925e4d9e7889e8cfd369cea9a8e5da3554d2 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java c4435cb74925c9ed04a37820b22c3ecdfcad49d4 src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java fc3eaf6ba461dbfc371afc6ccf5afbd34760f2c5 src/main/java/org/apache/aurora/scheduler/storage/Storage.java f83a71a877a317810cd166c74ca468dd17c50d07 src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java 4bfb44d43224e8bb99efcd3051d7f01ee636c2a3 src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java 6f94af50a9992dd5efd9f28c0d39ae808a3f3e87 src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java ce42ad20e8839698583e04f1780c59197a9f0be8 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 186bc46d74c562603d5e0a724b0fe2ff5b69131d src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 49770e5f87f047502e4f5653b908657a40d8683f src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java d07220ae3e83c5dae43dd6280fa65c1f9a94f075 src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52ff46447c4b73f2b126ac297f2a74b731373267 Diff: https://reviews.apache.org/r/25914/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 25913: HTML Grid Fixes in Scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/#review54208 --- Ship it! Ship It! - Bill Farner On Sept. 22, 2014, 11:23 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/ --- (Updated Sept. 22, 2014, 11:23 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-436 https://issues.apache.org/jira/browse/AURORA-436 Repository: aurora Description --- HTML Grid Fixes in Scheduler UI. Got rid of custom self-closing (void) tags: https://github.com/angular/angular.js/issues/1953. Got rid of nested container-fluids (caused inconsistent margins on role/env pages). Got rid of redundant nested if/else on errors. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 5c4fe96e9c6cb816e497f9dc145f99b6568de887 src/main/resources/org/apache/aurora/scheduler/http/ui/error.html 5b03acaf593ee9d0c32e70f7178fb0e54162c7b8 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html ca1a0f666a1eea7c225f017918f4755c28c57502 src/main/resources/org/apache/aurora/scheduler/http/ui/role.html c3a2fd9f12fe6b99a5253f123002a7a02e51a9ec src/main/resources/org/apache/aurora/scheduler/http/ui/update.html b6cf4f0ed44f33bd5048c5ba9267eabb837dab84 Diff: https://reviews.apache.org/r/25913/diff/ Testing --- Manual testing. These are effectively code cleanup no-ops. The main goal is to avoid people cargo-culting existing bad practices in the name of consistency (which I did with the time-display directives). Thanks, David McLaughlin
Re: Review Request 25913: HTML Grid Fixes in Scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/#review54209 --- Ship it! I'm sure it's fine, but in the future it might be helpful to include screenshots comparable to those in the ticket showing the proper alignment? - Joshua Cohen On Sept. 22, 2014, 11:23 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/ --- (Updated Sept. 22, 2014, 11:23 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-436 https://issues.apache.org/jira/browse/AURORA-436 Repository: aurora Description --- HTML Grid Fixes in Scheduler UI. Got rid of custom self-closing (void) tags: https://github.com/angular/angular.js/issues/1953. Got rid of nested container-fluids (caused inconsistent margins on role/env pages). Got rid of redundant nested if/else on errors. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 5c4fe96e9c6cb816e497f9dc145f99b6568de887 src/main/resources/org/apache/aurora/scheduler/http/ui/error.html 5b03acaf593ee9d0c32e70f7178fb0e54162c7b8 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html ca1a0f666a1eea7c225f017918f4755c28c57502 src/main/resources/org/apache/aurora/scheduler/http/ui/role.html c3a2fd9f12fe6b99a5253f123002a7a02e51a9ec src/main/resources/org/apache/aurora/scheduler/http/ui/update.html b6cf4f0ed44f33bd5048c5ba9267eabb837dab84 Diff: https://reviews.apache.org/r/25913/diff/ Testing --- Manual testing. These are effectively code cleanup no-ops. The main goal is to avoid people cargo-culting existing bad practices in the name of consistency (which I did with the time-display directives). Thanks, David McLaughlin
Re: Review Request 25914: use javax.inject.Qualifier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/ --- (Updated Sept. 22, 2014, 5:27 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora Description --- use javax.inject.Qualifier instead of @BindingAnnotation See https://github.com/google/guice/wiki/JSR330 Diffs - src/main/java/org/apache/aurora/GuiceUtils.java a27243c6b93330bf8415a140ad7052e6144a1fef src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java e72961abf6509fbd3ee7e3c73ea61a4c2536bb80 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 4088559c39014befaddb0b29dad45fac9f4545c4 src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 1a65a3418c1bf8276f78a2d3aad532b4768a010c src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java fd08be11381255f1aca640db9c6276eaddeb7b91 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 05417ca29714a18b0f3f8e062ae005d04671051e src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 085454c63a3023e28ae1d148c64d25cfed99c4f1 src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 779e925e4d9e7889e8cfd369cea9a8e5da3554d2 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java c4435cb74925c9ed04a37820b22c3ecdfcad49d4 src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java fc3eaf6ba461dbfc371afc6ccf5afbd34760f2c5 src/main/java/org/apache/aurora/scheduler/storage/Storage.java f83a71a877a317810cd166c74ca468dd17c50d07 src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java 4bfb44d43224e8bb99efcd3051d7f01ee636c2a3 src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java 6f94af50a9992dd5efd9f28c0d39ae808a3f3e87 src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java ce42ad20e8839698583e04f1780c59197a9f0be8 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 186bc46d74c562603d5e0a724b0fe2ff5b69131d src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 49770e5f87f047502e4f5653b908657a40d8683f src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java d07220ae3e83c5dae43dd6280fa65c1f9a94f075 src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52ff46447c4b73f2b126ac297f2a74b731373267 Diff: https://reviews.apache.org/r/25914/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/#review54214 --- Ping wfarner - Kevin Sweeney On Sept. 22, 2014, 4:07 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/ --- (Updated Sept. 22, 2014, 4:07 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Use Guice AssistedInject to construct StreamManager Refactor other component in log to be Guice-constructed. More info: https://github.com/google/guice/wiki/AssistedInject Diffs - build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883 src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064 src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa Diff: https://reviews.apache.org/r/25870/diff/ Testing --- ./gradlew -Pq build Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars) Thanks, Kevin Sweeney
Re: Review Request 25857: Disable updater by default in prod.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/#review54216 --- Ship it! Thanks! - Bill Farner On Sept. 22, 2014, 8:41 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/ --- (Updated Sept. 22, 2014, 8:41 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-732 https://issues.apache.org/jira/browse/AURORA-732 Repository: aurora Description --- Added command line arg to control startJobUpdate. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 83ac034cff009530e5e16c0613b9d085f3b908d8 src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java aa35182c47582fbd803a277cd4fde4a34a9dcc2a src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 336cada625b85618486660fc24f3e83a312609f8 Diff: https://reviews.apache.org/r/25857/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 25913: HTML Grid Fixes in Scheduler UI
On Sept. 23, 2014, 12:08 a.m., Joshua Cohen wrote: I'm sure it's fine, but in the future it might be helpful to include screenshots comparable to those in the ticket showing the proper alignment? Ack. Will add before/after screenshots for this type of work in the future. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/#review54209 --- On Sept. 22, 2014, 11:23 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/ --- (Updated Sept. 22, 2014, 11:23 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-436 https://issues.apache.org/jira/browse/AURORA-436 Repository: aurora Description --- HTML Grid Fixes in Scheduler UI. Got rid of custom self-closing (void) tags: https://github.com/angular/angular.js/issues/1953. Got rid of nested container-fluids (caused inconsistent margins on role/env pages). Got rid of redundant nested if/else on errors. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 5c4fe96e9c6cb816e497f9dc145f99b6568de887 src/main/resources/org/apache/aurora/scheduler/http/ui/error.html 5b03acaf593ee9d0c32e70f7178fb0e54162c7b8 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html ca1a0f666a1eea7c225f017918f4755c28c57502 src/main/resources/org/apache/aurora/scheduler/http/ui/role.html c3a2fd9f12fe6b99a5253f123002a7a02e51a9ec src/main/resources/org/apache/aurora/scheduler/http/ui/update.html b6cf4f0ed44f33bd5048c5ba9267eabb837dab84 Diff: https://reviews.apache.org/r/25913/diff/ Testing --- Manual testing. These are effectively code cleanup no-ops. The main goal is to avoid people cargo-culting existing bad practices in the name of consistency (which I did with the time-display directives). Thanks, David McLaughlin
Re: Review Request 25812: Implementing quota checking for async job updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/ --- (Updated Sept. 23, 2014, 12:59 a.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Changes --- +kevints Bugs: AURORA-686 https://issues.apache.org/jira/browse/AURORA-686 Repository: aurora Description --- Getting it right required a deep refactoring of the QuotaManager. The prod consumption is now calculated from: - production tasks not participating in job updates; - unaffected production tasks from a job being updated (i.e. those that are not covered by the update working set); - production tasks directly affected by the job update (max of old and new resources used). Also, moved all logic back to SchedulerThriftInterface as quota checks are done only there now. Diffs - src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3661f8487985f631e3ea437fe6430e0296376a9e src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 14b0dd8f86026840d0444c128f656a144eab017d src/main/java/org/apache/aurora/scheduler/state/StateModule.java 54b90127551c69509dbd41ee95c384dbbf1a7ee4 src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 779e925e4d9e7889e8cfd369cea9a8e5da3554d2 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 83ac034cff009530e5e16c0613b9d085f3b908d8 src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 49770e5f87f047502e4f5653b908657a40d8683f src/test/java/org/apache/aurora/scheduler/state/TaskLimitValidatorTest.java 8f18617b2052201f87bb1464314c2ee45b279276 src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 5aebbfbc691dfac4a066cb1425d18d3fccc77090 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 336cada625b85618486660fc24f3e83a312609f8 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 40156c211a346664c0d2f174235efb2049cf3bb9 Diff: https://reviews.apache.org/r/25812/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 25812: Implementing quota checking for async job updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/#review54168 --- src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java https://reviews.apache.org/r/25812/#comment94165 Remember - javadoc is like html. These newlines are not preserved unless you do it explicitly. Drop a p here, ditto in other comments. src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java https://reviews.apache.org/r/25812/#comment94163 how about s/prodFromTasks/getRequiredQuota/? src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java https://reviews.apache.org/r/25812/#comment94164 ditto - how about how about getRequiredQuota src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/25812/#comment94225 Catching IllegalArgumentException is likely to be more broad than you intend. I suggest you throw a specific exception from the validate function to avoid incorrectly replying 400 for something that should be 500. src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/25812/#comment94226 How about 'validateInstanceAddition'? I'm not tied to the name, but something more informative than 'validate' would be nice. src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/25812/#comment94227 Ditto - avoid catching IllegalArgumentException. src/main/thrift/org/apache/aurora/gen/api.thrift https://reviews.apache.org/r/25812/#comment94228 Can you update JobUpdateControllerImpl to use this as well? Also, you should wrap this with a constant that we define. Thrift produces a mutable static Set for this, which comes with risk. - Bill Farner On Sept. 23, 2014, 12:59 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/ --- (Updated Sept. 23, 2014, 12:59 a.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bugs: AURORA-686 https://issues.apache.org/jira/browse/AURORA-686 Repository: aurora Description --- Getting it right required a deep refactoring of the QuotaManager. The prod consumption is now calculated from: - production tasks not participating in job updates; - unaffected production tasks from a job being updated (i.e. those that are not covered by the update working set); - production tasks directly affected by the job update (max of old and new resources used). Also, moved all logic back to SchedulerThriftInterface as quota checks are done only there now. Diffs - src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3661f8487985f631e3ea437fe6430e0296376a9e src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 14b0dd8f86026840d0444c128f656a144eab017d src/main/java/org/apache/aurora/scheduler/state/StateModule.java 54b90127551c69509dbd41ee95c384dbbf1a7ee4 src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 779e925e4d9e7889e8cfd369cea9a8e5da3554d2 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 83ac034cff009530e5e16c0613b9d085f3b908d8 src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 49770e5f87f047502e4f5653b908657a40d8683f src/test/java/org/apache/aurora/scheduler/state/TaskLimitValidatorTest.java 8f18617b2052201f87bb1464314c2ee45b279276 src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 5aebbfbc691dfac4a066cb1425d18d3fccc77090 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 336cada625b85618486660fc24f3e83a312609f8 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 40156c211a346664c0d2f174235efb2049cf3bb9 Diff: https://reviews.apache.org/r/25812/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/#review54224 --- Ship it! src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java https://reviews.apache.org/r/25870/#comment94230 While you're here, might as well drop @Timed to start collecting data on this. src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java https://reviews.apache.org/r/25870/#comment94232 Comment implies this is a known problem. How about: Assess performance of md5 versus other hash functions. src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java https://reviews.apache.org/r/25870/#comment94236 s/public // src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java https://reviews.apache.org/r/25870/#comment94234 s/public //? i can't find any uses outside the package src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java https://reviews.apache.org/r/25870/#comment94235 s/public // - Bill Farner On Sept. 22, 2014, 11:07 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/ --- (Updated Sept. 22, 2014, 11:07 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Use Guice AssistedInject to construct StreamManager Refactor other component in log to be Guice-constructed. More info: https://github.com/google/guice/wiki/AssistedInject Diffs - build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883 src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064 src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa Diff: https://reviews.apache.org/r/25870/diff/ Testing --- ./gradlew -Pq build Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars) Thanks, Kevin Sweeney
Re: Review Request 25857: Disable updater by default in prod.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/ --- (Updated Sept. 23, 2014, 1:12 a.m.) Review request for Aurora and Bill Farner. Changes --- Replacing @BingingAnnotation with @Qualifier to match master. Bugs: AURORA-732 https://issues.apache.org/jira/browse/AURORA-732 Repository: aurora Description --- Added command line arg to control startJobUpdate. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 83ac034cff009530e5e16c0613b9d085f3b908d8 src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java aa35182c47582fbd803a277cd4fde4a34a9dcc2a src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 336cada625b85618486660fc24f3e83a312609f8 Diff: https://reviews.apache.org/r/25857/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/ --- (Updated Sept. 22, 2014, 6:35 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Bill's feedback. Repository: aurora Description (updated) --- Use Guice AssistedInject to construct StreamManager Refactor other components in log to be Guice-constructed. More info: https://github.com/google/guice/wiki/AssistedInject Diffs (updated) - build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883 src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064 src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa Diff: https://reviews.apache.org/r/25870/diff/ Testing --- ./gradlew -Pq build Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars) Thanks, Kevin Sweeney
Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager
On Sept. 22, 2014, 6:12 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java, line 63 https://reviews.apache.org/r/25870/diff/3/?file=700622#file700622line63 While you're here, might as well drop @Timed to start collecting data on this. Done. On Sept. 22, 2014, 6:12 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java, line 98 https://reviews.apache.org/r/25870/diff/3/?file=700625#file700625line98 Comment implies this is a known problem. How about: Assess performance of md5 versus other hash functions. Updated TODO with justification. On Sept. 22, 2014, 6:12 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java, line 33 https://reviews.apache.org/r/25870/diff/3/?file=700626#file700626line33 s/public // Done - automated refactoring got a little out of hand raising visibility. On Sept. 22, 2014, 6:12 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java, line 62 https://reviews.apache.org/r/25870/diff/3/?file=700628#file700628line62 s/public //? i can't find any uses outside the package Fixed. On Sept. 22, 2014, 6:12 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java, line 24 https://reviews.apache.org/r/25870/diff/3/?file=700629#file700629line24 s/public // Fixed. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/#review54224 --- On Sept. 22, 2014, 6:35 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/ --- (Updated Sept. 22, 2014, 6:35 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Use Guice AssistedInject to construct StreamManager Refactor other components in log to be Guice-constructed. More info: https://github.com/google/guice/wiki/AssistedInject Diffs - build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883 src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064 src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa Diff: https://reviews.apache.org/r/25870/diff/ Testing --- ./gradlew -Pq build Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars) Thanks, Kevin Sweeney
Re: Review Request 25918: Improve aurora command-line help using metavars.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25918/#review54239 --- Ship it! Ship It! - Zameer Manji On Sept. 22, 2014, 6:53 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25918/ --- (Updated Sept. 22, 2014, 6:53 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-737 https://issues.apache.org/jira/browse/aurora-737 Repository: aurora Description --- Improve aurora command-line help using metavars. Diffs - src/main/python/apache/aurora/client/cli/jobs.py 383c59143ae87d1f059644fdc3433e4c2075d02e src/main/python/apache/aurora/client/cli/options.py 36f80aa175beaf8f2dc6b6f962394643313d6405 src/main/python/apache/aurora/client/cli/task.py 5b5710ae9005664e17be1053c63b282364ae0300 Diff: https://reviews.apache.org/r/25918/diff/ Testing --- All unit tests pass. Thanks, Mark Chu-Carroll
