Review Request 26982: Make v2 job status look more like v1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26982/ --- Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: AURORA-874 https://issues.apache.org/jira/browse/AURORA-874 Repository: aurora Description --- Adds a header line to each task in a task status line specifying the instance number, host, etc., the way v1 did. (We had originally planned not to display that information in v2, but we also have tests that depend on it being present.) Diffs - src/main/python/apache/aurora/client/cli/jobs.py 7bbde156e64e969c6d402a04aaf7c038b919693a src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8 Diff: https://reviews.apache.org/r/26982/diff/ Testing --- $ ./pants src/test/python/apache/aurora/client/cli:job Build operating on top level addresses: set([BuildFileAddress(/Users/mchucarroll/Code/incubator-aurora/src/test/python/apache/aurora/client/cli/BUILD, job)]) = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3 plugins: cov, timeout collected 62 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py ... src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py src/test/python/apache/aurora/client/cli/test_open.py . src/test/python/apache/aurora/client/cli/test_restart.py src/test/python/apache/aurora/client/cli/test_status.py src/test/python/apache/aurora/client/cli/test_update.py . == 62 passed in 6.42 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 26982: Make v2 job status look more like v1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26982/#review57614 --- Ship it! Thanks for also using the term instance. - Zameer Manji On Oct. 21, 2014, 9:19 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26982/ --- (Updated Oct. 21, 2014, 9:19 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: AURORA-874 https://issues.apache.org/jira/browse/AURORA-874 Repository: aurora Description --- Adds a header line to each task in a task status line specifying the instance number, host, etc., the way v1 did. (We had originally planned not to display that information in v2, but we also have tests that depend on it being present.) Diffs - src/main/python/apache/aurora/client/cli/jobs.py 7bbde156e64e969c6d402a04aaf7c038b919693a src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8 Diff: https://reviews.apache.org/r/26982/diff/ Testing --- $ ./pants src/test/python/apache/aurora/client/cli:job Build operating on top level addresses: set([BuildFileAddress(/Users/mchucarroll/Code/incubator-aurora/src/test/python/apache/aurora/client/cli/BUILD, job)]) = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3 plugins: cov, timeout collected 62 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py ... src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py src/test/python/apache/aurora/client/cli/test_open.py . src/test/python/apache/aurora/client/cli/test_restart.py src/test/python/apache/aurora/client/cli/test_status.py src/test/python/apache/aurora/client/cli/test_update.py . == 62 passed in 6.42 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Review Request 26985: Printing coverage report path on failed analysis.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26985/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora Description --- Failed coverage analysis blocks coverage report file message. Moving the `doLast` block into `jacocoTestReport` task. Diffs - build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5 Diff: https://reviews.apache.org/r/26985/diff/ Testing --- BEFORE: ``` ... :jacocoTestReport UP-TO-DATE :analyzeReport FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':analyzeReport'. Instruction coverage of 0.88 exceeds min instruction coverage of 0.87, please raise the threshold! * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED ``` AFTER: ``` ... :jacocoTestReport Coverage report generated: file:///Users/mkhutornenko/workspace3/aurora/dist/reports/jacoco/test/html/index.html :analyzeReport FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':analyzeReport'. Instruction coverage of 0.88 exceeds min instruction coverage of 0.87, please raise the threshold! * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED ``` Thanks, Maxim Khutornenko
Re: Review Request 26753: Start removing clientv1.
On Oct. 15, 2014, 2:24 p.m., Bill Farner wrote: Should `docs/clientv2.md` be rehashed/removed to wipe traces of v1, or in a separte diff? Can you also update `examples/vagrant/test_tutorial.sh`? I suspect it's broken by this patch. I'd prefer to leave that doc - it's a historical which will be useful for understanding the code. I think just adding a header to it saying that it's a historical document is enough. But you're right that the docs in general need update - in particular, the developing-aurora-client doc should remove references to v1. I would prefer to make that a separate change. On Oct. 15, 2014, 2:24 p.m., Bill Farner wrote: src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh, line 38 https://reviews.apache.org/r/26753/diff/1/?file=722233#file722233line38 Looks like leftover debugging, and the actual test is commented out? Was a temporary workaround for part of the end-to-end test problem that Kevin has now fixed. - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26753/#review56757 --- On Oct. 15, 2014, 12:20 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26753/ --- (Updated Oct. 15, 2014, 12:20 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: aurora-131 https://issues.apache.org/jira/browse/aurora-131 Repository: aurora Description --- - Make the aurora2 main target be the standalone clientv2; - Don't build the bridged client by default; but allow forced build using aurora2_bridge. - Modify cli tests so that they only depend on the standalone clientv2. - Modify vagrant config to make clientv2 the primary client. - Modify end-to-end tests to match the vagrant changes. (Note: end-to-end tests are failing, but in the same way as they fail without this change. I'm working on debugging that, but it should be its own change/review, and I don't want to delay reviewing this.) Diffs - docs/developing-aurora-client.md e1b2ccd7504f983169118a288721894184d67c97 examples/vagrant/aurorabuild.sh a27636655d722ca79f66b377fd847954d52e8feb examples/vagrant/provision-dev-cluster.sh 740bc212ba604b2c64af92eba1be41e8ed3fdbde src/main/python/apache/aurora/client/cli/BUILD 995570325bbb09ecbcc2ace5d223760c5d49367f src/test/python/apache/aurora/client/cli/test_api_from_cli.py a2b28ba23961284ba60358af54726e0386dd69b6 src/test/python/apache/aurora/client/cli/test_cancel_update.py e7052465411165acb3d5145664f2f166ac052500 src/test/python/apache/aurora/client/cli/test_command_hooks.py 9fc6fe2c2063cda494437d83044557b345acacea src/test/python/apache/aurora/client/cli/test_config_noun.py dfcbd7217b1d51609fa01c4d9cefed5471c91718 src/test/python/apache/aurora/client/cli/test_create.py 427f7ce4476b48d407b8bd2bf2c54c52e6e63079 src/test/python/apache/aurora/client/cli/test_cron.py c7b71c29d44150162fec8066947623fa91815424 src/test/python/apache/aurora/client/cli/test_diff.py 10817695352687cdb5b0c3ed9720e3091b230e68 src/test/python/apache/aurora/client/cli/test_help.py f73c8a3778b7d118ea2865f213b442a607fb4a7d src/test/python/apache/aurora/client/cli/test_inspect.py e997b9743b63d71f8624ecf5ca1dcae0227be70d src/test/python/apache/aurora/client/cli/test_kill.py bac4485fa105848d96e2505c4a2ea2eee45dc968 src/test/python/apache/aurora/client/cli/test_logging.py 9ca4dceeaa87d5fb2e38fe0d83fdcdf1ee597a0e src/test/python/apache/aurora/client/cli/test_open.py c20649f5cada241d0f6e9ae5f88d300eac073517 src/test/python/apache/aurora/client/cli/test_plugins.py dc5edd4f03cee062673231a04908193480c8071c src/test/python/apache/aurora/client/cli/test_quota.py 88fb9aec4d1eae6ad05da01752a670f902bafb1b src/test/python/apache/aurora/client/cli/test_restart.py a5f94484b30ecb8417116db9ce12c015957357c5 src/test/python/apache/aurora/client/cli/test_sla.py a1a3d8161ba747aa23a5e614e9ae31473d2058c1 src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8 src/test/python/apache/aurora/client/cli/test_supdate.py 6775c389cb1a0b80dd17fe179e8b98d4e9db0332 src/test/python/apache/aurora/client/cli/test_task_run.py 16fde14c03f6fd2c000e76625fad174835763f1b src/test/python/apache/aurora/client/cli/test_update.py cff1b6578aec6f5bcc1e610e58b47af233f32b41 src/test/sh/org/apache/aurora/e2e/test_common.sh 43d2516133c6d6cdb4236358f942396f057f739c src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 324aa4dbeff00e673fe73b87e3a0766856cd213c src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
Re: Review Request 26531: Defining schema for the heartbeat RPC.
On Oct. 20, 2014, 7:35 p.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 1024 https://reviews.apache.org/r/26531/diff/3/?file=723031#file723031line1024 This method name reads strangely to me, since it's using heartbeat as a verb. 'Pulse' has a similar meaning, and can be used as both a verb and a noun. What do you think? Sure, works for me. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/#review57410 --- On Oct. 16, 2014, 4:44 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/ --- (Updated Oct. 16, 2014, 4:44 p.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Bugs: AURORA-690 https://issues.apache.org/jira/browse/AURORA-690 Repository: aurora Description --- Defining the flag and the schema for the update coordination (aka heartbeats). Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445 src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831 src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e src/test/python/apache/aurora/client/api/test_scheduler_client.py d78e7dca28d67997bc6c98cff619ab94a257c7dc Diff: https://reviews.apache.org/r/26531/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26982: Make v2 job status look more like v1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26982/#review57622 --- Is there an end to end test for this that needs updated? - David McLaughlin On Oct. 21, 2014, 4:19 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26982/ --- (Updated Oct. 21, 2014, 4:19 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: AURORA-874 https://issues.apache.org/jira/browse/AURORA-874 Repository: aurora Description --- Adds a header line to each task in a task status line specifying the instance number, host, etc., the way v1 did. (We had originally planned not to display that information in v2, but we also have tests that depend on it being present.) Diffs - src/main/python/apache/aurora/client/cli/jobs.py 7bbde156e64e969c6d402a04aaf7c038b919693a src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8 Diff: https://reviews.apache.org/r/26982/diff/ Testing --- $ ./pants src/test/python/apache/aurora/client/cli:job Build operating on top level addresses: set([BuildFileAddress(/Users/mchucarroll/Code/incubator-aurora/src/test/python/apache/aurora/client/cli/BUILD, job)]) = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3 plugins: cov, timeout collected 62 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py ... src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py src/test/python/apache/aurora/client/cli/test_open.py . src/test/python/apache/aurora/client/cli/test_restart.py src/test/python/apache/aurora/client/cli/test_status.py src/test/python/apache/aurora/client/cli/test_update.py . == 62 passed in 6.42 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 26531: Defining schema for the heartbeat RPC.
On Oct. 20, 2014, 8 p.m., Joshua Cohen wrote: src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line 109 https://reviews.apache.org/r/26531/diff/3/?file=723030#file723030line109 Other instances of delays stored in ms seem to be INT not BIGINT. Signed BIGINT is something on the order of 300,000 millenia between heartbeats? ;). Good point, it's actually i32 in the schema anyway. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/#review57415 --- On Oct. 16, 2014, 4:44 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/ --- (Updated Oct. 16, 2014, 4:44 p.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Bugs: AURORA-690 https://issues.apache.org/jira/browse/AURORA-690 Repository: aurora Description --- Defining the flag and the schema for the update coordination (aka heartbeats). Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445 src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831 src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e src/test/python/apache/aurora/client/api/test_scheduler_client.py d78e7dca28d67997bc6c98cff619ab94a257c7dc Diff: https://reviews.apache.org/r/26531/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26531: Defining schema for the heartbeat RPC.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/ --- (Updated Oct. 21, 2014, 5:58 p.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Changes --- CR comments. Bugs: AURORA-690 https://issues.apache.org/jira/browse/AURORA-690 Repository: aurora Description --- Defining the flag and the schema for the update coordination (aka heartbeats). Diffs (updated) - build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java e792d23d6bb13b4e61b078beea6d063f72f0d8fc src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445 src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831 src/main/thrift/org/apache/aurora/gen/api.thrift 401083621e1a1bbe43751b8bd168277543b9a812 src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e src/test/python/apache/aurora/client/api/test_scheduler_client.py 076008e400bd9200cfd70fc469a4c310f291d70f Diff: https://reviews.apache.org/r/26531/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26982: Make v2 job status look more like v1.
On Oct. 21, 2014, 1:57 p.m., David McLaughlin wrote: Is there an end to end test for this that needs updated? No. The end-to-end doesn't check the output from the status command. - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26982/#review57622 --- On Oct. 21, 2014, 12:19 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26982/ --- (Updated Oct. 21, 2014, 12:19 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: AURORA-874 https://issues.apache.org/jira/browse/AURORA-874 Repository: aurora Description --- Adds a header line to each task in a task status line specifying the instance number, host, etc., the way v1 did. (We had originally planned not to display that information in v2, but we also have tests that depend on it being present.) Diffs - src/main/python/apache/aurora/client/cli/jobs.py 7bbde156e64e969c6d402a04aaf7c038b919693a src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8 Diff: https://reviews.apache.org/r/26982/diff/ Testing --- $ ./pants src/test/python/apache/aurora/client/cli:job Build operating on top level addresses: set([BuildFileAddress(/Users/mchucarroll/Code/incubator-aurora/src/test/python/apache/aurora/client/cli/BUILD, job)]) = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3 plugins: cov, timeout collected 62 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py ... src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py src/test/python/apache/aurora/client/cli/test_open.py . src/test/python/apache/aurora/client/cli/test_restart.py src/test/python/apache/aurora/client/cli/test_status.py src/test/python/apache/aurora/client/cli/test_update.py . == 62 passed in 6.42 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 26982: Make v2 job status look more like v1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26982/#review57626 --- Ship it! Ship It! - David McLaughlin On Oct. 21, 2014, 4:19 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26982/ --- (Updated Oct. 21, 2014, 4:19 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: AURORA-874 https://issues.apache.org/jira/browse/AURORA-874 Repository: aurora Description --- Adds a header line to each task in a task status line specifying the instance number, host, etc., the way v1 did. (We had originally planned not to display that information in v2, but we also have tests that depend on it being present.) Diffs - src/main/python/apache/aurora/client/cli/jobs.py 7bbde156e64e969c6d402a04aaf7c038b919693a src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8 Diff: https://reviews.apache.org/r/26982/diff/ Testing --- $ ./pants src/test/python/apache/aurora/client/cli:job Build operating on top level addresses: set([BuildFileAddress(/Users/mchucarroll/Code/incubator-aurora/src/test/python/apache/aurora/client/cli/BUILD, job)]) = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3 plugins: cov, timeout collected 62 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py ... src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py src/test/python/apache/aurora/client/cli/test_open.py . src/test/python/apache/aurora/client/cli/test_restart.py src/test/python/apache/aurora/client/cli/test_status.py src/test/python/apache/aurora/client/cli/test_update.py . == 62 passed in 6.42 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 26753: Start removing clientv1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26753/ --- (Updated Oct. 21, 2014, 2:05 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Changes --- Address reviews. (Note that this builds on https://reviews.apache.org/r/26982/, which will need to be pushed before this.) Bugs: aurora-131 https://issues.apache.org/jira/browse/aurora-131 Repository: aurora Description --- - Make the aurora2 main target be the standalone clientv2; - Don't build the bridged client by default; but allow forced build using aurora2_bridge. - Modify cli tests so that they only depend on the standalone clientv2. - Modify vagrant config to make clientv2 the primary client. - Modify end-to-end tests to match the vagrant changes. (Note: end-to-end tests are failing, but in the same way as they fail without this change. I'm working on debugging that, but it should be its own change/review, and I don't want to delay reviewing this.) Diffs (updated) - docs/developing-aurora-client.md b9912bce44d65ddd7f1e35f0ea9356a89d5fe767 examples/vagrant/aurorabuild.sh 8659bffb8fb6170c02aef0edce92349540d4366a examples/vagrant/provision-dev-cluster.sh 1d4fd77a83dbfc6724a3a3b5f44301dc54b3085c examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 src/main/python/apache/aurora/client/cli/BUILD 995570325bbb09ecbcc2ace5d223760c5d49367f src/main/python/apache/aurora/client/cli/jobs.py 7bbde156e64e969c6d402a04aaf7c038b919693a src/test/python/apache/aurora/client/cli/test_api_from_cli.py 95aa649cfff9166dd10aa432c4d470739e8f06c5 src/test/python/apache/aurora/client/cli/test_cancel_update.py e7052465411165acb3d5145664f2f166ac052500 src/test/python/apache/aurora/client/cli/test_command_hooks.py 9fc6fe2c2063cda494437d83044557b345acacea src/test/python/apache/aurora/client/cli/test_config_noun.py dfcbd7217b1d51609fa01c4d9cefed5471c91718 src/test/python/apache/aurora/client/cli/test_create.py 328297ab1d29efb0adce8f4931a13929a04dcd9c src/test/python/apache/aurora/client/cli/test_cron.py c7b71c29d44150162fec8066947623fa91815424 src/test/python/apache/aurora/client/cli/test_diff.py 10817695352687cdb5b0c3ed9720e3091b230e68 src/test/python/apache/aurora/client/cli/test_help.py 551c9f949cda3971a370cb696216ec9584584336 src/test/python/apache/aurora/client/cli/test_inspect.py e997b9743b63d71f8624ecf5ca1dcae0227be70d src/test/python/apache/aurora/client/cli/test_kill.py f7601d82dbb45900bec2939dca2b921bf147961d src/test/python/apache/aurora/client/cli/test_logging.py 9ca4dceeaa87d5fb2e38fe0d83fdcdf1ee597a0e src/test/python/apache/aurora/client/cli/test_open.py c20649f5cada241d0f6e9ae5f88d300eac073517 src/test/python/apache/aurora/client/cli/test_plugins.py dc5edd4f03cee062673231a04908193480c8071c src/test/python/apache/aurora/client/cli/test_quota.py 88fb9aec4d1eae6ad05da01752a670f902bafb1b src/test/python/apache/aurora/client/cli/test_restart.py a753ab4aead7e2560cae77c441562811924f8f1b src/test/python/apache/aurora/client/cli/test_sla.py a1a3d8161ba747aa23a5e614e9ae31473d2058c1 src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8 src/test/python/apache/aurora/client/cli/test_supdate.py f3fa6cf6e9e080689593c40e787018eff46f8ede src/test/python/apache/aurora/client/cli/test_task_run.py 16fde14c03f6fd2c000e76625fad174835763f1b src/test/python/apache/aurora/client/cli/test_update.py cff1b6578aec6f5bcc1e610e58b47af233f32b41 src/test/sh/org/apache/aurora/e2e/test_common.sh 43d2516133c6d6cdb4236358f942396f057f739c src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 324aa4dbeff00e673fe73b87e3a0766856cd213c src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bbbf90b95e91bcdf8aaf8b2a7b577dee70a7c8a7 Diff: https://reviews.apache.org/r/26753/diff/ Testing --- - Ran all unit tests, confirmed they continue to pass. - Ran end-to-end tests (both v1 and v2 variants) with the updated setup, and verified that they fail in exactly the same way as before this change. Thanks, Mark Chu-Carroll
Re: Review Request 26985: Printing coverage report path on failed analysis.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26985/#review57630 --- Ship it! Ship It! - Kevin Sweeney On Oct. 21, 2014, 10:46 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26985/ --- (Updated Oct. 21, 2014, 10:46 a.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora Description --- Failed coverage analysis blocks coverage report file message. Moving the `doLast` block into `jacocoTestReport` task. Diffs - build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5 Diff: https://reviews.apache.org/r/26985/diff/ Testing --- BEFORE: ``` ... :jacocoTestReport UP-TO-DATE :analyzeReport FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':analyzeReport'. Instruction coverage of 0.88 exceeds min instruction coverage of 0.87, please raise the threshold! * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED ``` AFTER: ``` ... :jacocoTestReport Coverage report generated: file:///Users/mkhutornenko/workspace3/aurora/dist/reports/jacoco/test/html/index.html :analyzeReport FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':analyzeReport'. Instruction coverage of 0.88 exceeds min instruction coverage of 0.87, please raise the threshold! * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED ``` Thanks, Maxim Khutornenko
Re: Review Request 26753: Start removing clientv1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26753/ --- (Updated Oct. 21, 2014, 2:34 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Changes --- Rebase, now that 26982 was pushed. Bugs: aurora-131 https://issues.apache.org/jira/browse/aurora-131 Repository: aurora Description --- - Make the aurora2 main target be the standalone clientv2; - Don't build the bridged client by default; but allow forced build using aurora2_bridge. - Modify cli tests so that they only depend on the standalone clientv2. - Modify vagrant config to make clientv2 the primary client. - Modify end-to-end tests to match the vagrant changes. (Note: end-to-end tests are failing, but in the same way as they fail without this change. I'm working on debugging that, but it should be its own change/review, and I don't want to delay reviewing this.) Diffs (updated) - docs/developing-aurora-client.md b9912bce44d65ddd7f1e35f0ea9356a89d5fe767 examples/vagrant/aurorabuild.sh 8659bffb8fb6170c02aef0edce92349540d4366a examples/vagrant/provision-dev-cluster.sh 1d4fd77a83dbfc6724a3a3b5f44301dc54b3085c examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 src/main/python/apache/aurora/client/cli/BUILD 995570325bbb09ecbcc2ace5d223760c5d49367f src/test/python/apache/aurora/client/cli/test_api_from_cli.py 95aa649cfff9166dd10aa432c4d470739e8f06c5 src/test/python/apache/aurora/client/cli/test_cancel_update.py e7052465411165acb3d5145664f2f166ac052500 src/test/python/apache/aurora/client/cli/test_command_hooks.py 9fc6fe2c2063cda494437d83044557b345acacea src/test/python/apache/aurora/client/cli/test_config_noun.py dfcbd7217b1d51609fa01c4d9cefed5471c91718 src/test/python/apache/aurora/client/cli/test_create.py 328297ab1d29efb0adce8f4931a13929a04dcd9c src/test/python/apache/aurora/client/cli/test_cron.py c7b71c29d44150162fec8066947623fa91815424 src/test/python/apache/aurora/client/cli/test_diff.py 10817695352687cdb5b0c3ed9720e3091b230e68 src/test/python/apache/aurora/client/cli/test_help.py 551c9f949cda3971a370cb696216ec9584584336 src/test/python/apache/aurora/client/cli/test_inspect.py e997b9743b63d71f8624ecf5ca1dcae0227be70d src/test/python/apache/aurora/client/cli/test_kill.py f7601d82dbb45900bec2939dca2b921bf147961d src/test/python/apache/aurora/client/cli/test_logging.py 9ca4dceeaa87d5fb2e38fe0d83fdcdf1ee597a0e src/test/python/apache/aurora/client/cli/test_open.py c20649f5cada241d0f6e9ae5f88d300eac073517 src/test/python/apache/aurora/client/cli/test_plugins.py dc5edd4f03cee062673231a04908193480c8071c src/test/python/apache/aurora/client/cli/test_quota.py 88fb9aec4d1eae6ad05da01752a670f902bafb1b src/test/python/apache/aurora/client/cli/test_restart.py a753ab4aead7e2560cae77c441562811924f8f1b src/test/python/apache/aurora/client/cli/test_sla.py a1a3d8161ba747aa23a5e614e9ae31473d2058c1 src/test/python/apache/aurora/client/cli/test_status.py 4f62cf0c52e5837309cf7ad702df6d907df8f510 src/test/python/apache/aurora/client/cli/test_supdate.py f3fa6cf6e9e080689593c40e787018eff46f8ede src/test/python/apache/aurora/client/cli/test_task_run.py 16fde14c03f6fd2c000e76625fad174835763f1b src/test/python/apache/aurora/client/cli/test_update.py cff1b6578aec6f5bcc1e610e58b47af233f32b41 src/test/sh/org/apache/aurora/e2e/test_common.sh 43d2516133c6d6cdb4236358f942396f057f739c src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 324aa4dbeff00e673fe73b87e3a0766856cd213c src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bbbf90b95e91bcdf8aaf8b2a7b577dee70a7c8a7 Diff: https://reviews.apache.org/r/26753/diff/ Testing --- - Ran all unit tests, confirmed they continue to pass. - Ran end-to-end tests (both v1 and v2 variants) with the updated setup, and verified that they fail in exactly the same way as before this change. Thanks, Mark Chu-Carroll
Review Request 26991: Upgrade mesos to 0.20.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26991/ --- Review request for Aurora, David McLaughlin and Mark Chu-Carroll. Bugs: AURORA-875 https://issues.apache.org/jira/browse/AURORA-875 Repository: aurora Description --- See https://github.com/apache/mesos/blob/master/CHANGELOG Diffs - 3rdparty/python/BUILD b4fde0279bc0c4941e838b9f445411263905 build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5 docs/deploying-aurora-scheduler.md 9b89335bbf7ff4e7a8d47fabdfd659b188df7dae examples/vagrant/provision-dev-cluster.sh 1d4fd77a83dbfc6724a3a3b5f44301dc54b3085c Diff: https://reviews.apache.org/r/26991/diff/ Testing --- ./gradlew -Pq build ./pants src/test/python:all ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kevin Sweeney
Review Request 26995: Download thrift from archive.a.o.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26995/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-877 https://issues.apache.org/jira/browse/AURORA-877 Repository: aurora Description --- The us.apache.org URL 404s and breaks our build. Diffs - build-support/thrift/Makefile 11fac91cb2a2c67927d6f7f6d7de73e8c3336b59 Diff: https://reviews.apache.org/r/26995/diff/ Testing --- ./gradlew bootstrapThrift Thanks, Kevin Sweeney
Re: Review Request 26995: Download thrift from archive.a.o.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26995/#review57655 --- Ship it! Ship It! - Zameer Manji On Oct. 21, 2014, 1:54 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26995/ --- (Updated Oct. 21, 2014, 1:54 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-877 https://issues.apache.org/jira/browse/AURORA-877 Repository: aurora Description --- The us.apache.org URL 404s and breaks our build. Diffs - build-support/thrift/Makefile 11fac91cb2a2c67927d6f7f6d7de73e8c3336b59 Diff: https://reviews.apache.org/r/26995/diff/ Testing --- ./gradlew bootstrapThrift Thanks, Kevin Sweeney
Re: Review Request 26995: Download thrift from archive.a.o.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26995/#review57657 --- Ship it! Ship It! - Joshua Cohen On Oct. 21, 2014, 8:54 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26995/ --- (Updated Oct. 21, 2014, 8:54 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-877 https://issues.apache.org/jira/browse/AURORA-877 Repository: aurora Description --- The us.apache.org URL 404s and breaks our build. Diffs - build-support/thrift/Makefile 11fac91cb2a2c67927d6f7f6d7de73e8c3336b59 Diff: https://reviews.apache.org/r/26995/diff/ Testing --- ./gradlew bootstrapThrift Thanks, Kevin Sweeney
Re: Review Request 26995: Download thrift from archive.a.o.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26995/#review57659 --- build-support/thrift/Makefile https://reviews.apache.org/r/26995/#comment98466 Is there any evidence this mirror is any better SLA-wise that the old one? - Maxim Khutornenko On Oct. 21, 2014, 8:54 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26995/ --- (Updated Oct. 21, 2014, 8:54 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-877 https://issues.apache.org/jira/browse/AURORA-877 Repository: aurora Description --- The us.apache.org URL 404s and breaks our build. Diffs - build-support/thrift/Makefile 11fac91cb2a2c67927d6f7f6d7de73e8c3336b59 Diff: https://reviews.apache.org/r/26995/diff/ Testing --- ./gradlew bootstrapThrift Thanks, Kevin Sweeney
Re: Review Request 26995: Download thrift from archive.a.o.
On Oct. 21, 2014, 2:18 p.m., Maxim Khutornenko wrote: build-support/thrift/Makefile, line 15 https://reviews.apache.org/r/26995/diff/1/?file=727984#file727984line15 Is there any evidence this mirror is any better SLA-wise that the old one? From the [homepage](https://archive.apache.org): The main archive of all public software releases of the Apache Software Foundation. *This is simply a copy of the main distribution directory with the only difference that nothing will be ever removed over here*. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26995/#review57659 --- On Oct. 21, 2014, 1:54 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26995/ --- (Updated Oct. 21, 2014, 1:54 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-877 https://issues.apache.org/jira/browse/AURORA-877 Repository: aurora Description --- The us.apache.org URL 404s and breaks our build. Diffs - build-support/thrift/Makefile 11fac91cb2a2c67927d6f7f6d7de73e8c3336b59 Diff: https://reviews.apache.org/r/26995/diff/ Testing --- ./gradlew bootstrapThrift Thanks, Kevin Sweeney
Review Request 26997: Adding quota check into scheduleCronJob RPC.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26997/ --- Review request for Aurora, Joshua Cohen and Kevin Sweeney. Bugs: AURORA-824 https://issues.apache.org/jira/browse/AURORA-824 Repository: aurora Description --- Adding quota check into scheduleCronJob. Also, added missing tests for cron-related RPCs. Diffs - build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5 src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java e792d23d6bb13b4e61b078beea6d063f72f0d8fc src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f36a88fda3539553800bd727c3d2a77a54f1e71c Diff: https://reviews.apache.org/r/26997/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26997: Adding quota check into scheduleCronJob RPC.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26997/#review57662 --- Ship it! Ship It! - Kevin Sweeney On Oct. 21, 2014, 2:24 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26997/ --- (Updated Oct. 21, 2014, 2:24 p.m.) Review request for Aurora, Joshua Cohen and Kevin Sweeney. Bugs: AURORA-824 https://issues.apache.org/jira/browse/AURORA-824 Repository: aurora Description --- Adding quota check into scheduleCronJob. Also, added missing tests for cron-related RPCs. Diffs - build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5 src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java e792d23d6bb13b4e61b078beea6d063f72f0d8fc src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f36a88fda3539553800bd727c3d2a77a54f1e71c Diff: https://reviews.apache.org/r/26997/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26995: Download thrift from archive.a.o.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26995/#review57664 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 21, 2014, 8:54 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26995/ --- (Updated Oct. 21, 2014, 8:54 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-877 https://issues.apache.org/jira/browse/AURORA-877 Repository: aurora Description --- The us.apache.org URL 404s and breaks our build. Diffs - build-support/thrift/Makefile 11fac91cb2a2c67927d6f7f6d7de73e8c3336b59 Diff: https://reviews.apache.org/r/26995/diff/ Testing --- ./gradlew bootstrapThrift Thanks, Kevin Sweeney
Re: Review Request 26985: Printing coverage report path on failed analysis.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26985/ --- (Updated Oct. 21, 2014, 9:33 p.m.) Review request for Aurora, Joshua Cohen and Kevin Sweeney. Changes --- -wfarner +kevints Repository: aurora Description --- Failed coverage analysis blocks coverage report file message. Moving the `doLast` block into `jacocoTestReport` task. Diffs - build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5 Diff: https://reviews.apache.org/r/26985/diff/ Testing --- BEFORE: ``` ... :jacocoTestReport UP-TO-DATE :analyzeReport FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':analyzeReport'. Instruction coverage of 0.88 exceeds min instruction coverage of 0.87, please raise the threshold! * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED ``` AFTER: ``` ... :jacocoTestReport Coverage report generated: file:///Users/mkhutornenko/workspace3/aurora/dist/reports/jacoco/test/html/index.html :analyzeReport FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':analyzeReport'. Instruction coverage of 0.88 exceeds min instruction coverage of 0.87, please raise the threshold! * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED ``` Thanks, Maxim Khutornenko
Re: Review Request 26998: Building aurora client/admin before running e2 tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26998/#review57679 --- This end-to-end test runs against all components (it recently caught an executor build break). Any reason not to build them all here? - Kevin Sweeney On Oct. 21, 2014, 3:14 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26998/ --- (Updated Oct. 21, 2014, 3:14 p.m.) Review request for Aurora, Joshua Cohen and Kevin Sweeney. Bugs: AURORA-498 https://issues.apache.org/jira/browse/AURORA-498 Repository: aurora Description --- Building aurora client/admin before running e2 tests. Diffs - src/test/sh/org/apache/aurora/e2e/test_common.sh 43d2516133c6d6cdb4236358f942396f057f739c src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 324aa4dbeff00e673fe73b87e3a0766856cd213c src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bbbf90b95e91bcdf8aaf8b2a7b577dee70a7c8a7 Diff: https://reviews.apache.org/r/26998/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh Thanks, Maxim Khutornenko
Re: Review Request 26998: Building aurora client/admin before running e2 tests.
On Oct. 21, 2014, 10:15 p.m., Kevin Sweeney wrote: This end-to-end test runs against all components (it recently caught an executor build break). Any reason not to build them all here? +1, I'd say build them all by default but maybe add an env switch to skip building for speedier iteration during development (last step before posting review should still be to run the tests with cleanly built artifacts ofc). - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26998/#review57679 --- On Oct. 21, 2014, 10:14 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26998/ --- (Updated Oct. 21, 2014, 10:14 p.m.) Review request for Aurora, Joshua Cohen and Kevin Sweeney. Bugs: AURORA-498 https://issues.apache.org/jira/browse/AURORA-498 Repository: aurora Description --- Building aurora client/admin before running e2 tests. Diffs - src/test/sh/org/apache/aurora/e2e/test_common.sh 43d2516133c6d6cdb4236358f942396f057f739c src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 324aa4dbeff00e673fe73b87e3a0766856cd213c src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bbbf90b95e91bcdf8aaf8b2a7b577dee70a7c8a7 Diff: https://reviews.apache.org/r/26998/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh Thanks, Maxim Khutornenko
Re: Review Request 26998: Building aurora client/admin before running e2 tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26998/ --- (Updated Oct. 21, 2014, 10:29 p.m.) Review request for Aurora, Joshua Cohen and Kevin Sweeney. Changes --- CR comments. Bugs: AURORA-498 https://issues.apache.org/jira/browse/AURORA-498 Repository: aurora Description --- Building aurora client/admin before running e2 tests. Diffs (updated) - src/test/sh/org/apache/aurora/e2e/test_common.sh 43d2516133c6d6cdb4236358f942396f057f739c src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 324aa4dbeff00e673fe73b87e3a0766856cd213c src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bbbf90b95e91bcdf8aaf8b2a7b577dee70a7c8a7 Diff: https://reviews.apache.org/r/26998/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh Thanks, Maxim Khutornenko
Re: Review Request 26998: Building aurora client/admin before running e2 tests.
On Oct. 21, 2014, 10:15 p.m., Kevin Sweeney wrote: This end-to-end test runs against all components (it recently caught an executor build break). Any reason not to build them all here? Joshua Cohen wrote: +1, I'd say build them all by default but maybe add an env switch to skip building for speedier iteration during development (last step before posting review should still be to run the tests with cleanly built artifacts ofc). Thought about that but given that it's mostly a client validation suite decided to keep it lean for better perf. I am happy to add other components if no objection. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26998/#review57679 --- On Oct. 21, 2014, 10:14 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26998/ --- (Updated Oct. 21, 2014, 10:14 p.m.) Review request for Aurora, Joshua Cohen and Kevin Sweeney. Bugs: AURORA-498 https://issues.apache.org/jira/browse/AURORA-498 Repository: aurora Description --- Building aurora client/admin before running e2 tests. Diffs - src/test/sh/org/apache/aurora/e2e/test_common.sh 43d2516133c6d6cdb4236358f942396f057f739c src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 324aa4dbeff00e673fe73b87e3a0766856cd213c src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bbbf90b95e91bcdf8aaf8b2a7b577dee70a7c8a7 Diff: https://reviews.apache.org/r/26998/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh Thanks, Maxim Khutornenko
Review Request 27001: Fixing python style check issues.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27001/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Fixing build broken by https://reviews.apache.org/r/26363 due to python style check issues. Diffs - src/main/python/apache/aurora/client/cli/jobs.py 362af7a08b5d92b21747f0f3739f949a7dbaa45e src/test/python/apache/aurora/client/cli/test_update.py 1aff9816cd33b4dfc2e399e8b4423e9e6f4a67df Diff: https://reviews.apache.org/r/27001/diff/ Testing --- ./build-support/hooks/pre-commit ./pants src/test/python/apache/aurora/client/cli:all Thanks, Maxim Khutornenko
Re: Review Request 26998: Building aurora client/admin before running e2 tests.
On Oct. 21, 2014, 3:32 p.m., Joshua Cohen wrote: Thoughts on adding an 'all' component to aurorabuild.sh that builds everything? We do this in three places now that I know of (these two and the provision script). Maxim Khutornenko wrote: That's exactly what I was hesitating on but decided in favor of an explicit approach to make it completely obvious what is affected in every case. Also, a minor (though temporary) speedup of not building unrelated client version for every test path. +1 to an 'all' target - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26998/#review57690 --- On Oct. 21, 2014, 3:29 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26998/ --- (Updated Oct. 21, 2014, 3:29 p.m.) Review request for Aurora, Joshua Cohen and Kevin Sweeney. Bugs: AURORA-498 https://issues.apache.org/jira/browse/AURORA-498 Repository: aurora Description --- Building aurora client/admin before running e2 tests. Diffs - src/test/sh/org/apache/aurora/e2e/test_common.sh 43d2516133c6d6cdb4236358f942396f057f739c src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 324aa4dbeff00e673fe73b87e3a0766856cd213c src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bbbf90b95e91bcdf8aaf8b2a7b577dee70a7c8a7 Diff: https://reviews.apache.org/r/26998/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh Thanks, Maxim Khutornenko
Re: Review Request 26998: Building aurora client/admin before running e2 tests.
On Oct. 21, 2014, 3:15 p.m., Kevin Sweeney wrote: This end-to-end test runs against all components (it recently caught an executor build break). Any reason not to build them all here? Joshua Cohen wrote: +1, I'd say build them all by default but maybe add an env switch to skip building for speedier iteration during development (last step before posting review should still be to run the tests with cleanly built artifacts ofc). Maxim Khutornenko wrote: Thought about that but given that it's mostly a client validation suite decided to keep it lean for better perf. I am happy to add other components if no objection. It's doing a lot more than just validating the client, for example it verifies that the serverset announcer functionality of the executor is tested, as well as a test of the full communication path (client-scheduler-mesos-master-mesos-slave-executor) with real libmesos binaries. We just use client output as a proxy for this because it's convenient. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26998/#review57679 --- On Oct. 21, 2014, 3:29 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26998/ --- (Updated Oct. 21, 2014, 3:29 p.m.) Review request for Aurora, Joshua Cohen and Kevin Sweeney. Bugs: AURORA-498 https://issues.apache.org/jira/browse/AURORA-498 Repository: aurora Description --- Building aurora client/admin before running e2 tests. Diffs - src/test/sh/org/apache/aurora/e2e/test_common.sh 43d2516133c6d6cdb4236358f942396f057f739c src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 324aa4dbeff00e673fe73b87e3a0766856cd213c src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bbbf90b95e91bcdf8aaf8b2a7b577dee70a7c8a7 Diff: https://reviews.apache.org/r/26998/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh Thanks, Maxim Khutornenko
Re: Review Request 27001: Fixing python style check issues.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27001/#review57699 --- Ship it! Ship It! - Kevin Sweeney On Oct. 21, 2014, 3:38 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27001/ --- (Updated Oct. 21, 2014, 3:38 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Fixing build broken by https://reviews.apache.org/r/26363 due to python style check issues. Diffs - src/main/python/apache/aurora/client/cli/jobs.py 362af7a08b5d92b21747f0f3739f949a7dbaa45e src/test/python/apache/aurora/client/cli/test_update.py 1aff9816cd33b4dfc2e399e8b4423e9e6f4a67df Diff: https://reviews.apache.org/r/27001/diff/ Testing --- ./build-support/hooks/pre-commit ./pants src/test/python/apache/aurora/client/cli:all Thanks, Maxim Khutornenko
Re: Review Request 26998: Building aurora client/admin before running e2 tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26998/#review57714 --- Ship it! Thanks! - Joshua Cohen On Oct. 21, 2014, 11:22 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26998/ --- (Updated Oct. 21, 2014, 11:22 p.m.) Review request for Aurora, Joshua Cohen and Kevin Sweeney. Bugs: AURORA-498 https://issues.apache.org/jira/browse/AURORA-498 Repository: aurora Description --- Building aurora client/admin before running e2 tests. Diffs - examples/vagrant/aurorabuild.sh 8659bffb8fb6170c02aef0edce92349540d4366a examples/vagrant/provision-dev-cluster.sh 1d4fd77a83dbfc6724a3a3b5f44301dc54b3085c src/test/sh/org/apache/aurora/e2e/test_common.sh 43d2516133c6d6cdb4236358f942396f057f739c src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 324aa4dbeff00e673fe73b87e3a0766856cd213c src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bbbf90b95e91bcdf8aaf8b2a7b577dee70a7c8a7 Diff: https://reviews.apache.org/r/26998/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh Thanks, Maxim Khutornenko
Re: Review Request 26997: Adding quota check into scheduleCronJob RPC.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26997/#review57723 --- Ship it! src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java https://reviews.apache.org/r/26997/#comment98555 Consider sticking to the standard here of using guava's ToStringHelper instead: http://docs.guava-libraries.googlecode.com/git-history/release/javadoc/com/google/common/base/MoreObjects.html#toStringHelper(java.lang.Object) - Bill Farner On Oct. 21, 2014, 9:24 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26997/ --- (Updated Oct. 21, 2014, 9:24 p.m.) Review request for Aurora, Joshua Cohen and Kevin Sweeney. Bugs: AURORA-824 https://issues.apache.org/jira/browse/AURORA-824 Repository: aurora Description --- Adding quota check into scheduleCronJob. Also, added missing tests for cron-related RPCs. Diffs - build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5 src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java e792d23d6bb13b4e61b078beea6d063f72f0d8fc src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f36a88fda3539553800bd727c3d2a77a54f1e71c Diff: https://reviews.apache.org/r/26997/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26997: Adding quota check into scheduleCronJob RPC.
On Oct. 21, 2014, 6:40 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java, line 150 https://reviews.apache.org/r/26997/diff/1/?file=728016#file728016line150 Consider sticking to the standard here of using guava's ToStringHelper instead: http://docs.guava-libraries.googlecode.com/git-history/release/javadoc/com/google/common/base/MoreObjects.html#toStringHelper(java.lang.Object) +1 to that - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26997/#review57723 --- On Oct. 21, 2014, 2:24 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26997/ --- (Updated Oct. 21, 2014, 2:24 p.m.) Review request for Aurora, Joshua Cohen and Kevin Sweeney. Bugs: AURORA-824 https://issues.apache.org/jira/browse/AURORA-824 Repository: aurora Description --- Adding quota check into scheduleCronJob. Also, added missing tests for cron-related RPCs. Diffs - build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5 src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java e792d23d6bb13b4e61b078beea6d063f72f0d8fc src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f36a88fda3539553800bd727c3d2a77a54f1e71c Diff: https://reviews.apache.org/r/26997/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26753: Start removing clientv1.
On Oct. 15, 2014, 6:24 p.m., Bill Farner wrote: Should `docs/clientv2.md` be rehashed/removed to wipe traces of v1, or in a separte diff? Can you also update `examples/vagrant/test_tutorial.sh`? I suspect it's broken by this patch. Mark Chu-Carroll wrote: I'd prefer to leave that doc - it's a historical which will be useful for understanding the code. I think just adding a header to it saying that it's a historical document is enough. But you're right that the docs in general need update - in particular, the developing-aurora-client doc should remove references to v1. I would prefer to make that a separate change. Can you please file a ticket and follow up ~immediately updating docs/clientv2.md? - shouldn't be called v2 - needs to be scrubbed for migratory statements like `Our goal is to replace the current Aurora command-line client` - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26753/#review56757 --- On Oct. 21, 2014, 6:34 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26753/ --- (Updated Oct. 21, 2014, 6:34 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: aurora-131 https://issues.apache.org/jira/browse/aurora-131 Repository: aurora Description --- - Make the aurora2 main target be the standalone clientv2; - Don't build the bridged client by default; but allow forced build using aurora2_bridge. - Modify cli tests so that they only depend on the standalone clientv2. - Modify vagrant config to make clientv2 the primary client. - Modify end-to-end tests to match the vagrant changes. (Note: end-to-end tests are failing, but in the same way as they fail without this change. I'm working on debugging that, but it should be its own change/review, and I don't want to delay reviewing this.) Diffs - docs/developing-aurora-client.md b9912bce44d65ddd7f1e35f0ea9356a89d5fe767 examples/vagrant/aurorabuild.sh 8659bffb8fb6170c02aef0edce92349540d4366a examples/vagrant/provision-dev-cluster.sh 1d4fd77a83dbfc6724a3a3b5f44301dc54b3085c examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 src/main/python/apache/aurora/client/cli/BUILD 995570325bbb09ecbcc2ace5d223760c5d49367f src/test/python/apache/aurora/client/cli/test_api_from_cli.py 95aa649cfff9166dd10aa432c4d470739e8f06c5 src/test/python/apache/aurora/client/cli/test_cancel_update.py e7052465411165acb3d5145664f2f166ac052500 src/test/python/apache/aurora/client/cli/test_command_hooks.py 9fc6fe2c2063cda494437d83044557b345acacea src/test/python/apache/aurora/client/cli/test_config_noun.py dfcbd7217b1d51609fa01c4d9cefed5471c91718 src/test/python/apache/aurora/client/cli/test_create.py 328297ab1d29efb0adce8f4931a13929a04dcd9c src/test/python/apache/aurora/client/cli/test_cron.py c7b71c29d44150162fec8066947623fa91815424 src/test/python/apache/aurora/client/cli/test_diff.py 10817695352687cdb5b0c3ed9720e3091b230e68 src/test/python/apache/aurora/client/cli/test_help.py 551c9f949cda3971a370cb696216ec9584584336 src/test/python/apache/aurora/client/cli/test_inspect.py e997b9743b63d71f8624ecf5ca1dcae0227be70d src/test/python/apache/aurora/client/cli/test_kill.py f7601d82dbb45900bec2939dca2b921bf147961d src/test/python/apache/aurora/client/cli/test_logging.py 9ca4dceeaa87d5fb2e38fe0d83fdcdf1ee597a0e src/test/python/apache/aurora/client/cli/test_open.py c20649f5cada241d0f6e9ae5f88d300eac073517 src/test/python/apache/aurora/client/cli/test_plugins.py dc5edd4f03cee062673231a04908193480c8071c src/test/python/apache/aurora/client/cli/test_quota.py 88fb9aec4d1eae6ad05da01752a670f902bafb1b src/test/python/apache/aurora/client/cli/test_restart.py a753ab4aead7e2560cae77c441562811924f8f1b src/test/python/apache/aurora/client/cli/test_sla.py a1a3d8161ba747aa23a5e614e9ae31473d2058c1 src/test/python/apache/aurora/client/cli/test_status.py 4f62cf0c52e5837309cf7ad702df6d907df8f510 src/test/python/apache/aurora/client/cli/test_supdate.py f3fa6cf6e9e080689593c40e787018eff46f8ede src/test/python/apache/aurora/client/cli/test_task_run.py 16fde14c03f6fd2c000e76625fad174835763f1b src/test/python/apache/aurora/client/cli/test_update.py cff1b6578aec6f5bcc1e610e58b47af233f32b41 src/test/sh/org/apache/aurora/e2e/test_common.sh 43d2516133c6d6cdb4236358f942396f057f739c src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 324aa4dbeff00e673fe73b87e3a0766856cd213c src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
Re: Review Request 26991: Upgrade mesos to 0.20.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26991/#review57726 --- Ship it! Ship It! - Bill Farner On Oct. 21, 2014, 7:42 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26991/ --- (Updated Oct. 21, 2014, 7:42 p.m.) Review request for Aurora, David McLaughlin and Mark Chu-Carroll. Bugs: AURORA-875 https://issues.apache.org/jira/browse/AURORA-875 Repository: aurora Description --- See https://github.com/apache/mesos/blob/master/CHANGELOG Diffs - 3rdparty/python/BUILD b4fde0279bc0c4941e838b9f445411263905 build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5 docs/deploying-aurora-scheduler.md 9b89335bbf7ff4e7a8d47fabdfd659b188df7dae examples/vagrant/provision-dev-cluster.sh 1d4fd77a83dbfc6724a3a3b5f44301dc54b3085c Diff: https://reviews.apache.org/r/26991/diff/ Testing --- ./gradlew -Pq build ./pants src/test/python:all ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kevin Sweeney
Re: Review Request 26991: Upgrade mesos to 0.20.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26991/#review57727 --- Ship it! Ship It! - David McLaughlin On Oct. 21, 2014, 7:42 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26991/ --- (Updated Oct. 21, 2014, 7:42 p.m.) Review request for Aurora, David McLaughlin and Mark Chu-Carroll. Bugs: AURORA-875 https://issues.apache.org/jira/browse/AURORA-875 Repository: aurora Description --- See https://github.com/apache/mesos/blob/master/CHANGELOG Diffs - 3rdparty/python/BUILD b4fde0279bc0c4941e838b9f445411263905 build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5 docs/deploying-aurora-scheduler.md 9b89335bbf7ff4e7a8d47fabdfd659b188df7dae examples/vagrant/provision-dev-cluster.sh 1d4fd77a83dbfc6724a3a3b5f44301dc54b3085c Diff: https://reviews.apache.org/r/26991/diff/ Testing --- ./gradlew -Pq build ./pants src/test/python:all ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kevin Sweeney
