Re: Review Request 27779: Create the PyCharm project configuration for easier IDE setup.

2014-11-10 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27779/#review60634 --- Ship it! Ship It! - Zameer Manji On Nov. 8, 2014, 11:27 a.m.,

Re: Review Request 27779: Create the PyCharm project configuration for easier IDE setup.

2014-11-10 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27779/#review60635 --- Ship it! Ship It! - Kevin Sweeney On Nov. 8, 2014, 11:27 a.m.,

Re: Review Request 27770: Make it easier to request another ReviewBot run, and flag diffs that seem to lack test coverage.

2014-11-10 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27770/#review60631 --- Ship it! build-support/jenkins/review_feedback.py

Re: Review Request 27710: Remove stracktrace redirection.

2014-11-10 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27710/#review60637 --- Bill, since you are the only committer and everyone has given a

Re: Review Request 27772: Fix false passing test case in SchedulerDriverServiceTest.

2014-11-10 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27772/#review60639 --- Ship it! Ship It! - Kevin Sweeney On Nov. 7, 2014, 9:53 p.m.,

Re: Review Request 27770: Make it easier to request another ReviewBot run, and flag diffs that seem to lack test coverage.

2014-11-10 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27770/#review60650 --- Ship it! Awesome. - David McLaughlin On Nov. 8, 2014, 4:24

Re: Review Request 27770: Make it easier to request another ReviewBot run, and flag diffs that seem to lack test coverage.

2014-11-10 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27770/#review60638 --- Ship it! build-support/jenkins/review_feedback.py

Re: Review Request 27828: Move read-modify-write logic out of AttributeStore.Mutable for simpler layering.

2014-11-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27828/#review60675 --- Ship it! Master (54b0262) is green with this patch.

Re: Review Request 27828: Move read-modify-write logic out of AttributeStore.Mutable for simpler layering.

2014-11-10 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27828/#review60677 --- Ship it! Ship It! - Kevin Sweeney On Nov. 10, 2014, 12:50 p.m.,

Review Request 27830: Undo 0.6.0 .auroraversion and CHANGELOG changes to prepare for 0.6.0-RC1

2014-11-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27830/ --- Review request for Aurora and Jake Farrell. Bugs: AURORA-711

Re: Review Request 27830: Undo 0.6.0 .auroraversion and CHANGELOG changes to prepare for 0.6.0-RC1

2014-11-10 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27830/#review60680 --- Ship it! Ship It! - Jake Farrell On Nov. 10, 2014, 9:11 p.m.,

Re: Review Request 27828: Move read-modify-write logic out of AttributeStore.Mutable for simpler layering.

2014-11-10 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27828/#review60678 --- Ship it! Ship It! - Zameer Manji On Nov. 10, 2014, 12:50 p.m.,

Review Request 27828: Move read-modify-write logic out of AttributeStore.Mutable for simpler layering.

2014-11-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27828/ --- Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-913

Re: Review Request 27657: Print out the job url after scheduling a cron job.

2014-11-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27657/#review60696 --- Ship it! This is now on master: $ git log -1 origin/master

Re: Review Request 27710: Remove stracktrace redirection.

2014-11-10 Thread Bill Farner
On Nov. 10, 2014, 6:49 p.m., Zameer Manji wrote: Bill, since you are the only committer and everyone has given a shipit can you please commit this change? Before i commit, can you run and confirm passing end-to-end tests? ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Re: Review Request 27710: Remove stracktrace redirection.

2014-11-10 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27710/ --- (Updated Nov. 10, 2014, 3:36 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 27710: Remove stracktrace redirection.

2014-11-10 Thread Zameer Manji
On Nov. 10, 2014, 10:49 a.m., Zameer Manji wrote: Bill, since you are the only committer and everyone has given a shipit can you please commit this change? Bill Farner wrote: Before i commit, can you run and confirm passing end-to-end tests?

Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-10 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-885

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-10 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/ --- (Updated Nov. 11, 2014, 12:29 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/#review60723 --- Master (01958b1) is red with this patch.

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-10 Thread David McLaughlin
On Nov. 11, 2014, 12:43 a.m., Aurora ReviewBot wrote: Master (01958b1) is red with this patch. ./build-support/jenkins/build.sh Skipping installation of

Re: Review Request 27710: Remove stracktrace redirection.

2014-11-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27710/#review60727 --- Ship it! This is now on master: $ git log -1 origin/master

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/#review60728 --- Ship it! Master (01958b1) is green with this patch.