Re: Review Request 28731: Implemented TaskScheduler benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28731/#review66972 --- Master (1089413) is green with this patch. ./build-support/jenkins

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

> On Jan. 7, 2015, 1:39 a.m., Bill Farner wrote: > > Thanks for the patch! Most of my comments are style-related, but i think a > > bunch of the python changes are unneeded. Cool, I'll clean up these style comments tomorrow morning. > On Jan. 7, 2015, 1:39 a.m., Bill Farner wrote: > > api/sr

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29464/#review66935 --- Thanks for the patch! Most of my comments are style-related, but i

Re: Review Request 28731: Implemented TaskScheduler benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28731/ --- (Updated Jan. 7, 2015, 1:34 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 28731: Implemented TaskScheduler benchmarks.

> On Jan. 5, 2015, 8:38 p.m., Bill Farner wrote: > > src/jmh/java/org/apache/aurora/benchmark/Hosts.java, line 44 > > > > > > It would be nice to supply the minimal attributes we expect - host and > > rack designations

Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28617/#review66964 --- Ship it! Master (8c49029) is green with this patch. ./build-suppo

Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28617/ --- (Updated Jan. 7, 2015, 12:26 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.

> On Dec. 24, 2014, 12:26 a.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 79 > > > > > > How about either > > > > 1) Make this a member function of VetoGroup (so it'

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29137/#review66952 --- Ship it! Master (8c49029) is green with this patch. ./build-suppo

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review66950 --- Ship it! Master (8c49029) is green with this patch. ./build-suppo

Re: Review Request 29015: Suppressing duplicate error messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29015/#review66949 --- Ship it! Ship It! - Zameer Manji On Jan. 6, 2015, 3:49 p.m., Max

Re: Review Request 29015: Suppressing duplicate error messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29015/ --- (Updated Jan. 6, 2015, 11:49 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 29015: Suppressing duplicate error messages.

> On Dec. 15, 2014, 8:38 p.m., Zameer Manji wrote: > > The changes look good to me. Can you please update the testing portion of > > the ticket with the actual outout from a vagrant session? Added killall example. - Maxim --- This is a

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 6, 2015, 11:32 p.m.) Review request for Aurora, Jay Buffington, K

Re: Review Request 29117: Adding thrift API changes document.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/ --- (Updated Jan. 6, 2015, 11:30 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29137/ --- (Updated Jan. 6, 2015, 11:30 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66943 --- Ship it! Ship It! - Brian Wickman On Jan. 5, 2015, 7:07 p.m., Jo

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29464/#review66937 --- Ship it! Master (9f6ec4b) is green with this patch. ./build-suppo

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

> On Jan. 6, 2015, 9:46 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java, > > line 29 > > > > > > There's some legacy baggage we could shed here if you'r

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29464/ --- (Updated Jan. 6, 2015, 10:45 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 29216: Removing client v1 code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29216/#review66928 --- Ship it! src/main/python/apache/aurora/client/base.py

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

> On Jan. 6, 2015, 9:46 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java, > > line 29 > > > > > > There's some legacy baggage we could shed here if you'r

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

> On Dec. 29, 2014, 8:36 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/LocalServiceRegistryWithOverrides.java, > > line 21 > > > > > > Convention is to place CmdLine Args in Gui

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29464/#review66920 --- src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryW

Re: Review Request 28971: Begin dismantling client v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28971/ --- (Updated Jan. 6, 2015, 9:23 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 28971: Begin dismantling client v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28971/#review66914 --- Ship it! Master (1c53b94) is green with this patch. ./build-suppo

Re: Review Request 28971: Begin dismantling client v1.

> On Jan. 6, 2015, 9:20 p.m., Kevin Sweeney wrote: > > docs/clientv2.md, line 180 > > > > > > remove reference to "more consistent". I think this doc was initially > > written as a design doc to justify the client rew

Re: Review Request 28971: Begin dismantling client v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28971/#review66912 --- Ship it! docs/clientv2.md

Re: Review Request 28971: Begin dismantling client v1.

> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote: > > docs/client-commands.md, line 192 > > > > > > while at it, how about s/shard/instance/g/ Done. > On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote: >

Re: Review Request 28971: Begin dismantling client v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28971/ --- (Updated Jan. 6, 2015, 9:15 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66910 --- Ship it! Ship It! - Kevin Sweeney On Jan. 5, 2015, 11:07 a.m., J

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66909 --- *ping* - Joshua Cohen On Jan. 5, 2015, 7:07 p.m., Joshua Cohen wr

Re: Review Request 28971: Begin dismantling client v1.

> On Dec. 11, 2014, 10:56 p.m., Zameer Manji wrote: > > src/main/python/apache/aurora/client/BUILD, line 102 > > > > > > Are we going to keep the artifact name like this? Good catch, i think we should not. Fixed. -

Re: Review Request 29463: Upgrade pystachio to 0.7.4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29463/#review66897 --- Ship it! Master (c1174a7) is green with this patch. ./build-suppo

Re: Review Request 29271: Removing cron schedule support from createJob and killTasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29271/#review66895 --- Ship it! Ship It! - Bill Farner On Jan. 6, 2015, 7:56 p.m., Maxi

Re: Review Request 29271: Removing cron schedule support from createJob and killTasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29271/ --- (Updated Jan. 6, 2015, 7:56 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29464/#review66894 --- Ship it! Master (c1174a7) is green with this patch. ./build-suppo

Re: Review Request 29472: [WIP] Updates documentation markdown to a consistent style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29472/#review66892 --- This patch does not apply cleanly on master (c1174a7), do you need t

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66891 --- Ship it! Master (c1174a7) is green with this patch. ./build-suppo

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review66890 --- This patch does not apply cleanly on master (c1174a7), do you need t

Re: Review Request 28913: Remove SANDBOX_DELETED state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28913/#review66889 --- Ship it! Master (c1174a7) is green with this patch. ./build-suppo

Re: Review Request 29491: [AURORA-986] RequestLoggerTest failed for Locale.FRANCE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29491/#review66888 --- Ship it! Master (c1174a7) is green with this patch. ./build-suppo

Re: Review Request 29491: [AURORA-986] RequestLoggerTest failed for Locale.FRANCE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29491/#review66887 --- Ship it! Ship It! - Kevin Sweeney On Jan. 5, 2015, 1:34 p.m., Is

Re: Review Request 28913: Remove SANDBOX_DELETED state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28913/ --- (Updated Jan. 6, 2015, 7 p.m.) Review request for Aurora, Kevin Sweeney and Max

Re: Review Request 28913: Remove SANDBOX_DELETED state.

> On Dec. 16, 2014, 12:48 a.m., Maxim Khutornenko wrote: > > src/test/java/org/apache/aurora/scheduler/base/JobsTest.java, line 39 > > > > > > Remove the TODO. Done. - Bill -