date:20150106

Re: Review Request 28731: Implemented TaskScheduler benchmarks.

2015-01-06 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review66972
---


Master (1089413) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 7, 2015, 1:34 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28731/
> ---
> 
> (Updated Jan. 7, 2015, 1:34 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added baseline benchmarks for a few static veto cases.
> 
> 
> Diffs
> -
> 
>   build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 
>   src/jmh/java/org/apache/aurora/benchmark/Hosts.java PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/Offers.java PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulerBenchmark.java 
> 5cecada93e4e04b689e826af49f691ed7e94ae49 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/Tasks.java PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeClusterState.java 
> PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeDriver.java PRE-CREATION 
>   
> src/jmh/java/org/apache/aurora/benchmark/fakes/FakeRescheduleCalculator.java 
> PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> b6402ae42e3c7e4dca1c120fa6ef82d2d69e69d5 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterState.java 
> f7e157c890b5627411acd4bd5c2559ef4829147c 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 
> 0204d14b19ae412236f19ca274d81decb4eba12d 
> 
> Diff: https://reviews.apache.org/r/28731/diff/
> 
> 
> Testing
> ---
> 
> Sample run on a local box:
> ```
> # VM invoker: 
> /Library/Java/JavaVirtualMachines/jdk1.7.0_25.jdk/Contents/Home/jre/bin/java
> # VM options: -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en 
> -Duser.variant
> # Warmup: 10 iterations, 1 s each
> # Measurement: 100 iterations, 1 s each
> # Timeout: 10 min per iteration
> # Threads: 1 thread, will synchronize iterations
> # Benchmark mode: Average time, time/op
> # Benchmark: 
> org.apache.aurora.benchmark.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.runBenchmark
> 
> # Run progress: 0.00% complete, ETA 00:05:30
> # Fork: 1 of 1
> # Warmup Iteration   1: 278284250.000 ns/op
> # Warmup Iteration   2: 70294312.500 ns/op
> # Warmup Iteration   3: 19293379.310 ns/op
> # Warmup Iteration   4: 11945387.097 ns/op
> # Warmup Iteration   5: 10725388.350 ns/op
> # Warmup Iteration   6: 13043282.353 ns/op
> # Warmup Iteration   7: 9233083.333 ns/op
> # Warmup Iteration   8: 9521051.724 ns/op
> # Warmup Iteration   9: 10750854.369 ns/op
> # Warmup Iteration  10: 7460243.243 ns/op
> Iteration   1: 7885364.286 ns/op
> Iteration   2: 7735139.860 ns/op
> Iteration   3: 7660208.333 ns/op
> Iteration   4: 7761204.225 ns/op
> Iteration   5: 7868907.143 ns/op
> Iteration   6: 7567404.110 ns/op
> Iteration   7: 7611000.000 ns/op
> Iteration   8: 7766154.930 ns/op
> Iteration   9: 7669344.828 ns/op
> Iteration  10: 7707783.217 ns/op
> Iteration  11: 7435651.007 ns/op
> Iteration  12: 7697631.944 ns/op
> Iteration  13: 7712531.469 ns/op
> Iteration  14: 7899407.143 ns/op
> Iteration  15: 7448472.973 ns/op
> Iteration  16: 7791521.127 ns/op
> Iteration  17: 7612213.793 ns/op
> Iteration  18: 7710867.133 ns/op
> Iteration  19: 7649296.552 ns/op
> Iteration  20: 7768309.859 ns/op
> Iteration  21: 7688666.667 ns/op
> Iteration  22: 7531557.823 ns/op
> Iteration  23: 7381193.333 ns/op
> Iteration  24: 7726006.993 ns/op
> Iteration  25: 7603358.621 ns/op
> Iteration  26: 7653631.944 ns/op
> Iteration  27: 7442275.168 ns/op
> Iteration  28: 7613186.207 ns/op
> Iteration  29: 7765823.944 ns/op
> Iteration  30: 7489687.075 ns/op
> Iteration  31: 7811443.662 ns/op
> Iteration  32: 8015007.246 ns/op
> Iteration  33: 8192392.593 ns/op
> Iteration  34: 8040335.766 ns/op
> Iteration  35: 7584212.329 ns/op
> Iteration  36: 8001934.783 ns/op
> Iteration  37: 9744815.789 ns/op
> Iteration  38: 11688284.211 ns/op
> Iteration  39: 8661406.250 ns/op
> Iteration  40: 7678413.793 ns/op
> Iteration  41: 8502223.077 ns/op
> Iteration  42: 7640820.690 ns/op
> Iteration  43: 7875624.113 ns/op
> Iteration  44: 7506809.524 ns/op
> Iteration  45: 8005431.655 ns/op
> Iteration  46: 8081664.234 ns/op
> Iteration  47: 7579438.356 ns/op
> Ite

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-06 Thread Steve Niemitz



> On Jan. 7, 2015, 1:39 a.m., Bill Farner wrote:
> > Thanks for the patch!  Most of my comments are style-related, but i think a 
> > bunch of the python changes are unneeded.

Cool, I'll clean up these style comments tomorrow morning.


> On Jan. 7, 2015, 1:39 a.m., Bill Farner wrote:
> > api/src/main/thrift/org/apache/thermos/thermos_internal.thrift, line 83
> > 
> >
> > AFAICT this value is not really used for anything meaningful, and no 
> > changes should be made in the runner code.  I followed this value, and it 
> > is plumbed into 
> > `src/main/python/apache/thermos/observer/http/templates/rawtask.tpl`, just 
> > a title HTML tag.

It's also used here I believe (which was why I had to change this part too 
unfortunatly)
https://github.com/tellapart/incubator-aurora/blob/dns-override/src/main/python/apache/thermos/observer/http/templates/task.tpl#L60

And hostname come from here in the observer:
https://github.com/tellapart/incubator-aurora/blob/dns-override/src/main/python/apache/thermos/observer/task_observer.py#L218


> On Jan. 7, 2015, 1:39 a.m., Bill Farner wrote:
> > src/main/python/apache/aurora/executor/common/announcer.py, line 79
> > 
> >
> > I assume this is effectively picking up the `--hostname` command line 
> > argument from the slave, is that correct?  If so, please include a comment 
> > here about why we do that rather than calling `socket.gethostname()`.

Correct, I'll add a comment to clarify.


- Steve


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29464/#review66935
---


On Jan. 6, 2015, 10:45 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29464/
> ---
> 
> (Updated Jan. 6, 2015, 10:45 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've added a new flag for the aurora scheduler, -hostname which can override 
> the scheduler server address published into ZK.
> 
> This is useful for cases such as running the scheduler in EC2, where the 
> autodetected local address is actual an interal IP and not the public address 
> of the machine.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/thermos/thermos_internal.thrift 
> 2c449a491bc5a8ac858ea6487e4cef0591f36f66 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 360e161b6c3f6fd412c7e8de7f1b9a3af109593c 
>   
> src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
> cf173850635572c0df38bdd5cb14de8ce2016bf7 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 9e5bdc3885e76d8d03aa946caac9fdec7e1e9186 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 5e4bd65537d186459003c0b9434f1b769e04f448 
>   src/main/python/apache/thermos/bin/thermos_runner.py 
> 647de2771f301b17de33d8b45198c211d2e84367 
>   src/main/python/apache/thermos/core/runner.py 
> 8aac6b50c66080abbb5308b367e9f74c487f42e3 
>   
> src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java
>  PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 5e54364a49a208bd5f19b9649633dc8feca591e9 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> fbc3da3ab239b67ce3012d5a14fccd3ccb20a241 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 
> c3bf5ea4cbeaad03e187f84215b86531d55c25b3 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> e329a90b8fba43611f5120e2a5ee82220dbe2a91 
> 
> Diff: https://reviews.apache.org/r/29464/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-06 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29464/#review66935
---


Thanks for the patch!  Most of my comments are style-related, but i think a 
bunch of the python changes are unneeded.


api/src/main/thrift/org/apache/thermos/thermos_internal.thrift


AFAICT this value is not really used for anything meaningful, and no 
changes should be made in the runner code.  I followed this value, and it is 
plumbed into 
`src/main/python/apache/thermos/observer/http/templates/rawtask.tpl`, just a 
title HTML tag.



src/main/java/org/apache/aurora/scheduler/app/AppModule.java


These were already out of order before your patch, but please make sure 
that field declaration, arguments, and assignment are all in the same order.



src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java


please add a class javadoc



src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java


style nit - we format wrapped method signatures as:

```
public LocalServiceRegistryWithOverrides(
LocalServiceRegistry registry,
Settings settings) {
```



src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java


requireNonNull



src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java


Indented too far - should be +4 from previous line



src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java


remove @Nullable



src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java


When wrapping a long argument list, break out each argument on its own line.



src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java


Ditto re: signature wrapping style



src/main/python/apache/aurora/executor/common/announcer.py


I assume this is effectively picking up the `--hostname` command line 
argument from the slave, is that correct?  If so, please include a comment here 
about why we do that rather than calling `socket.gethostname()`.



src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java


Can you use an actual mock instead of the fake?



src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java


Indent style should be:

```
return new A(
arg1,
arg2);



src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java


expand this into arg-per-line



src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java


pull this up to the previous line.  intellij likes to do this particular 
auto-refactor.


- Bill Farner


On Jan. 6, 2015, 10:45 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29464/
> ---
> 
> (Updated Jan. 6, 2015, 10:45 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've added a new flag for the aurora scheduler, -hostname which can override 
> the scheduler server address published into ZK.
> 
> This is useful for cases such as running the scheduler in EC2, where the 
> autodetected local address is actual an interal IP and not the public address 
> of the machine.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/thermos/thermos_internal.thrift 
> 2c449a491bc5a8ac858ea6487e4cef0591f36f66 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 360e161b6c3f6fd412c7e8de7f1b9a3af109593c 
>   
> src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
> cf173850635572c0df38bdd5cb14de8ce2016bf7 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 9e5bdc3885e76d8d03aa946caac9fdec7e1e9186 
>   src/m

Re: Review Request 28731: Implemented TaskScheduler benchmarks.

2015-01-06 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/
---

(Updated Jan. 7, 2015, 1:34 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Bill's comments.


Repository: aurora


Description
---

Added baseline benchmarks for a few static veto cases.


Diffs (updated)
-

  build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 
  src/jmh/java/org/apache/aurora/benchmark/Hosts.java PRE-CREATION 
  src/jmh/java/org/apache/aurora/benchmark/Offers.java PRE-CREATION 
  src/jmh/java/org/apache/aurora/benchmark/SchedulerBenchmark.java 
5cecada93e4e04b689e826af49f691ed7e94ae49 
  src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
PRE-CREATION 
  src/jmh/java/org/apache/aurora/benchmark/Tasks.java PRE-CREATION 
  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeClusterState.java 
PRE-CREATION 
  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeDriver.java PRE-CREATION 
  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeRescheduleCalculator.java 
PRE-CREATION 
  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
b6402ae42e3c7e4dca1c120fa6ef82d2d69e69d5 
  src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterState.java 
f7e157c890b5627411acd4bd5c2559ef4829147c 
  src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 
0204d14b19ae412236f19ca274d81decb4eba12d 

Diff: https://reviews.apache.org/r/28731/diff/


Testing
---

Sample run on a local box:
```
# VM invoker: 
/Library/Java/JavaVirtualMachines/jdk1.7.0_25.jdk/Contents/Home/jre/bin/java
# VM options: -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en 
-Duser.variant
# Warmup: 10 iterations, 1 s each
# Measurement: 100 iterations, 1 s each
# Timeout: 10 min per iteration
# Threads: 1 thread, will synchronize iterations
# Benchmark mode: Average time, time/op
# Benchmark: 
org.apache.aurora.benchmark.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.runBenchmark

# Run progress: 0.00% complete, ETA 00:05:30
# Fork: 1 of 1
# Warmup Iteration   1: 278284250.000 ns/op
# Warmup Iteration   2: 70294312.500 ns/op
# Warmup Iteration   3: 19293379.310 ns/op
# Warmup Iteration   4: 11945387.097 ns/op
# Warmup Iteration   5: 10725388.350 ns/op
# Warmup Iteration   6: 13043282.353 ns/op
# Warmup Iteration   7: 9233083.333 ns/op
# Warmup Iteration   8: 9521051.724 ns/op
# Warmup Iteration   9: 10750854.369 ns/op
# Warmup Iteration  10: 7460243.243 ns/op
Iteration   1: 7885364.286 ns/op
Iteration   2: 7735139.860 ns/op
Iteration   3: 7660208.333 ns/op
Iteration   4: 7761204.225 ns/op
Iteration   5: 7868907.143 ns/op
Iteration   6: 7567404.110 ns/op
Iteration   7: 7611000.000 ns/op
Iteration   8: 7766154.930 ns/op
Iteration   9: 7669344.828 ns/op
Iteration  10: 7707783.217 ns/op
Iteration  11: 7435651.007 ns/op
Iteration  12: 7697631.944 ns/op
Iteration  13: 7712531.469 ns/op
Iteration  14: 7899407.143 ns/op
Iteration  15: 7448472.973 ns/op
Iteration  16: 7791521.127 ns/op
Iteration  17: 7612213.793 ns/op
Iteration  18: 7710867.133 ns/op
Iteration  19: 7649296.552 ns/op
Iteration  20: 7768309.859 ns/op
Iteration  21: 7688666.667 ns/op
Iteration  22: 7531557.823 ns/op
Iteration  23: 7381193.333 ns/op
Iteration  24: 7726006.993 ns/op
Iteration  25: 7603358.621 ns/op
Iteration  26: 7653631.944 ns/op
Iteration  27: 7442275.168 ns/op
Iteration  28: 7613186.207 ns/op
Iteration  29: 7765823.944 ns/op
Iteration  30: 7489687.075 ns/op
Iteration  31: 7811443.662 ns/op
Iteration  32: 8015007.246 ns/op
Iteration  33: 8192392.593 ns/op
Iteration  34: 8040335.766 ns/op
Iteration  35: 7584212.329 ns/op
Iteration  36: 8001934.783 ns/op
Iteration  37: 9744815.789 ns/op
Iteration  38: 11688284.211 ns/op
Iteration  39: 8661406.250 ns/op
Iteration  40: 7678413.793 ns/op
Iteration  41: 8502223.077 ns/op
Iteration  42: 7640820.690 ns/op
Iteration  43: 7875624.113 ns/op
Iteration  44: 7506809.524 ns/op
Iteration  45: 8005431.655 ns/op
Iteration  46: 8081664.234 ns/op
Iteration  47: 7579438.356 ns/op
Iteration  48: 7993405.797 ns/op
Iteration  49: 7571958.904 ns/op
Iteration  50: 8116463.235 ns/op
Iteration  51: 7941330.935 ns/op
Iteration  52: 7687145.833 ns/op
Iteration  53: 8082554.745 ns/op
Iteration  54: 7597889.655 ns/op
Iteration  55: 7299907.285 ns/op
Iteration  56: 7992789.855 ns/op
Iteration  57: 7648268.966 ns/op
Iteration  58: 7570863.014 ns/op
Iteration  59: 7885078.571 ns/op
Iteration  60: 7647158.621 ns/op
Iteration  61: 7830858.156 ns/op
Iteration  62: 7773690.141 ns/op
Iteration  63: 7905850.000 ns/op
Iteration  64: 7653800.000 ns/op
Iteration  65: 7408248.322 ns/op
Iteration  66: 7961352.518 ns/op
Iteration  67: 7879785.714 ns/op
Iteration  68: 8308616.541 ns/op
Iteration  69: 7396852.349 ns/op
Iteration  70:

Re: Review Request 28731: Implemented TaskScheduler benchmarks.

2015-01-06 Thread Maxim Khutornenko



> On Jan. 5, 2015, 8:38 p.m., Bill Farner wrote:
> > src/jmh/java/org/apache/aurora/benchmark/Hosts.java, line 44
> > 
> >
> > It would be nice to supply the minimal attributes we expect - host and 
> > rack designations.  this will at least cause diversity computation to be 
> > realistic.  Seems like all you need to accomplish that is a parameter for 
> > the number of hosts per rack.

Sure, added.


> On Jan. 5, 2015, 8:38 p.m., Bill Farner wrote:
> > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 123
> > 
> >
> > Did you consider using a fake for `StateManager`?  I consider its 
> > behavior out of scope for this benchmark, and cutting it out might remove 
> > the need for a bunch of additional binding glue.  The same can be said (to 
> > a lesster extent) about `TaskAssigner`.

I actually prefer relying on real objects as much as possible to get more 
realistic perf picture. Excessive use of fakes may distort the perf results to 
the extent of hiding problems or missing important observations. In addition, 
faking out StateManager would require manual assignment of tasks to hosts when 
filling up cluster (see below).


> On Jan. 5, 2015, 8:38 p.m., Bill Farner wrote:
> > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 166
> > 
> >
> > Is this only to get the tasks out of PENDING?  If so, would it make 
> > sense to instead initialize the storage with tasks in the state you want?  
> > Seems like that would reduce the setup complexity.

Not just that, this is filling up cluster with real task->host assignments 
populating AssignedTask slave fields. Doing this manually would require much 
more overhead.


> On Jan. 5, 2015, 8:38 p.m., Bill Farner wrote:
> > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 196
> > 
> >
> > `getClusterUtilization`?

Changed.


> On Jan. 5, 2015, 8:38 p.m., Bill Farner wrote:
> > src/jmh/java/org/apache/aurora/benchmark/Tasks.java, line 65
> > 
> >
> > This might be worth omitting, i fear its prominent inclusion here could 
> > be misleading about how priority is used in scheduling.

It was used for preemptor path to work correctly. I have replaced it with 
"isProduction".


> On Jan. 5, 2015, 8:38 p.m., Bill Farner wrote:
> > src/jmh/java/org/apache/aurora/benchmark/fakes/FakeClusterState.java, line 
> > 23
> > 
> >
> > Did you consider using `CachedClusterState` instead?  That might cause 
> > some other things to fall into place, and alleviate the manual maintenance 
> > of this mapping.  AFAICT there's a small amount of wiring necessary to make 
> > this work (including a more real `EventSink`), but that might be a 
> > worthwhile investment if it simplifies the benchmark implementations.

I am hesitant to make CachedClusterState public as it's meaningless outside of 
its package. There is not much happening in FakeClusterState to press for a 
real object use here.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review66714
---


On Dec. 15, 2014, 10:15 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28731/
> ---
> 
> (Updated Dec. 15, 2014, 10:15 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added baseline benchmarks for a few static veto cases.
> 
> 
> Diffs
> -
> 
>   build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 
>   src/jmh/java/org/apache/aurora/benchmark/Hosts.java PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/Offers.java PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulerBenchmark.java 
> 5cecada93e4e04b689e826af49f691ed7e94ae49 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/Tasks.java PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeClusterState.java 
> PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeDriver.java PRE-CREATION 
>   
> src/jmh/java/org/apache/aurora/benchmark/fakes/FakeRescheduleCalculator.java 
> PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
> PRE-CREAT

Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.

2015-01-06 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28617/#review66964
---

Ship it!


Master (8c49029) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 7, 2015, 12:26 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28617/
> ---
> 
> (Updated Jan. 7, 2015, 12:26 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-909
> https://issues.apache.org/jira/browse/AURORA-909
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Modified the task offer/task matching logic to skip offer matching for tasks 
> previously vetoed statically.
> 
> Preliminary testing in vagrant (see pictures below) shows close to 50% 
> improvement in task scheduling performance.
> 
> Update:
> Testing with JMH (https://reviews.apache.org/r/28710/ and 
> https://reviews.apache.org/r/28731/) shows over 97% better perf when testing 
> with disabled preemptor:
> ```
> Master with cluster fillup 0.9:
> Benchmark 
>Mode  SamplesScoreError  Units
> o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example   
>avgt  100  8291046.074 Â± 145251.995  ns/op
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example 
>avgt  100  7522269.050 Â± 142446.265  ns/op
> 
> This RB with cluster fillup 0.9:
> Benchmark 
>Mode  Samples   Score  Error  Units
> o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example   
>avgt  100  204171.046 Â± 3800.124  ns/op
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example 
>avgt  100  215854.129 Â± 8959.851  ns/op
> ```
> 
> Testing with preemptor enabled and running the worst case possible scenario 
> (every slave is eligible and has task victims to evaluate) is still 16-22% 
> faster than the master.
> ```
> Master with cluster fillup 0.9:
> Benchmark 
> Mode  SamplesScoreError  Units
> o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.runBenchmark
>   avgt  100  7170244.522 Â± 230259.848  ns/op
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
> avgt  100  8158184.909 Â± 465853.379  ns/op
> 
> This RB with cluster fillup 0.9:
> Benchmark 
>  Mode  Samples Score Error  Units
> o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.runBenchmark
>avgt  100   6050901.381 Â±  182134.371  ns/op
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
>  avgt  100   6425953.419 Â±  163741.064  ns/op
> ```
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> f017cdd26ca40138a7e141f21613ed567314c399 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> f66383830140e5eaba436f35ebb5192eee65947a 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> b6402ae42e3c7e4dca1c120fa6ef82d2d69e69d5 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> c2a342ce07bfb223193886038761f0da5230135d 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> 1cb56f19c331508a1585077e9c4a98f52aac343b 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> e1c29747c9854cf75bf63f6f085cf40ca68989af 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> 4e7efb3c1214c3d193afd61f162713490eb8effb 
>   src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
> 4cf602ad32b972c18eb5a81e9b2f59c67859bdb2 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 5647349854a5e04de749c4d809684a0066d4da06 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 6cc13231560996b144101eba36577f49017aba06 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  265c38d20136210e7639ac8ea915d307a4b72949 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> 411a55a8d85f60bb2703468f2d69b64b2736eee4 
> 
> Diff: https://reviews.apache.org/r/28617/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> Tested in vagrant
> 
> 
> File Attachments
> 
> 
> NoStaticVetoFilterin

Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.

2015-01-06 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28617/
---

(Updated Jan. 7, 2015, 12:26 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Kevin's comments.


Bugs: AURORA-909
https://issues.apache.org/jira/browse/AURORA-909


Repository: aurora


Description
---

Modified the task offer/task matching logic to skip offer matching for tasks 
previously vetoed statically.

Preliminary testing in vagrant (see pictures below) shows close to 50% 
improvement in task scheduling performance.

Update:
Testing with JMH (https://reviews.apache.org/r/28710/ and 
https://reviews.apache.org/r/28731/) shows over 97% better perf when testing 
with disabled preemptor:
```
Master with cluster fillup 0.9:
Benchmark   
 Mode  SamplesScoreError  Units
o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example 
 avgt  100  8291046.074 Â± 145251.995  ns/op
o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example   
 avgt  100  7522269.050 Â± 142446.265  ns/op

This RB with cluster fillup 0.9:
Benchmark   
 Mode  Samples   Score  Error  Units
o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example 
 avgt  100  204171.046 Â± 3800.124  ns/op
o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example   
 avgt  100  215854.129 Â± 8959.851  ns/op
```

Testing with preemptor enabled and running the worst case possible scenario 
(every slave is eligible and has task victims to evaluate) is still 16-22% 
faster than the master.
```
Master with cluster fillup 0.9:
Benchmark   
  Mode  SamplesScoreError  Units
o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.runBenchmark
  avgt  100  7170244.522 Â± 230259.848  ns/op
o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
avgt  100  8158184.909 Â± 465853.379  ns/op

This RB with cluster fillup 0.9:
Benchmark   
   Mode  Samples Score Error  Units
o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.runBenchmark
   avgt  100   6050901.381 Â±  182134.371  ns/op
o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
 avgt  100   6425953.419 Â±  163741.064  ns/op
```


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
f017cdd26ca40138a7e141f21613ed567314c399 
  src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
f66383830140e5eaba436f35ebb5192eee65947a 
  src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
b6402ae42e3c7e4dca1c120fa6ef82d2d69e69d5 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
c2a342ce07bfb223193886038761f0da5230135d 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
1cb56f19c331508a1585077e9c4a98f52aac343b 
  src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
e1c29747c9854cf75bf63f6f085cf40ca68989af 
  src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
4e7efb3c1214c3d193afd61f162713490eb8effb 
  src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
4cf602ad32b972c18eb5a81e9b2f59c67859bdb2 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
5647349854a5e04de749c4d809684a0066d4da06 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
6cc13231560996b144101eba36577f49017aba06 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
265c38d20136210e7639ac8ea915d307a4b72949 
  src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
411a55a8d85f60bb2703468f2d69b64b2736eee4 

Diff: https://reviews.apache.org/r/28617/diff/


Testing
---

./gradlew -Pq build

Tested in vagrant


File Attachments


NoStaticVetoFiltering.png
  
https://reviews.apache.org/media/uploaded/files/2014/12/03/7945c60b-4135-4016-a9bf-8d4815a4a573__NoStaticVetoFiltering.png
StaticVetoFiltering.png
  
https://reviews.apache.org/media/uploaded/files/2014/12/03/2f73b94a-5ba9-43b6-922e-e9e4ec18d0bb__StaticVetoFiltering.png


Thanks,

Maxim Khutornenko

Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.

2015-01-06 Thread Maxim Khutornenko



> On Dec. 24, 2014, 12:26 a.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 79
> > 
> >
> > How about either
> > 
> > 1) Make this a member function of VetoGroup (so it's guaranteed by the 
> > compiler to be implemented if we add a new group type).
> > 
> > 2) Make this a Function>.
> > 
> > 3) Make this a Function with a default for a missing 
> > value.
> > 
> > Right now we risk a runtime NullPointerException if we add a new 
> > VetoGroup implementation and forget to update this map in a different 
> > package.

#1 - metric name mapping does not logically fit into the VetoGroup
#2 - this would add extra heap churn (Optional creation) I am trying to avoid 
for this very high frequency call event handler
#3 - default string value would slip the build phase and manifest itself as an 
invalid metric name at runtime, which is arguably even worse.

How about a test case exhaustively covering all VetoGroup mappings instead? 
Added.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28617/#review65988
---


On Dec. 15, 2014, 11:12 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28617/
> ---
> 
> (Updated Dec. 15, 2014, 11:12 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-909
> https://issues.apache.org/jira/browse/AURORA-909
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Modified the task offer/task matching logic to skip offer matching for tasks 
> previously vetoed statically.
> 
> Preliminary testing in vagrant (see pictures below) shows close to 50% 
> improvement in task scheduling performance.
> 
> Update:
> Testing with JMH (https://reviews.apache.org/r/28710/ and 
> https://reviews.apache.org/r/28731/) shows over 97% better perf when testing 
> with disabled preemptor:
> ```
> Master with cluster fillup 0.9:
> Benchmark 
>Mode  SamplesScoreError  Units
> o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example   
>avgt  100  8291046.074 Â± 145251.995  ns/op
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example 
>avgt  100  7522269.050 Â± 142446.265  ns/op
> 
> This RB with cluster fillup 0.9:
> Benchmark 
>Mode  Samples   Score  Error  Units
> o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example   
>avgt  100  204171.046 Â± 3800.124  ns/op
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example 
>avgt  100  215854.129 Â± 8959.851  ns/op
> ```
> 
> Testing with preemptor enabled and running the worst case possible scenario 
> (every slave is eligible and has task victims to evaluate) is still 16-22% 
> faster than the master.
> ```
> Master with cluster fillup 0.9:
> Benchmark 
> Mode  SamplesScoreError  Units
> o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.runBenchmark
>   avgt  100  7170244.522 Â± 230259.848  ns/op
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
> avgt  100  8158184.909 Â± 465853.379  ns/op
> 
> This RB with cluster fillup 0.9:
> Benchmark 
>  Mode  Samples Score Error  Units
> o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.runBenchmark
>avgt  100   6050901.381 Â±  182134.371  ns/op
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
>  avgt  100   6425953.419 Â±  163741.064  ns/op
> ```
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> f017cdd26ca40138a7e141f21613ed567314c399 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> f66383830140e5eaba436f35ebb5192eee65947a 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> b6402ae42e3c7e4dca1c120fa6ef82d2d69e69d5 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> c2a342ce07bfb223193886038761f0da5230135d 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> 1cb56f19c331508a1585077e9c4a98f52aac343b 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> e1c29747c9854cf75bf63f6f085cf40ca68989af 
>   src/

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2015-01-06 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/#review66952
---

Ship it!


Master (8c49029) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 6, 2015, 11:30 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29137/
> ---
> 
> (Updated Jan. 6, 2015, 11:30 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-691
> https://issues.apache.org/jira/browse/AURORA-691
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Dual reading populated configs to make sure we are backwards compatible by 
> 0.8.0.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/updater.py 
> 1c5708c300ba9e4ff3183978ab3c9aa84754fb7e 
>   src/main/python/apache/aurora/client/base.py 
> 258c1fa87645ec48854198529392c84ae08c93be 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 8bdb7f488f68b10b767ced627e55e57698e4f5f2 
>   src/main/python/apache/aurora/client/commands/core.py 
> cbaa67a78533fedf679eb993c9deb0f09b705616 
>   src/test/python/apache/aurora/client/api/test_updater.py 
> dad69e20598c1daf62706989dafcb4be50fed82b 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> d8da68fef7603e0da5f53c059367541d971bda50 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> c19b21dd99dded0fdc631cef90997e2f2bd1156e 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
>   src/test/python/apache/aurora/client/commands/test_diff.py 
> 8e346ed3e6b8c91a7882029cd0734bd55165c479 
>   src/test/python/apache/aurora/client/commands/test_restart.py 
> 3789f3bd9ea2753070c966e0b755ab2168f7dd05 
>   src/test/python/apache/aurora/client/commands/test_update.py 
> 3f5f83e75d287984a926ccf1c4fe2ad0d362b036 
>   src/test/python/apache/aurora/client/test_base.py 
> fba08aeb8103aaa62fb86c389a1976f89289a086 
> 
> Diff: https://reviews.apache.org/r/29137/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client:all
> Verified in vagrant. 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-06 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review66950
---

Ship it!


Master (8c49029) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 6, 2015, 11:32 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28920/
> ---
> 
> (Updated Jan. 6, 2015, 11:32 p.m.)
> 
> 
> Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-633
> https://issues.apache.org/jira/browse/AURORA-633
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This change adds support for launching docker containers through aurora.  
> These changes are based off of the discussion in 
> https://issues.apache.org/jira/browse/AURORA-633
> 
> As of now, a special thermos_executor.sh script is needed to launch the 
> executor inside docker containers.  A sample aurora file is in 
> examples/jobs/docker.
> 
> In addition, mesos-slave must be run with `--containerizers=docker,mesos`, 
> the example upstart config in examples/vagrant/upstart has been updated to 
> reflect this.
> 
> More information is in subsequent review request comments.
> 
> 
> Diffs
> -
> 
>   Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 5665c69cd7b49c3fd7345074c9f16a3b224496ab 
>   docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea 
>   docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7 
>   examples/jobs/docker/hello_docker.aurora PRE-CREATION 
>   examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
>   examples/vagrant/upstart/mesos-slave.conf 
> 512ce7ecf34042ed68dda55efb2dd0415f8469db 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> 5226e3d1b303b1773a057078f2911c5ec2aa97f5 
>   src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 
> d885b224ec5a1d529347d84e03ba98ab6734a126 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 5bf283062c9d119ff91ed45da8b236e36d0fc9aa 
>   src/main/python/apache/aurora/config/thrift.py 
> ba94ac3c0cbaf3c91eb1a1d86a244ed6fa3b649c 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> 636b23d30a897b557eb8c3f8733c90b23cb807ef 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 
>   src/main/python/apache/aurora/executor/common/sandbox.py 
> f47a32b3fefb4a89940b1ddc473b8316ac00df12 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 5e4bd65537d186459003c0b9434f1b769e04f448 
>   src/main/python/apache/thermos/config/schema_base.py 
> f9143cc1b83143d6147f59d90c79435d055d0518 
>   src/main/python/apache/thermos/core/runner.py 
> 8aac6b50c66080abbb5308b367e9f74c487f42e3 
>   src/main/resources/scheduler/assets/configSummary.html 
> 28878908b0c9381e366b71a3135dfc28c542a890 
>   src/main/resources/scheduler/assets/js/services.js 
> b744f375411e09b7f776e4a05ee5961227143439 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 5e54364a49a208bd5f19b9649633dc8feca591e9 
>   src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 
> 876e173ccbac04e4a06a245648c7c6af15eaaa92 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> ddcb511d108220ab5e4efcf3496458f7ab4a20c2 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
> 
> Diff: https://reviews.apache.org/r/28920/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 29015: Suppressing duplicate error messages.

2015-01-06 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29015/#review66949
---

Ship it!


Ship It!

- Zameer Manji


On Jan. 6, 2015, 3:49 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29015/
> ---
> 
> (Updated Jan. 6, 2015, 3:49 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-968
> https://issues.apache.org/jira/browse/AURORA-968
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Problems addressed:
> - Duplicate output due to relying on both `context.print_err()` and `raise 
> CommandError`
> - Duplicate output in case of missing err_msg in `check_and_log_response()`
> - Inconsistent messaging and error handling cases
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> b1ffc05ebd520e91be58704615c5a12c62e75f03 
>   src/main/python/apache/aurora/client/cli/cron.py 
> 1f1efdb47eaf09af84813ae1af210c5ebdde7d0c 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 8bdb7f488f68b10b767ced627e55e57698e4f5f2 
>   src/main/python/apache/aurora/client/cli/quota.py 
> 137aab1285a9732a3b65aee65948e836df3c7cac 
>   src/main/python/apache/aurora/client/cli/task.py 
> a70f908de63904f9d3bd3776f60432d9329931e7 
>   src/main/python/apache/aurora/client/cli/update.py 
> d1d0b2946c0513381345d90fabe22c1b7c6b8ca9 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 9aaf82a485e2c517848ad7e0b2fc41efa017bbbd 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 3036f9cdf9e4805229664e64445fec5ec222be8e 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> 202cc45ffa7efb5b5268bf41ca14104504735478 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> c19b21dd99dded0fdc631cef90997e2f2bd1156e 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> eafb909098e6f757db1522d5cb605ff04a96e8b6 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
>   src/test/python/apache/aurora/client/cli/util.py 
> 6dba1855f8951d38882c0d5b01a5a609b774d00f 
> 
> Diff: https://reviews.apache.org/r/29015/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client/cli:all
> Also, visually verified in vagrant:
> 
> Before:
> vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall 
> devcluster/www-data/prod/hello
>  INFO] Checking status of devcluster/www-data/prod/hello
>  INFO] 
>  INFO] Killing tasks for job: devcluster/www-data/prod/hello
>  INFO] Instances to be killed: [0]
> Tasks were not killed in time.
> Kill of shards [0] failed with error:
> Exceeded maximum number of errors while killing instances
> Error executing command: Exceeded maximum number of errors while killing 
> instances
> 
> After:
> vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall 
> devcluster/www-data/prod/hello
>  INFO] Checking status of devcluster/www-data/prod/hello
>  INFO] 
>  INFO] Killing tasks for job: devcluster/www-data/prod/hello
>  INFO] Instances to be killed: [0]
> Instances [0] were not killed in time
> Error executing command: Exceeded maximum number of errors while killing 
> instances
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 29015: Suppressing duplicate error messages.

2015-01-06 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29015/
---

(Updated Jan. 6, 2015, 11:49 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Added vagrant output example.


Bugs: AURORA-968
https://issues.apache.org/jira/browse/AURORA-968


Repository: aurora


Description
---

Problems addressed:
- Duplicate output due to relying on both `context.print_err()` and `raise 
CommandError`
- Duplicate output in case of missing err_msg in `check_and_log_response()`
- Inconsistent messaging and error handling cases


Diffs
-

  src/main/python/apache/aurora/client/cli/context.py 
b1ffc05ebd520e91be58704615c5a12c62e75f03 
  src/main/python/apache/aurora/client/cli/cron.py 
1f1efdb47eaf09af84813ae1af210c5ebdde7d0c 
  src/main/python/apache/aurora/client/cli/jobs.py 
8bdb7f488f68b10b767ced627e55e57698e4f5f2 
  src/main/python/apache/aurora/client/cli/quota.py 
137aab1285a9732a3b65aee65948e836df3c7cac 
  src/main/python/apache/aurora/client/cli/task.py 
a70f908de63904f9d3bd3776f60432d9329931e7 
  src/main/python/apache/aurora/client/cli/update.py 
d1d0b2946c0513381345d90fabe22c1b7c6b8ca9 
  src/test/python/apache/aurora/client/cli/test_create.py 
9aaf82a485e2c517848ad7e0b2fc41efa017bbbd 
  src/test/python/apache/aurora/client/cli/test_kill.py 
3036f9cdf9e4805229664e64445fec5ec222be8e 
  src/test/python/apache/aurora/client/cli/test_quota.py 
202cc45ffa7efb5b5268bf41ca14104504735478 
  src/test/python/apache/aurora/client/cli/test_restart.py 
c19b21dd99dded0fdc631cef90997e2f2bd1156e 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
eafb909098e6f757db1522d5cb605ff04a96e8b6 
  src/test/python/apache/aurora/client/cli/test_update.py 
044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
  src/test/python/apache/aurora/client/cli/util.py 
6dba1855f8951d38882c0d5b01a5a609b774d00f 

Diff: https://reviews.apache.org/r/29015/diff/


Testing (updated)
---

./pants src/test/python/apache/aurora/client/cli:all
Also, visually verified in vagrant:

Before:
vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall 
devcluster/www-data/prod/hello
 INFO] Checking status of devcluster/www-data/prod/hello
 INFO] 
 INFO] Killing tasks for job: devcluster/www-data/prod/hello
 INFO] Instances to be killed: [0]
Tasks were not killed in time.
Kill of shards [0] failed with error:
Exceeded maximum number of errors while killing instances
Error executing command: Exceeded maximum number of errors while killing 
instances

After:
vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall 
devcluster/www-data/prod/hello
 INFO] Checking status of devcluster/www-data/prod/hello
 INFO] 
 INFO] Killing tasks for job: devcluster/www-data/prod/hello
 INFO] Instances to be killed: [0]
Instances [0] were not killed in time
Error executing command: Exceeded maximum number of errors while killing 
instances


Thanks,

Maxim Khutornenko

Re: Review Request 29015: Suppressing duplicate error messages.

2015-01-06 Thread Maxim Khutornenko



> On Dec. 15, 2014, 8:38 p.m., Zameer Manji wrote:
> > The changes look good to me. Can you please update the testing portion of 
> > the ticket with the actual outout from a vagrant session?

Added killall example.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29015/#review65117
---


On Dec. 13, 2014, 12:40 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29015/
> ---
> 
> (Updated Dec. 13, 2014, 12:40 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-968
> https://issues.apache.org/jira/browse/AURORA-968
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Problems addressed:
> - Duplicate output due to relying on both `context.print_err()` and `raise 
> CommandError`
> - Duplicate output in case of missing err_msg in `check_and_log_response()`
> - Inconsistent messaging and error handling cases
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> b1ffc05ebd520e91be58704615c5a12c62e75f03 
>   src/main/python/apache/aurora/client/cli/cron.py 
> 1f1efdb47eaf09af84813ae1af210c5ebdde7d0c 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 8bdb7f488f68b10b767ced627e55e57698e4f5f2 
>   src/main/python/apache/aurora/client/cli/quota.py 
> 137aab1285a9732a3b65aee65948e836df3c7cac 
>   src/main/python/apache/aurora/client/cli/task.py 
> a70f908de63904f9d3bd3776f60432d9329931e7 
>   src/main/python/apache/aurora/client/cli/update.py 
> d1d0b2946c0513381345d90fabe22c1b7c6b8ca9 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 9aaf82a485e2c517848ad7e0b2fc41efa017bbbd 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 3036f9cdf9e4805229664e64445fec5ec222be8e 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> 202cc45ffa7efb5b5268bf41ca14104504735478 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> c19b21dd99dded0fdc631cef90997e2f2bd1156e 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> eafb909098e6f757db1522d5cb605ff04a96e8b6 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
>   src/test/python/apache/aurora/client/cli/util.py 
> 6dba1855f8951d38882c0d5b01a5a609b774d00f 
> 
> Diff: https://reviews.apache.org/r/29015/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client/cli:all
> Also, visually verified in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-06 Thread Steve Niemitz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---

(Updated Jan. 6, 2015, 11:32 p.m.)


Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner.


Changes
---

Some refactoring to use Optional more.


Bugs: AURORA-633
https://issues.apache.org/jira/browse/AURORA-633


Repository: aurora


Description
---

This change adds support for launching docker containers through aurora.  These 
changes are based off of the discussion in 
https://issues.apache.org/jira/browse/AURORA-633

As of now, a special thermos_executor.sh script is needed to launch the 
executor inside docker containers.  A sample aurora file is in 
examples/jobs/docker.

In addition, mesos-slave must be run with `--containerizers=docker,mesos`, the 
example upstart config in examples/vagrant/upstart has been updated to reflect 
this.

More information is in subsequent review request comments.


Diffs (updated)
-

  Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
5665c69cd7b49c3fd7345074c9f16a3b224496ab 
  docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea 
  docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7 
  examples/jobs/docker/hello_docker.aurora PRE-CREATION 
  examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
  examples/vagrant/upstart/mesos-slave.conf 
512ce7ecf34042ed68dda55efb2dd0415f8469db 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 
  src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
5226e3d1b303b1773a057078f2911c5ec2aa97f5 
  src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 
d885b224ec5a1d529347d84e03ba98ab6734a126 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
5bf283062c9d119ff91ed45da8b236e36d0fc9aa 
  src/main/python/apache/aurora/config/thrift.py 
ba94ac3c0cbaf3c91eb1a1d86a244ed6fa3b649c 
  src/main/python/apache/aurora/executor/aurora_executor.py 
636b23d30a897b557eb8c3f8733c90b23cb807ef 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
9df9b4b79c0c7d29c5088409bf15c0d32a621df0 
  src/main/python/apache/aurora/executor/common/sandbox.py 
f47a32b3fefb4a89940b1ddc473b8316ac00df12 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
5e4bd65537d186459003c0b9434f1b769e04f448 
  src/main/python/apache/thermos/config/schema_base.py 
f9143cc1b83143d6147f59d90c79435d055d0518 
  src/main/python/apache/thermos/core/runner.py 
8aac6b50c66080abbb5308b367e9f74c487f42e3 
  src/main/resources/scheduler/assets/configSummary.html 
28878908b0c9381e366b71a3135dfc28c542a890 
  src/main/resources/scheduler/assets/js/services.js 
b744f375411e09b7f776e4a05ee5961227143439 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
5e54364a49a208bd5f19b9649633dc8feca591e9 
  src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 
876e173ccbac04e4a06a245648c7c6af15eaaa92 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
ddcb511d108220ab5e4efcf3496458f7ab4a20c2 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
503e62f4cac872b14f6985b5bccc3e4dfcf81789 

Diff: https://reviews.apache.org/r/28920/diff/


Testing
---


Thanks,

Steve Niemitz

Re: Review Request 29117: Adding thrift API changes document.

2015-01-06 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29117/
---

(Updated Jan. 6, 2015, 11:30 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

+wfarner


Bugs: AURORA-973
https://issues.apache.org/jira/browse/AURORA-973


Repository: aurora


Description
---

This is a first stab at documenting thrift deprecation. Any 
suggestions/comments are welcome.


Diffs
-

  docs/developing-aurora-client.md b9912bce44d65ddd7f1e35f0ea9356a89d5fe767 
  docs/developing-aurora-scheduler.md 7f6cc2e6c8e01115a9b7a7dc7633bcd88ba02a0f 
  docs/thrift-deprecation.md PRE-CREATION 

Diff: https://reviews.apache.org/r/29117/diff/


Testing
---

https://github.com/maxim111333/incubator-aurora/blob/populated_deprecation/docs/thrift-deprecation.md


Thanks,

Maxim Khutornenko

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2015-01-06 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/
---

(Updated Jan. 6, 2015, 11:30 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

-kevints
+wfarner


Bugs: AURORA-691
https://issues.apache.org/jira/browse/AURORA-691


Repository: aurora


Description
---

Dual reading populated configs to make sure we are backwards compatible by 
0.8.0.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/updater.py 
1c5708c300ba9e4ff3183978ab3c9aa84754fb7e 
  src/main/python/apache/aurora/client/base.py 
258c1fa87645ec48854198529392c84ae08c93be 
  src/main/python/apache/aurora/client/cli/jobs.py 
8bdb7f488f68b10b767ced627e55e57698e4f5f2 
  src/main/python/apache/aurora/client/commands/core.py 
cbaa67a78533fedf679eb993c9deb0f09b705616 
  src/test/python/apache/aurora/client/api/test_updater.py 
dad69e20598c1daf62706989dafcb4be50fed82b 
  src/test/python/apache/aurora/client/cli/test_diff.py 
d8da68fef7603e0da5f53c059367541d971bda50 
  src/test/python/apache/aurora/client/cli/test_restart.py 
c19b21dd99dded0fdc631cef90997e2f2bd1156e 
  src/test/python/apache/aurora/client/cli/test_update.py 
044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
  src/test/python/apache/aurora/client/commands/test_diff.py 
8e346ed3e6b8c91a7882029cd0734bd55165c479 
  src/test/python/apache/aurora/client/commands/test_restart.py 
3789f3bd9ea2753070c966e0b755ab2168f7dd05 
  src/test/python/apache/aurora/client/commands/test_update.py 
3f5f83e75d287984a926ccf1c4fe2ad0d362b036 
  src/test/python/apache/aurora/client/test_base.py 
fba08aeb8103aaa62fb86c389a1976f89289a086 

Diff: https://reviews.apache.org/r/29137/diff/


Testing
---

./pants src/test/python/apache/aurora/client:all
Verified in vagrant. 


Thanks,

Maxim Khutornenko

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-06 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29586/#review66943
---

Ship it!


Ship It!

- Brian Wickman


On Jan. 5, 2015, 7:07 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29586/
> ---
> 
> (Updated Jan. 5, 2015, 7:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Replace twitter.common.python dependency with a direct pex dependency (at the 
> latest version).
> 
> 
> Diffs
> -
> 
>   3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/commands/BUILD 
> 78a2f57b4b42edf363f40e2988cf9a69c36ad003 
>   src/main/python/apache/aurora/common/BUILD 
> 1c6464d8a91a84ca74191814edacaac5e83b78e8 
>   src/main/python/apache/aurora/common/pex_version.py 
> 6aecd8a14eff7cd58becbecc8b05ea193a6c9cec 
>   src/main/python/apache/aurora/executor/BUILD 
> 72d1ec5e891a4b7b5101ae913f7520609ccd98a8 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> 7c018271724ffab2ff6930e5802a48b50a39dded 
>   src/test/python/apache/aurora/common/test_pex_version.py 
> 7280f703463c6205493a718310f20a7fd21a0c6b 
> 
> Diff: https://reviews.apache.org/r/29586/diff/
> 
> 
> Testing
> ---
> 
> ./pants build src/test/python/apache/aurora:all
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-06 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29464/#review66937
---

Ship it!


Master (9f6ec4b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 6, 2015, 10:45 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29464/
> ---
> 
> (Updated Jan. 6, 2015, 10:45 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've added a new flag for the aurora scheduler, -hostname which can override 
> the scheduler server address published into ZK.
> 
> This is useful for cases such as running the scheduler in EC2, where the 
> autodetected local address is actual an interal IP and not the public address 
> of the machine.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/thermos/thermos_internal.thrift 
> 2c449a491bc5a8ac858ea6487e4cef0591f36f66 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 360e161b6c3f6fd412c7e8de7f1b9a3af109593c 
>   
> src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
> cf173850635572c0df38bdd5cb14de8ce2016bf7 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 9e5bdc3885e76d8d03aa946caac9fdec7e1e9186 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 5e4bd65537d186459003c0b9434f1b769e04f448 
>   src/main/python/apache/thermos/bin/thermos_runner.py 
> 647de2771f301b17de33d8b45198c211d2e84367 
>   src/main/python/apache/thermos/core/runner.py 
> 8aac6b50c66080abbb5308b367e9f74c487f42e3 
>   
> src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java
>  PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 5e54364a49a208bd5f19b9649633dc8feca591e9 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> fbc3da3ab239b67ce3012d5a14fccd3ccb20a241 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 
> c3bf5ea4cbeaad03e187f84215b86531d55c25b3 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> e329a90b8fba43611f5120e2a5ee82220dbe2a91 
> 
> Diff: https://reviews.apache.org/r/29464/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-06 Thread Bill Farner



> On Jan. 6, 2015, 9:46 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java,
> >  line 29
> > 
> >
> > There's some legacy baggage we could shed here if you're game - it 
> > should actually simplify the code and your patch if so.
> > 
> > `LocalServiceRegistry` was designed to be an abstract registry for a 
> > framework we are moving away from, supporting an arbitrary number of 
> > services.  Since we now know we _only_ have an HTTP port, we can remove the 
> > abstraction.
> > 
> > I'm imagining this would mean extracting 
> > `JettyServerModule.HttpServerLauncher` into its own source file, and 
> > addressing the TODO to use `AbstractIdleService`.  You would then add a 
> > method like `public HostAndPort getListeningAddress()`, where the host part 
> > is either the locally-resolved name or the override.
> > 
> > That said - i understand if this yak shave exceeds your appetite, and 
> > would accept `TODO(wfarner)`.
> > 
> > Holding on your decision here before i review other code that might 
> > change based on your path.
> 
> Steve Niemitz wrote:
> I'd prefer to keep this patch small so it doesn't get held up a lot.  
> However, I wouldn't mind spending some time in the near future helping out 
> with that refactor.

Fair enough, mind inserting that `TODO(wfarner)` here for me to remove the use 
of `LocalServiceRegistry`?


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29464/#review66920
---


On Jan. 6, 2015, 10:45 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29464/
> ---
> 
> (Updated Jan. 6, 2015, 10:45 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've added a new flag for the aurora scheduler, -hostname which can override 
> the scheduler server address published into ZK.
> 
> This is useful for cases such as running the scheduler in EC2, where the 
> autodetected local address is actual an interal IP and not the public address 
> of the machine.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/thermos/thermos_internal.thrift 
> 2c449a491bc5a8ac858ea6487e4cef0591f36f66 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 360e161b6c3f6fd412c7e8de7f1b9a3af109593c 
>   
> src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
> cf173850635572c0df38bdd5cb14de8ce2016bf7 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 9e5bdc3885e76d8d03aa946caac9fdec7e1e9186 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 5e4bd65537d186459003c0b9434f1b769e04f448 
>   src/main/python/apache/thermos/bin/thermos_runner.py 
> 647de2771f301b17de33d8b45198c211d2e84367 
>   src/main/python/apache/thermos/core/runner.py 
> 8aac6b50c66080abbb5308b367e9f74c487f42e3 
>   
> src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java
>  PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 5e54364a49a208bd5f19b9649633dc8feca591e9 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> fbc3da3ab239b67ce3012d5a14fccd3ccb20a241 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 
> c3bf5ea4cbeaad03e187f84215b86531d55c25b3 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> e329a90b8fba43611f5120e2a5ee82220dbe2a91 
> 
> Diff: https://reviews.apache.org/r/29464/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-06 Thread Steve Niemitz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29464/
---

(Updated Jan. 6, 2015, 10:45 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Repository: aurora


Description
---

I've added a new flag for the aurora scheduler, -hostname which can override 
the scheduler server address published into ZK.

This is useful for cases such as running the scheduler in EC2, where the 
autodetected local address is actual an interal IP and not the public address 
of the machine.


Diffs (updated)
-

  api/src/main/thrift/org/apache/thermos/thermos_internal.thrift 
2c449a491bc5a8ac858ea6487e4cef0591f36f66 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
360e161b6c3f6fd412c7e8de7f1b9a3af109593c 
  
src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
 PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 
  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
cf173850635572c0df38bdd5cb14de8ce2016bf7 
  src/main/python/apache/aurora/executor/common/announcer.py 
9e5bdc3885e76d8d03aa946caac9fdec7e1e9186 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
5e4bd65537d186459003c0b9434f1b769e04f448 
  src/main/python/apache/thermos/bin/thermos_runner.py 
647de2771f301b17de33d8b45198c211d2e84367 
  src/main/python/apache/thermos/core/runner.py 
8aac6b50c66080abbb5308b367e9f74c487f42e3 
  
src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java
 PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
5e54364a49a208bd5f19b9649633dc8feca591e9 
  src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
fbc3da3ab239b67ce3012d5a14fccd3ccb20a241 
  src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 
c3bf5ea4cbeaad03e187f84215b86531d55c25b3 
  src/test/python/apache/aurora/executor/common/test_announcer.py 
e329a90b8fba43611f5120e2a5ee82220dbe2a91 

Diff: https://reviews.apache.org/r/29464/diff/


Testing
---


Thanks,

Steve Niemitz

Re: Review Request 29216: Removing client v1 code.

2015-01-06 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29216/#review66928
---

Ship it!



src/main/python/apache/aurora/client/base.py


s/ v2//, s/V2_//?



src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


s/mchucarroll/maxim/



src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Remove extra space after `killall`



src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Is there a reason we can't grep for the full URL any more?


- Bill Farner


On Dec. 23, 2014, 1:35 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29216/
> ---
> 
> (Updated Dec. 23, 2014, 1:35 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-775
> https://issues.apache.org/jira/browse/AURORA-775
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Despite the diff size, the changes are very limited in scope. The majority of 
> green/yellow is consolidating admin-related code under /apache/aurora/admin. 
> The rest is removals and renamings to get rid of "v2". 
> 
> This diff has minor overlaps with https://reviews.apache.org/r/28971 in 
> vagrant and target renaming parts.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
>   src/main/python/apache/aurora/admin/BUILD 
> f874264bdf07a9cbb2f0990739be3c95f851b040 
>   src/main/python/apache/aurora/client/BUILD 
> a2a29ff53ffb0088909a10e1673f9578425df5ce 
>   src/main/python/apache/aurora/client/api/BUILD 
> 65e5a85e23c4c698356c8b45c45943e560c1bcd5 
>   src/main/python/apache/aurora/client/api/command_runner.py 
> 48cb567c2098620e0ee322fe9528e167ce7c7c62 
>   src/main/python/apache/aurora/client/api/disambiguator.py 
> 6a78ccd44533ef327f751a08c9e2e16555354d97 
>   src/main/python/apache/aurora/client/base.py 
> 258c1fa87645ec48854198529392c84ae08c93be 
>   src/main/python/apache/aurora/client/bin/BUILD 
> 671bd78148788d885e50a93bdc006361297a63a2 
>   src/main/python/apache/aurora/client/bin/__init__.py 
> 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd 
>   src/main/python/apache/aurora/client/bin/aurora_admin.py 
> 136cf601f0cc137f5111f1ddec5fd823375626b6 
>   src/main/python/apache/aurora/client/bin/aurora_client.py 
> 4999265af358d06d236e819bd600426f4574742c 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/cli/bridge.py 
> 227abf8e21186dd079bc6ce6ff0408a973ad3ab8 
>   src/main/python/apache/aurora/client/cli/context.py 
> f062afc8de1769f6796fc307107c61a59e9366c5 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 8bdb7f488f68b10b767ced627e55e57698e4f5f2 
>   src/main/python/apache/aurora/client/cli/update.py 
> d1d0b2946c0513381345d90fabe22c1b7c6b8ca9 
>   src/main/python/apache/aurora/client/commands/BUILD 
> 78a2f57b4b42edf363f40e2988cf9a69c36ad003 
>   src/main/python/apache/aurora/client/commands/__init__.py  
>   src/main/python/apache/aurora/client/commands/admin.py 
> b7cbba02860af576d9d09e54641d261d7e32c56e 
>   src/main/python/apache/aurora/client/commands/core.py 
> cbaa67a78533fedf679eb993c9deb0f09b705616 
>   src/main/python/apache/aurora/client/commands/help.py 
> f79e9718fa9fd8f69331d60e95988f89105089f4 
>   src/main/python/apache/aurora/client/commands/maintenance.py 
> 5321eb6e8d8a15a5e2115e3664d5f12990b67617 
>   src/main/python/apache/aurora/client/commands/run.py 
> 6844ac3eb977f5debfad003eb9e6590d3bb2022e 
>   src/main/python/apache/aurora/client/commands/ssh.py 
> ab6832ccb53335ed044b2708abfdac041253f676 
>   src/main/python/apache/aurora/client/options.py 
> f43aced0131cea3adac018d8abcd938ad45af35f 
>   src/test/python/apache/aurora/admin/BUILD 
> 3a216809d1e31247f7d01451fcc7fd877a4c1fb2 
>   src/test/python/apache/aurora/client/BUILD 
> e40c7a6cb0e86d0436aff18341a5fc8f3bf9faf8 
>   src/test/python/apache/aurora/client/api/BUILD 
> 2c0c4070cc1f1784b1d4e7f9cd8aac236e97be75 
>   src/test/python/apache/aurora/client/api/api_util.py  
>   src/test/python/apache/aurora/client/api/test_api.py 
> 7390d1c4efc5f7b2ec140590de4a293958f73a87 
>   src/test/python/apache/aurora/client/api/test_disambiguator.py 
> 72e98d266e96104552e6891dad737701a04f29c1 
>   src/test/python/apache/aurora/client/api/test_job_monitor.py 
> 1e7a8793e821da3ed53e0ea2b073ea434993a2c6 
>   src/test/python/apache/aurora/client/api/test_quota_check.py 
> 2fc76d21ca63ae7f33b1e03ccb88f52fe82dc76c 
>   src/test/python/apache/aurora/client/api/tes

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-06 Thread Steve Niemitz



> On Jan. 6, 2015, 9:46 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java,
> >  line 29
> > 
> >
> > There's some legacy baggage we could shed here if you're game - it 
> > should actually simplify the code and your patch if so.
> > 
> > `LocalServiceRegistry` was designed to be an abstract registry for a 
> > framework we are moving away from, supporting an arbitrary number of 
> > services.  Since we now know we _only_ have an HTTP port, we can remove the 
> > abstraction.
> > 
> > I'm imagining this would mean extracting 
> > `JettyServerModule.HttpServerLauncher` into its own source file, and 
> > addressing the TODO to use `AbstractIdleService`.  You would then add a 
> > method like `public HostAndPort getListeningAddress()`, where the host part 
> > is either the locally-resolved name or the override.
> > 
> > That said - i understand if this yak shave exceeds your appetite, and 
> > would accept `TODO(wfarner)`.
> > 
> > Holding on your decision here before i review other code that might 
> > change based on your path.

I'd prefer to keep this patch small so it doesn't get held up a lot.  However, 
I wouldn't mind spending some time in the near future helping out with that 
refactor.


> On Jan. 6, 2015, 9:46 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java,
> >  line 33
> > 
> >
> > Prefer Optional over nullable values.

:thumbsup:


- Steve


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29464/#review66920
---


On Jan. 5, 2015, 6:47 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29464/
> ---
> 
> (Updated Jan. 5, 2015, 6:47 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've added a new flag for the aurora scheduler, -hostname which can override 
> the scheduler server address published into ZK.
> 
> This is useful for cases such as running the scheduler in EC2, where the 
> autodetected local address is actual an interal IP and not the public address 
> of the machine.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/thermos/thermos_internal.thrift 
> 2c449a491bc5a8ac858ea6487e4cef0591f36f66 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 360e161b6c3f6fd412c7e8de7f1b9a3af109593c 
>   
> src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
> cf173850635572c0df38bdd5cb14de8ce2016bf7 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 9e5bdc3885e76d8d03aa946caac9fdec7e1e9186 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 5e4bd65537d186459003c0b9434f1b769e04f448 
>   src/main/python/apache/thermos/bin/thermos_runner.py 
> 647de2771f301b17de33d8b45198c211d2e84367 
>   src/main/python/apache/thermos/core/runner.py 
> 8aac6b50c66080abbb5308b367e9f74c487f42e3 
>   
> src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java
>  PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 5e54364a49a208bd5f19b9649633dc8feca591e9 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> fbc3da3ab239b67ce3012d5a14fccd3ccb20a241 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 
> c3bf5ea4cbeaad03e187f84215b86531d55c25b3 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> e329a90b8fba43611f5120e2a5ee82220dbe2a91 
> 
> Diff: https://reviews.apache.org/r/29464/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-06 Thread Bill Farner



> On Dec. 29, 2014, 8:36 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/LocalServiceRegistryWithOverrides.java,
> >  line 21
> > 
> >
> > Convention is to place CmdLine Args in Guice Modules (to separate 
> > wiring from implementation). Also, this value will need to be plumbed into 
> > the mesos Log somehow.
> 
> Steve Niemitz wrote:
> Ok cool, I can make that change.
> 
> Steve Niemitz wrote:
> Also can you explain more what you mean by "plumbed into the mesos Log 
> somehow"?
> 
> Kevin Sweeney wrote:
> When running multiple schedulers they need to communicate with each other 
> to coordinate writes to the Mesos replicated log. They do this by advertising 
> their IP address in zookeeper. Part of that: the scheduler IP (actually 
> libprocess PID, which contains the scheduler IP) is written to a znode under 
> (the value of -native_log_zk_group_path).
> 
> Steve Niemitz wrote:
> Ah ok I understand now.  The intention of this patch was more for ease of 
> use for external clients (eg I'm not able to resolve EC2 internal IPs).  Do 
> you think this needs to change as well?  I'm hesitant to change it since I 
> haven't seen any issues with it as-is.

I think you're okay as-is, since it's probably rare for the schedulers in a 
quorum to have a network barrier.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29464/#review66297
---


On Jan. 5, 2015, 6:47 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29464/
> ---
> 
> (Updated Jan. 5, 2015, 6:47 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've added a new flag for the aurora scheduler, -hostname which can override 
> the scheduler server address published into ZK.
> 
> This is useful for cases such as running the scheduler in EC2, where the 
> autodetected local address is actual an interal IP and not the public address 
> of the machine.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/thermos/thermos_internal.thrift 
> 2c449a491bc5a8ac858ea6487e4cef0591f36f66 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 360e161b6c3f6fd412c7e8de7f1b9a3af109593c 
>   
> src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
> cf173850635572c0df38bdd5cb14de8ce2016bf7 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 9e5bdc3885e76d8d03aa946caac9fdec7e1e9186 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 5e4bd65537d186459003c0b9434f1b769e04f448 
>   src/main/python/apache/thermos/bin/thermos_runner.py 
> 647de2771f301b17de33d8b45198c211d2e84367 
>   src/main/python/apache/thermos/core/runner.py 
> 8aac6b50c66080abbb5308b367e9f74c487f42e3 
>   
> src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java
>  PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 5e54364a49a208bd5f19b9649633dc8feca591e9 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> fbc3da3ab239b67ce3012d5a14fccd3ccb20a241 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 
> c3bf5ea4cbeaad03e187f84215b86531d55c25b3 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> e329a90b8fba43611f5120e2a5ee82220dbe2a91 
> 
> Diff: https://reviews.apache.org/r/29464/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-06 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29464/#review66920
---



src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java


There's some legacy baggage we could shed here if you're game - it should 
actually simplify the code and your patch if so.

`LocalServiceRegistry` was designed to be an abstract registry for a 
framework we are moving away from, supporting an arbitrary number of services.  
Since we now know we _only_ have an HTTP port, we can remove the abstraction.

I'm imagining this would mean extracting 
`JettyServerModule.HttpServerLauncher` into its own source file, and addressing 
the TODO to use `AbstractIdleService`.  You would then add a method like 
`public HostAndPort getListeningAddress()`, where the host part is either the 
locally-resolved name or the override.

That said - i understand if this yak shave exceeds your appetite, and would 
accept `TODO(wfarner)`.

Holding on your decision here before i review other code that might change 
based on your path.



src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java


Prefer Optional over nullable values.


- Bill Farner


On Jan. 5, 2015, 6:47 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29464/
> ---
> 
> (Updated Jan. 5, 2015, 6:47 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've added a new flag for the aurora scheduler, -hostname which can override 
> the scheduler server address published into ZK.
> 
> This is useful for cases such as running the scheduler in EC2, where the 
> autodetected local address is actual an interal IP and not the public address 
> of the machine.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/thermos/thermos_internal.thrift 
> 2c449a491bc5a8ac858ea6487e4cef0591f36f66 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 360e161b6c3f6fd412c7e8de7f1b9a3af109593c 
>   
> src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
> cf173850635572c0df38bdd5cb14de8ce2016bf7 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 9e5bdc3885e76d8d03aa946caac9fdec7e1e9186 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 5e4bd65537d186459003c0b9434f1b769e04f448 
>   src/main/python/apache/thermos/bin/thermos_runner.py 
> 647de2771f301b17de33d8b45198c211d2e84367 
>   src/main/python/apache/thermos/core/runner.py 
> 8aac6b50c66080abbb5308b367e9f74c487f42e3 
>   
> src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java
>  PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 5e54364a49a208bd5f19b9649633dc8feca591e9 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> fbc3da3ab239b67ce3012d5a14fccd3ccb20a241 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 
> c3bf5ea4cbeaad03e187f84215b86531d55c25b3 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> e329a90b8fba43611f5120e2a5ee82220dbe2a91 
> 
> Diff: https://reviews.apache.org/r/29464/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/
---

(Updated Jan. 6, 2015, 9:23 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-775
https://issues.apache.org/jira/browse/AURORA-775


Repository: aurora


Description
---

I've also done some bulk removal in `docs/client-commands.md`, which was 
essentially a regurgitation of the client's help output.


Diffs (updated)
-

  docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
  docs/client.md PRE-CREATION 
  docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
  docs/developing-aurora-client.md bf82d05be5007d17a5738613039eda18a06bce7c 
  examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
  examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
  src/main/python/apache/aurora/client/BUILD 
3ae2a616cb5867fbe6e496269f263b2991c0f3a3 
  src/main/python/apache/aurora/client/bin/BUILD 
671bd78148788d885e50a93bdc006361297a63a2 
  src/main/python/apache/aurora/client/cli/BUILD 
e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
  src/main/python/apache/aurora/client/cli/__init__.py 
2717210543359d0ecf75244672b8d478cbb5f568 
  src/main/python/apache/aurora/client/cli/client.py 
c8768c772dfbfd642e1a7967670ad799b836a7be 
  src/main/python/apache/aurora/client/cli/config.py 
637e7acd088a33ccc7d9e8302fab5645dfb44378 
  src/test/python/apache/aurora/client/cli/test_help.py 
2fef28222cb528d4d7b11fedbcc9ba3a083055d4 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
1458e7d134dfe6125c27ef38ce33aee396a33e19 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
d157bb1d3b2ca0aa6fb391336332c71b07946fe0 

Diff: https://reviews.apache.org/r/28971/diff/


Testing
---

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
./examples/vagrant/test_tutorial.sh


Thanks,

Bill Farner

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/#review66914
---

Ship it!


Master (1c53b94) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 6, 2015, 9:15 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28971/
> ---
> 
> (Updated Jan. 6, 2015, 9:15 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-775
> https://issues.apache.org/jira/browse/AURORA-775
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some bulk removal in `docs/client-commands.md`, which was 
> essentially a regurgitation of the client's help output.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
>   docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
>   docs/developing-aurora-client.md bf82d05be5007d17a5738613039eda18a06bce7c 
>   examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
>   examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
>   src/main/python/apache/aurora/client/BUILD 
> 3ae2a616cb5867fbe6e496269f263b2991c0f3a3 
>   src/main/python/apache/aurora/client/bin/BUILD 
> 671bd78148788d885e50a93bdc006361297a63a2 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2717210543359d0ecf75244672b8d478cbb5f568 
>   src/main/python/apache/aurora/client/cli/client.py 
> c8768c772dfbfd642e1a7967670ad799b836a7be 
>   src/main/python/apache/aurora/client/cli/config.py 
> 637e7acd088a33ccc7d9e8302fab5645dfb44378 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 2fef28222cb528d4d7b11fedbcc9ba3a083055d4 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1458e7d134dfe6125c27ef38ce33aee396a33e19 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> d157bb1d3b2ca0aa6fb391336332c71b07946fe0 
> 
> Diff: https://reviews.apache.org/r/28971/diff/
> 
> 
> Testing
> ---
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Bill Farner



> On Jan. 6, 2015, 9:20 p.m., Kevin Sweeney wrote:
> > docs/clientv2.md, line 180
> > 
> >
> > remove reference to "more consistent". I think this doc was initially 
> > written as a design doc to justify the client rewrite, might not be useful 
> > context for new users.

Good catch - yes, there was a lot carved out here for that reason.  Removed 
this relic.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/#review66912
---


On Jan. 6, 2015, 9:15 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28971/
> ---
> 
> (Updated Jan. 6, 2015, 9:15 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-775
> https://issues.apache.org/jira/browse/AURORA-775
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some bulk removal in `docs/client-commands.md`, which was 
> essentially a regurgitation of the client's help output.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
>   docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
>   docs/developing-aurora-client.md bf82d05be5007d17a5738613039eda18a06bce7c 
>   examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
>   examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
>   src/main/python/apache/aurora/client/BUILD 
> 3ae2a616cb5867fbe6e496269f263b2991c0f3a3 
>   src/main/python/apache/aurora/client/bin/BUILD 
> 671bd78148788d885e50a93bdc006361297a63a2 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2717210543359d0ecf75244672b8d478cbb5f568 
>   src/main/python/apache/aurora/client/cli/client.py 
> c8768c772dfbfd642e1a7967670ad799b836a7be 
>   src/main/python/apache/aurora/client/cli/config.py 
> 637e7acd088a33ccc7d9e8302fab5645dfb44378 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 2fef28222cb528d4d7b11fedbcc9ba3a083055d4 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1458e7d134dfe6125c27ef38ce33aee396a33e19 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> d157bb1d3b2ca0aa6fb391336332c71b07946fe0 
> 
> Diff: https://reviews.apache.org/r/28971/diff/
> 
> 
> Testing
> ---
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/#review66912
---

Ship it!



docs/clientv2.md


remove reference to "more consistent". I think this doc was initially 
written as a design doc to justify the client rewrite, might not be useful 
context for new users.


- Kevin Sweeney


On Jan. 6, 2015, 1:15 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28971/
> ---
> 
> (Updated Jan. 6, 2015, 1:15 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-775
> https://issues.apache.org/jira/browse/AURORA-775
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some bulk removal in `docs/client-commands.md`, which was 
> essentially a regurgitation of the client's help output.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
>   docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
>   docs/developing-aurora-client.md bf82d05be5007d17a5738613039eda18a06bce7c 
>   examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
>   examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
>   src/main/python/apache/aurora/client/BUILD 
> 3ae2a616cb5867fbe6e496269f263b2991c0f3a3 
>   src/main/python/apache/aurora/client/bin/BUILD 
> 671bd78148788d885e50a93bdc006361297a63a2 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2717210543359d0ecf75244672b8d478cbb5f568 
>   src/main/python/apache/aurora/client/cli/client.py 
> c8768c772dfbfd642e1a7967670ad799b836a7be 
>   src/main/python/apache/aurora/client/cli/config.py 
> 637e7acd088a33ccc7d9e8302fab5645dfb44378 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 2fef28222cb528d4d7b11fedbcc9ba3a083055d4 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1458e7d134dfe6125c27ef38ce33aee396a33e19 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> d157bb1d3b2ca0aa6fb391336332c71b07946fe0 
> 
> Diff: https://reviews.apache.org/r/28971/diff/
> 
> 
> Testing
> ---
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Bill Farner



> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 192
> > 
> >
> > while at it, how about s/shard/instance/g/

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 256
> > 
> >
> > missing trailing '>'

Fixed.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 320
> > 
> >
> > drop '-shards' option here

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 370
> > 
> >
> > s/config/

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 392
> > 
> >
> > s/pathname/

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 406
> > 
> >
> > same here

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/BUILD, line 102
> > 
> >
> > +1 to renaming the artifact

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/BUILD, line 105
> > 
> >
> > s/aurora2/aurora

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 38
> > 
> >
> > drop?

Thanks, restored in a way that works.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/#review65152
---


On Dec. 11, 2014, 10:53 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28971/
> ---
> 
> (Updated Dec. 11, 2014, 10:53 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-775
> https://issues.apache.org/jira/browse/AURORA-775
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some bulk removal in `docs/client-commands.md`, which was 
> essentially a regurgitation of the client's help output.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
>   docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
>   docs/developing-aurora-client.md b9912bce44d65ddd7f1e35f0ea9356a89d5fe767 
>   examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
>   examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
>   src/main/python/apache/aurora/client/BUILD 
> 2a66825426923fd7e5b7c70101747bc292208e19 
>   src/main/python/apache/aurora/client/bin/BUILD 
> 671bd78148788d885e50a93bdc006361297a63a2 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> c2eb89cae536838ac4dd46b0125a248d84f6e54c 
>   src/main/python/apache/aurora/client/cli/client.py 
> c8768c772dfbfd642e1a7967670ad799b836a7be 
>   src/main/python/apache/aurora/client/cli/config.py 
> 637e7acd088a33ccc7d9e8302fab5645dfb44378 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 1576edcaf0f59911c1c7aec42052d5ebfe41caac 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1458e7d134dfe6125c27ef38ce33aee396a33e19 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> d157bb1d3b2ca0aa6fb391336332c71b07946fe0 
> 
> Diff: https://reviews.apache.org/r/28971/diff/
> 
> 
> Testing
> ---
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/
---

(Updated Jan. 6, 2015, 9:15 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-775
https://issues.apache.org/jira/browse/AURORA-775


Repository: aurora


Description
---

I've also done some bulk removal in `docs/client-commands.md`, which was 
essentially a regurgitation of the client's help output.


Diffs (updated)
-

  docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
  docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
  docs/developing-aurora-client.md bf82d05be5007d17a5738613039eda18a06bce7c 
  examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
  examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
  src/main/python/apache/aurora/client/BUILD 
3ae2a616cb5867fbe6e496269f263b2991c0f3a3 
  src/main/python/apache/aurora/client/bin/BUILD 
671bd78148788d885e50a93bdc006361297a63a2 
  src/main/python/apache/aurora/client/cli/BUILD 
e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
  src/main/python/apache/aurora/client/cli/__init__.py 
2717210543359d0ecf75244672b8d478cbb5f568 
  src/main/python/apache/aurora/client/cli/client.py 
c8768c772dfbfd642e1a7967670ad799b836a7be 
  src/main/python/apache/aurora/client/cli/config.py 
637e7acd088a33ccc7d9e8302fab5645dfb44378 
  src/test/python/apache/aurora/client/cli/test_help.py 
2fef28222cb528d4d7b11fedbcc9ba3a083055d4 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
1458e7d134dfe6125c27ef38ce33aee396a33e19 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
d157bb1d3b2ca0aa6fb391336332c71b07946fe0 

Diff: https://reviews.apache.org/r/28971/diff/


Testing
---

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
./examples/vagrant/test_tutorial.sh


Thanks,

Bill Farner

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-06 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29586/#review66910
---

Ship it!


Ship It!

- Kevin Sweeney


On Jan. 5, 2015, 11:07 a.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29586/
> ---
> 
> (Updated Jan. 5, 2015, 11:07 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Replace twitter.common.python dependency with a direct pex dependency (at the 
> latest version).
> 
> 
> Diffs
> -
> 
>   3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/commands/BUILD 
> 78a2f57b4b42edf363f40e2988cf9a69c36ad003 
>   src/main/python/apache/aurora/common/BUILD 
> 1c6464d8a91a84ca74191814edacaac5e83b78e8 
>   src/main/python/apache/aurora/common/pex_version.py 
> 6aecd8a14eff7cd58becbecc8b05ea193a6c9cec 
>   src/main/python/apache/aurora/executor/BUILD 
> 72d1ec5e891a4b7b5101ae913f7520609ccd98a8 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> 7c018271724ffab2ff6930e5802a48b50a39dded 
>   src/test/python/apache/aurora/common/test_pex_version.py 
> 7280f703463c6205493a718310f20a7fd21a0c6b 
> 
> Diff: https://reviews.apache.org/r/29586/diff/
> 
> 
> Testing
> ---
> 
> ./pants build src/test/python/apache/aurora:all
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-06 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29586/#review66909
---


*ping*

- Joshua Cohen


On Jan. 5, 2015, 7:07 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29586/
> ---
> 
> (Updated Jan. 5, 2015, 7:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Replace twitter.common.python dependency with a direct pex dependency (at the 
> latest version).
> 
> 
> Diffs
> -
> 
>   3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/commands/BUILD 
> 78a2f57b4b42edf363f40e2988cf9a69c36ad003 
>   src/main/python/apache/aurora/common/BUILD 
> 1c6464d8a91a84ca74191814edacaac5e83b78e8 
>   src/main/python/apache/aurora/common/pex_version.py 
> 6aecd8a14eff7cd58becbecc8b05ea193a6c9cec 
>   src/main/python/apache/aurora/executor/BUILD 
> 72d1ec5e891a4b7b5101ae913f7520609ccd98a8 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> 7c018271724ffab2ff6930e5802a48b50a39dded 
>   src/test/python/apache/aurora/common/test_pex_version.py 
> 7280f703463c6205493a718310f20a7fd21a0c6b 
> 
> Diff: https://reviews.apache.org/r/29586/diff/
> 
> 
> Testing
> ---
> 
> ./pants build src/test/python/apache/aurora:all
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Bill Farner



> On Dec. 11, 2014, 10:56 p.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/client/BUILD, line 102
> > 
> >
> > Are we going to keep the artifact name like this?

Good catch, i think we should not.  Fixed.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/#review64805
---


On Dec. 11, 2014, 10:53 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28971/
> ---
> 
> (Updated Dec. 11, 2014, 10:53 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-775
> https://issues.apache.org/jira/browse/AURORA-775
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some bulk removal in `docs/client-commands.md`, which was 
> essentially a regurgitation of the client's help output.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
>   docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
>   docs/developing-aurora-client.md b9912bce44d65ddd7f1e35f0ea9356a89d5fe767 
>   examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
>   examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
>   src/main/python/apache/aurora/client/BUILD 
> 2a66825426923fd7e5b7c70101747bc292208e19 
>   src/main/python/apache/aurora/client/bin/BUILD 
> 671bd78148788d885e50a93bdc006361297a63a2 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> c2eb89cae536838ac4dd46b0125a248d84f6e54c 
>   src/main/python/apache/aurora/client/cli/client.py 
> c8768c772dfbfd642e1a7967670ad799b836a7be 
>   src/main/python/apache/aurora/client/cli/config.py 
> 637e7acd088a33ccc7d9e8302fab5645dfb44378 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 1576edcaf0f59911c1c7aec42052d5ebfe41caac 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1458e7d134dfe6125c27ef38ce33aee396a33e19 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> d157bb1d3b2ca0aa6fb391336332c71b07946fe0 
> 
> Diff: https://reviews.apache.org/r/28971/diff/
> 
> 
> Testing
> ---
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 29463: Upgrade pystachio to 0.7.4.

2015-01-06 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29463/#review66897
---

Ship it!


Master (c1174a7) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 29, 2014, 7:26 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29463/
> ---
> 
> (Updated Dec. 29, 2014, 7:26 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade pystachio to 0.7.4.  This fixes a bug with loading a serialized 
> pystachio config with multiply nested include statements.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 
> 
> Diff: https://reviews.apache.org/r/29463/diff/
> 
> 
> Testing
> ---
> 
> build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 29271: Removing cron schedule support from createJob and killTasks

2015-01-06 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29271/#review66895
---

Ship it!


Ship It!

- Bill Farner


On Jan. 6, 2015, 7:56 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29271/
> ---
> 
> (Updated Jan. 6, 2015, 7:56 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-454 and AURORA-976
> https://issues.apache.org/jira/browse/AURORA-454
> https://issues.apache.org/jira/browse/AURORA-976
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> While working on AURORA-454, realized we have a bigger problem with cron 
> schedules killing non-cron jobs. Field AURORA-976, which is also addressed in 
> this diff.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/Query.java 
> a6ff14a69a32965a87a7a3a6d73ef53f5bdf75c0 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  6e3caa164e4b98907e1a87460aab3afb9be95ef9 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  8d41e7011344aa6a9ba39feacc166dd3c3e64227 
> 
> Diff: https://reviews.apache.org/r/29271/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> ```
> $ aurora cron schedule  devcluster/www-data/prod/hello 
> aurora/examples/jobs/cron_hello_world.aurora 
>  INFO] Registering job hello with cron
> Error scheduling cron job devcluster/www-data/prod/hello:
>   Job www-data/prod/hello already exists
> 
> $ aurora job create  devcluster/www-data/prod/hello 
> aurora/examples/jobs/hello_world.aurora 
>  INFO] Creating job hello
> Job creation failed due to error:
>   Job www-data/prod/hello already exists
> ```
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 29271: Removing cron schedule support from createJob and killTasks

2015-01-06 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29271/
---

(Updated Jan. 6, 2015, 7:56 p.m.)


Review request for Aurora and Kevin Sweeney.


Changes
---

Fixed bug links.

-wfarner


Bugs: AURORA-454 and AURORA-976
https://issues.apache.org/jira/browse/AURORA-454
https://issues.apache.org/jira/browse/AURORA-976


Repository: aurora


Description
---

While working on AURORA-454, realized we have a bigger problem with cron 
schedules killing non-cron jobs. Field AURORA-976, which is also addressed in 
this diff.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/base/Query.java 
a6ff14a69a32965a87a7a3a6d73ef53f5bdf75c0 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
6e3caa164e4b98907e1a87460aab3afb9be95ef9 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 8d41e7011344aa6a9ba39feacc166dd3c3e64227 

Diff: https://reviews.apache.org/r/29271/diff/


Testing
---

./gradlew -Pq build

```
$ aurora cron schedule  devcluster/www-data/prod/hello 
aurora/examples/jobs/cron_hello_world.aurora 
 INFO] Registering job hello with cron
Error scheduling cron job devcluster/www-data/prod/hello:
Job www-data/prod/hello already exists

$ aurora job create  devcluster/www-data/prod/hello 
aurora/examples/jobs/hello_world.aurora 
 INFO] Creating job hello
Job creation failed due to error:
Job www-data/prod/hello already exists
```


Thanks,

Maxim Khutornenko

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-06 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29464/#review66894
---

Ship it!


Master (c1174a7) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 5, 2015, 6:47 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29464/
> ---
> 
> (Updated Jan. 5, 2015, 6:47 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've added a new flag for the aurora scheduler, -hostname which can override 
> the scheduler server address published into ZK.
> 
> This is useful for cases such as running the scheduler in EC2, where the 
> autodetected local address is actual an interal IP and not the public address 
> of the machine.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/thermos/thermos_internal.thrift 
> 2c449a491bc5a8ac858ea6487e4cef0591f36f66 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 360e161b6c3f6fd412c7e8de7f1b9a3af109593c 
>   
> src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
> cf173850635572c0df38bdd5cb14de8ce2016bf7 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 9e5bdc3885e76d8d03aa946caac9fdec7e1e9186 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 5e4bd65537d186459003c0b9434f1b769e04f448 
>   src/main/python/apache/thermos/bin/thermos_runner.py 
> 647de2771f301b17de33d8b45198c211d2e84367 
>   src/main/python/apache/thermos/core/runner.py 
> 8aac6b50c66080abbb5308b367e9f74c487f42e3 
>   
> src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java
>  PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 5e54364a49a208bd5f19b9649633dc8feca591e9 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> fbc3da3ab239b67ce3012d5a14fccd3ccb20a241 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 
> c3bf5ea4cbeaad03e187f84215b86531d55c25b3 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> e329a90b8fba43611f5120e2a5ee82220dbe2a91 
> 
> Diff: https://reviews.apache.org/r/29464/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 29472: [WIP] Updates documentation markdown to a consistent style.

2015-01-06 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29472/#review66892
---


This patch does not apply cleanly on master (c1174a7), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 30, 2014, 10:18 p.m., Dave Lester wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29472/
> ---
> 
> (Updated Dec. 30, 2014, 10:18 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-983
> https://issues.apache.org/jira/browse/AURORA-983
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updates documentation markdown to a consistent style. WIP. Still needs a 
> style guide typed up to formalize the style of markdown.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
>   docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
>   docs/committers.md 23a25c1e78450690102120ed61afb3f37b69c9c2 
>   docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea 
>   docs/configuration-tutorial.md b64dc14649939083821ac682b08a5d3eb6e8ae41 
>   docs/contributing.md 0ac89543a75921397a80b0473b52bbeea0ed9a30 
>   docs/cron-jobs.md c3e8eede307fa94807bd65b34d9c24711c8269c1 
>   docs/developing-aurora-client.md b9912bce44d65ddd7f1e35f0ea9356a89d5fe767 
>   docs/developing-aurora-scheduler.md 
> 7f6cc2e6c8e01115a9b7a7dc7633bcd88ba02a0f 
>   docs/hooks.md 533c81df9a5934ea903e3dbfb9fca6a211ceba21 
>   docs/monitoring.md 8aee66915f40d39368b57acd2b9e328e52b8cdbe 
>   docs/resource-isolation.md 7e8d88d09093d85c07c84bd3d6476fc89ff21c3b 
>   docs/scheduler-storage.md 1cd02f87d3062d76942cb9ec755084adc64d0aec 
>   docs/sla.md 14e9108fda91200bbf56384c96b9cd926689311f 
>   docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a 
>   docs/storage.md 6ffed541d1579a8131ce642b082be602431329d3 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   docs/tutorial.md e46addd664ae6219b10b6a57822efeabf16ede40 
>   docs/user-guide.md 877f5b7f44e58dd102a6111635e1b669ef24508f 
>   docs/vagrant.md c3632eebfe4c65d7dec6fd6cd02b45308691914d 
> 
> Diff: https://reviews.apache.org/r/29472/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Lester
> 
>

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-06 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29586/#review66891
---

Ship it!


Master (c1174a7) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 5, 2015, 7:07 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29586/
> ---
> 
> (Updated Jan. 5, 2015, 7:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Replace twitter.common.python dependency with a direct pex dependency (at the 
> latest version).
> 
> 
> Diffs
> -
> 
>   3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/commands/BUILD 
> 78a2f57b4b42edf363f40e2988cf9a69c36ad003 
>   src/main/python/apache/aurora/common/BUILD 
> 1c6464d8a91a84ca74191814edacaac5e83b78e8 
>   src/main/python/apache/aurora/common/pex_version.py 
> 6aecd8a14eff7cd58becbecc8b05ea193a6c9cec 
>   src/main/python/apache/aurora/executor/BUILD 
> 72d1ec5e891a4b7b5101ae913f7520609ccd98a8 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> 7c018271724ffab2ff6930e5802a48b50a39dded 
>   src/test/python/apache/aurora/common/test_pex_version.py 
> 7280f703463c6205493a718310f20a7fd21a0c6b 
> 
> Diff: https://reviews.apache.org/r/29586/diff/
> 
> 
> Testing
> ---
> 
> ./pants build src/test/python/apache/aurora:all
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-06 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review66890
---


This patch does not apply cleanly on master (c1174a7), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 5, 2015, 11:53 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28920/
> ---
> 
> (Updated Jan. 5, 2015, 11:53 p.m.)
> 
> 
> Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-633
> https://issues.apache.org/jira/browse/AURORA-633
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This change adds support for launching docker containers through aurora.  
> These changes are based off of the discussion in 
> https://issues.apache.org/jira/browse/AURORA-633
> 
> As of now, a special thermos_executor.sh script is needed to launch the 
> executor inside docker containers.  A sample aurora file is in 
> examples/jobs/docker.
> 
> In addition, mesos-slave must be run with `--containerizers=docker,mesos`, 
> the example upstart config in examples/vagrant/upstart has been updated to 
> reflect this.
> 
> More information is in subsequent review request comments.
> 
> 
> Diffs
> -
> 
>   Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 5665c69cd7b49c3fd7345074c9f16a3b224496ab 
>   docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea 
>   docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7 
>   examples/jobs/docker/hello_docker.aurora PRE-CREATION 
>   examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
>   examples/vagrant/upstart/mesos-slave.conf 
> 512ce7ecf34042ed68dda55efb2dd0415f8469db 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> 5226e3d1b303b1773a057078f2911c5ec2aa97f5 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> ead9d28100673440168a32d114ecaa15874978a6 
>   src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 
> d885b224ec5a1d529347d84e03ba98ab6734a126 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 5bf283062c9d119ff91ed45da8b236e36d0fc9aa 
>   src/main/python/apache/aurora/config/thrift.py 
> ba94ac3c0cbaf3c91eb1a1d86a244ed6fa3b649c 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> 636b23d30a897b557eb8c3f8733c90b23cb807ef 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 9df9b4b79c0c7d29c5088409bf15c0d32a621df0 
>   src/main/python/apache/aurora/executor/common/sandbox.py 
> f47a32b3fefb4a89940b1ddc473b8316ac00df12 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 5e4bd65537d186459003c0b9434f1b769e04f448 
>   src/main/python/apache/thermos/config/schema_base.py 
> f9143cc1b83143d6147f59d90c79435d055d0518 
>   src/main/python/apache/thermos/core/runner.py 
> 8aac6b50c66080abbb5308b367e9f74c487f42e3 
>   src/main/resources/scheduler/assets/configSummary.html 
> 28878908b0c9381e366b71a3135dfc28c542a890 
>   src/main/resources/scheduler/assets/js/services.js 
> b744f375411e09b7f776e4a05ee5961227143439 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 5e54364a49a208bd5f19b9649633dc8feca591e9 
>   src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 
> 876e173ccbac04e4a06a245648c7c6af15eaaa92 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> ddcb511d108220ab5e4efcf3496458f7ab4a20c2 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
> 
> Diff: https://reviews.apache.org/r/28920/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 28913: Remove SANDBOX_DELETED state.

2015-01-06 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28913/#review66889
---

Ship it!


Master (c1174a7) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 6, 2015, 7 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28913/
> ---
> 
> (Updated Jan. 6, 2015, 7 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-832
> https://issues.apache.org/jira/browse/AURORA-832
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The only questionable part for me is the change to `gc_executor.py`.  
> `SANDBOX_DELETED` was used as a catch-all for an unrecognized state.  I 
> changed this to `LOST`, for what i consider to be lack of a better state.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 5665c69cd7b49c3fd7345074c9f16a3b224496ab 
>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
> 3e3543a37137eb57db7e70b171000a254f2bb37c 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> 9c24771e91d55e2bb7304beaddc3abc2399c6e75 
>   src/test/java/org/apache/aurora/scheduler/base/JobsTest.java 
> 56d49eaf288fd13d533f2c103059ef44ca524a63 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> 50d387d3bac34890cf2c9715d7d307c1aa92b569 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> 64c1b7f367898eff0902e17f655bae66a5fe61e5 
> 
> Diff: https://reviews.apache.org/r/28913/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 29491: [AURORA-986] RequestLoggerTest failed for Locale.FRANCE

2015-01-06 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29491/#review66888
---

Ship it!


Master (c1174a7) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 5, 2015, 9:34 p.m., Issam EL ATIF wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29491/
> ---
> 
> (Updated Jan. 5, 2015, 9:34 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> [AURORA-986] RequestLoggerTest failed for Locale.FRANCE
> 
> 
> Diffs
> -
> 
>   src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java 
> 298a34e1a23716cf63ccc02c0ebc9945490fd7bb 
> 
> Diff: https://reviews.apache.org/r/29491/diff/
> 
> 
> Testing
> ---
> 
> All tests in RequestLoggerTest pass now.
> 
> 
> Thanks,
> 
> Issam EL ATIF
> 
>

Re: Review Request 29491: [AURORA-986] RequestLoggerTest failed for Locale.FRANCE

2015-01-06 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29491/#review66887
---

Ship it!


Ship It!

- Kevin Sweeney


On Jan. 5, 2015, 1:34 p.m., Issam EL ATIF wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29491/
> ---
> 
> (Updated Jan. 5, 2015, 1:34 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> [AURORA-986] RequestLoggerTest failed for Locale.FRANCE
> 
> 
> Diffs
> -
> 
>   src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java 
> 298a34e1a23716cf63ccc02c0ebc9945490fd7bb 
> 
> Diff: https://reviews.apache.org/r/29491/diff/
> 
> 
> Testing
> ---
> 
> All tests in RequestLoggerTest pass now.
> 
> 
> Thanks,
> 
> Issam EL ATIF
> 
>

Re: Review Request 28913: Remove SANDBOX_DELETED state.

2015-01-06 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28913/
---

(Updated Jan. 6, 2015, 7 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-832
https://issues.apache.org/jira/browse/AURORA-832


Repository: aurora


Description
---

The only questionable part for me is the change to `gc_executor.py`.  
`SANDBOX_DELETED` was used as a catch-all for an unrecognized state.  I changed 
this to `LOST`, for what i consider to be lack of a better state.


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
5665c69cd7b49c3fd7345074c9f16a3b224496ab 
  src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
3e3543a37137eb57db7e70b171000a254f2bb37c 
  src/main/python/apache/aurora/executor/gc_executor.py 
9c24771e91d55e2bb7304beaddc3abc2399c6e75 
  src/test/java/org/apache/aurora/scheduler/base/JobsTest.java 
56d49eaf288fd13d533f2c103059ef44ca524a63 
  src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
50d387d3bac34890cf2c9715d7d307c1aa92b569 
  src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
64c1b7f367898eff0902e17f655bae66a5fe61e5 

Diff: https://reviews.apache.org/r/28913/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 28913: Remove SANDBOX_DELETED state.

2015-01-06 Thread Bill Farner



> On Dec. 16, 2014, 12:48 a.m., Maxim Khutornenko wrote:
> > src/test/java/org/apache/aurora/scheduler/base/JobsTest.java, line 39
> > 
> >
> > Remove the TODO.

Done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28913/#review65159
---


On Dec. 10, 2014, 7:41 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28913/
> ---
> 
> (Updated Dec. 10, 2014, 7:41 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-832
> https://issues.apache.org/jira/browse/AURORA-832
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The only questionable part for me is the change to `gc_executor.py`.  
> `SANDBOX_DELETED` was used as a catch-all for an unrecognized state.  I 
> changed this to `LOST`, for what i consider to be lack of a better state.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 5665c69cd7b49c3fd7345074c9f16a3b224496ab 
>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
> 3e3543a37137eb57db7e70b171000a254f2bb37c 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> 9c24771e91d55e2bb7304beaddc3abc2399c6e75 
>   src/test/java/org/apache/aurora/scheduler/base/JobsTest.java 
> 56d49eaf288fd13d533f2c103059ef44ca524a63 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> 50d387d3bac34890cf2c9715d7d307c1aa92b569 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> 64c1b7f367898eff0902e17f655bae66a5fe61e5 
> 
> Diff: https://reviews.apache.org/r/28913/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

45 matches

Mail list logo