Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/#review70332 --- Ship it! Master (4f04a34) is green with this patch. ./build-suppo

Review Request 30446: Fix compile errors under Java 8.

2015-01-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora

Re: Review Request 30433: Prevent multiple active job updates from being inserted into storage.

2015-01-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30433/#review70316 --- Ship it! src/main/java/org/apache/aurora/scheduler/updater/JobUpda

Re: Review Request 30433: Prevent multiple active job updates from being inserted into storage.

2015-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30433/#review70302 --- Ship it! Master (4f04a34) is green with this patch. ./build-suppo

Review Request 30433: Prevent multiple active job updates from being inserted into storage.

2015-01-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30433/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1023 https://

Re: Review Request 30389: Deny attempts to create a job update with a non-service job.

2015-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30389/#review70290 --- Ship it! Master (4f04a34) is green with this patch. ./build-suppo

Re: Review Request 30225: Modifying update controller to support heartbeats.

2015-01-29 Thread David McLaughlin
> On Jan. 28, 2015, 7:41 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, > > lines 259-263 > > > > > > I am unsure why this is being called inside puls

Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30187/#review70281 --- Brian - ping? - Bill Farner On Jan. 28, 2015, 8:26 p.m., Bill Far

Re: Review Request 30225: Modifying update controller to support heartbeats.

2015-01-29 Thread Bill Farner
> On Jan. 28, 2015, 7:41 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, > > lines 259-263 > > > > > > I am unsure why this is being called inside puls

Re: Review Request 30389: Deny attempts to create a job update with a non-service job.

2015-01-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30389/ --- (Updated Jan. 29, 2015, 9:26 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 30389: Deny attempts to create a job update with a non-service job.

2015-01-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30389/#review70274 --- Ship it! Ship It! - Joshua Cohen On Jan. 29, 2015, 7:31 p.m., Bi

Re: Review Request 30389: Deny attempts to create a job update with a non-service job.

2015-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30389/#review70269 --- Master (4f04a34) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28731: Implemented TaskScheduler benchmarks.

2015-01-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28731/ --- (Updated Jan. 29, 2015, 8:11 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 30389: Deny attempts to create a job update with a non-service job.

2015-01-29 Thread Bill Farner
> On Jan. 29, 2015, 7:36 p.m., Zameer Manji wrote: > > src/test/python/apache/aurora/client/cli/test_update.py, line 99 > > > > > > This seems like a code smell. Shouldn't we be able to configure the > > fake_context

Re: Review Request 28731: Implemented TaskScheduler benchmarks.

2015-01-29 Thread Kevin Sweeney
> On Jan. 21, 2015, 10:19 a.m., Bill Farner wrote: > > Kevin - any chance you're available to take a pass at this soon? My > > attempts to free up a chunk of time for a thoughtful review have so far > > failed, and this is blocking other work of Maxim's. I'm afraid my review plate is full for

Re: Review Request 30389: Deny attempts to create a job update with a non-service job.

2015-01-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30389/#review70255 --- Ship it! src/test/python/apache/aurora/client/cli/test_update.py <

Re: Review Request 30389: Deny attempts to create a job update with a non-service job.

2015-01-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30389/ --- (Updated Jan. 29, 2015, 7:31 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 30389: Deny attempts to create a job update with a non-service job.

2015-01-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30389/#review70252 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 30389: Deny attempts to create a job update with a non-service job.

2015-01-29 Thread Bill Farner
> On Jan. 29, 2015, 7:15 p.m., Zameer Manji wrote: > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, > > line 3116 > > > > > > Why is this change necessary? Thrift-generated cod

Re: Review Request 30389: Deny attempts to create a job update with a non-service job.

2015-01-29 Thread Bill Farner
> On Jan. 29, 2015, 6:49 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, line 741 > > > > > > Should we include the proper way to update a non-service job > > (kill/create) in this mess

Re: Review Request 30389: Deny attempts to create a job update with a non-service job.

2015-01-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30389/#review70248 --- src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInt

Re: Review Request 30389: Deny attempts to create a job update with a non-service job.

2015-01-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30389/#review70244 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 30389: Deny attempts to create a job update with a non-service job.

2015-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30389/#review70233 --- Ship it! Master (4f04a34) is green with this patch. ./build-suppo

Review Request 30389: Deny attempts to create a job update with a non-service job.

2015-01-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30389/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-330