Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/#review72876 --- This patch does not apply cleanly on master (ec66a5e), do you need

Re: Review Request 31104: task-executor: TASK_RUNNING after first health check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31104/#review72868 --- Will this change break update configs because some time values in

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

On Feb. 17, 2015, 4:59 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java, line 316 https://reviews.apache.org/r/30891/diff/3/?file=862798#file862798line316 It seems like an abstraction violation for a thing named Queue to make logic

Re: Review Request 30647: Instrument the HealthChecker to export stats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- (Updated Feb. 17, 2015, 10:46 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 31029: Documenting coordinated updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31029/#review72814 --- Ship it! Ship It! - Bill Farner On Feb. 14, 2015, 12:33 a.m.,

Re: Review Request 31138: Add ability to pass configurable options to pytest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31138/#review72840 --- Ship it! Ship It! - Brian Wickman On Feb. 17, 2015, 11:12 p.m.,

Re: Review Request 31104: task-executor: TASK_RUNNING after first health check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31104/#review72865 --- Master (4b43305) is red with this patch.

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/ --- (Updated Feb. 18, 2015, 2:01 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 31144: Renaming OfferQueue into OfferManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31144/#review72883 --- Master (ec66a5e) is red with this patch.

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31136/#review72804 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 31137: Update aurora to commons 0.3.3, unflake tests using ThreadedClock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31137/#review72810 --- Ship it! Ship It! - Joshua Cohen On Feb. 17, 2015, 9:59 p.m.,

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31136/#review72815 --- Master (219c3ad) is red with this patch.

Re: Review Request 31137: Update aurora to commons 0.3.3, unflake tests using ThreadedClock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31137/#review72809 --- Ship it! Ship It! - Joe Smith On Feb. 17, 2015, 1:59 p.m.,

Review Request 31138: Add ability to pass configurable options to pytest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31138/ --- Review request for Aurora, Bill Farner and Brian Wickman. Repository: aurora

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31136/#review72828 ---

Re: Review Request 31144: Renaming OfferQueue into OfferManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31144/#review72881 --- Ship it! Ship It! - Bill Farner On Feb. 18, 2015, 2:11 a.m.,

Re: Review Request 31104: task-executor: TASK_RUNNING after first health check

On Feb. 18, 2015, 1:40 a.m., Zameer Manji wrote: Will this change break update configs because some time values in the UpdateConfig are timeouts until a task enters the RUNNING state? It very likely will, communication will be imperative with this change. Moses - can you link this

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

On Feb. 17, 2015, 10:51 p.m., Kevin Sweeney wrote: src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml, line 24 https://reviews.apache.org/r/31136/diff/1/?file=866552#file866552line24 why the underscores here? Bill Farner wrote: Matching

Re: Review Request 31137: Update aurora to commons 0.3.3, unflake tests using ThreadedClock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31137/#review72818 --- Master (219c3ad) is red with this patch.

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

On Feb. 17, 2015, 10:51 p.m., Kevin Sweeney wrote: api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 721 https://reviews.apache.org/r/31136/diff/1/?file=866545#file866545line721 Should these be marked deprecated now (to be removed in 0.9.0?) The TODOs added will be

Re: Review Request 30647: Instrument the HealthChecker to export stats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review72858 --- Ship it! Ship It! - Joshua Cohen On Feb. 18, 2015, 1 a.m.,

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/#review72885 --- Ship it! Master (e0e3f2e) is green with this patch.

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/ --- (Updated Feb. 18, 2015, 2:40 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

On Feb. 18, 2015, 12:59 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java, line 316 https://reviews.apache.org/r/30891/diff/3/?file=862798#file862798line316 It seems like an abstraction violation for a thing named Queue to make logic

Re: Review Request 31104: task-executor: TASK_RUNNING after first health check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31104/ --- (Updated Feb. 18, 2015, 4:32 a.m.) Review request for Aurora and Brian

Re: Review Request 31104: task-executor: TASK_RUNNING after first health check

On Feb. 18, 2015, 1:40 a.m., Zameer Manji wrote: Will this change break update configs because some time values in the UpdateConfig are timeouts until a task enters the RUNNING state? Bill Farner wrote: It very likely will, communication will be imperative with this change.

Re: Review Request 31123: Enable checkstyle indentation check, fix violations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/#review72778 --- This patch does not apply cleanly on master (2b8eb4b), do you need

Re: Review Request 31123: Enable checkstyle indentation check, fix violations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/#review72739 --- Ship it! Ship It! - Zameer Manji On Feb. 17, 2015, 10 a.m.,

Review Request 31124: Fix build break - remove unused imports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31124/ --- Review request for Aurora, Brian Wickman and Zameer Manji. Repository: aurora

Review Request 31123: Enable checkstyle indentation check, fix violations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/ --- Review request for Aurora, Joshua Cohen and Zameer Manji. Repository: aurora

Re: Review Request 31124: Fix build break - remove unused imports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31124/#review72740 --- Ship it! Ship It! - Zameer Manji On Feb. 17, 2015, 10:09 a.m.,

Re: Review Request 31124: Fix build break - remove unused imports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31124/#review72752 --- Ship it! Ship It! - Brian Wickman On Feb. 17, 2015, 6:09 p.m.,

Re: Review Request 31123: Enable checkstyle indentation check, fix violations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/#review72787 --- Ship it! Ship It! - Kevin Sweeney On Feb. 17, 2015, 10 a.m.,

Re: Review Request 31101: Native Debian packaging for Aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31101/#review72785 --- This is great! If this is gonna be mainline and not contrib, how

Review Request 31135: Pin protobuf dependency to 2.6.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31135/ --- Review request for Aurora, Joe Smith and Kevin Sweeney. Bugs: AURORA-1128

Re: Review Request 31123: Enable checkstyle indentation check, fix violations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/#review72796 --- Ship it! Ship It! - Joshua Cohen On Feb. 17, 2015, 6 p.m., Bill

Re: Review Request 31123: Enable checkstyle indentation check, fix violations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/ --- (Updated Feb. 17, 2015, 9:49 p.m.) Review request for Aurora, Joshua Cohen and

Review Request 31137: Update aurora to commons 0.3.3, unflake tests using ThreadedClock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31137/ --- Review request for Aurora, Joshua Cohen and Joe Smith. Repository: aurora

Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31136/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs:

Re: Review Request 31123: Enable checkstyle indentation check, fix violations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/ --- (Updated Feb. 17, 2015, 10:01 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 31135: Pin protobuf dependency to 2.6.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31135/#review72792 --- Ship it! Ship It! - Kevin Sweeney On Feb. 17, 2015, 1:15 p.m.,

Re: Review Request 31029: Documenting coordinated updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31029/#review72795 --- Ship it! Ship It! - David McLaughlin On Feb. 14, 2015, 12:33

Re: Review Request 31135: Pin protobuf dependency to 2.6.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31135/#review72799 --- Ship it! Ship It! - Joe Smith On Feb. 17, 2015, 1:15 p.m.,

Re: Review Request 31123: Enable checkstyle indentation check, fix violations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/#review72801 --- Ship it! Ship It! - Joshua Cohen On Feb. 17, 2015, 9:49 p.m.,