---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32295/
---
Review request for Aurora.
Bugs: AURORA-316
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32295/#review77198
---
Master (db79418) is red with this patch.
On March 20, 2015, 11:06 a.m., Aurora ReviewBot wrote:
Master (db79418) is red with this patch.
./build-support/jenkins/build.sh
Installing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32295/
---
(Updated March 20, 2015, 11:13 a.m.)
Review request for Aurora.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32295/#review77203
---
Ship it!
Master (db79418) is green with this patch.
On March 20, 2015, 3:52 p.m., Joe Smith wrote:
It seems like the `self.quitquitquit` is the important part (on line 340 of the
runner)- doesn't decreasing the timeout not give `quitquitquit` the time it
needs?
- Joe
---
This is an
On March 20, 2015, 3:52 p.m., Joe Smith wrote:
Joe Smith wrote:
It seems like the `self.quitquitquit` is the important part (on line 340
of the runner)- doesn't decreasing the timeout not give `quitquitquit` the
time it needs?
In
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32319/#review77314
---
Ship it!
The updater is dead, long live the updater.
- Joshua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32329/
---
(Updated March 20, 2015, 5:16 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32329/#review77319
---
Ship it!
Master (a3a35e9) is green with this patch.
On Feb. 6, 2015, 6:52 p.m., Brian Wickman wrote:
This is super rad. Thanks for taking this on.
Before I do a deeper dive, what do you think about making the logrotate
policy be specified by the user instead of the framework owner, with a
sensible default? For example, if this is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32353/#review77325
---
Ship it!
Master (a3a35e9) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32353/#review77317
---
Ship it!
Ship It!
- Bill Farner
On March 21, 2015, 12:25 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77302
---
Ship it!
Master (f12d9fe) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32353/
---
Review request for Aurora and Bill Farner.
Repository: aurora
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32359/
---
Review request for Aurora and Bill Farner.
Bugs: AURORA-1211
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32352/#review77329
---
Ship it!
Master (a3a35e9) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32221/#review77296
---
src/test/python/apache/aurora/executor/test_thermos_task_runner.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32352/
---
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1158
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32359/#review77330
---
Ship it!
Master (a3a35e9) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32302/
---
Review request for Aurora.
Bugs: AURORA-1212
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32302/#review77213
---
Ship it!
Master (db79418) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32231/#review77222
---
Ship it!
Cool, spun this up in vagrant and confirmed:
```
W0320
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32323/
---
Review request for Aurora, Joshua Cohen and Bill Farner.
Repository: aurora
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77242
---
Realized i neglected to update docs. Please review what's here,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77248
---
Ship it!
src/test/python/apache/aurora/client/cli/test_supdate.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32231/
---
(Updated March 20, 2015, 4:36 p.m.)
Review request for Aurora and Bill Farner.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/
---
Review request for Aurora, Joshua Cohen and Zameer Manji.
Bugs: AURORA-1206
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77243
---
Ship it!
Master (91aec8c) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32231/#review77233
---
Master (3cb8af1) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77268
---
Ship it!
Master (f12d9fe) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32329/#review77273
---
Master (f12d9fe) is red with this patch.
On March 20, 2015, 5:59 p.m., Zameer Manji wrote:
src/test/python/apache/aurora/client/cli/test_supdate.py, line 101
https://reviews.apache.org/r/32313/diff/1/?file=901501#file901501line101
Using a raw mock here is a little bit dangerous if the shape of the raw
config changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/
---
(Updated March 20, 2015, 7:51 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32323/#review77260
---
Ship it!
Master (91aec8c) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32323/#review77261
---
Ship it!
Thanks! Good find!
- Bill Farner
On March 20, 2015,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/
---
(Updated March 20, 2015, 8:15 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32329/
---
Review request for Aurora, Joshua Cohen and Bill Farner.
Bugs: AURORA-1187
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/
---
(Updated March 20, 2015, 8:23 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32329/
---
(Updated March 20, 2015, 3:01 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77284
---
Ship it!
src/test/python/apache/aurora/client/cli/test_supdate.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32329/#review77286
---
Ship it!
Master (f12d9fe) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32319/
---
Review request for Aurora.
Bugs: AURORA-1190
On March 20, 2015, 10:11 p.m., Joshua Cohen wrote:
src/test/python/apache/aurora/client/cli/test_supdate.py, lines 158-162
https://reviews.apache.org/r/32313/diff/4/?file=901692#file901692line158
Can we assert `self._mock_api.start_job.mock_calls = [call(...)]`
instead?
We can!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/
---
(Updated March 20, 2015, 10:30 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/
---
(Updated March 20, 2015, 10:31 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77291
---
Ship it!
src/test/python/apache/aurora/client/cli/test_supdate.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77292
---
Master (f12d9fe) is red with this patch.
On March 20, 2015, 10:33 p.m., Joshua Cohen wrote:
src/test/python/apache/aurora/client/cli/test_supdate.py, line 636
https://reviews.apache.org/r/32313/diff/5/?file=901848#file901848line636
Yes, let us add stuff! Stuff is great and junk!
Stuff=added. This pointed out that i
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32319/#review77295
---
Ship it!
Master (f12d9fe) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/
---
(Updated March 20, 2015, 10:48 p.m.)
Review request for Aurora, Joshua Cohen
51 matches
Mail list logo