Review Request 32295: Make health check configurable

2015-03-20 Thread Brian Brazil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32295/ --- Review request for Aurora. Bugs: AURORA-316

Re: Review Request 32295: Make health check configurable

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32295/#review77198 --- Master (db79418) is red with this patch.

Re: Review Request 32295: Make health check configurable

2015-03-20 Thread Brian Brazil
On March 20, 2015, 11:06 a.m., Aurora ReviewBot wrote: Master (db79418) is red with this patch. ./build-support/jenkins/build.sh Installing

Re: Review Request 32295: Make health check configurable

2015-03-20 Thread Brian Brazil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32295/ --- (Updated March 20, 2015, 11:13 a.m.) Review request for Aurora. Bugs:

Re: Review Request 32295: Make health check configurable

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32295/#review77203 --- Ship it! Master (db79418) is green with this patch.

Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-20 Thread Joe Smith
On March 20, 2015, 3:52 p.m., Joe Smith wrote: It seems like the `self.quitquitquit` is the important part (on line 340 of the runner)- doesn't decreasing the timeout not give `quitquitquit` the time it needs? - Joe --- This is an

Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-20 Thread Joe Smith
On March 20, 2015, 3:52 p.m., Joe Smith wrote: Joe Smith wrote: It seems like the `self.quitquitquit` is the important part (on line 340 of the runner)- doesn't decreasing the timeout not give `quitquitquit` the time it needs? In

Re: Review Request 32319: Add a deprecation warning when using the client-side updater.

2015-03-20 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32319/#review77314 --- Ship it! The updater is dead, long live the updater. - Joshua

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/ --- (Updated March 20, 2015, 5:16 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/#review77319 --- Ship it! Master (a3a35e9) is green with this patch.

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-03-20 Thread George Sirois
On Feb. 6, 2015, 6:52 p.m., Brian Wickman wrote: This is super rad. Thanks for taking this on. Before I do a deeper dive, what do you think about making the logrotate policy be specified by the user instead of the framework owner, with a sensible default? For example, if this is

Re: Review Request 32353: Renaming PreemptionSlotFinder.

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32353/#review77325 --- Ship it! Master (a3a35e9) is green with this patch.

Re: Review Request 32353: Renaming PreemptionSlotFinder.

2015-03-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32353/#review77317 --- Ship it! Ship It! - Bill Farner On March 21, 2015, 12:25 a.m.,

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77302 --- Ship it! Master (f12d9fe) is green with this patch.

Review Request 32353: Renaming PreemptionSlotFinder.

2015-03-20 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32353/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Review Request 32359: Adding a configurable delay into writing a backup file.

2015-03-20 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32359/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1211

Re: Review Request 32352: Making preemptor asynchronous. Part 3(final) - background service.

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32352/#review77329 --- Ship it! Master (a3a35e9) is green with this patch.

Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-20 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32221/#review77296 --- src/test/python/apache/aurora/executor/test_thermos_task_runner.py

Review Request 32352: Making preemptor asynchronous. Part 3(final) - background service.

2015-03-20 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32352/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1158

Re: Review Request 32359: Adding a configurable delay into writing a backup file.

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32359/#review77330 --- Ship it! Master (a3a35e9) is green with this patch.

Review Request 32302: Allow config to specify static ports for non-dedicated jobs.

2015-03-20 Thread Brian Brazil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32302/ --- Review request for Aurora. Bugs: AURORA-1212

Re: Review Request 32302: Allow config to specify static ports for non-dedicated jobs.

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32302/#review77213 --- Ship it! Master (db79418) is green with this patch.

Re: Review Request 32231: AURORA-1189: Adding check to see if java version is below 1.8

2015-03-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32231/#review77222 --- Ship it! Cool, spun this up in vagrant and confirmed: ``` W0320

Review Request 32323: DRY up PMD configuration.

2015-03-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32323/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77242 --- Realized i neglected to update docs. Please review what's here,

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77248 --- Ship it! src/test/python/apache/aurora/client/cli/test_supdate.py

Re: Review Request 32231: AURORA-1189: Adding check to see if java version is below 1.8

2015-03-20 Thread Florian Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32231/ --- (Updated March 20, 2015, 4:36 p.m.) Review request for Aurora and Bill Farner.

Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1206

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77243 --- Ship it! Master (91aec8c) is green with this patch.

Re: Review Request 32231: AURORA-1189: Adding check to see if java version is below 1.8

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32231/#review77233 --- Master (3cb8af1) is green with this patch.

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77268 --- Ship it! Master (f12d9fe) is green with this patch.

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/#review77273 --- Master (f12d9fe) is red with this patch.

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Bill Farner
On March 20, 2015, 5:59 p.m., Zameer Manji wrote: src/test/python/apache/aurora/client/cli/test_supdate.py, line 101 https://reviews.apache.org/r/32313/diff/1/?file=901501#file901501line101 Using a raw mock here is a little bit dangerous if the shape of the raw config changes

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 7:51 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32323: DRY up PMD configuration.

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32323/#review77260 --- Ship it! Master (91aec8c) is green with this patch.

Re: Review Request 32323: DRY up PMD configuration.

2015-03-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32323/#review77261 --- Ship it! Thanks! Good find! - Bill Farner On March 20, 2015,

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 8:15 p.m.) Review request for Aurora, Joshua Cohen

Review Request 32329: Extract job key from RPC parameters

2015-03-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1187

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 8:23 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/ --- (Updated March 20, 2015, 3:01 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77284 --- Ship it! src/test/python/apache/aurora/client/cli/test_supdate.py

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/#review77286 --- Ship it! Master (f12d9fe) is green with this patch.

Review Request 32319: Add a deprecation warning when using the client-side updater.

2015-03-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32319/ --- Review request for Aurora. Bugs: AURORA-1190

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Bill Farner
On March 20, 2015, 10:11 p.m., Joshua Cohen wrote: src/test/python/apache/aurora/client/cli/test_supdate.py, lines 158-162 https://reviews.apache.org/r/32313/diff/4/?file=901692#file901692line158 Can we assert `self._mock_api.start_job.mock_calls = [call(...)]` instead? We can!

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 10:30 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 10:31 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77291 --- Ship it! src/test/python/apache/aurora/client/cli/test_supdate.py

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77292 --- Master (f12d9fe) is red with this patch.

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Bill Farner
On March 20, 2015, 10:33 p.m., Joshua Cohen wrote: src/test/python/apache/aurora/client/cli/test_supdate.py, line 636 https://reviews.apache.org/r/32313/diff/5/?file=901848#file901848line636 Yes, let us add stuff! Stuff is great and junk! Stuff=added. This pointed out that i

Re: Review Request 32319: Add a deprecation warning when using the client-side updater.

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32319/#review77295 --- Ship it! Master (f12d9fe) is green with this patch.

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 10:48 p.m.) Review request for Aurora, Joshua Cohen