.
- Mark Chu-Carroll
On Jan. 8, 2014, 7:12 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423
.
Thanks,
Mark Chu-Carroll
/util.py
2985865264a7fd9dd8f59182a4df9e335e210f84
Diff: https://reviews.apache.org/r/17051/diff/
Testing
---
Unit tests all pass; new tests added for the new update command.
Thanks,
Mark Chu-Carroll
/test/python/apache/aurora/client/cli/util.py
2985865264a7fd9dd8f59182a4df9e335e210f84
Diff: https://reviews.apache.org/r/17051/diff/
Testing
---
Unit tests all pass; new tests added for the new update command.
Thanks,
Mark Chu-Carroll
de6039be73edec030890cb8ebca9c99b28acb4fc
src/test/python/apache/aurora/client/commands/util.py
22694a29d277b3693a429793a0fc7c0ca2552260
Diff: https://reviews.apache.org/r/17051/diff/
Testing
---
Unit tests all pass; new tests added for the new update command.
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17051/#review32377
---
ping?
- Mark Chu-Carroll
On Jan. 17, 2014, 3:05 p.m., Mark Chu
/python/apache/aurora/client/cli/test_restart.py ...
=== 23 passed in 1.39 seconds
===
src.test.python.apache.aurora.client.cli.job
. SUCCESS
[sun-wukong aurora (restart)]$
Thanks,
Mark Chu
://reviews.apache.org/r/17153/#review32454
---
On Jan. 21, 2014, 5:03 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
-Carroll
On Jan. 21, 2014, 5:03 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17153/
---
(Updated Jan. 21
src.test.python.apache.aurora.executor.executor_detector
. SUCCESS
src.test.python.apache.aurora.executor.executor_vars
. SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner
. SUCCESS
Thanks,
Mark Chu-Carroll
...
= 20 passed in 0.71 seconds
=
src.test.python.apache.aurora.client.cli.job
. SUCCESS
Thanks,
Mark Chu-Carroll
that a quota could be set at a lower level the first is more extensible
aurora quota get west/ksweeney/prod
aurora quota get west/ksweeney/prod/appserver
- Kevin Sweeney
On January 24th, 2014, 2:07 p.m. PST, Mark Chu-Carroll wrote:
Review request for Aurora, Kevin Sweeney and Brian Wickman
. SUCCESS
Thanks,
Mark Chu-Carroll
., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17185/
---
(Updated Jan. 27, 2014, 1:21 p.m.)
Review
.
- Mark Chu-Carroll
On Jan. 23, 2014, 6:10 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17270
-wukong incubator-aurora (bridge)]$ ./dist/client.pex job status
usage: client.pex job status [-h] [--json] jobspec
client.pex job status: error: too few arguments
Thanks,
Mark Chu-Carroll
: http://precise64:8081/scheduler/vagrant/test/flask_example
***
OK (all tests passed)
***
[sun-wukong incubator-aurora (e2e)]$
Thanks,
Mark Chu-Carroll
://precise64:8081/scheduler/vagrant/test/flask_example
***
OK (all tests passed)
***
[sun-wukong incubator-aurora (e2e)]$
Thanks,
Mark Chu-Carroll
incubator-aurora (bridge)]$ ./dist/client.pex job status
usage: client.pex job status [-h] [--json] jobspec
client.pex job status: error: too few arguments
Thanks,
Mark Chu-Carroll
(all tests passed)
***
[sun-wukong incubator-aurora (e2e)]$
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17332/#review32757
---
On Jan. 24, 2014, 5:07 p.m., Mark Chu-Carroll wrote
---
Fix whitespace glitches.
Diffs
-
src/main/python/apache/aurora/client/commands/admin.py
d8b9a44a02cd9e8873a97e9107a7b18e3c97b66b
Diff: https://reviews.apache.org/r/17614/diff/
Testing
---
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17457/#review33359
---
ping?
- Mark Chu-Carroll
On Jan. 30, 2014, 4:09 p.m., Mark Chu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17270/#review33360
---
ping?
- Mark Chu-Carroll
On Jan. 30, 2014, 4:03 p.m., Mark Chu
/test/flask_example
***
OK (all tests passed)
***
[sun-wukong incubator-aurora (e2e)]$
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17637/#review33435
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Feb. 3, 2014, 10:58 a.m
://reviews.apache.org/r/17457/#comment62917
Because in the vmware precise64 image, git and python-setuptools aren't
included.
With these added to the list, the test works on both vmware and virtualbox.
- Mark Chu-Carroll
On Feb. 3, 2014, 11:30 a.m., Mark Chu-Carroll wrote
/flask_example
***
OK (all tests passed)
***
[sun-wukong incubator-aurora (e2e)]$
Thanks,
Mark Chu-Carroll
:
https://reviews.apache.org/r/17457/#review33510
---
On Feb. 3, 2014, 3:16 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
)]$
Thanks,
Mark Chu-Carroll
/ksweeney/prod/appserver
On January 31st, 2014, 7:37 a.m. PST, *Mark Chu-Carroll* wrote:
I've been thinking about this, debating it in my own head, and I just can't
agree.
Quota isn't a standalone entity; A quota is an attribute of a role. It
doesn't make sense to me to have
,
Mark Chu-Carroll
. SUCCESS
Thanks,
Mark Chu-Carroll
://reviews.apache.org/r/17645/#comment63329
I would prefer for the help to make it clear what adding the parameter
would do. If false, prevent update from performing a rollback.
- Mark Chu-Carroll
On Feb. 3, 2014, 4 p.m., David Robinson wrote
/17270/#review33471
---
On Jan. 30, 2014, 4:03 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17270
://reviews.apache.org/r/17332/#comment63426
Yes, this entire file was meant to be removed. I git mv'ed it to create
quota.py and it's not in my branch. I'm not sure what to do to fix the review -
rbt doesn't see any diff, because the file's already gone.
- Mark Chu-Carroll
On Feb. 5, 2014, 10:08 a.m
On Feb. 6, 2014, 1:36 p.m., Mark Chu-Carroll wrote:
src/main/python/apache/aurora/client/cli/role.py, line 44
https://reviews.apache.org/r/17332/diff/1/?file=450590#file450590line44
Yes, this entire file was meant to be removed. I git mv'ed it to create
quota.py and it's
,
Mark Chu-Carroll
/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_get_quota.py ...
= 20 passed in 0.71 seconds
=
src.test.python.apache.aurora.client.cli.job
. SUCCESS
Thanks,
Mark Chu
/ssh.py
d1499ec1e9e910bc32f5f9f4b050c53316348503
src/test/python/apache/aurora/client/commands/test_run.py
abcc275d57373038227d3805c16b17b967f92048
Diff: https://reviews.apache.org/r/17724/diff/
Testing
---
Manual testing on the command line.
Thanks,
Mark Chu-Carroll
On Feb. 6, 2014, 5:36 p.m., Mark Chu-Carroll wrote:
src/main/python/apache/aurora/client/cli/__init__.py, line 149
https://reviews.apache.org/r/17270/diff/3/?file=456886#file456886line149
That's actually the way that I originally wrote it, and wickman wanted
me to change
: 18afec3ae3a5d896f69984784a1dbc6e0e743e44
date: Thursday Jan 23, 2014
Aurora API version: APIVersion(major=3)
V2 COMMAND:
[sun-wukong incubator-aurora (bridge)]$ ./dist/client.pex job status
usage: client.pex job status [-h] [--json] jobspec
client.pex job status: error: too few arguments
Thanks,
Mark Chu-Carroll
. SUCCESS
Thanks,
Mark Chu-Carroll
, but rbt
hasn't caught up. Will upload ASAP.
src/main/python/apache/aurora/client/cli/options.py
https://reviews.apache.org/r/17752/#comment63778
D'oh. This is called during the argument processing. The context isn't
around yet.
- Mark Chu-Carroll
On Feb. 7, 2014, 1:55 p.m., Mark Chu
===
src.test.python.apache.aurora.client.cli.job
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
Thanks,
Mark Chu-Carroll
://reviews.apache.org/r/17877/#comment64205
Die expects a message string, not an exception object. die('Invalid unit
specification') would end up with a better error message.
- Mark Chu-Carroll
On Feb. 10, 2014, 2:17 p.m., Dan Norris wrote
===
src.test.python.apache.aurora.client.cli.job
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18086/#review34380
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Feb. 13, 2014, 11:45
://reviews.apache.org/r/17948/#comment64931
Yeah, but that'll add a leading CR. I think it's better to just leave it as
is.
- Mark Chu-Carroll
On Feb. 18, 2014, 10:06 a.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail
===
src.test.python.apache.aurora.client.cli.job
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
Thanks,
Mark Chu-Carroll
://reviews.apache.org/r/17948/diff/
Testing
---
Added unit tests of new functions; verified that all client tests pass.
Thanks,
Mark Chu-Carroll
src.test.python.apache.aurora.client.cli.task
. SUCCESS
[sun-wukong incubator-aurora (plugins)]$
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/#review34878
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Feb. 18, 2014, 6:19 p.m
. Thanks!
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18265/#review34876
---
On Feb. 19, 2014, 8:29 a.m., Mark Chu-Carroll wrote
Ping? I would really like to get this pushed and hopefully deployed soon.
-Mark
On Wed, Feb 19, 2014 at 12:55 PM, Mark Chu-Carroll
mchucarr...@twopensource.com wrote:
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18265/
Review request
. SUCCESS
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
[sun-wukong incubator-aurora (bridgehelp)]$
Thanks,
Mark Chu-Carroll
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
[sun-wukong incubator-aurora (bridgehelp)]$
Thanks,
Mark Chu-Carroll
---
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16144/#review35154
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Dec. 9, 2013, 8:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/#review35152
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Feb. 20, 2014, 7:05 p.m
them stricter?
- Mark Chu-Carroll
On Feb. 21, 2014, 11:30 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18296
-python-sdists
43e74be8496916cd4f56d4930b3e8d8a217c001c
src/main/python/apache/aurora/client/BUILD
11ad955866b82b327a57a0f52cff0cdc1a2d83fc
Diff: https://reviews.apache.org/r/18354/diff/
Testing
---
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18440/#review35438
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Feb. 25, 2014, 1:59 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18546/#review35827
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Feb. 27, 2014, 8:32 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18720/#review36551
---
Ship it!
Ship It!
- Mark Chu-Carroll
On March 6, 2014, 5:42 p.m
/__init__.py
4a6a7eef7b781be79a3d40776a3bd6f0c6e8c4c0
Diff: https://reviews.apache.org/r/18979/diff/
Testing
---
n/a
Thanks,
Mark Chu-Carroll
the updated doc.)
Diffs
-
docs/clientv2.md PRE-CREATION
src/main/python/apache/aurora/client/cli/__init__.py
4a6a7eef7b781be79a3d40776a3bd6f0c6e8c4c0
Diff: https://reviews.apache.org/r/18979/diff/
Testing
---
n/a
Thanks,
Mark Chu-Carroll
: https://reviews.apache.org/r/18996/diff/
Testing
---
Thanks,
Mark Chu-Carroll
3b327df5f9c5f1d5e7e68863191313921a8dde44
Diff: https://reviews.apache.org/r/18979/diff/
Testing
---
n/a
Thanks,
Mark Chu-Carroll
src.test.python.apache.aurora.client.commands.ssh
. SUCCESS
Thanks,
Mark Chu-Carroll
---
On March 11, 2014, 3:42 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19061/
---
(Updated March
,
Mark Chu-Carroll
want to discourage - saying that you can't do it
from a script, and can only do it explicitly is a good thing.
- Mark Chu-Carroll
On March 11, 2014, 6:23 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail
src.test.python.apache.aurora.client.commands.maintenance
. SUCCESS
src.test.python.apache.aurora.client.commands.run
. SUCCESS
src.test.python.apache.aurora.client.commands.ssh
. SUCCESS
Thanks,
Mark Chu-Carroll
/19143/diff/
Testing
---
Thanks,
Mark Chu-Carroll
-mail. To reply, visit:
https://reviews.apache.org/r/18979/#review36827
---
On March 11, 2014, 12:34 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail
---
n/a
Thanks,
Mark Chu-Carroll
is also in this change - see the change above in kill.
- Mark Chu-Carroll
On March 12, 2014, 6:11 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159
/apache/aurora/client/api/scheduler_client.py
f770df7a23779f919cd11cc28b2aaf7cfdf9c5a1
Diff: https://reviews.apache.org/r/19143/diff/
Testing
---
Thanks,
Mark Chu-Carroll
://reviews.apache.org/r/19159/
On March 12th, 2014, 3:25 p.m. PDT, *Mark Chu-Carroll* wrote:
src/main/python/apache/aurora/client/commands/core.pyhttps://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line399
(Diff
revision 1)
def show_job_pretty(job):
397
without the --force
flag. The standard optional semantic of that flag is violated here.
On Mar 13, 2014, at 11:07 AM, Mark Chu-Carroll mchucarr...@apache.org
wrote:
I think making a reasonable effort to make it harder to accidentally do
this is worthwhile - there's no harm in it, and it might
==
src.test.python.apache.aurora.client.commands.core
. SUCCESS
Thanks,
Mark Chu-Carroll
==
src.test.python.apache.aurora.client.commands.core
. SUCCESS
Thanks,
Mark Chu-Carroll
==
src.test.python.apache.aurora.client.commands.core
. SUCCESS
Thanks,
Mark Chu-Carroll
..
src/test/python/apache/aurora/client/commands/test_update.py ...
= 26 passed in 11.34 seconds ==
src.test.python.apache.aurora.client.commands.core
. SUCCESS
Thanks,
Mark Chu-Carroll
==
src.test.python.apache.aurora.client.commands.core
. SUCCESS
Thanks,
Mark Chu-Carroll
a good idea.)
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19143/#review37080
---
On March 12, 2014, 6:59 p.m., Mark Chu-Carroll
src.test.python.apache.aurora.client.cli.quota
. SUCCESS
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
Thanks,
Mark Chu
of
boolean, and if they supply an override, then hooks don't run?
- Mark Chu-Carroll
On March 19, 2014, 1:09 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19411
. SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
Thanks,
Mark Chu-Carroll
. SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api
. SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
Thanks,
Mark Chu-Carroll
shards: you need to explicitly say that that's what you want to do.
- Mark Chu-Carroll
On March 19, 2014, 7:38 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
Thanks,
Mark Chu-Carroll
No need for weaselword typically here.
docs/hooks.md
https://reviews.apache.org/r/19313/#comment70062
Tons of trailing whitespace everywhere, and smart quotes for apostrophes.
- Mark Chu-Carroll
On March 17, 2014, 3:01 p.m., Tom Galloway wrote
src.test.python.apache.aurora.client.hooks.hooked_api
. SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
Thanks,
Mark Chu-Carroll
in this change that
should cause a thermos problem - but I don't know nearly enough about thermos,
so I'll defer to Brian, who's the thermos God.
- Mark Chu-Carroll
On March 20, 2014, 10:39 p.m., Suman Karumuri wrote
/#review38154
---
On March 20, 2014, 11:42 a.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466
for
the people who build/maintain it.
If you think of it that way, I think it's clear when to use which.
- Mark Chu-Carroll
On March 19, 2014, 9:20 a.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail
src.test.python.apache.aurora.client.cli.quota
. SUCCESS
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19509/#review38205
---
Ship it!
Ship It!
- Mark Chu-Carroll
On March 20, 2014, 10:39
1 - 100 of 373 matches
Mail list logo
