Re: Review Request 16423: client v2: added implementations of job diff, job inspect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16423/#review31615 --- Sorry about the merge glitches; that was sloppy of me. I shouldn't have tried to push the branch-merge so quickly. src/test/python/twitter/aurora/client/cli/BUILD https://reviews.apache.org/r/16423/#comment60210 Weird - don't see this in my workspace. Strange; I must have done something stupid like not saved one of my open buffers before pushing the review. - Mark Chu-Carroll On Jan. 8, 2014, 7:12 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16423/ --- (Updated Jan. 8, 2014, 7:12 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Repository: aurora Description --- Implemented client v2 versions of the diff and inspect verbs. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513 src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa src/main/python/apache/aurora/client/options.py af56351eed21805f09bfe50cb91745d58b665627 src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773 src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION Diff: https://reviews.apache.org/r/16423/diff/ Testing --- Added new unit tests for diff; inspect doesn't do any API calls that aren't already tested. Thanks, Mark Chu-Carroll
Re: Review Request 16423: client v2: added implementations of job diff, job inspect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16423/ --- (Updated Jan. 13, 2014, 5:28 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Changes --- Addressed latest round of reviews. Repository: aurora Description --- Implemented client v2 versions of the diff and inspect verbs. Diffs (updated) - src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513 src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa src/main/python/apache/aurora/client/options.py af56351eed21805f09bfe50cb91745d58b665627 src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 9528eed70e76431f720c4a26651ae0729903288c src/test/python/apache/aurora/client/cli/test_create.py df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54 src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773 src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py c6d38304fb8ac89b9a175d8c20438a8831f784df src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION Diff: https://reviews.apache.org/r/16423/diff/ Testing --- Added new unit tests for diff; inspect doesn't do any API calls that aren't already tested. Thanks, Mark Chu-Carroll
Re: Review Request 17051: Add clientv2 implementations of update and list jobs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17051/ --- (Updated Jan. 17, 2014, 1:58 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Changes --- Address wickman's review comments. Bugs: aurora-53 https://issues.apache.org/jira/browse/aurora-53 Repository: aurora Description --- Add clientv2 implementations of update and list jobs. (This was originally planned to also include cancel_update and restart, but after testing problems led to splitting out AURORA-42, and merges with restart failed, I decided to submit these two, and put the others in a subsequent change.) Diffs (updated) - src/main/python/apache/aurora/client/cli/context.py be156bb52dd48e8e5a0df3ddfb0aef1a815d538e src/main/python/apache/aurora/client/cli/jobs.py c519e3c1a4dc055ae1a77d29ca5ba2e6464cacf0 src/main/python/apache/aurora/client/cli/options.py 0aaf8801950b18be2f00fb1a1f9d8a5a853a1c42 src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d src/test/python/apache/aurora/client/cli/BUILD 97b074488c569c1c92e2bfd69f09ffbd3a827d49 src/test/python/apache/aurora/client/cli/test_kill.py 66d729dc0cdff71a8f8496c528d6fb71dbdb5457 src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84 Diff: https://reviews.apache.org/r/17051/diff/ Testing --- Unit tests all pass; new tests added for the new update command. Thanks, Mark Chu-Carroll
Re: Review Request 17051: Add clientv2 implementations of update and list jobs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17051/ --- (Updated Jan. 17, 2014, 2:11 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Changes --- grumble, I screwed up my git commands; this should be the correct diff. Bugs: aurora-53 https://issues.apache.org/jira/browse/aurora-53 Repository: aurora Description --- Add clientv2 implementations of update and list jobs. (This was originally planned to also include cancel_update and restart, but after testing problems led to splitting out AURORA-42, and merges with restart failed, I decided to submit these two, and put the others in a subsequent change.) Diffs (updated) - src/main/python/apache/aurora/client/cli/context.py be156bb52dd48e8e5a0df3ddfb0aef1a815d538e src/main/python/apache/aurora/client/cli/jobs.py c519e3c1a4dc055ae1a77d29ca5ba2e6464cacf0 src/main/python/apache/aurora/client/cli/options.py 0aaf8801950b18be2f00fb1a1f9d8a5a853a1c42 src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d src/test/python/apache/aurora/client/cli/BUILD 97b074488c569c1c92e2bfd69f09ffbd3a827d49 src/test/python/apache/aurora/client/cli/test_kill.py 66d729dc0cdff71a8f8496c528d6fb71dbdb5457 src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84 Diff: https://reviews.apache.org/r/17051/diff/ Testing --- Unit tests all pass; new tests added for the new update command. Thanks, Mark Chu-Carroll
Re: Review Request 17051: Add clientv2 implementations of update and list jobs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17051/ --- (Updated Jan. 17, 2014, 3:05 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Changes --- address jonboulle's review comments. Bugs: aurora-53 https://issues.apache.org/jira/browse/aurora-53 Repository: aurora Description --- Add clientv2 implementations of update and list jobs. (This was originally planned to also include cancel_update and restart, but after testing problems led to splitting out AURORA-42, and merges with restart failed, I decided to submit these two, and put the others in a subsequent change.) Diffs (updated) - src/main/python/apache/aurora/client/api/__init__.py 0fdf1f99feb24445735ce3783578d1aa1cb0f933 src/main/python/apache/aurora/client/api/job_monitor.py f444d1edb52e3763310460dd5737e0a63d005157 src/main/python/apache/aurora/client/api/scheduler_client.py fb65aee66c42969a719c5c0a1eb868dbf6b16ac4 src/main/python/apache/aurora/client/cli/context.py be156bb52dd48e8e5a0df3ddfb0aef1a815d538e src/main/python/apache/aurora/client/cli/jobs.py c519e3c1a4dc055ae1a77d29ca5ba2e6464cacf0 src/main/python/apache/aurora/client/cli/options.py 0aaf8801950b18be2f00fb1a1f9d8a5a853a1c42 src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d src/test/python/apache/aurora/client/api/test_job_monitor.py 9327b32c746d0ff3bd58c900d38bd804331937cf src/test/python/apache/aurora/client/cli/BUILD 97b074488c569c1c92e2bfd69f09ffbd3a827d49 src/test/python/apache/aurora/client/cli/test_create.py 2b0c504e439db777067f02a085e833ac42a1ebc0 src/test/python/apache/aurora/client/cli/test_diff.py b8997e2215585631b8a4b3ddccf38dca7c44464c src/test/python/apache/aurora/client/cli/test_kill.py 66d729dc0cdff71a8f8496c528d6fb71dbdb5457 src/test/python/apache/aurora/client/cli/test_status.py f4ca0d0c824cb7d20585f609a2f5f259f36a3ca0 src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84 src/test/python/apache/aurora/client/commands/test_cancel_update.py b1d63cc75f2d6407e3960d6cf254d5fd832f96c5 src/test/python/apache/aurora/client/commands/test_create.py 57a6dc8fe94282db455f37e7918c63ba14c5d737 src/test/python/apache/aurora/client/commands/test_diff.py a0421530b272a6a0bc03d5f4fc23fad4881c756b src/test/python/apache/aurora/client/commands/test_kill.py edca5dc039fe9a8411d9f83bc6e6e8e3360a1084 src/test/python/apache/aurora/client/commands/test_listjobs.py 16973d4281298f89ceb0ec3fb57efaae83933456 src/test/python/apache/aurora/client/commands/test_restart.py 77a24e8143e84b32b47d6018f79f8d949668be35 src/test/python/apache/aurora/client/commands/test_run.py 0a6aaf8c951e6bdb4dddcda4d1bb0589276238ef src/test/python/apache/aurora/client/commands/test_ssh.py 64dc896a6fbee8c4fe282c61aa1d8b4f236676fd src/test/python/apache/aurora/client/commands/test_status.py 9241631a8f35c82b0d0940c69569431b6c8a43da src/test/python/apache/aurora/client/commands/test_update.py de6039be73edec030890cb8ebca9c99b28acb4fc src/test/python/apache/aurora/client/commands/util.py 22694a29d277b3693a429793a0fc7c0ca2552260 Diff: https://reviews.apache.org/r/17051/diff/ Testing --- Unit tests all pass; new tests added for the new update command. Thanks, Mark Chu-Carroll
Re: Review Request 17051: Add clientv2 implementations of update and list jobs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17051/#review32377 --- ping? - Mark Chu-Carroll On Jan. 17, 2014, 3:05 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17051/ --- (Updated Jan. 17, 2014, 3:05 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Bugs: aurora-53 https://issues.apache.org/jira/browse/aurora-53 Repository: aurora Description --- Add clientv2 implementations of update and list jobs. (This was originally planned to also include cancel_update and restart, but after testing problems led to splitting out AURORA-42, and merges with restart failed, I decided to submit these two, and put the others in a subsequent change.) Diffs - src/main/python/apache/aurora/client/api/__init__.py 0fdf1f99feb24445735ce3783578d1aa1cb0f933 src/main/python/apache/aurora/client/api/job_monitor.py f444d1edb52e3763310460dd5737e0a63d005157 src/main/python/apache/aurora/client/api/scheduler_client.py fb65aee66c42969a719c5c0a1eb868dbf6b16ac4 src/main/python/apache/aurora/client/cli/context.py be156bb52dd48e8e5a0df3ddfb0aef1a815d538e src/main/python/apache/aurora/client/cli/jobs.py c519e3c1a4dc055ae1a77d29ca5ba2e6464cacf0 src/main/python/apache/aurora/client/cli/options.py 0aaf8801950b18be2f00fb1a1f9d8a5a853a1c42 src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d src/test/python/apache/aurora/client/api/test_job_monitor.py 9327b32c746d0ff3bd58c900d38bd804331937cf src/test/python/apache/aurora/client/cli/BUILD 97b074488c569c1c92e2bfd69f09ffbd3a827d49 src/test/python/apache/aurora/client/cli/test_create.py 2b0c504e439db777067f02a085e833ac42a1ebc0 src/test/python/apache/aurora/client/cli/test_diff.py b8997e2215585631b8a4b3ddccf38dca7c44464c src/test/python/apache/aurora/client/cli/test_kill.py 66d729dc0cdff71a8f8496c528d6fb71dbdb5457 src/test/python/apache/aurora/client/cli/test_status.py f4ca0d0c824cb7d20585f609a2f5f259f36a3ca0 src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84 src/test/python/apache/aurora/client/commands/test_cancel_update.py b1d63cc75f2d6407e3960d6cf254d5fd832f96c5 src/test/python/apache/aurora/client/commands/test_create.py 57a6dc8fe94282db455f37e7918c63ba14c5d737 src/test/python/apache/aurora/client/commands/test_diff.py a0421530b272a6a0bc03d5f4fc23fad4881c756b src/test/python/apache/aurora/client/commands/test_kill.py edca5dc039fe9a8411d9f83bc6e6e8e3360a1084 src/test/python/apache/aurora/client/commands/test_listjobs.py 16973d4281298f89ceb0ec3fb57efaae83933456 src/test/python/apache/aurora/client/commands/test_restart.py 77a24e8143e84b32b47d6018f79f8d949668be35 src/test/python/apache/aurora/client/commands/test_run.py 0a6aaf8c951e6bdb4dddcda4d1bb0589276238ef src/test/python/apache/aurora/client/commands/test_ssh.py 64dc896a6fbee8c4fe282c61aa1d8b4f236676fd src/test/python/apache/aurora/client/commands/test_status.py 9241631a8f35c82b0d0940c69569431b6c8a43da src/test/python/apache/aurora/client/commands/test_update.py de6039be73edec030890cb8ebca9c99b28acb4fc src/test/python/apache/aurora/client/commands/util.py 22694a29d277b3693a429793a0fc7c0ca2552260 Diff: https://reviews.apache.org/r/17051/diff/ Testing --- Unit tests all pass; new tests added for the new update command. Thanks, Mark Chu-Carroll
Re: Review Request 17153: Implement restart command for client v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17153/ --- (Updated Jan. 21, 2014, 5:03 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Changes --- Updated link to jira. Bugs: aurora-54 https://issues.apache.org/jira/browse/aurora-54 Repository: aurora Description --- Implement restart command for client v2. Diffs - src/main/python/apache/aurora/client/cli/context.py 78e54a2233b825ab057a1fb2397c91b50ad1aec0 src/main/python/apache/aurora/client/cli/jobs.py f60d7e9fa5367f43829957e3485e43e76c84bf48 src/main/python/apache/aurora/client/cli/options.py 1b7155409505b46451df072edd196dd7e4c88f1c src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_restart.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION Diff: https://reviews.apache.org/r/17153/diff/ Testing --- [sun-wukong aurora (restart)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) == test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 23 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_restart.py ... === 23 passed in 1.39 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS [sun-wukong aurora (restart)]$ Thanks, Mark Chu-Carroll
Re: Review Request 17153: Implement restart command for client v2.
On Jan. 21, 2014, 9:16 p.m., Jonathan Boulle wrote: Mark - want to put some time in my calendar tomorrow to sit down together and go through all the outstanding reviews to get them merged? The patches are in a bit of a confusing state, every time I look at a review it seems like it's reverting something inadvertently :-( I've been trying, as much as possible, to make the changes independent, against master, to make them easier to review. (Past experience with trying to pile changes with dependency relationships has taught me that I'm not good at keeping the dependency relations in my head!) So I'd suggest not to worry too much about seeming regressions; these changes were sent for review before other changes were pushed to master. If I were in SF, getting together to merge into one big change would work, but I've never had a good experience doing that over skype. Just too hard to coordinate! I'm happy to push all of these into one big change on my own if Brian (the other reviewer) agrees that would make it easier. - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17153/#review32454 --- On Jan. 21, 2014, 5:03 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17153/ --- (Updated Jan. 21, 2014, 5:03 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Bugs: aurora-54 https://issues.apache.org/jira/browse/aurora-54 Repository: aurora Description --- Implement restart command for client v2. Diffs - src/main/python/apache/aurora/client/cli/context.py 78e54a2233b825ab057a1fb2397c91b50ad1aec0 src/main/python/apache/aurora/client/cli/jobs.py f60d7e9fa5367f43829957e3485e43e76c84bf48 src/main/python/apache/aurora/client/cli/options.py 1b7155409505b46451df072edd196dd7e4c88f1c src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_restart.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION Diff: https://reviews.apache.org/r/17153/diff/ Testing --- [sun-wukong aurora (restart)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) == test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 23 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_restart.py ... === 23 passed in 1.39 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS [sun-wukong aurora (restart)]$ Thanks, Mark Chu-Carroll
Re: Review Request 17153: Implement restart command for client v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17153/#review32493 --- Superseded by https://reviews.apache.org/r/17184/ - Mark Chu-Carroll On Jan. 21, 2014, 5:03 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17153/ --- (Updated Jan. 21, 2014, 5:03 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Bugs: aurora-54 https://issues.apache.org/jira/browse/aurora-54 Repository: aurora Description --- Implement restart command for client v2. Diffs - src/main/python/apache/aurora/client/cli/context.py 78e54a2233b825ab057a1fb2397c91b50ad1aec0 src/main/python/apache/aurora/client/cli/jobs.py f60d7e9fa5367f43829957e3485e43e76c84bf48 src/main/python/apache/aurora/client/cli/options.py 1b7155409505b46451df072edd196dd7e4c88f1c src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_restart.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION Diff: https://reviews.apache.org/r/17153/diff/ Testing --- [sun-wukong aurora (restart)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) == test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 23 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_restart.py ... === 23 passed in 1.39 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS [sun-wukong aurora (restart)]$ Thanks, Mark Chu-Carroll
Review Request 17185: Merged all of the open clientv2 reviews into one unified change.
src.test.python.apache.aurora.config.test_loader . SUCCESS src.test.python.apache.aurora.config.test_thrift . SUCCESS src.test.python.apache.aurora.executor.common.directory_sandbox . SUCCESS src.test.python.apache.aurora.executor.common.health_checker . SUCCESS src.test.python.apache.aurora.executor.common.status_checker . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_detector . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS Thanks, Mark Chu-Carroll
Review Request 17332: Add a noun supporting operations on roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-107 https://issues.apache.org/jira/browse/aurora-107 Repository: aurora Description --- Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Diffs - src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/options.py 1b7155409505b46451df072edd196dd7e4c88f1c src/main/python/apache/aurora/client/cli/role.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_get_quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 76f954377c154d2a7ab3292a2d772b0566ea06fa Diff: https://reviews.apache.org/r/17332/diff/ Testing --- [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17332: Add a noun supporting operations on roles
Interesting idea... I just thought of quota as being a natural property of the role. Are there are quota verbs that would make sense? Maybe an automated quota request could be a verb? On Fri, Jan 24, 2014 at 5:35 PM, Kevin Sweeney kevi...@apache.org wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ Why is this happening on a role noun and not a quota noun. i.e. aurora quota get west/ksweeney v.s. aurora role get_quota west/ksweeney The second looks inconsistent with the noun-verb model to me and if we ever decide that a quota could be set at a lower level the first is more extensible aurora quota get west/ksweeney/prod aurora quota get west/ksweeney/prod/appserver - Kevin Sweeney On January 24th, 2014, 2:07 p.m. PST, Mark Chu-Carroll wrote: Review request for Aurora, Kevin Sweeney and Brian Wickman. By Mark Chu-Carroll. *Updated Jan. 24, 2014, 2:07 p.m.* *Bugs: * aurora-107 https://issues.apache.org/jira/browse/aurora-107 *Repository: * aurora Description Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Testing [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Diffs - src/main/python/apache/aurora/client/cli/BUILD (8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1) - src/main/python/apache/aurora/client/cli/__init__.py (20ecbcf5d3a868f91922244162b516a66d24d32b) - src/main/python/apache/aurora/client/cli/options.py (1b7155409505b46451df072edd196dd7e4c88f1c) - src/main/python/apache/aurora/client/cli/role.py (PRE-CREATION) - src/test/python/apache/aurora/client/cli/BUILD (f9ebe0cf626a040aa67654faea07b8902e558282) - src/test/python/apache/aurora/client/cli/test_get_quota.py (PRE-CREATION) - src/test/python/apache/aurora/client/cli/util.py (76f954377c154d2a7ab3292a2d772b0566ea06fa) View Diff https://reviews.apache.org/r/17332/diff/
Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.
src.test.python.apache.aurora.config.test_constraint_parsing . SUCCESS src.test.python.apache.aurora.config.test_loader . SUCCESS src.test.python.apache.aurora.config.test_thrift . SUCCESS src.test.python.apache.aurora.executor.common.directory_sandbox . SUCCESS src.test.python.apache.aurora.executor.common.health_checker . SUCCESS src.test.python.apache.aurora.executor.common.status_checker . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_detector . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.
On Jan. 25, 2014, 6:54 p.m., Jonathan Boulle wrote: src/main/python/apache/aurora/client/cli/jobs.py, line 378 https://reviews.apache.org/r/17185/diff/1/?file=435145#file435145line378 1sp Sorry, don't know what you mean by this. It's a line continuation, so it's indented 4; and I don't see any other extra space. - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17185/#review32577 --- On Jan. 27, 2014, 1:21 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17185/ --- (Updated Jan. 27, 2014, 1:21 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Bugs: aurora-53 and aurora-54 https://issues.apache.org/jira/browse/aurora-53 https://issues.apache.org/jira/browse/aurora-54 Repository: aurora Description --- Merged all of the open clientv2 reviews into one unified change. - Add clientv2 implementation of job status with jobkey wildcard support. - Add clientv2 implementations of job update and job list - Add clientv2 implementation of job restart - Add clientv2 implementation of job cancel_update - Extract more common options into options.py. - General code cleanup. This supersedes the following reviews: - https://reviews.apache.org/r/17153/ - https://reviews.apache.org/r/17051/ - https://reviews.apache.org/r/17154/ - https://reviews.apache.org/r/16306/ Diffs - src/main/python/apache/aurora/client/cli/context.py 78e54a2233b825ab057a1fb2397c91b50ad1aec0 src/main/python/apache/aurora/client/cli/jobs.py f60d7e9fa5367f43829957e3485e43e76c84bf48 src/main/python/apache/aurora/client/cli/options.py 1b7155409505b46451df072edd196dd7e4c88f1c src/main/python/apache/aurora/client/commands/core.py 13657c4827072c4f67e0b05034e575616f02338b src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_cancel_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_restart.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 76f954377c154d2a7ab3292a2d772b0566ea06fa Diff: https://reviews.apache.org/r/17185/diff/ Testing --- = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 3 items src/test/python/apache/aurora/admin/test_mesos_maintenance.py ... === 3 passed in 0.29 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.30 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.40 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.25 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . === 1 passed in 0.22 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. === 6 passed in 0.21 seconds === = test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py
Re: Review Request 17270: Bridge framework for client v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review32992 --- src/main/python/apache/aurora/client/cli/__init__.py https://reviews.apache.org/r/17270/#comment62125 I'll add a note about this to the code, but it's also worth explaining here. It's not intended to be truly lazy registration; it's explicit registration, but giving things a chance to initialize before they're registered. The idea is that a command-line object could peek at its environment, and decide whether or not a noun is appropriate. For example, you could have specific commands in the command-line tool for checking AWS quotas - but you don't even want those to be registered if the clusters file doesn't declare and AWS clusters. - Mark Chu-Carroll On Jan. 23, 2014, 6:10 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/ --- (Updated Jan. 23, 2014, 6:10 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-76 https://issues.apache.org/jira/browse/aurora-76 Repository: aurora Description --- Bridge framework for client v2. Diffs - src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION src/main/python/apache/aurora/client/cli/client.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_diff.py 32433c17322e52c4ffb005bcc620fba56e728879 src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 Diff: https://reviews.apache.org/r/17270/diff/ Testing --- [sun-wukong incubator-aurora (bridge)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. = 2 passed in 0.31 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. = 6 passed in 0.41 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. = 6 passed in 0.28 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . = 1 passed in 0.23 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. = 6 passed in 0.22 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... === 47 passed, 1 skipped in 0.60 seconds test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python
Re: Review Request 17270: Bridge framework for client v2.
-2.5.1 collected 17 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... = 17 passed in 0.66 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py = 4 passed in 0.08 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 24 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py ... src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... = 24 passed in 1.31 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . = 1 passed in 0.36 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . = 1 passed in 0.30 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 12 items src/test/python/apache/aurora/client/hooks/test_hooked_api.py = 12 passed in 0.23 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py = 4 passed in 0.23 seconds == src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS [sun-wukong incubator-aurora (bridge)]$ V1 COMMAND: [sun-wukong incubator-aurora (bridge)]$ ./dist/client.pex version Aurora client build info: sha: 18afec3ae3a5d896f69984784a1dbc6e0e743e44 date: Thursday Jan 23, 2014 Aurora API version: APIVersion(major=3) V2 COMMAND: [sun-wukong incubator-aurora (bridge)]$ ./dist/client.pex job status usage: client.pex job status [-h] [--json] jobspec client.pex job status: error: too few arguments Thanks, Mark Chu-Carroll
Review Request 17457: Initial version of an end-to-end test using vagrant
/vagrant/test/flask_example INFO] Response from scheduler: OK (message: Tasks killed.) INFO] Job url: http://precise64:8081/scheduler/vagrant/test/flask_example *** OK (all tests passed) *** [sun-wukong incubator-aurora (e2e)]$ Thanks, Mark Chu-Carroll
Re: Review Request 17457: Initial version of an end-to-end test using vagrant
/test/flask_example) INFO] Job url: http://precise64:8081/scheduler/vagrant/test/flask_example == Updating test job INFO] Updating job: flask_example INFO] Starting job update. INFO] Examining instances: [0] INFO] Killing instances: [0] INFO] Instances killed INFO] Adding instances: [0] INFO] Instances added INFO] Watching instances: [0] INFO] Detected RUNNING instance 0 INFO] Instance 0 has been up and healthy for at least 30 seconds INFO] Update successful INFO] Response from scheduler: OK (message: Lock has been released.) INFO] Killing tasks for job: example/vagrant/test/flask_example INFO] Response from scheduler: OK (message: Tasks killed.) INFO] Job url: http://precise64:8081/scheduler/vagrant/test/flask_example *** OK (all tests passed) *** [sun-wukong incubator-aurora (e2e)]$ Thanks, Mark Chu-Carroll
Re: Review Request 17270: Bridge framework for client v2.
collected 17 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... = 17 passed in 0.66 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py = 4 passed in 0.08 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 24 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py ... src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... = 24 passed in 1.31 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . = 1 passed in 0.36 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . = 1 passed in 0.30 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 12 items src/test/python/apache/aurora/client/hooks/test_hooked_api.py = 12 passed in 0.23 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py = 4 passed in 0.23 seconds == src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS [sun-wukong incubator-aurora (bridge)]$ V1 COMMAND: [sun-wukong incubator-aurora (bridge)]$ ./dist/client.pex version Aurora client build info: sha: 18afec3ae3a5d896f69984784a1dbc6e0e743e44 date: Thursday Jan 23, 2014 Aurora API version: APIVersion(major=3) V2 COMMAND: [sun-wukong incubator-aurora (bridge)]$ ./dist/client.pex job status usage: client.pex job status [-h] [--json] jobspec client.pex job status: error: too few arguments Thanks, Mark Chu-Carroll
Re: Review Request 17457: Initial version of an end-to-end test using vagrant
://precise64:8081/scheduler/vagrant/test/flask_example == Updating test job INFO] Updating job: flask_example INFO] Starting job update. INFO] Examining instances: [0] INFO] Killing instances: [0] INFO] Instances killed INFO] Adding instances: [0] INFO] Instances added INFO] Watching instances: [0] INFO] Detected RUNNING instance 0 INFO] Instance 0 has been up and healthy for at least 30 seconds INFO] Update successful INFO] Response from scheduler: OK (message: Lock has been released.) INFO] Killing tasks for job: example/vagrant/test/flask_example INFO] Response from scheduler: OK (message: Tasks killed.) INFO] Job url: http://precise64:8081/scheduler/vagrant/test/flask_example *** OK (all tests passed) *** [sun-wukong incubator-aurora (e2e)]$ Thanks, Mark Chu-Carroll
Re: Review Request 17332: Add a noun supporting operations on roles
On Jan. 24, 2014, 5:35 p.m., Kevin Sweeney wrote: Why is this happening on a role noun and not a quota noun. i.e. aurora quota get west/ksweeney v.s. aurora role get_quota west/ksweeney The second looks inconsistent with the noun-verb model to me and if we ever decide that a quota could be set at a lower level the first is more extensible aurora quota get west/ksweeney/prod aurora quota get west/ksweeney/prod/appserver I've been thinking about this, debating it in my own head, and I just can't agree. Quota isn't a standalone entity; A quota is an attribute of a role. It doesn't make sense to me to have it be a standalone noun. In terms of syntax, in noun/verb commands, the first parameter is almost always a value of the noun type. (For example, inn job create, the first parameter is a job identifier.) For quota, there is no such thing as a quota identifier or a quota object. You specify the role who's quota you're interested in. Even in the extended scenarios you're talking about, I don't think it makes sense. The quota for west/ksweeney/prod is ksweeney's quota in the prod environment. - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/#review32757 --- On Jan. 24, 2014, 5:07 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Jan. 24, 2014, 5:07 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-107 https://issues.apache.org/jira/browse/aurora-107 Repository: aurora Description --- Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Diffs - src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/options.py 1b7155409505b46451df072edd196dd7e4c88f1c src/main/python/apache/aurora/client/cli/role.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_get_quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 76f954377c154d2a7ab3292a2d772b0566ea06fa Diff: https://reviews.apache.org/r/17332/diff/ Testing --- [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Review Request 17614: Fix whitespace glitches I missed in review.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17614/ --- Review request for Aurora and Jake Farrell. Repository: aurora Description --- Fix whitespace glitches. Diffs - src/main/python/apache/aurora/client/commands/admin.py d8b9a44a02cd9e8873a97e9107a7b18e3c97b66b Diff: https://reviews.apache.org/r/17614/diff/ Testing --- Thanks, Mark Chu-Carroll
Re: Review Request 17457: Initial version of an end-to-end test using vagrant
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33359 --- ping? - Mark Chu-Carroll On Jan. 30, 2014, 4:09 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/ --- (Updated Jan. 30, 2014, 4:09 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-125 and aurora-80 https://issues.apache.org/jira/browse/aurora-125 https://issues.apache.org/jira/browse/aurora-80 Repository: aurora Description --- Got an initial version of the end-to-end test working. Currently creates a job, probes it via the scheduler pages, updates it, and kills it. AURORA-127 will extend this to run multiple instances; AURORA-125 will extend this to use aurora run and aurora ssh to probe the running tasks. Diffs - 3rdparty/python/BUILD 735a0631f2a6e5ae14ab6417fc5f6fac381a2742 Vagrantfile 98dcf439aed53da5e78440de04562baf63c7272f examples/vagrant/provision-aurora-scheduler.sh f96c2e79305aab882af9c2f8219b723fe8aab0eb examples/vagrant/provision-dev-environment.sh d8cc1fe9333cd607b0373d9cc49b3a71c683edcc examples/vagrant/provision-mesos-slave.sh 5170b4076fc6e4424914493208c779f4494ed097 src/test/sh/org/apache/aurora/e2e/flask/BUILD PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example.py PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_common.sh PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh PRE-CREATION Diff: https://reviews.apache.org/r/17457/diff/ Testing --- [sun-wukong incubator-aurora (e2e)]$ sh src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Bringing machine 'devtools' up with 'virtualbox' provider... Bringing machine 'zookeeper' up with 'virtualbox' provider... Bringing machine 'mesos-master' up with 'virtualbox' provider... Bringing machine 'mesos-slave' up with 'virtualbox' provider... Bringing machine 'aurora-scheduler' up with 'virtualbox' provider... [devtools] VirtualBox VM is already running. [zookeeper] VirtualBox VM is already running. [mesos-master] VirtualBox VM is already running. [mesos-slave] VirtualBox VM is already running. [aurora-scheduler] VirtualBox VM is already running. Cloning into '/home/vagrant/test_dev'... done. Already on 'e2e' Already up-to-date. + VIRTUALENV_VERSION=1.10.1 + which python2.7 ++ which python2.7 + PY=/usr/bin/python2.7 + echo 'Using /usr/bin/python2.7' Using /usr/bin/python2.7 + '[' -f build-support/virtualenv-1.10.1/BOOTSTRAPPED ']' + pushd build-support ~/test_dev/build-support ~/test_dev + curl -O https://pypi.python.org/packages/source/v/virtualenv/virtualenv-1.10.1.tar.gz % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 1294k 100 1294k0 0 3261k 0 --:--:-- --:--:-- --:--:-- 3817k + tar zxvf virtualenv-1.10.1.tar.gz virtualenv-1.10.1/ virtualenv-1.10.1/AUTHORS.txt virtualenv-1.10.1/bin/ virtualenv-1.10.1/bin/rebuild-script.py virtualenv-1.10.1/docs/ virtualenv-1.10.1/docs/_theme/ virtualenv-1.10.1/docs/_theme/nature/ virtualenv-1.10.1/docs/_theme/nature/static/ virtualenv-1.10.1/docs/_theme/nature/static/nature.css_t virtualenv-1.10.1/docs/_theme/nature/static/pygments.css virtualenv-1.10.1/docs/_theme/nature/theme.conf virtualenv-1.10.1/docs/conf.py virtualenv-1.10.1/docs/index.rst virtualenv-1.10.1/docs/make.bat virtualenv-1.10.1/docs/Makefile virtualenv-1.10.1/docs/news.rst virtualenv-1.10.1/LICENSE.txt virtualenv-1.10.1/MANIFEST.in virtualenv-1.10.1/PKG-INFO virtualenv-1.10.1/README.rst virtualenv-1.10.1/scripts/ virtualenv-1.10.1/scripts/virtualenv virtualenv-1.10.1/setup.cfg virtualenv-1.10.1/setup.py virtualenv-1.10.1/virtualenv.egg-info/ virtualenv-1.10.1/virtualenv.egg-info/dependency_links.txt virtualenv-1.10.1/virtualenv.egg-info/entry_points.txt virtualenv-1.10.1/virtualenv.egg-info/not-zip-safe virtualenv-1.10.1/virtualenv.egg-info/PKG-INFO virtualenv-1.10.1/virtualenv.egg-info/SOURCES.txt virtualenv-1.10.1/virtualenv.egg-info/top_level.txt virtualenv-1.10.1/virtualenv.py virtualenv-1.10.1/virtualenv_embedded/ virtualenv-1.10.1/virtualenv_embedded/activate.bat virtualenv-1.10.1/virtualenv_embedded/activate.csh virtualenv-1.10.1/virtualenv_embedded/activate.fish virtualenv-1.10.1/virtualenv_embedded/activate.ps1 virtualenv-1.10.1/virtualenv_embedded/activate.sh virtualenv
Re: Review Request 17270: Bridge framework for client v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33360 --- ping? - Mark Chu-Carroll On Jan. 30, 2014, 4:03 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/ --- (Updated Jan. 30, 2014, 4:03 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-76 https://issues.apache.org/jira/browse/aurora-76 Repository: aurora Description --- Bridge framework for client v2. Diffs - src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION src/main/python/apache/aurora/client/cli/client.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_diff.py 32433c17322e52c4ffb005bcc620fba56e728879 src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 Diff: https://reviews.apache.org/r/17270/diff/ Testing --- [sun-wukong incubator-aurora (bridge)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. = 2 passed in 0.31 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. = 6 passed in 0.41 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. = 6 passed in 0.28 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . = 1 passed in 0.23 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. = 6 passed in 0.22 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... === 47 passed, 1 skipped in 0.60 seconds test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py = 20 passed in 0.25 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 26 items src/test/python/apache/aurora/client/api/test_updater.py .. = 26 passed in 0.44 seconds = test session starts
Re: Review Request 17457: Initial version of an end-to-end test using vagrant
) INFO] Job url: http://precise64:8081/scheduler/vagrant/test/flask_example == Updating test job INFO] Updating job: flask_example INFO] Starting job update. INFO] Examining instances: [0] INFO] Killing instances: [0] INFO] Instances killed INFO] Adding instances: [0] INFO] Instances added INFO] Watching instances: [0] INFO] Detected RUNNING instance 0 INFO] Instance 0 has been up and healthy for at least 30 seconds INFO] Update successful INFO] Response from scheduler: OK (message: Lock has been released.) INFO] Killing tasks for job: example/vagrant/test/flask_example INFO] Response from scheduler: OK (message: Tasks killed.) INFO] Job url: http://precise64:8081/scheduler/vagrant/test/flask_example *** OK (all tests passed) *** [sun-wukong incubator-aurora (e2e)]$ Thanks, Mark Chu-Carroll
Re: Review Request 17637: AURORA-88: get_quota -h lists --cluster as deprecated
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17637/#review33435 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 3, 2014, 10:58 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17637/ --- (Updated Feb. 3, 2014, 10:58 a.m.) Review request for Aurora, Mark Chu-Carroll and Maxim Khutornenko. Bugs: aurora-88 https://issues.apache.org/jira/browse/aurora-88 Repository: aurora Description --- AURORA-88: get_quota -h lists --cluster as deprecated Replaces CLUSTER_INVOKE_OPTION with a new CLUSTER_NAME_OPTION so that get_quota -h shows the correct help dialog. Diffs - src/main/python/apache/aurora/client/commands/core.py 8dc4917df7e0d699ee144b4e8fbede6ac05157c2 src/main/python/apache/aurora/client/options.py 4e53b0765375989bb80ffd02e0ef2b08af1eea50 Diff: https://reviews.apache.org/r/17637/diff/ Testing --- Tests pass locally and running aurora_client.pex get_quota -h shows the updated text for the --cluster option. Thanks, Dan Norris
Re: Review Request 17457: Initial version of an end-to-end test using vagrant
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33476 --- examples/vagrant/provision-dev-environment.sh https://reviews.apache.org/r/17457/#comment62917 Because in the vmware precise64 image, git and python-setuptools aren't included. With these added to the list, the test works on both vmware and virtualbox. - Mark Chu-Carroll On Feb. 3, 2014, 11:30 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/ --- (Updated Feb. 3, 2014, 11:30 a.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-125 and aurora-80 https://issues.apache.org/jira/browse/aurora-125 https://issues.apache.org/jira/browse/aurora-80 Repository: aurora Description --- Got an initial version of the end-to-end test working. Currently creates a job, probes it via the scheduler pages, updates it, and kills it. AURORA-127 will extend this to run multiple instances; AURORA-125 will extend this to use aurora run and aurora ssh to probe the running tasks. Diffs - 3rdparty/python/BUILD cc3e8c929e7b2b614a6ea3dbbb4e70d2f8d22586 Vagrantfile 98dcf439aed53da5e78440de04562baf63c7272f examples/vagrant/provision-aurora-scheduler.sh e48291a8673aeb169747486b7d50a54f5a56 examples/vagrant/provision-dev-environment.sh 7fc11bf523a054f6d068cf676e87bb043d854a25 examples/vagrant/provision-mesos-slave.sh c2548a268e0fad7aa4f84d3fa48aea012007502b src/test/sh/org/apache/aurora/e2e/flask/BUILD PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example.py PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_common.sh PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh PRE-CREATION Diff: https://reviews.apache.org/r/17457/diff/ Testing --- [sun-wukong incubator-aurora (e2e)]$ sh src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Bringing machine 'devtools' up with 'virtualbox' provider... Bringing machine 'zookeeper' up with 'virtualbox' provider... Bringing machine 'mesos-master' up with 'virtualbox' provider... Bringing machine 'mesos-slave' up with 'virtualbox' provider... Bringing machine 'aurora-scheduler' up with 'virtualbox' provider... [devtools] VirtualBox VM is already running. [zookeeper] VirtualBox VM is already running. [mesos-master] VirtualBox VM is already running. [mesos-slave] VirtualBox VM is already running. [aurora-scheduler] VirtualBox VM is already running. Cloning into '/home/vagrant/test_dev'... done. Already on 'e2e' Already up-to-date. + VIRTUALENV_VERSION=1.10.1 + which python2.7 ++ which python2.7 + PY=/usr/bin/python2.7 + echo 'Using /usr/bin/python2.7' Using /usr/bin/python2.7 + '[' -f build-support/virtualenv-1.10.1/BOOTSTRAPPED ']' + pushd build-support ~/test_dev/build-support ~/test_dev + curl -O https://pypi.python.org/packages/source/v/virtualenv/virtualenv-1.10.1.tar.gz % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 1294k 100 1294k0 0 3261k 0 --:--:-- --:--:-- --:--:-- 3817k + tar zxvf virtualenv-1.10.1.tar.gz virtualenv-1.10.1/ virtualenv-1.10.1/AUTHORS.txt virtualenv-1.10.1/bin/ virtualenv-1.10.1/bin/rebuild-script.py virtualenv-1.10.1/docs/ virtualenv-1.10.1/docs/_theme/ virtualenv-1.10.1/docs/_theme/nature/ virtualenv-1.10.1/docs/_theme/nature/static/ virtualenv-1.10.1/docs/_theme/nature/static/nature.css_t virtualenv-1.10.1/docs/_theme/nature/static/pygments.css virtualenv-1.10.1/docs/_theme/nature/theme.conf virtualenv-1.10.1/docs/conf.py virtualenv-1.10.1/docs/index.rst virtualenv-1.10.1/docs/make.bat virtualenv-1.10.1/docs/Makefile virtualenv-1.10.1/docs/news.rst virtualenv-1.10.1/LICENSE.txt virtualenv-1.10.1/MANIFEST.in virtualenv-1.10.1/PKG-INFO virtualenv-1.10.1/README.rst virtualenv-1.10.1/scripts/ virtualenv-1.10.1/scripts/virtualenv virtualenv-1.10.1/setup.cfg virtualenv-1.10.1/setup.py virtualenv-1.10.1/virtualenv.egg-info/ virtualenv-1.10.1/virtualenv.egg-info/dependency_links.txt virtualenv-1.10.1/virtualenv.egg-info/entry_points.txt virtualenv-1.10.1/virtualenv.egg-info/not-zip-safe virtualenv-1.10.1/virtualenv.egg-info/PKG-INFO virtualenv-1.10.1/virtualenv.egg-info/SOURCES.txt virtualenv-1.10.1/virtualenv.egg-info/top_level.txt virtualenv-1.10.1/virtualenv.py virtualenv-1.10.1/virtualenv_embedded/ virtualenv
Re: Review Request 17457: Initial version of an end-to-end test using vagrant
: http://precise64:8081/scheduler/vagrant/test/flask_example == Updating test job INFO] Updating job: flask_example INFO] Starting job update. INFO] Examining instances: [0] INFO] Killing instances: [0] INFO] Instances killed INFO] Adding instances: [0] INFO] Instances added INFO] Watching instances: [0] INFO] Detected RUNNING instance 0 INFO] Instance 0 has been up and healthy for at least 30 seconds INFO] Update successful INFO] Response from scheduler: OK (message: Lock has been released.) INFO] Killing tasks for job: example/vagrant/test/flask_example INFO] Response from scheduler: OK (message: Tasks killed.) INFO] Job url: http://precise64:8081/scheduler/vagrant/test/flask_example *** OK (all tests passed) *** [sun-wukong incubator-aurora (e2e)]$ Thanks, Mark Chu-Carroll
Re: Review Request 17457: Initial version of an end-to-end test using vagrant
On Feb. 3, 2014, 4:47 p.m., Kevin Sweeney wrote: examples/vagrant/provision-dev-environment.sh, line 5 https://reviews.apache.org/r/17457/diff/4/?file=463503#file463503line5 git is already on this commandline and setuptools shouldn't be needed. From the virtualbox environment % vagrant ssh devtools Welcome to Ubuntu 12.04 LTS (GNU/Linux 3.2.0-23-generic x86_64) * Documentation: https://help.ubuntu.com/ Welcome to your Vagrant-built virtual machine. Last login: Fri Sep 14 06:23:18 2012 from 10.0.2.2 vagrant@precise64:~$ python Python 2.7.3 (default, Sep 26 2013, 20:03:06) [GCC 4.6.3] on linux2 Type help, copyright, credits or license for more information. import setuptools Traceback (most recent call last): File stdin, line 1, in module ImportError: No module named setuptools vagrant@precise64:~$ dpkg -L python-setuptools Package `python-setuptools' is not installed. Use dpkg --info (= dpkg-deb --info) to examine archive files, and dpkg --contents (= dpkg-deb --contents) to list their contents. I'll fix the double-git. But setuptools is necessary for vmware. In the vmware precise64 image default, pants doesn't work due to missing python packages. With setuptools, pants is able to bootstrap itself. - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33510 --- On Feb. 3, 2014, 3:16 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/ --- (Updated Feb. 3, 2014, 3:16 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-125 and aurora-80 https://issues.apache.org/jira/browse/aurora-125 https://issues.apache.org/jira/browse/aurora-80 Repository: aurora Description --- Got an initial version of the end-to-end test working. Currently creates a job, probes it via the scheduler pages, updates it, and kills it. AURORA-127 will extend this to run multiple instances; AURORA-125 will extend this to use aurora run and aurora ssh to probe the running tasks. Diffs - 3rdparty/python/BUILD cc3e8c929e7b2b614a6ea3dbbb4e70d2f8d22586 Vagrantfile 98dcf439aed53da5e78440de04562baf63c7272f examples/vagrant/provision-aurora-scheduler.sh e48291a8673aeb169747486b7d50a54f5a56 examples/vagrant/provision-dev-environment.sh 7fc11bf523a054f6d068cf676e87bb043d854a25 examples/vagrant/provision-mesos-slave.sh c2548a268e0fad7aa4f84d3fa48aea012007502b src/test/sh/org/apache/aurora/e2e/flask/BUILD PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example.py PRE-CREATION src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_common.sh PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh PRE-CREATION Diff: https://reviews.apache.org/r/17457/diff/ Testing --- [sun-wukong incubator-aurora (e2e)]$ sh src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Bringing machine 'devtools' up with 'virtualbox' provider... Bringing machine 'zookeeper' up with 'virtualbox' provider... Bringing machine 'mesos-master' up with 'virtualbox' provider... Bringing machine 'mesos-slave' up with 'virtualbox' provider... Bringing machine 'aurora-scheduler' up with 'virtualbox' provider... [devtools] VirtualBox VM is already running. [zookeeper] VirtualBox VM is already running. [mesos-master] VirtualBox VM is already running. [mesos-slave] VirtualBox VM is already running. [aurora-scheduler] VirtualBox VM is already running. Cloning into '/home/vagrant/test_dev'... done. Already on 'e2e' Already up-to-date. + VIRTUALENV_VERSION=1.10.1 + which python2.7 ++ which python2.7 + PY=/usr/bin/python2.7 + echo 'Using /usr/bin/python2.7' Using /usr/bin/python2.7 + '[' -f build-support/virtualenv-1.10.1/BOOTSTRAPPED ']' + pushd build-support ~/test_dev/build-support ~/test_dev + curl -O https://pypi.python.org/packages/source/v/virtualenv/virtualenv-1.10.1.tar.gz % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 1294k 100 1294k0 0 3261k 0 --:--:-- --:--:-- --:--:-- 3817k + tar zxvf virtualenv-1.10.1.tar.gz virtualenv-1.10.1/ virtualenv-1.10.1/AUTHORS.txt virtualenv-1.10.1/bin/ virtualenv-1.10.1/bin/rebuild-script.py virtualenv-1.10.1/docs/ virtualenv-1.10.1/docs/_theme/ virtualenv-1.10.1
Re: Review Request 17457: Initial version of an end-to-end test using vagrant
job INFO] Updating job: flask_example INFO] Starting job update. INFO] Examining instances: [0] INFO] Killing instances: [0] INFO] Instances killed INFO] Adding instances: [0] INFO] Instances added INFO] Watching instances: [0] INFO] Detected RUNNING instance 0 INFO] Instance 0 has been up and healthy for at least 30 seconds INFO] Update successful INFO] Response from scheduler: OK (message: Lock has been released.) INFO] Killing tasks for job: example/vagrant/test/flask_example INFO] Response from scheduler: OK (message: Tasks killed.) INFO] Job url: http://precise64:8081/scheduler/vagrant/test/flask_example *** OK (all tests passed) *** [sun-wukong incubator-aurora (e2e)]$ Thanks, Mark Chu-Carroll
Re: Review Request 17332: Add a noun supporting operations on roles
I disagree. To me, the fundamental issue is just what a quota is. Is a quota a primitive basic object which has the role/cluster/environment as an attribute? Or is the role the basic object, and the quota is an attribute of the role? I think that the quota as attribute of a user makes much more sense. Even in the case of things like the quota for a specific environment. I think that the question What is roleA's quota on cluster west in the prod environment? is more natural than What is the quota in the test environment of cluster west for roleA? And so asking aurora role get_quota smf1/mchucarroll/test makes sense, because it's asking about the quota for a user in a particular place. I'm willing to give in if the consensus is against me, but I really think that the role-based quota command makes much more sense. Can others please chip in with their opinions? -Mark On Fri, Jan 31, 2014 at 7:49 PM, Kevin Sweeney kevi...@apache.org wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ On January 24th, 2014, 2:35 p.m. PST, *Kevin Sweeney* wrote: Why is this happening on a role noun and not a quota noun. i.e. aurora quota get west/ksweeney v.s. aurora role get_quota west/ksweeney The second looks inconsistent with the noun-verb model to me and if we ever decide that a quota could be set at a lower level the first is more extensible aurora quota get west/ksweeney/prod aurora quota get west/ksweeney/prod/appserver On January 31st, 2014, 7:37 a.m. PST, *Mark Chu-Carroll* wrote: I've been thinking about this, debating it in my own head, and I just can't agree. Quota isn't a standalone entity; A quota is an attribute of a role. It doesn't make sense to me to have it be a standalone noun. In terms of syntax, in noun/verb commands, the first parameter is almost always a value of the noun type. (For example, inn job create, the first parameter is a job identifier.) For quota, there is no such thing as a quota identifier or a quota object. You specify the role who's quota you're interested in. Even in the extended scenarios you're talking about, I don't think it makes sense. The quota for west/ksweeney/prod is ksweeney's quota in the prod environment. So it seems better to add: aurora role get_quota smf1/ksweeney aurora environment get_quota smf1/ksweeney/prod aurora job get_quota smf1/ksweeney/prod/app I'm not quite convinced, but I recognize I could be wrong. Anybody else want to chime in here? - Kevin On January 24th, 2014, 2:07 p.m. PST, Mark Chu-Carroll wrote: Review request for Aurora, Kevin Sweeney and Brian Wickman. By Mark Chu-Carroll. *Updated Jan. 24, 2014, 2:07 p.m.* *Bugs: * aurora-107 https://issues.apache.org/jira/browse/aurora-107 *Repository: * aurora Description Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Testing [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Diffs - src/main/python/apache/aurora/client/cli/BUILD (8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1) - src/main/python/apache/aurora/client/cli/__init__.py (20ecbcf5d3a868f91922244162b516a66d24d32b) - src/main/python/apache/aurora/client/cli/options.py (1b7155409505b46451df072edd196dd7e4c88f1c) - src/main/python/apache/aurora/client/cli/role.py (PRE-CREATION) - src/test/python/apache/aurora/client/cli/BUILD (f9ebe0cf626a040aa67654faea07b8902e558282) - src/test/python/apache/aurora/client/cli/test_get_quota.py (PRE-CREATION) - src/test/python/apache/aurora/client/cli/util.py (76f954377c154d2a7ab3292a2d772b0566ea06fa) View Diff https://reviews.apache.org/r/17332/diff/
Review Request 17724: Add an exception catch to provide a better error message when distributed command runner fails due to un-specified executor parameters in the slave configurations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17724/ --- Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-128 https://issues.apache.org/jira/browse/aurora-128 Repository: aurora Description --- Add an exception catch to provide a better error message when distributed command runner fails due to un-specified executor parameters in the slave configurations. Diffs - src/main/python/apache/aurora/client/api/command_runner.py c645e9556b50b332cc5a298ceee3d9188a68a727 src/test/python/apache/aurora/client/commands/test_run.py abcc275d57373038227d3805c16b17b967f92048 Diff: https://reviews.apache.org/r/17724/diff/ Testing --- Manual testing on the command line. Thanks, Mark Chu-Carroll
Re: Review Request 17332: Add a noun supporting operations on roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 5, 2014, 10:08 a.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Changes --- I concede on the debate about whether quota or role should be the noun for the get_quota operation! Bugs: aurora-107 https://issues.apache.org/jira/browse/aurora-107 Repository: aurora Description --- Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Diffs (updated) - src/main/python/apache/aurora/client/cli/BUILD 1019e006998b84ff5757778c05ec39881e44d7ba src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/options.py b45af3218e45150a55a4db8d41ae33c320a2c7f6 src/main/python/apache/aurora/client/cli/quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 5ba08ad95964ad609e6611d601c765c5c17dae69 src/test/python/apache/aurora/client/cli/test_quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py cbd544d1e5d0e68bcb94e46e827868e259099d0b Diff: https://reviews.apache.org/r/17332/diff/ Testing --- [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17645: added rollback_on_failure to UpdateConfig
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/#review33723 --- src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/17645/#comment63329 I would prefer for the help to make it clear what adding the parameter would do. If false, prevent update from performing a rollback. - Mark Chu-Carroll On Feb. 3, 2014, 4 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/ --- (Updated Feb. 3, 2014, 4 p.m.) Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian Wickman. Bugs: AURORA-148 https://issues.apache.org/jira/browse/AURORA-148 Repository: aurora Description --- added rollback_on_failure to UpdateConfig Diffs - src/main/python/apache/aurora/client/api/updater.py 61e5737cc3cb4d457348cbc1df1f0fc93143de51 src/main/python/apache/aurora/client/api/updater_util.py 623b0c0ae53d32f0af20c98aa4c9c1ff73720ecb src/main/python/apache/aurora/client/cli/jobs.py caff6d824d9f43cc9eb0c738ea6bb489321d4669 src/main/python/apache/aurora/client/commands/core.py 8dc4917df7e0d699ee144b4e8fbede6ac05157c2 src/main/python/apache/aurora/config/schema/base.py 1d9f3019d2379e25ab311b45f2851de3b60e263a src/test/python/apache/aurora/client/api/test_restarter.py c53824236895d60a61935a0706ad397900aa1148 src/test/python/apache/aurora/client/api/test_updater.py eabb938ead5b3bab067339ae085dbe2fd262d6a7 Diff: https://reviews.apache.org/r/17645/diff/ Testing --- [drobinson@x1 incubator-aurora (drobinson/rollback_on_failure)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. 2 passed in 0.23 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/test_config.py .. 6 passed in 0.29 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. 6 passed in 0.12 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . 1 passed in 0.09 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. 6 passed in 0.11 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... == 47 passed, 1 skipped in 0.44 seconds === === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py 20 passed in 0.13 seconds === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 27 items src/test/python/apache/aurora/client/api/test_updater.py
Re: Review Request 17270: Bridge framework for client v2.
On Feb. 3, 2014, 2:15 p.m., Bill Farner wrote: Ship It! brian, ping? can't ship without shipits from everyone on the People line. - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33471 --- On Jan. 30, 2014, 4:03 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/ --- (Updated Jan. 30, 2014, 4:03 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-76 https://issues.apache.org/jira/browse/aurora-76 Repository: aurora Description --- Bridge framework for client v2. Diffs - src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION src/main/python/apache/aurora/client/cli/client.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_diff.py 32433c17322e52c4ffb005bcc620fba56e728879 src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 Diff: https://reviews.apache.org/r/17270/diff/ Testing --- [sun-wukong incubator-aurora (bridge)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. = 2 passed in 0.31 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. = 6 passed in 0.41 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. = 6 passed in 0.28 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . = 1 passed in 0.23 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. = 6 passed in 0.22 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... === 47 passed, 1 skipped in 0.60 seconds test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py = 20 passed in 0.25 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 26 items src/test/python/apache/aurora/client/api/test_updater.py .. = 26 passed in 0.44 seconds
Re: Review Request 17332: Add a noun supporting operations on roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/#review33814 --- src/main/python/apache/aurora/client/cli/role.py https://reviews.apache.org/r/17332/#comment63426 Yes, this entire file was meant to be removed. I git mv'ed it to create quota.py and it's not in my branch. I'm not sure what to do to fix the review - rbt doesn't see any diff, because the file's already gone. - Mark Chu-Carroll On Feb. 5, 2014, 10:08 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 5, 2014, 10:08 a.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-107 https://issues.apache.org/jira/browse/aurora-107 Repository: aurora Description --- Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Diffs - src/main/python/apache/aurora/client/cli/BUILD 1019e006998b84ff5757778c05ec39881e44d7ba src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/options.py b45af3218e45150a55a4db8d41ae33c320a2c7f6 src/main/python/apache/aurora/client/cli/quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 5ba08ad95964ad609e6611d601c765c5c17dae69 src/test/python/apache/aurora/client/cli/test_quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py cbd544d1e5d0e68bcb94e46e827868e259099d0b Diff: https://reviews.apache.org/r/17332/diff/ Testing --- [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17332: Add a noun supporting operations on roles
On Feb. 6, 2014, 1:36 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/role.py, line 44 https://reviews.apache.org/r/17332/diff/1/?file=450590#file450590line44 Yes, this entire file was meant to be removed. I git mv'ed it to create quota.py and it's not in my branch. I'm not sure what to do to fix the review - rbt doesn't see any diff, because the file's already gone. Mark Chu-Carroll wrote: Check with rbt diff, and it does *not* include role.py. So this is just a UI glitch in RBT. Jonathan Boulle wrote: Same story with test_get_quota.py? Yup. Given that the UI is screwed up, maybe look at the diff using rbt diff on the command line? - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/#review33814 --- On Feb. 5, 2014, 10:08 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 5, 2014, 10:08 a.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-107 https://issues.apache.org/jira/browse/aurora-107 Repository: aurora Description --- Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Diffs - src/main/python/apache/aurora/client/cli/BUILD 1019e006998b84ff5757778c05ec39881e44d7ba src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/options.py b45af3218e45150a55a4db8d41ae33c320a2c7f6 src/main/python/apache/aurora/client/cli/quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 5ba08ad95964ad609e6611d601c765c5c17dae69 src/test/python/apache/aurora/client/cli/test_quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py cbd544d1e5d0e68bcb94e46e827868e259099d0b Diff: https://reviews.apache.org/r/17332/diff/ Testing --- [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17332: Add a noun supporting operations on roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 6, 2014, 2:19 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Changes --- re-uploading changes to try to unglitch rbt. Bugs: aurora-107 https://issues.apache.org/jira/browse/aurora-107 Repository: aurora Description --- Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Diffs (updated) - src/main/python/apache/aurora/client/cli/BUILD 1019e006998b84ff5757778c05ec39881e44d7ba src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/options.py b45af3218e45150a55a4db8d41ae33c320a2c7f6 src/main/python/apache/aurora/client/cli/quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 5ba08ad95964ad609e6611d601c765c5c17dae69 src/test/python/apache/aurora/client/cli/test_quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py cbd544d1e5d0e68bcb94e46e827868e259099d0b Diff: https://reviews.apache.org/r/17332/diff/ Testing --- [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17332: Add a noun supporting operations on roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 6, 2014, 2:27 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Changes --- address jonboulle's review comments. Bugs: aurora-107 https://issues.apache.org/jira/browse/aurora-107 Repository: aurora Description --- Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Diffs (updated) - src/main/python/apache/aurora/client/cli/BUILD 1019e006998b84ff5757778c05ec39881e44d7ba src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/options.py b45af3218e45150a55a4db8d41ae33c320a2c7f6 src/main/python/apache/aurora/client/cli/quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 5ba08ad95964ad609e6611d601c765c5c17dae69 src/test/python/apache/aurora/client/cli/test_quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py cbd544d1e5d0e68bcb94e46e827868e259099d0b Diff: https://reviews.apache.org/r/17332/diff/ Testing --- [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17724: Add an exception catch to provide a better error message when distributed command runner fails
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17724/ --- (Updated Feb. 6, 2014, 4:40 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Changes --- Better? Bugs: aurora-128 https://issues.apache.org/jira/browse/aurora-128 Repository: aurora Description --- Add an exception catch to provide a better error message when distributed command runner fails due to un-specified executor parameters in the slave configurations. Diffs (updated) - src/main/python/apache/aurora/client/api/command_runner.py f7605f40b5c4ec864a1bae68649f282268260528 src/main/python/apache/aurora/client/commands/run.py 332bded632ee4cfc0a986540239cb4cc296807ea src/main/python/apache/aurora/client/commands/ssh.py d1499ec1e9e910bc32f5f9f4b050c53316348503 src/test/python/apache/aurora/client/commands/test_run.py abcc275d57373038227d3805c16b17b967f92048 Diff: https://reviews.apache.org/r/17724/diff/ Testing --- Manual testing on the command line. Thanks, Mark Chu-Carroll
Re: Review Request 17270: Bridge framework for client v2.
On Feb. 6, 2014, 5:36 p.m., Mark Chu-Carroll wrote:
src/main/python/apache/aurora/client/cli/__init__.py, line 149
https://reviews.apache.org/r/17270/diff/3/?file=456886#file456886line149
That's actually the way that I originally wrote it, and wickman wanted
me to change it to this.
Jonathan Boulle wrote:
Well, not quite - he proposed something like
def register_noun(self, noun):
if self.registered:
raise self.Error('Cannot add new nouns after registration')
which is a different behaviour from what's here, although I don't
understand what he was trying to achieve...
Overall I guess I'm unclear on the exact semantics you're trying to
implement. Should register_nouns only be callable once?
register_nouns should be idempotent; calling it repeatedly is a waste of time,
but it shouldn't harm anything.
The point of the check is to allowed a delayed initialization of the verbs map.
The idea is that I can imagine usecases where a commandline needs to look at
the environment in order to determine whether or not to register a particular
noun. For example, I can imagine a situation where packer is an optional
component of aurora. Then the aurora client starts up, and checks to see if
there's a packer, and if so, it would register the package noun, otherwise it
wouldn't. That kind of test relies on other pieces of the system being
initialized - for example, it could rely on CLUSTERS being properly populated
for the environment, so that it can examine the clusters and see if any of them
have a packer. So I don't want to eagerly run noun registration before other
things have been initialized. So all that this is trying to do is delay the
population of the nouns until they're needed. (That's why I mostly followed
Brian's suggestion, but didn't include the raising of an error, because I don
't care if it gets called more than once; I just care that it doesn't get
called until after other things have been initialized.)
I've tried a change that gets rid of the registered field which I'll upload
shortly; hopefully that's better.
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17270/#review33855
---
On Jan. 30, 2014, 4:03 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17270/
---
(Updated Jan. 30, 2014, 4:03 p.m.)
Review request for Aurora, Bill Farner and Brian Wickman.
Bugs: aurora-76
https://issues.apache.org/jira/browse/aurora-76
Repository: aurora
Description
---
Bridge framework for client v2.
Diffs
-
src/main/python/apache/aurora/client/bin/BUILD
46695b423663c8e970773714c3dcb7de1046a9fb
src/main/python/apache/aurora/client/cli/BUILD
8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1
src/main/python/apache/aurora/client/cli/__init__.py
20ecbcf5d3a868f91922244162b516a66d24d32b
src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION
src/main/python/apache/aurora/client/cli/client.py PRE-CREATION
src/test/python/apache/aurora/client/cli/BUILD
f9ebe0cf626a040aa67654faea07b8902e558282
src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION
src/test/python/apache/aurora/client/cli/test_create.py
64eb51be32f33de7d67962ff9300e64820a37baf
src/test/python/apache/aurora/client/cli/test_diff.py
32433c17322e52c4ffb005bcc620fba56e728879
src/test/python/apache/aurora/client/cli/test_kill.py
714d5fbeebaaba6cede438c40b3b370d0ee99934
src/test/python/apache/aurora/client/cli/test_status.py
efcf164682a56294863a2aec916b9382a50032b7
Diff: https://reviews.apache.org/r/17270/diff/
Testing
---
[sun-wukong incubator-aurora (bridge)]$ ./pants
src/test/python/apache/aurora/client:all
Build operating on targets:
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
test session starts
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 2 items
src/test/python/apache/aurora/client/test_binding_helper.py ..
= 2 passed in 0.31 seconds
==
test session starts
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/test_config.py ..
= 6 passed in 0.41 seconds
==
test session starts
platform darwin
Re: Review Request 17270: Bridge framework for client v2.
. SUCCESS [sun-wukong incubator-aurora (bridge)]$ V1 COMMAND: [sun-wukong incubator-aurora (bridge)]$ ./dist/client.pex version Aurora client build info: sha: 18afec3ae3a5d896f69984784a1dbc6e0e743e44 date: Thursday Jan 23, 2014 Aurora API version: APIVersion(major=3) V2 COMMAND: [sun-wukong incubator-aurora (bridge)]$ ./dist/client.pex job status usage: client.pex job status [-h] [--json] jobspec client.pex job status: error: too few arguments Thanks, Mark Chu-Carroll
Re: Review Request 17752: Add task noun, supporting run and ssh verbs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/ --- (Updated Feb. 7, 2014, 1:55 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Changes --- - Rebase against master; - address Jon Boulle's review comments - fix some instance/shard glitches that got missed in past reviews. Bugs: aurora-124 https://issues.apache.org/jira/browse/aurora-124 Repository: aurora Description --- Add task noun, supporting run and ssh verbs. Diffs (updated) - src/main/python/apache/aurora/client/cli/BUILD 63954d6709b4aac32661f306e1809363bdac2aae src/main/python/apache/aurora/client/cli/__init__.py 14a66762c5217f2eeb6f0762278ed460f72c745d src/main/python/apache/aurora/client/cli/jobs.py caff6d824d9f43cc9eb0c738ea6bb489321d4669 src/main/python/apache/aurora/client/cli/options.py 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 src/main/python/apache/aurora/client/cli/task.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 51cc3806736ee277b76e4f3609a07cc2a910f31e src/test/python/apache/aurora/client/cli/test_task_run.py PRE-CREATION Diff: https://reviews.apache.org/r/17752/diff/ Testing --- [sun-wukong incubator-aurora (tasknoun)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 25 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... == 25 passed in 1.37 seconds === = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.30 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17752: Add task noun, supporting run and ssh verbs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/#review33953 --- Grumble, can't upload the latest changes yet; I merged with master, but rbt hasn't caught up. Will upload ASAP. src/main/python/apache/aurora/client/cli/options.py https://reviews.apache.org/r/17752/#comment63778 D'oh. This is called during the argument processing. The context isn't around yet. - Mark Chu-Carroll On Feb. 7, 2014, 1:55 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/ --- (Updated Feb. 7, 2014, 1:55 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-124 https://issues.apache.org/jira/browse/aurora-124 Repository: aurora Description --- Add task noun, supporting run and ssh verbs. Diffs - src/main/python/apache/aurora/client/cli/BUILD 63954d6709b4aac32661f306e1809363bdac2aae src/main/python/apache/aurora/client/cli/__init__.py 14a66762c5217f2eeb6f0762278ed460f72c745d src/main/python/apache/aurora/client/cli/jobs.py caff6d824d9f43cc9eb0c738ea6bb489321d4669 src/main/python/apache/aurora/client/cli/options.py 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 src/main/python/apache/aurora/client/cli/task.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 51cc3806736ee277b76e4f3609a07cc2a910f31e src/test/python/apache/aurora/client/cli/test_task_run.py PRE-CREATION Diff: https://reviews.apache.org/r/17752/diff/ Testing --- [sun-wukong incubator-aurora (tasknoun)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 25 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... == 25 passed in 1.37 seconds === = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.30 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17752: Add task noun, supporting run and ssh verbs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/ --- (Updated Feb. 7, 2014, 3:44 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Changes --- Rebase with latest master. Address reviews. Bugs: aurora-124 https://issues.apache.org/jira/browse/aurora-124 Repository: aurora Description --- Add task noun, supporting run and ssh verbs. Diffs (updated) - src/main/python/apache/aurora/client/cli/BUILD f5c9ae75d7a26883d90b9bd8ac9c80cd436d03a1 src/main/python/apache/aurora/client/cli/client.py e416d3879cc5943ec5ab3931a8b1aedb85a379a9 src/main/python/apache/aurora/client/cli/jobs.py caff6d824d9f43cc9eb0c738ea6bb489321d4669 src/main/python/apache/aurora/client/cli/options.py 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 src/main/python/apache/aurora/client/cli/task.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD c106b97a0902da5cd791b18117da3198bfb43b8c src/test/python/apache/aurora/client/cli/test_task_run.py PRE-CREATION Diff: https://reviews.apache.org/r/17752/diff/ Testing --- [sun-wukong incubator-aurora (tasknoun)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 25 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... == 25 passed in 1.37 seconds === = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.30 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17877: AURORA-200: set_quota should die if given invalid arguments
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17877/#review34193
---
src/main/python/apache/aurora/client/commands/admin.py
https://reviews.apache.org/r/17877/#comment64205
Die expects a message string, not an exception object. die('Invalid unit
specification') would end up with a better error message.
- Mark Chu-Carroll
On Feb. 10, 2014, 2:17 p.m., Dan Norris wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17877/
---
(Updated Feb. 10, 2014, 2:17 p.m.)
Review request for Aurora, Jonathan Boulle and Mark Chu-Carroll.
Bugs: AURORA-200
https://issues.apache.org/jira/browse/AURORA-200
Repository: aurora
Description
---
AURORA-200: set_quota should die if given invalid arguments
Diffs
-
src/main/python/apache/aurora/client/commands/admin.py
45686aec8d69f0dfa1d649a92a19ca87bd315823
Diff: https://reviews.apache.org/r/17877/diff/
Testing
---
./gradlew clean build ./pants src/test/python:all -vxs along with manual
testing w/ bad arguments.
Thanks,
Dan Norris
Re: Review Request 17752: Add task noun, supporting run and ssh verbs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/ --- (Updated Feb. 11, 2014, 9:16 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Changes --- fix glitched merge. Bugs: aurora-124 https://issues.apache.org/jira/browse/aurora-124 Repository: aurora Description --- Add task noun, supporting run and ssh verbs. Diffs (updated) - src/main/python/apache/aurora/client/cli/BUILD f5c9ae75d7a26883d90b9bd8ac9c80cd436d03a1 src/main/python/apache/aurora/client/cli/client.py e416d3879cc5943ec5ab3931a8b1aedb85a379a9 src/main/python/apache/aurora/client/cli/jobs.py caff6d824d9f43cc9eb0c738ea6bb489321d4669 src/main/python/apache/aurora/client/cli/options.py 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 src/main/python/apache/aurora/client/cli/task.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD c106b97a0902da5cd791b18117da3198bfb43b8c src/test/python/apache/aurora/client/cli/test_task_run.py PRE-CREATION Diff: https://reviews.apache.org/r/17752/diff/ Testing --- [sun-wukong incubator-aurora (tasknoun)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 25 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... == 25 passed in 1.37 seconds === = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.30 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 18086: Fixing python test failure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18086/#review34380 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 13, 2014, 11:45 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18086/ --- (Updated Feb. 13, 2014, 11:45 a.m.) Review request for Aurora and Mark Chu-Carroll. Repository: aurora Description --- Fixing python test failure. Diffs - src/test/python/apache/aurora/client/commands/test_run.py abcc275d57373038227d3805c16b17b967f92048 src/test/python/apache/aurora/client/commands/test_ssh.py d0b91887dee6121e032566f887848cd4151191b2 Diff: https://reviews.apache.org/r/18086/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 17948: Implement help message generation for the noun/verb framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/#review34714 --- src/main/python/apache/aurora/client/cli/sla.py https://reviews.apache.org/r/17948/#comment64931 Yeah, but that'll add a leading CR. I think it's better to just leave it as is. - Mark Chu-Carroll On Feb. 18, 2014, 10:06 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/ --- (Updated Feb. 18, 2014, 10:06 a.m.) Review request for Aurora, David Robinson and Brian Wickman. Bugs: aurora-202 https://issues.apache.org/jira/browse/aurora-202 Repository: aurora Description --- Implement help message generation for the noun/verb framework. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 9eb5c52097f0e75567977ba2d4fe10932d227a4b src/main/python/apache/aurora/client/cli/client.py 3c07c948a74bb9facb7c58e788624e1a404175d2 src/main/python/apache/aurora/client/cli/context.py 4d1de48abd571e809221fcf2487761227b212129 src/main/python/apache/aurora/client/cli/jobs.py 632c539083ba50c3115a2bddc92e4bed6bcdc782 src/main/python/apache/aurora/client/cli/options.py 017f141a605eb6b522fcd7c4fe827eefdc626fca src/main/python/apache/aurora/client/cli/quota.py a7bcfbe0100fe8e400abda3710519e3e5029c477 src/main/python/apache/aurora/client/cli/sla.py a3973df870567052083b1d5a524438191eb6d812 src/test/python/apache/aurora/client/cli/BUILD 636f407d10e85b1ffc58b72a419d81d854a40ffd src/test/python/apache/aurora/client/cli/test_help.py PRE-CREATION Diff: https://reviews.apache.org/r/17948/diff/ Testing --- Added unit tests of new functions; verified that all client tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 17752: Add task noun, supporting run and ssh verbs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/ --- (Updated Feb. 18, 2014, 2:30 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Changes --- merge from master. Bugs: aurora-124 https://issues.apache.org/jira/browse/aurora-124 Repository: aurora Description --- Add task noun, supporting run and ssh verbs. Diffs (updated) - src/main/python/apache/aurora/client/cli/BUILD 7df9deeca1299db02319219b1c299eb284e2cfc6 src/main/python/apache/aurora/client/cli/client.py 3c07c948a74bb9facb7c58e788624e1a404175d2 src/main/python/apache/aurora/client/cli/jobs.py 632c539083ba50c3115a2bddc92e4bed6bcdc782 src/main/python/apache/aurora/client/cli/options.py 017f141a605eb6b522fcd7c4fe827eefdc626fca src/main/python/apache/aurora/client/cli/task.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 636f407d10e85b1ffc58b72a419d81d854a40ffd src/test/python/apache/aurora/client/cli/test_task_run.py PRE-CREATION Diff: https://reviews.apache.org/r/17752/diff/ Testing --- [sun-wukong incubator-aurora (tasknoun)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 25 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... == 25 passed in 1.37 seconds === = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.30 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17948: Implement help message generation for the noun/verb framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/ --- (Updated Feb. 18, 2014, 3:31 p.m.) Review request for Aurora, David Robinson and Brian Wickman. Changes --- Rebase. Bugs: aurora-202 https://issues.apache.org/jira/browse/aurora-202 Repository: aurora Description --- Implement help message generation for the noun/verb framework. Diffs (updated) - src/main/python/apache/aurora/client/cli/__init__.py 9eb5c52097f0e75567977ba2d4fe10932d227a4b src/main/python/apache/aurora/client/cli/client.py 604eb444b5f7e8679731b01bc9cef471143e092d src/main/python/apache/aurora/client/cli/context.py 4d1de48abd571e809221fcf2487761227b212129 src/main/python/apache/aurora/client/cli/jobs.py 199d27f6d320c9d834a140bf5eb64740f41da48f src/main/python/apache/aurora/client/cli/options.py 37f416d563b526cccf3c9cab69a5df15873db250 src/main/python/apache/aurora/client/cli/quota.py a7bcfbe0100fe8e400abda3710519e3e5029c477 src/main/python/apache/aurora/client/cli/sla.py a3973df870567052083b1d5a524438191eb6d812 src/main/python/apache/aurora/client/cli/task.py d7bf5cd34018f4e3678fa9df6a6a48f640e23e81 src/test/python/apache/aurora/client/cli/BUILD 13a3d09a7e98dcec697346f6496d09efd603f947 src/test/python/apache/aurora/client/cli/test_help.py PRE-CREATION Diff: https://reviews.apache.org/r/17948/diff/ Testing --- Added unit tests of new functions; verified that all client tests pass. Thanks, Mark Chu-Carroll
Review Request 18265: Add configuration plugins to the clientv2 framework
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18265/ --- Review request for Aurora, David Robinson and Maxim Khutornenko. Bugs: aurora-220 https://issues.apache.org/jira/browse/aurora-220 Repository: aurora Description --- Add configuration plugins to the clientv2 framework. A configuration plugin is a component that allows a commandline to have objects which perform some kind of configuration option ahead of actually invoking commands. For example, a configuration plugin could add options to perform a security handshake before connecting to a production cluster. Diffs - src/main/python/apache/aurora/client/cli/__init__.py d3bd119fb0930ce6acc9e1945900a7faa840ecd5 src/main/python/apache/aurora/client/cli/sla.py 02002703879557f481aa2252ec2d45456042e24e src/test/python/apache/aurora/client/cli/BUILD f9e674928fd7610e90fdbe7129ef5d69c9b17723 src/test/python/apache/aurora/client/cli/test_plugins.py PRE-CREATION Diff: https://reviews.apache.org/r/18265/diff/ Testing --- [sun-wukong incubator-aurora (plugins)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.02 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_help.py . === 5 passed in 0.47 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 25 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... == 25 passed in 1.63 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_plugins.py .. === 2 passed in 0.49 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 3 items src/test/python/apache/aurora/client/cli/test_quota.py ... === 3 passed in 0.49 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_sla.py .. === 2 passed in 0.48 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.50 seconds === src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (plugins)]$ Thanks, Mark Chu-Carroll
Re: Review Request 18153: Added sla get_job_uptime command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18153/#review34878 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 18, 2014, 6:19 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18153/ --- (Updated Feb. 18, 2014, 6:19 p.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-207 https://issues.apache.org/jira/browse/AURORA-207 Repository: aurora Description --- Added sla get_job_uptime command. Also, changed from ValueError to ArgumentTypeError in options.py as the former is not handled properly by argparser and no custom messages were reported. Diffs - src/main/python/apache/aurora/client/api/sla.py b69d20818836fb6ae87b333e33008b27e013954f src/main/python/apache/aurora/client/cli/options.py 37f416d563b526cccf3c9cab69a5df15873db250 src/main/python/apache/aurora/client/cli/sla.py a3973df870567052083b1d5a524438191eb6d812 src/test/python/apache/aurora/client/api/test_sla.py 54f904c122b9e41d85dc7ad63fe3698cd0bf2923 src/test/python/apache/aurora/client/cli/test_sla.py 703d39e4566a30900f1e9bcca5871c4a426cc6c3 Diff: https://reviews.apache.org/r/18153/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18265: Add configuration plugins to the clientv2 framework
On Feb. 19, 2014, 12:23 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 250 https://reviews.apache.org/r/18265/diff/1/?file=497608#file497608line250 Inconsistent use of positional file arg. Ah, good catch. Supposed to be file=sys.stderr. Thanks! - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18265/#review34876 --- On Feb. 19, 2014, 8:29 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18265/ --- (Updated Feb. 19, 2014, 8:29 a.m.) Review request for Aurora, David Robinson and Maxim Khutornenko. Bugs: aurora-220 https://issues.apache.org/jira/browse/aurora-220 Repository: aurora Description --- Add configuration plugins to the clientv2 framework. A configuration plugin is a component that allows a commandline to have objects which perform some kind of configuration option ahead of actually invoking commands. For example, a configuration plugin could add options to perform a security handshake before connecting to a production cluster. Diffs - src/main/python/apache/aurora/client/cli/__init__.py d3bd119fb0930ce6acc9e1945900a7faa840ecd5 src/main/python/apache/aurora/client/cli/sla.py 02002703879557f481aa2252ec2d45456042e24e src/test/python/apache/aurora/client/cli/BUILD f9e674928fd7610e90fdbe7129ef5d69c9b17723 src/test/python/apache/aurora/client/cli/test_plugins.py PRE-CREATION Diff: https://reviews.apache.org/r/18265/diff/ Testing --- [sun-wukong incubator-aurora (plugins)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.02 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_help.py . === 5 passed in 0.47 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 25 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... == 25 passed in 1.63 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_plugins.py .. === 2 passed in 0.49 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 3 items src/test/python/apache/aurora/client/cli/test_quota.py ... === 3 passed in 0.49 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_sla.py .. === 2 passed in 0.48 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.50 seconds === src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.plugins
Re: Review Request 18265: Add configuration plugins to the clientv2 framework
Ping? I would really like to get this pushed and hopefully deployed soon. -Mark On Wed, Feb 19, 2014 at 12:55 PM, Mark Chu-Carroll mchucarr...@twopensource.com wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18265/ Review request for Aurora, David Robinson and Maxim Khutornenko. By Mark Chu-Carroll. *Updated Feb. 19, 2014, 12:55 p.m.* Changes fix typo. *Bugs: * aurora-220 https://issues.apache.org/jira/browse/aurora-220 *Repository: * aurora Description Add configuration plugins to the clientv2 framework. A configuration plugin is a component that allows a commandline to have objects which perform some kind of configuration option ahead of actually invoking commands. For example, a configuration plugin could add options to perform a security handshake before connecting to a production cluster. Testing [sun-wukong incubator-aurora (plugins)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.02 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_help.py . === 5 passed in 0.47 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 25 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... == 25 passed in 1.63 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_plugins.py .. === 2 passed in 0.49 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 3 items src/test/python/apache/aurora/client/cli/test_quota.py ... === 3 passed in 0.49 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_sla.py .. === 2 passed in 0.48 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.50 seconds === src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (plugins)]$ Diffs (updated) - src/main/python/apache/aurora/client/cli/__init__.py (d3bd119fb0930ce6acc9e1945900a7faa840ecd5) - src/main/python/apache/aurora/client/cli/sla.py (02002703879557f481aa2252ec2d45456042e24e) - src/test/python/apache/aurora/client/cli/BUILD (f9e674928fd7610e90fdbe7129ef5d69c9b17723) - src/test/python/apache/aurora/client/cli/test_plugins.py (PRE-CREATION) View Diff https://reviews.apache.org/r/18265/diff/
Re: Review Request 18267: Implement help for v2 bridge
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18267/ --- (Updated Feb. 20, 2014, 2:33 p.m.) Review request for Aurora, David Robinson and Brian Wickman. Changes --- Address wickman's review. Bugs: aurora-203 https://issues.apache.org/jira/browse/aurora-203 Repository: aurora Description --- Implement help message generation for the noun/verb framework. Diffs (updated) - src/main/python/apache/aurora/client/cli/bridge.py 27079da1430d1b6b36d64c9176797f803db6ff62 src/main/python/apache/aurora/client/cli/client.py 56d63660850b7a3a437cb3575b9ba8add8813956 src/main/python/apache/aurora/client/cli/options.py 2f373723eb4aa51ebd9bd139ce455ae54fbdd3cd Diff: https://reviews.apache.org/r/18267/diff/ Testing --- [sun-wukong incubator-aurora (bridgehelp)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.02 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 25 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... == 25 passed in 1.61 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 3 items src/test/python/apache/aurora/client/cli/test_quota.py ... === 3 passed in 0.49 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_sla.py .. === 2 passed in 0.49 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.50 seconds === src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (bridgehelp)]$ Thanks, Mark Chu-Carroll
Re: Review Request 18267: Implement help for v2 bridge
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18267/ --- (Updated Feb. 21, 2014, 8:56 a.m.) Review request for Aurora, David Robinson and Brian Wickman. Changes --- rebase to master. Bugs: aurora-203 https://issues.apache.org/jira/browse/aurora-203 Repository: aurora Description --- Implement help message generation for the noun/verb framework. Diffs (updated) - src/main/python/apache/aurora/client/cli/bridge.py 27079da1430d1b6b36d64c9176797f803db6ff62 src/main/python/apache/aurora/client/cli/client.py 56d63660850b7a3a437cb3575b9ba8add8813956 src/main/python/apache/aurora/client/cli/options.py 2f373723eb4aa51ebd9bd139ce455ae54fbdd3cd Diff: https://reviews.apache.org/r/18267/diff/ Testing --- [sun-wukong incubator-aurora (bridgehelp)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.02 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 25 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... == 25 passed in 1.61 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 3 items src/test/python/apache/aurora/client/cli/test_quota.py ... === 3 passed in 0.49 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_sla.py .. === 2 passed in 0.49 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.50 seconds === src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (bridgehelp)]$ Thanks, Mark Chu-Carroll
Review Request 18354: Add a packaging target for clientv2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18354/ --- Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-226 https://issues.apache.org/jira/browse/aurora-226 Repository: aurora Description --- Add a packaging target for clientv2. Diffs - src/main/python/apache/aurora/client/BUILD 11ad955866b82b327a57a0f52cff0cdc1a2d83fc Diff: https://reviews.apache.org/r/18354/diff/ Testing --- Thanks, Mark Chu-Carroll
Re: Review Request 16144: ZookeeperSchedulerClient url property errored when no proxy_url was set, and the client was not connected.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16144/#review35154 --- Ship it! Ship It! - Mark Chu-Carroll On Dec. 9, 2013, 8:57 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16144/ --- (Updated Dec. 9, 2013, 8:57 p.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-6 https://issues.apache.org/jira/browse/AURORA-6 Repository: aurora Description --- commit 69f4b79e4054b85b36490c04fb569e3f752dca6f Author: Joshua Cohen jco...@twitter.com Date: Mon Dec 9 18:09:22 2013 -0600 ZookeeperSchedulerClient url property errored when no proxy_url was set, and the client was not connected. .../twitter/aurora/client/api/scheduler_client.py | 3 ++ .../aurora/client/api/test_scheduler_client.py | 56 ++ 2 files changed, 59 insertions(+) The original failure is: File twitter/aurora/client/api/scheduler_client.py, line 138, in url if self._http: AttributeError: 'ZookeeperSchedulerClient' object has no attribute '_http' The fix presented here is to implicitly connect if we're not connected though I'm not sure if this is the desired behavior. The alternative would be to gracefully fail if cluster.proxy_url is not set and self._http is None, then leave it up to the caller to decide whether or not to connect. Connecting is generally implicit today though, so I went this way (though connecting as a result of trying to access the scheduler url may be unexpected). Diffs - src/main/python/twitter/aurora/client/api/scheduler_client.py ffec6043ecab7215eb6be523b879259976c4b2c8 src/test/python/twitter/aurora/client/api/test_scheduler_client.py fe62cd24f3da755859b1fbbfe9a1ee8f91116606 Diff: https://reviews.apache.org/r/16144/diff/ Testing --- Added unit test, ./pants src/test/python/twitter/aurora/client:all Thanks, Joshua Cohen
Re: Review Request 18334: Move and unit test Maintenance module and commands
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18334/#review35152 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 20, 2014, 7:05 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18334/ --- (Updated Feb. 20, 2014, 7:05 p.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman. Bugs: AURORA-223 https://issues.apache.org/jira/browse/AURORA-223 Repository: aurora Description --- As always, feel free to tear it apart. I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach. Diffs - src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386 src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953 src/main/python/apache/aurora/client/base.py c5c969f9641c8e0e1604648b1f9ed542ab59b7d0 src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91 src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0 src/main/python/apache/aurora/client/commands/admin.py 45686aec8d69f0dfa1d649a92a19ca87bd315823 src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912 src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8 src/test/python/apache/aurora/client/commands/BUILD 02c27aa513d60ef901f446c56cbfc0d891445e30 src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION Diff: https://reviews.apache.org/r/18334/diff/ Testing --- ./pants ./src/test/python/apache/aurora:all particularly: src.test.python.apache.aurora.client.commands.maintenance . SUCCESS Thanks, Joe Smith
Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/#review35170 --- src/main/python/apache/aurora/client/api/sla.py https://reviews.apache.org/r/18296/#comment65589 Same comment as class below. src/main/python/apache/aurora/client/api/sla.py https://reviews.apache.org/r/18296/#comment65588 Minor stylistic nit: for a class, you should say what it is, for a method, what it does. So this would read better as A grouping of all active tasks by:... src/main/python/apache/aurora/client/api/sla.py https://reviews.apache.org/r/18296/#comment65590 Would help if this comment said a bit more - I don't know what the override map values mean. Can they arbitrarily change the limits in either direction? Or only make them stricter? - Mark Chu-Carroll On Feb. 21, 2014, 11:30 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/ --- (Updated Feb. 21, 2014, 11:30 a.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-208 https://issues.apache.org/jira/browse/AURORA-208 Repository: aurora Description --- Implemented admin_client sla_list_safe_domain command. Diffs - src/main/python/apache/aurora/client/api/__init__.py 0999b6f99bd74361663258cdae9d3920b3bb636f src/main/python/apache/aurora/client/api/sla.py b0b2b245951ea72d113ff2b3969c4d54024f73e7 src/main/python/apache/aurora/client/commands/admin.py 45686aec8d69f0dfa1d649a92a19ca87bd315823 src/test/python/apache/aurora/client/api/test_sla.py 2e6c8faf668182b497df59fe41b74af240459de7 src/test/python/apache/aurora/client/commands/BUILD 02c27aa513d60ef901f446c56cbfc0d891445e30 src/test/python/apache/aurora/client/commands/test_admin_sla.py PRE-CREATION src/test/python/apache/aurora/client/commands/util.py 11ae990c0d8e41470c6df438d37d8a2a79907a58 Diff: https://reviews.apache.org/r/18296/diff/ Testing --- ./pants src/test/python/apache/aurora/client:all Thanks, Maxim Khutornenko
Re: Review Request 18354: Add a packaging target for clientv2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18354/ --- (Updated Feb. 25, 2014, 11:33 a.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Changes --- Added clientv2 packaging target to make-python-sdists Bugs: aurora-226 https://issues.apache.org/jira/browse/aurora-226 Repository: aurora Description --- Add a packaging target for clientv2. Diffs (updated) - build-support/release/make-python-sdists 43e74be8496916cd4f56d4930b3e8d8a217c001c src/main/python/apache/aurora/client/BUILD 11ad955866b82b327a57a0f52cff0cdc1a2d83fc Diff: https://reviews.apache.org/r/18354/diff/ Testing --- Thanks, Mark Chu-Carroll
Re: Review Request 18440: Adding aurora_admin sla_probe_hosts command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18440/#review35438 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 25, 2014, 1:59 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18440/ --- (Updated Feb. 25, 2014, 1:59 p.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-209 https://issues.apache.org/jira/browse/AURORA-209 Repository: aurora Description --- Implemented sla_probe_hosts command. Diffs - src/main/python/apache/aurora/client/api/sla.py fd5edd1c8dffa99fd42c0e01ecfa8ec832a4a602 src/main/python/apache/aurora/client/commands/admin.py 989c5b625b48fe67ef1297ceda8d7e35cb8ead7e src/test/python/apache/aurora/client/api/test_sla.py 2778545b7cf42c20fb44e2fdb5b661556e84234f src/test/python/apache/aurora/client/commands/test_admin_sla.py 780ad180366a5b8664367e499fe86470418c1344 Diff: https://reviews.apache.org/r/18440/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18546: Renamed Quota to ResourceAggregate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/#review35827 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 27, 2014, 8:32 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/ --- (Updated Feb. 27, 2014, 8:32 p.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Bill Farner. Bugs: AURORA-105 https://issues.apache.org/jira/browse/AURORA-105 Repository: aurora Description --- Updated client to use the new struct. The client tests fail on my laptop. So, muted the failing assertion for now and added AURORA-237. Diffs - build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java a2008758f25d33dc000834ff0d77cba2352013ed src/main/java/org/apache/aurora/scheduler/http/Quotas.java 5f7e34ee1b09fc139ae5eb41fc68a716d555721f src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 6ff70af3975eeaf7bd3efd62eac29bc84b411b1d src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java c8985351fb21c010d3ae5fde5d00f25e77076b37 src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 0e286d8d822759169a11d363f09f5322408a103c src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 9868abc2c3d216ccb7d7749df739e0a898df737d src/main/java/org/apache/aurora/scheduler/quota/Quotas.java 9da3c3e9a1bd732633da8afdda89484f5f4475cb src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java e3ab1ddcc13c14e1aeec496748edaf0ecf5f0a8e src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 8855bfb2cd26f610c6ea6d87fb46abf1fd3d9970 src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java e3dffe080e3f46bff8eae23591da7a79b5237564 src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 34d39f2e9064b67ca226c13bb7e330f4daa2a2aa src/main/java/org/apache/aurora/scheduler/storage/QuotaStore.java 42c405ac43b6676b737c8e46a4f09bddcbeb9bed src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 1842210c91ee3e153f5d142266bc2696960535af src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java cb0ba508605cd2e98da83ef656a516e6c6e2d244 src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java b9bb4bb7a0f2892f29877e070d80cb900365453a src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 043dae68ede0264fad9bbf2b74aa91e9b8b0c9cc src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dccae15a2c529025c9bb6a6f7a0220779ca4f9a1 src/main/python/apache/aurora/client/api/__init__.py 37b7f428677c7f668079373d9a40e3a104c78e3b src/main/python/apache/aurora/client/api/quota_check.py 7de02c43438075629ff9ef93c79d8d7ecfb884c1 src/main/python/apache/aurora/client/api/sla.py 131c357d60fd00740b51055f555d56c599124d15 src/main/python/apache/aurora/client/api/updater.py 924e6d6138b3a192ff42c31588665985f8eb7d13 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/main/thrift/org/apache/aurora/gen/storage.thrift f138c74b2790612d932d330087c6d6d8c24d1570 src/test/java/org/apache/aurora/scheduler/quota/QuotaCheckResultTest.java e366026df7d8d4e1e356889eefaa6fba1aa2e612 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 82e17df016b0f1ad39f8817abe065394edb9f656 src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java c785b1c83ea2b530566050a80214861b3b5b47da src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java a07f3c98a72b3fccb1e1091ffa6bcafedde30247 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java d6624f470eadaf0be658db1d87d5863ea6701d94 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 69dadaf08e0c2771a0820406e8ed0c3778a83066 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 4a2d39d8b25c4a6b161c47d6ba7068d74f8a60e0 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 09a288a8c60b97bc13f72ba54762936eab391899 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 1edc0d7b224cc477ea6e8873e76ee8c70c6b4d50 src/test/python/apache/aurora/client/api/test_quota_check.py 6b1d7bdbce84860c282792a20d15c2229164f465 src/test/python/apache/aurora/client/api/test_scheduler_client.py 49cab1530563862157c85a9d5df38efbeae40777 src/test/python/apache/aurora/client/api
Re: Review Request 18720: Refactored admin client commands to take advantage of new TaskQuery fields.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18720/#review36551 --- Ship it! Ship It! - Mark Chu-Carroll On March 6, 2014, 5:42 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18720/ --- (Updated March 6, 2014, 5:42 p.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-239 https://issues.apache.org/jira/browse/AURORA-239 Repository: aurora Description --- Refactored admin client commands to take advantage of new TaskQuery fields. The jobKeys thrift field is tracked by https://reviews.apache.org/r/18655/ Diffs - src/main/python/apache/aurora/client/api/__init__.py 9d9ff668496c7369c3abcf3ab3feb9d4090de6a8 src/main/python/apache/aurora/client/api/sla.py 71013cdab23f1d0990169555a60fcc370cc0b85c src/main/python/apache/aurora/client/commands/admin.py 40588e23f5082604af9f474e9cf6ab84663b8d67 src/test/python/apache/aurora/client/api/test_sla.py c5ef100d42cde586e8d183d0f338d6b72b8b5dbd src/test/python/apache/aurora/client/commands/test_admin_sla.py 6e56bc48157efb6839e79d15cb1ba8de53ae1b7b Diff: https://reviews.apache.org/r/18720/diff/ Testing --- /build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Review Request 18979: Add an updated version of the clientv2 doc to apache.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18979/ --- Review request for Aurora and Dave Lester. Bugs: aurora-253 https://issues.apache.org/jira/browse/aurora-253 Repository: aurora Description --- Add an updated version of the clientv2 doc to apache. (Also make a few changes in the interfaces to match the updated doc.) Diffs - docs/clientv2.md PRE-CREATION src/main/python/apache/aurora/client/cli/__init__.py 4a6a7eef7b781be79a3d40776a3bd6f0c6e8c4c0 Diff: https://reviews.apache.org/r/18979/diff/ Testing --- n/a Thanks, Mark Chu-Carroll
Re: Review Request 18979: Add an updated version of the clientv2 doc to apache.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18979/ --- (Updated March 10, 2014, 6:24 p.m.) Review request for Aurora, Dave Lester and Tom Galloway. Changes --- Forgot to put Tom on the people line. Bugs: aurora-253 https://issues.apache.org/jira/browse/aurora-253 Repository: aurora Description --- Add an updated version of the clientv2 doc to apache. (Also make a few changes in the interfaces to match the updated doc.) Diffs - docs/clientv2.md PRE-CREATION src/main/python/apache/aurora/client/cli/__init__.py 4a6a7eef7b781be79a3d40776a3bd6f0c6e8c4c0 Diff: https://reviews.apache.org/r/18979/diff/ Testing --- n/a Thanks, Mark Chu-Carroll
Re: Review Request 18996: Fix errors in jobs.py.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18996/ --- (Updated March 10, 2014, 7:44 p.m.) Review request for Aurora and Maxim Khutornenko. Changes --- Another glitch found - since this isn't review yet, might at well toss it in. Repository: aurora Description --- Fix errors in jobs.py. Diffs (updated) - src/main/python/apache/aurora/client/cli/jobs.py 3b327df5f9c5f1d5e7e68863191313921a8dde44 Diff: https://reviews.apache.org/r/18996/diff/ Testing --- Thanks, Mark Chu-Carroll
Re: Review Request 18979: Add an updated version of the clientv2 doc to apache.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18979/ --- (Updated March 11, 2014, 12:34 p.m.) Review request for Aurora, Dave Lester and Tom Galloway. Changes --- Got rid of the lingering packer references, and added a bit more implementation detail. Bugs: aurora-253 https://issues.apache.org/jira/browse/aurora-253 Repository: aurora Description --- Add an updated version of the clientv2 doc to apache. (Also make a few changes in the interfaces to match the updated doc.) Diffs (updated) - docs/clientv2.md PRE-CREATION src/main/python/apache/aurora/client/cli/__init__.py 4a6a7eef7b781be79a3d40776a3bd6f0c6e8c4c0 src/main/python/apache/aurora/client/cli/jobs.py 3b327df5f9c5f1d5e7e68863191313921a8dde44 Diff: https://reviews.apache.org/r/18979/diff/ Testing --- n/a Thanks, Mark Chu-Carroll
Re: Review Request 19061: Disable kill of production jobs without force flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/ --- (Updated March 11, 2014, 3:42 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Changes --- fix headers. Summary (updated) - Disable kill of production jobs without force flag Repository: aurora Description (updated) --- Disable kill of production jobs without force flag. Diffs - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19061/diff/ Testing --- Added new test cases to the unit test for the kill command to cover the new cases. All tests, new and old, pass. [sun-wukong incubator-aurora (kill-force)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.47 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... == 26 passed in 1.35 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.43 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.54 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19061: Disable kill of production jobs without force flag
On March 11, 2014, 3:46 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/commands/core.py, line 398 https://reviews.apache.org/r/19061/diff/1/?file=516614#file516614line398 This will fail if a kill is attempted for a job that does not exist. Wouldn't that result in an error, which would be caught by the check-and-log-result? - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/#review36829 --- On March 11, 2014, 3:42 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/ --- (Updated March 11, 2014, 3:42 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Disable kill of production jobs without force flag. Diffs - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19061/diff/ Testing --- Added new test cases to the unit test for the kill command to cover the new cases. All tests, new and old, pass. [sun-wukong incubator-aurora (kill-force)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.47 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... == 26 passed in 1.35 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.43 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.54 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19061: Disable kill of production jobs without force flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/ --- (Updated March 11, 2014, 4:03 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Changes --- fix glitches found by reviewers. Repository: aurora Description --- Disable kill of production jobs without force flag. Diffs (updated) - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19061/diff/ Testing --- Added new test cases to the unit test for the kill command to cover the new cases. All tests, new and old, pass. [sun-wukong incubator-aurora (kill-force)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.47 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... == 26 passed in 1.35 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.43 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.54 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19061: Disable kill of production jobs without force flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/#review36877 --- src/main/python/apache/aurora/client/commands/core.py https://reviews.apache.org/r/19061/#comment68072 return 0 is equivalent to exit 0. App commands use the return value of the function as the exit code if it's numeric. Today, if the user calls kill on a command that doesn't exist, they don't get an error exit, so I didn't want to change that. src/main/python/apache/aurora/client/commands/core.py https://reviews.apache.org/r/19061/#comment68073 Chris IMed me and asked me to add it. I'm not a huge fan, but he insisted :-). In terms of scripting, I think this is a feature. Killing a production service is something that we want to discourage - saying that you can't do it from a script, and can only do it explicitly is a good thing. - Mark Chu-Carroll On March 11, 2014, 6:23 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/ --- (Updated March 11, 2014, 6:23 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Disable kill of production jobs without force flag. Diffs - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19061/diff/ Testing --- Added new test cases to the unit test for the kill command to cover the new cases. All tests, new and old, pass. [sun-wukong incubator-aurora (kill-force)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.47 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... == 26 passed in 1.35 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.43 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.54 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19061: Disable kill of production jobs without force flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/ --- (Updated March 12, 2014, 2:12 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Changes --- Address reviews. Repository: aurora Description --- Disable kill of production jobs without force flag. Diffs (updated) - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19061/diff/ Testing --- Added new test cases to the unit test for the kill command to cover the new cases. All tests, new and old, pass. [sun-wukong incubator-aurora (kill-force)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.47 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... == 26 passed in 1.35 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.43 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.54 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS Thanks, Mark Chu-Carroll
Review Request 19143: Catch errors thrown by authentication modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19143/ --- Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-259 https://issues.apache.org/jira/browse/aurora-259 Repository: aurora Description --- Catch errors thrown by authentication modules. Authentication modules can throw arbitrary errors - ldap exceptions, password errors, etc, if auth fails with one of these app specific errors, the client current dumps its cookies in a stack dump. This change catches the error cleanly, and transforms it into a handled authentication exception. Diffs - src/main/python/apache/aurora/client/api/scheduler_client.py f770df7a23779f919cd11cc28b2aaf7cfdf9c5a1 Diff: https://reviews.apache.org/r/19143/diff/ Testing --- Thanks, Mark Chu-Carroll
Re: Review Request 18979: Add an updated version of the clientv2 doc to apache.
On March 11, 2014, 3:16 p.m., Tom Galloway wrote: Line 148: Each noun will be separate component - Each noun will be a separate component noun verb syntax; are you wedded to this? aurora get quota and aurora create job are more English (if Tarzan sounding) like than aurora quota get and aurora job create and just seem to read better as verb noun to me. Line 200: * `submit jobkey config`: submits a job to a cluster, launching the jobs task. I'm not clear here on whether this should be job's tasks, job's task, or task named 'jobs' (for the last, I'm thinking going through the jobs list in the config file, could be a task, although a bit different from the defined ones.) Line 205: they'llbe - they'll be In the noun sections, I'd strongly suggest including at least the noun, and possibly aurora noun in the examples for clarity since you've made a big deal of the noun/verb syntax thing. It took me a minute to realize submit jobkey config was short for aurora job submit jobkey config Line 217-218: cluster/role, all jobs running under the role will be listed. I'd add on the cluster between running and under the role for claity Line 224: The cron commands all manipulate cron schedule entries Maybe just me, but I'd change this to All cron commands manipulate...; initially I was reading this as The cron commands all... with commands as a verb. Line 227: Again probably just me, but schedule a job to run by cron. has me doing flashbacks to Conan the Barbarian going By Crom! and is a bit awkward. How about schedule a cron-run job Line 234: Quotas are a data object maintained by the scheduler that specifies the maximum resources that may be consumed by jobs owned by a particular role. Definitely change Quotas are a data object to A quota is a data object. I'd suggest breaking up this four chained concepts sentence info multiples; A quota is a data object maintained by the scheduler. It specifies the maximum resources that jobs owned by a particular role may consume. Maybe also emphasize that it does *not* work on a single job as specified by a jobkey, but on all jobs sharing the specified cluster and role values. Line 247: command-line - command line Line 323: remove extra whitespace. Lines 326 and 328: command-line - command line Line 331: When commands are executed - When commands execute Lines 331-2: When commands are executed, they're given an instance of a *context object*. The context object must be an instance of a subclass of `AuroraCommandContext`. This is confusing, as you seem to be using object and instance interchangably. It seems that the command gets an instance of an instance? Two things I'd suggest mentioning; 1) Is every current open source command line command and option going to be available in some way out of the box with the new client? In other words, is there any existing functionality being removed (or, for that matter, added) in this new client? 2) Will the new client still have the ability to add hooks to the existing commands? I'd think so, since as the hooks stuff operates on the underlying Aurora API which the client commands call. 3) Not for open source, but will the Twitter-internal aurora packer and aurora deploy commands still be implemented in the new client? Fixed most of this. For the remainder: - scheduling a job to run by cron is (IME) the common phrasing. - we are committed to noun/verb order. That got nailed down during design reviews. - all of the functionality of the v1 client will, at least eventually, be supported by v2. Not necessarily every option in exactly the same way - but equivalent functionality. I think that that's beyond the scope of this document. - Hooks work exactly the way that they do in the existing client - no changes. - We want to keep discussions of twitter-internal stuff out of apache - it just isn't relevant here. (But for a quick answer, yes.) - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18979/#review36827 --- On March 11, 2014, 12:34 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18979/ --- (Updated March 11, 2014, 12:34 p.m.) Review request for Aurora, Dave Lester and Tom Galloway. Bugs: aurora-253 https://issues.apache.org/jira/browse/aurora-253 Repository: aurora Description --- Add an updated version of the clientv2 doc to apache. (Also make a few changes in the interfaces to match the updated doc.) Diffs - docs
Re: Review Request 18979: Add an updated version of the clientv2 doc to apache.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18979/ --- (Updated March 12, 2014, 5:44 p.m.) Review request for Aurora, Dave Lester and Tom Galloway. Changes --- review changes. Bugs: aurora-253 https://issues.apache.org/jira/browse/aurora-253 Repository: aurora Description --- Add an updated version of the clientv2 doc to apache. (Also make a few changes in the interfaces to match the updated doc.) Diffs (updated) - docs/clientv2.md PRE-CREATION src/main/python/apache/aurora/client/cli/__init__.py 4a6a7eef7b781be79a3d40776a3bd6f0c6e8c4c0 src/main/python/apache/aurora/client/cli/jobs.py 3b327df5f9c5f1d5e7e68863191313921a8dde44 Diff: https://reviews.apache.org/r/18979/diff/ Testing --- n/a Thanks, Mark Chu-Carroll
Re: Review Request 19159: Add killall.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19159/#review37008 --- src/main/python/apache/aurora/client/commands/core.py https://reviews.apache.org/r/19159/#comment68255 This is deliberate: the kill command doesn't have a force option. So this ensures that there's more than a search-and-replace killall for kill: you need to deliberately use the killall command, and specify the force option. The require --shards is also in this change - see the change above in kill. - Mark Chu-Carroll On March 12, 2014, 6:11 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19159/ --- (Updated March 12, 2014, 6:11 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: aurora-260 https://issues.apache.org/jira/browse/aurora-260 Repository: aurora Description --- Add killall. - the kill command now requires a shards parameter. - the new killall command only works when run with --force. - killall generates a scary warning message, and pauses to give the user a chance to abort. Diffs - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19159/diff/ Testing --- Modified the existing kill command's test suite, adding new tests of the new functionality. All pass. [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... = 26 passed in 11.34 seconds == src.test.python.apache.aurora.client.commands.core . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19143: Catch errors thrown by authentication modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19143/ --- (Updated March 12, 2014, 6:59 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Changes --- Added debug logging of stack traceback for auth errors. Bugs: aurora-259 https://issues.apache.org/jira/browse/aurora-259 Repository: aurora Description --- Catch errors thrown by authentication modules. Authentication modules can throw arbitrary errors - ldap exceptions, password errors, etc, if auth fails with one of these app specific errors, the client current dumps its cookies in a stack dump. This change catches the error cleanly, and transforms it into a handled authentication exception. Diffs (updated) - src/main/python/apache/aurora/client/api/scheduler_client.py f770df7a23779f919cd11cc28b2aaf7cfdf9c5a1 Diff: https://reviews.apache.org/r/19143/diff/ Testing --- Thanks, Mark Chu-Carroll
Re: Review Request 19159: Add killall.
I think making a reasonable effort to make it harder to accidentally do
this is worthwhile - there's no harm in it, and it might just help.
-Mark
On Thu, Mar 13, 2014 at 10:07 AM, Kevin Sweeney kevi...@apache.org wrote:
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/
On March 12th, 2014, 3:25 p.m. PDT, *Mark Chu-Carroll* wrote:
src/main/python/apache/aurora/client/commands/core.pyhttps://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line399
(Diff
revision 1)
def show_job_pretty(job):
397
@app.command_option('--force', default=False, action='store_true',
This is deliberate: the kill command doesn't have a force option. So
this ensures that there's more than a search-and-replace killall for kill:
you need to deliberately use the killall command, and specify the force
option.
The require --shards is also in this change - see the change above in kill.
On March 12th, 2014, 3:29 p.m. PDT, *Maxim Khutornenko* wrote:
Missed the --shards part, thanks.
If someone is going to search-and-replace kill with killall without wanting
to do that I'm not sure we can stop them from shooting themselves in the
foot. Up to you but I'm in favor of dropping this required option.
- Kevin
On March 12th, 2014, 3:11 p.m. PDT, Mark Chu-Carroll wrote:
Review request for Aurora, Kevin Sweeney and Bill Farner.
By Mark Chu-Carroll.
*Updated March 12, 2014, 3:11 p.m.*
*Bugs: * aurora-260 https://issues.apache.org/jira/browse/aurora-260
*Repository: * aurora
Description
Add killall.
- the kill command now requires a shards parameter.
- the new killall command only works when run with --force.
- killall generates a scary warning message, and pauses to give
the user a chance to abort.
Testing
Modified the existing kill command's test suite, adding new tests of the new
functionality. All pass.
[sun-wukong incubator-aurora (killall)]$ ./pants
src/test/python/apache/aurora/client/commands:core
Build operating on targets:
OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
= test session starts
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 26 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ..
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py .
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ..
src/test/python/apache/aurora/client/commands/test_update.py ...
= 26 passed in 11.34 seconds
==
src.test.python.apache.aurora.client.commands.core
. SUCCESS
Diffs
- src/main/python/apache/aurora/client/commands/core.py
(ff0f1f8668c8c405fa3a41b70cae32004034e223)
- src/test/python/apache/aurora/client/commands/test_kill.py
(7639dc98bfea0663461d15e3d46f1aedd13b124f)
View Diff https://reviews.apache.org/r/19159/diff/
Re: Review Request 19159: Add killall.
But in some sense, this isn't a standard command. This is a dangerous
command, and we want it to be out of the ordinary. We want to be sure that
it's not done accidentally, and making its flag behavior be strange is
arguably good.
-Mark
On Thu, Mar 13, 2014 at 11:14 AM, Maxim Khutornenko ma...@apache.orgwrote:
What looks odd though is a command that is unusable without the --force
flag. The standard optional semantic of that flag feels violated here.
On Thu, Mar 13, 2014 at 11:10 AM, Maxim Khutornenko ma...@apache.orgwrote:
What looks odd though is a command that is unusable without the --force
flag. The standard optional semantic of that flag is violated here.
On Mar 13, 2014, at 11:07 AM, Mark Chu-Carroll mchucarr...@apache.org
wrote:
I think making a reasonable effort to make it harder to accidentally do
this is worthwhile - there's no harm in it, and it might just help.
-Mark
On Thu, Mar 13, 2014 at 10:07 AM, Kevin Sweeney kevi...@apache.orgwrote:
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/
On March 12th, 2014, 3:25 p.m. PDT, *Mark Chu-Carroll* wrote:
src/main/python/apache/aurora/client/commands/core.pyhttps://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line399
(Diff
revision 1)
def show_job_pretty(job):
397
@app.command_option('--force', default=False, action='store_true',
This is deliberate: the kill command doesn't have a force option. So
this ensures that there's more than a search-and-replace killall for kill:
you need to deliberately use the killall command, and specify the force
option.
The require --shards is also in this change - see the change above in kill.
On March 12th, 2014, 3:29 p.m. PDT, *Maxim Khutornenko* wrote:
Missed the --shards part, thanks.
If someone is going to search-and-replace kill with killall without
wanting to do that I'm not sure we can stop them from shooting themselves
in the foot. Up to you but I'm in favor of dropping this required option.
- Kevin
On March 12th, 2014, 3:11 p.m. PDT, Mark Chu-Carroll wrote:
Review request for Aurora, Kevin Sweeney and Bill Farner.
By Mark Chu-Carroll.
*Updated March 12, 2014, 3:11 p.m.*
*Bugs: * aurora-260 https://issues.apache.org/jira/browse/aurora-260
*Repository: * aurora
Description
Add killall.
- the kill command now requires a shards parameter.
- the new killall command only works when run with --force.
- killall generates a scary warning message, and pauses to give
the user a chance to abort.
Testing
Modified the existing kill command's test suite, adding new tests of the
new functionality. All pass.
[sun-wukong incubator-aurora (killall)]$ ./pants
src/test/python/apache/aurora/client/commands:core
Build operating on targets:
OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
= test session starts
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 26 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ..
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py .
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ..
src/test/python/apache/aurora/client/commands/test_update.py ...
= 26 passed in 11.34 seconds
==
src.test.python.apache.aurora.client.commands.core
. SUCCESS
Diffs
- src/main/python/apache/aurora/client/commands/core.py
(ff0f1f8668c8c405fa3a41b70cae32004034e223)
- src/test/python/apache/aurora/client/commands/test_kill.py
(7639dc98bfea0663461d15e3d46f1aedd13b124f)
View Diff https://reviews.apache.org/r/19159/diff/
Re: Review Request 19159: Add killall.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19159/ --- (Updated March 13, 2014, 3:51 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Get rid of --force. Bugs: aurora-260 https://issues.apache.org/jira/browse/aurora-260 Repository: aurora Description --- Add killall. - the kill command now requires a shards parameter. - the new killall command only works when run with --force. - killall generates a scary warning message, and pauses to give the user a chance to abort. Diffs (updated) - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19159/diff/ Testing --- Modified the existing kill command's test suite, adding new tests of the new functionality. All pass. [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... = 26 passed in 11.34 seconds == src.test.python.apache.aurora.client.commands.core . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19159: Add killall.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19159/ --- (Updated March 13, 2014, 4:05 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- address maxim's review. Bugs: aurora-260 https://issues.apache.org/jira/browse/aurora-260 Repository: aurora Description --- Add killall. - the kill command now requires a shards parameter. - the new killall command only works when run with --force. - killall generates a scary warning message, and pauses to give the user a chance to abort. Diffs (updated) - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19159/diff/ Testing --- Modified the existing kill command's test suite, adding new tests of the new functionality. All pass. [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... = 26 passed in 11.34 seconds == src.test.python.apache.aurora.client.commands.core . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19159: Add killall.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19159/ --- (Updated March 13, 2014, 7:59 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Get rid of prompt/delay on killall. Bugs: aurora-260 https://issues.apache.org/jira/browse/aurora-260 Repository: aurora Description --- Add killall. - the kill command now requires a shards parameter. - the new killall command only works when run with --force. - killall generates a scary warning message, and pauses to give the user a chance to abort. Diffs (updated) - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19159/diff/ Testing --- Modified the existing kill command's test suite, adding new tests of the new functionality. All pass. [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... = 26 passed in 11.34 seconds == src.test.python.apache.aurora.client.commands.core . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19159: Add killall.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19159/ --- (Updated March 13, 2014, 8:14 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Get rid of the use of the disambiguator in the new killall command. Fix the end-to-end test. Bugs: aurora-260 https://issues.apache.org/jira/browse/aurora-260 Repository: aurora Description --- Add killall. - the kill command now requires a shards parameter. - the new killall command only works when run with --force. - killall generates a scary warning message, and pauses to give the user a chance to abort. Diffs (updated) - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 00a80d90c2ce9b6134784a91c2cb9d9e966446ae Diff: https://reviews.apache.org/r/19159/diff/ Testing --- Modified the existing kill command's test suite, adding new tests of the new functionality. All pass. [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... = 26 passed in 11.34 seconds == src.test.python.apache.aurora.client.commands.core . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19159: Add killall.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19159/ --- (Updated March 13, 2014, 8:14 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: aurora-260 https://issues.apache.org/jira/browse/aurora-260 Repository: aurora Description --- Add killall. - the kill command now requires a shards parameter. - the new killall command only works when run with --force. - killall generates a scary warning message, and pauses to give the user a chance to abort. Diffs - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 00a80d90c2ce9b6134784a91c2cb9d9e966446ae Diff: https://reviews.apache.org/r/19159/diff/ Testing --- Modified the existing kill command's test suite, adding new tests of the new functionality. All pass. [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... = 26 passed in 11.34 seconds == src.test.python.apache.aurora.client.commands.core . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19143: Catch errors thrown by authentication modules.
On March 13, 2014, 2:26 p.m., Joshua Cohen wrote: src/main/python/apache/aurora/client/api/scheduler_client.py, line 243 https://reviews.apache.org/r/19143/diff/2/?file=517784#file517784line243 The broad catch below worries me a bit. Would it be feasible to have the various _connect impls (which presumably are what are raising the various types of exceptions and therefore have a better idea of what types of exceptions might be raised) be responsible for catching the appropriate exception types and re-raising as auth errors if necessary, or is there really no way of narrowing this down to only auth errors? It would be difficult. The way that some of the auth code is patched in makes it very hard to control what exceptions get raised. (I don't want to go into more detail here; discussing how twitter does authentication on the open-source jira isn't a good idea.) - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19143/#review37080 --- On March 12, 2014, 6:59 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19143/ --- (Updated March 12, 2014, 6:59 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-259 https://issues.apache.org/jira/browse/aurora-259 Repository: aurora Description --- Catch errors thrown by authentication modules. Authentication modules can throw arbitrary errors - ldap exceptions, password errors, etc, if auth fails with one of these app specific errors, the client current dumps its cookies in a stack dump. This change catches the error cleanly, and transforms it into a handled authentication exception. Diffs - src/main/python/apache/aurora/client/api/scheduler_client.py f770df7a23779f919cd11cc28b2aaf7cfdf9c5a1 Diff: https://reviews.apache.org/r/19143/diff/ Testing --- Thanks, Mark Chu-Carroll
Review Request 19431: Add instance specifier syntax to clientv2
-wukong incubator-aurora (instance-syntax)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.02 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_help.py . === 5 passed in 0.47 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 27 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py ... src/test/python/apache/aurora/client/cli/test_update.py ... == 27 passed in 1.65 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_plugins.py .. === 2 passed in 0.51 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 3 items src/test/python/apache/aurora/client/cli/test_quota.py ... === 3 passed in 0.49 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_sla.py . === 5 passed in 0.53 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.53 seconds === src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19411: Add support for global hooks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/#review37834 --- src/main/python/apache/aurora/client/config.py https://reviews.apache.org/r/19411/#comment69584 It is getting exercised in the hooks test; what additional tests would you like to see? src/main/python/apache/aurora/client/options.py https://reviews.apache.org/r/19411/#comment69585 Not sure what you mean: make the parameter a string-value instead of boolean, and if they supply an override, then hooks don't run? - Mark Chu-Carroll On March 19, 2014, 1:09 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/ --- (Updated March 19, 2014, 1:09 p.m.) Review request for Aurora, Maxim Khutornenko and Brian Wickman. Bugs: aurora-269 https://issues.apache.org/jira/browse/aurora-269 Repository: aurora Description --- Add support for global hooks. To support site-specific policy requirements, we'd like to be able to have hooks that are applied to every configuration, and that are used regardless of whether a configuration specifically enables hooks. We'd like these to be baked in to the client. This change adds a global registry, which can be initialized with a set of global hooks. In case of errors/emergencies, there is an override flag to disable the global hooks. Diffs - src/main/python/apache/aurora/client/commands/core.py 9977c725528086d3e8cf58de294adee542570411 src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196 src/main/python/apache/aurora/client/hooks/hooked_api.py 6de81347e021a71fc6aef598e6933c440335c8bf src/main/python/apache/aurora/client/options.py b8278bdeeb777a1b6a72167100323fb177bc9636 src/test/python/apache/aurora/client/commands/BUILD 7c808089f1456f5907aaf95d3f8d025f576a56f6 src/test/python/apache/aurora/client/commands/test_admin_sla.py 51e74823e90f460200d60065ea0ad31bd57a34f6 src/test/python/apache/aurora/client/commands/test_cancel_update.py 7824b764561cc95614c196c297137b0a6b49dccc src/test/python/apache/aurora/client/commands/test_create.py adbff90f23b958eae03da41ef7cbc5bedc84f1c8 src/test/python/apache/aurora/client/commands/test_diff.py fc154214574c19e0fff1e4be82cd61dd42f676b6 src/test/python/apache/aurora/client/commands/test_kill.py 75e754ba2a850287ec0c3bbdee7289231ad35b2a src/test/python/apache/aurora/client/commands/test_listjobs.py 099475c90d3a5f350fe3240c345911a59f35df92 src/test/python/apache/aurora/client/commands/test_maintenance.py df368e2f89149ff6b18b174e61657f3faa9cb0ab src/test/python/apache/aurora/client/commands/test_restart.py 1cab2a2dd4b1bc58a6ea47c7a07a3cc92f4b20cd src/test/python/apache/aurora/client/commands/test_run.py fe666158e0e9ad38b4b4f0c2b91af737eef130cd src/test/python/apache/aurora/client/commands/test_ssh.py 2fe12ef5660f7ae2bf36493e6f1f6bc63ee9ccc7 src/test/python/apache/aurora/client/commands/test_status.py eed798d2475280c787bea749647528cfd0715a40 src/test/python/apache/aurora/client/commands/test_update.py 21951b6b06321894607531884a0acd75e303204e src/test/python/apache/aurora/client/hooks/BUILD 3d6f7966356fbe2b02868650a9784d3155884092 Diff: https://reviews.apache.org/r/19411/diff/ Testing --- = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.37 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.48 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.43 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . === 1 passed in 0.40 seconds === = test session starts
Re: Review Request 19411: Add support for global hooks.
/python/apache/aurora/client/commands/test_hooks.py ... === 3 passed in 1.03 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py === 4 passed in 0.46 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . === 1 passed in 0.45 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . === 1 passed in 0.46 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 12 items src/test/python/apache/aurora/client/hooks/test_hooked_api.py == 12 passed in 0.46 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py === 4 passed in 0.42 seconds === Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, Mark Chu-Carroll
Review Request 19466: Add batching to the kill and killall commands.
src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19431: Add instance specifier syntax to clientv2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review37933 --- src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/19431/#comment69748 The instance syntax is mandatory for commands that can operate on instances. The parser is shared between all of them. For restart, run, and update, it make sense to be able to say all shard. So you can say all instead of providing a numeric range. For kill, we don't want to allow users to specify all; we wnt them to use killall. src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/19431/#comment69749 Yes. Some of the wildcard stuff is still more up-in-the-air than I'd like; I just haven't had time to go through and make it uniform. The parser will still allow a wildcard. The wildcard won't actually be expanded to match anything, because that code doesn't run in kill. But there should be a proper, uniform error message in all commands that don't support wildcarding. src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/19431/#comment69750 See above. I can't remember who I've talked to about it - I know I've talked about i, but I don't remember who. Without instance syntax, if you run aurora job update c/r/e/j without --instances, it automatically runs on all instances. With instance syntax, the parameter to update and restart is a five-tuple, one part of which is a shard specifier. We don't want to eliminate all-shard update, but this does add a degree of safety, in that you can't accidentally update all shards: you need to explicitly say that that's what you want to do. - Mark Chu-Carroll On March 19, 2014, 7:38 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/ --- (Updated March 19, 2014, 7:38 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-268 https://issues.apache.org/jira/browse/aurora-268 Repository: aurora Description --- Add instance specifier syntax to commands that can specify instances for clientv2. Also, while I was at it, I added the kill/killall distinction to clientv2. Diffs - src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1 src/main/python/apache/aurora/client/cli/options.py 0e0bd45f9506e5dc729a24cd68b04b49650605b6 src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32 src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa src/test/python/apache/aurora/client/cli/test_restart.py aa23d5bfe81361243d82aadf9dc574608e28d953 src/test/python/apache/aurora/client/cli/test_update.py 51858b9e4ca02c2ae2151275fff9936460936bb4 Diff: https://reviews.apache.org/r/19431/diff/ Testing --- [sun-wukong incubator-aurora (instance-syntax)]$ !./p ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.02 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_help.py . === 5 passed in 0.48 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 27 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py ... src/test/python/apache/aurora/client/cli/test_update.py ... == 27 passed in 1.63 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora
Re: Review Request 19431: Add instance specifier syntax to clientv2
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
[sun-wukong incubator-aurora (instance-syntax)]$
[sun-wukong incubator-aurora (instance-syntax)]$ grep INSTANCES_OPTION
src/main/python/apache/aurora/client/cli/*.py
src/main/python/apache/aurora/client/cli/options.py:INSTANCES_OPTION =
CommandOption('--instances', type=parse_instances, dest='instances',
src/main/python/apache/aurora/client/cli/task.py:INSTANCES_OPTION,
[sun-wukong incubator-aurora (instance-syntax)]$ ./pants
src/test/python/apache/aurora/client/cli:all
Build operating on targets:
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items
src/test/python/apache/aurora/client/cli/test_bridge.py
=== 4 passed in 0.02 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items
src/test/python/apache/aurora/client/cli/test_help.py .
=== 5 passed in 0.47 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items
src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...
== 27 passed in 1.65 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/cli/test_plugins.py ..
=== 2 passed in 0.51 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 3 items
src/test/python/apache/aurora/client/cli/test_quota.py ...
=== 3 passed in 0.49 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items
src/test/python/apache/aurora/client/cli/test_sla.py .
=== 5 passed in 0.53 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/cli/test_task_run.py ..
=== 2 passed in 0.53 seconds ===
src.test.python.apache.aurora.client.cli.bridge
. SUCCESS
src.test.python.apache.aurora.client.cli.help
. SUCCESS
src.test.python.apache.aurora.client.cli.job
. SUCCESS
src.test.python.apache.aurora.client.cli.plugins
. SUCCESS
src.test.python.apache.aurora.client.cli.quota
. SUCCESS
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 19313: added killall command
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19313/#review38086
---
docs/README.md
https://reviews.apache.org/r/19313/#comment70051
Weasel wording: typical services consist of up to hundreds.
Either say typical services consist of hundreds or services consist of
up to hundreds.
docs/README.md
https://reviews.apache.org/r/19313/#comment70052
shards *or* instances.
docs/README.md
https://reviews.apache.org/r/19313/#comment70053
Not true. There are virtually no tasks that are single processes. Almost
every task is a sequence of at least 2 commands: install binary, and run.
docs/README.md
https://reviews.apache.org/r/19313/#comment70054
Get rid of trailing whitespace.
docs/clientcommands.md
https://reviews.apache.org/r/19313/#comment70055
Every line in this ToC has trailing whitespace.
docs/clientcommands.md
https://reviews.apache.org/r/19313/#comment70056
you've got a dash instead of an =.
docs/clientcommands.md
https://reviews.apache.org/r/19313/#comment70057
/s.
docs/clientcommands.md
https://reviews.apache.org/r/19313/#comment70058
Keep lines 100columns.
docs/configurationreference.md
https://reviews.apache.org/r/19313/#comment70059
Again, tons of trailing whitespace here.
docs/configurationreference.md
https://reviews.apache.org/r/19313/#comment70060
Here and elsewhere in the doc, reviewboard is complaining that you're using
a smartquote instead of a ' character. This will cause trouble for some people
reading on the command-line.
docs/configurationreference.md
https://reviews.apache.org/r/19313/#comment70061
No need for weaselword typically here.
docs/hooks.md
https://reviews.apache.org/r/19313/#comment70062
Tons of trailing whitespace everywhere, and smart quotes for apostrophes.
- Mark Chu-Carroll
On March 17, 2014, 3:01 p.m., Tom Galloway wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19313/
---
(Updated March 17, 2014, 3:01 p.m.)
Review request for Aurora, Chris Lambert, Dave Lester, and Mark Chu-Carroll.
Repository: aurora
Description
---
added killall command
Added killall command, changed kill command doc
Removed content about null-op {{#x}}
Minor edits
Minor edits
Minor edits
Minor edits
Minor edits
Minor edits
Minor edits
Minor edits
Minor Constraint/order() correction 2
Minor Constraint/order() correction
Client command hooks doc
Resource isolation doc
Configuration tutorial
User guide doc
Configuration file reference
Tutorial doc
Client commands doc
User doc overview
Doc images
Adding initial image in images directory
Diffs
-
docs/README.md PRE-CREATION
docs/clientcommands.md PRE-CREATION
docs/configurationreference.md PRE-CREATION
docs/configurationtutorial.md PRE-CREATION
docs/hooks.md PRE-CREATION
docs/images/CPUavailability.png PRE-CREATION
docs/images/HelloWorldJob.png PRE-CREATION
docs/images/RoleJobs.png PRE-CREATION
docs/images/ScheduledJobs.png PRE-CREATION
docs/images/TaskBreakdown.png PRE-CREATION
docs/images/aurora_hierarchy.png PRE-CREATION
docs/images/killedtask.png PRE-CREATION
docs/images/lifeofatask.png PRE-CREATION
docs/images/runningtask.png PRE-CREATION
docs/images/stderr.png PRE-CREATION
docs/images/stdout.png PRE-CREATION
docs/resourceisolation.md PRE-CREATION
docs/tutorial.md PRE-CREATION
docs/userguide.md PRE-CREATION
Diff: https://reviews.apache.org/r/19313/diff/
Testing
---
Thanks,
Tom Galloway
Re: Review Request 19411: Add support for global hooks.
-- pytest-2.5.2 collected 3 items src/test/python/apache/aurora/client/commands/test_hooks.py ... === 3 passed in 1.03 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py === 4 passed in 0.46 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . === 1 passed in 0.45 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . === 1 passed in 0.46 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 12 items src/test/python/apache/aurora/client/hooks/test_hooked_api.py == 12 passed in 0.46 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py === 4 passed in 0.42 seconds === Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) src.test.python.apache.aurora.client.api.disambiguator . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.hooks . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38147 --- Just FYI: the client unit tests weren't intended to detect stuff like this. The intention of those tests is just to verify that the client logic works - meaning that the client sends the API calls that we expect it to. If an API gets changed in a way that doesn't change the API behavior of the client, then the client API unit tests aren't going to catch it. There really should be tests beyond the simple API ones. For the updated, Maxim wrote some really nice logic tests that bypass the command-line parts, and verify that the API interaction logic is correct. That would be a good model to follow. As far as the thermos stuff goes, I don't see anything in this change that should cause a thermos problem - but I don't know nearly enough about thermos, so I'll defer to Brian, who's the thermos God. - Mark Chu-Carroll On March 20, 2014, 10:39 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/ --- (Updated March 20, 2014, 10:39 p.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman. Bugs: AURORA-246 https://issues.apache.org/jira/browse/AURORA-246 Repository: aurora Description --- Updated the client to consume the new getQuota API which contains nonProdConsumption(resources consumed by non-prod tasks) information also. Currently, the mocked calls can't detect renamed and missing thrift structs. Added tests to look for expected fields in GetQuotaResult and ResourceAggregate structs. Refactored tests in test_quota to remove duplicated code and added a missing test. Diffs - src/main/python/apache/aurora/client/cli/quota.py d06f21a80575058aefa3dffc72b365805d7a5ce2 src/main/python/apache/aurora/client/commands/core.py 9977c725528086d3e8cf58de294adee542570411 src/test/python/apache/aurora/client/cli/test_quota.py 44afd74aa5b11296951f45fe7edca8cb58b0ec18 Diff: https://reviews.apache.org/r/19509/diff/ Testing --- ./pants src/test/python:all -vxs Works for all quota related test. src.test.python.apache.thermos.bin.test_thermos fails on my laptop because of build issues. Sending out a code review since it is an un-related issue. Will look into this tomorrow, if it's a blocker. Found all the code to update by running the following query. ? git:(mansu/AURORA-246_getQuotaAPI) ag getQuotaResult -G '.py' ~/workspace/incubator-aurora src/main/python/apache/aurora/client/api/quota_check.py 90:allocated = CapacityRequest(resp.result.getQuotaResult.quota) 91:consumed = CapacityRequest(resp.result.getQuotaResult.prodConsumption) src/main/python/apache/aurora/client/cli/quota.py 65: return serialize(quota_resp.result.getQuotaResult, 69: result += get_quota_str(quota_resp.result.getQuotaResult.quota) 70: if quota_resp.result.getQuotaResult.prodConsumption: 72:result += get_quota_str(quota_resp.result.getQuotaResult.prodConsumption) 73: if quota_resp.result.getQuotaResult.nonProdConsumption: 75:result += get_quota_str(quota_resp.result.getQuotaResult.nonProdConsumption) src/main/python/apache/aurora/client/commands/admin.py 199: quota = resp.result.getQuotaResult.quota src/main/python/apache/aurora/client/commands/core.py 632: print_quota(resp.result.getQuotaResult.quota, 'Total allocated quota', role) 634: if resp.result.getQuotaResult.prodConsumption: 635:print_quota(resp.result.getQuotaResult.prodConsumption, 639: if resp.result.getQuotaResult.nonProdConsumption: 640:print_quota(resp.result.getQuotaResult.nonProdConsumption, src/test/python/apache/aurora/client/api/test_quota_check.py 49:getQuotaResult=GetQuotaResult( src/test/python/apache/aurora/client/cli/test_quota.py 35:response.result.getQuotaResult = GetQuotaResult() 36:response.result.getQuotaResult.quota = ResourceAggregate() 37:response.result.getQuotaResult.quota.numCpus = 5 38:response.result.getQuotaResult.quota.ramMb = 20480 39:response.result.getQuotaResult.quota.diskMb = 40960 40:response.result.getQuotaResult.consumed = None 47:response.result.getQuotaResult = GetQuotaResult() 48:response.result.getQuotaResult.quota = ResourceAggregate() 49:response.result.getQuotaResult.quota.numCpus = 5 50:response.result.getQuotaResult.quota.ramMb = 20480 51:response.result.getQuotaResult.quota.diskMb = 40960 52:response.result.getQuotaResult.prodConsumption
Re: Review Request 19466: Add batching to the kill and killall commands.
On March 21, 2014, 2:44 p.m., Maxim Khutornenko wrote: src/test/python/apache/aurora/client/cli/test_restart.py, line 43 https://reviews.apache.org/r/19466/diff/1/?file=529930#file529930line43 Right, my comment was about the method in this class that still uses the old reference? It's still accessible as self.setup_get_task_status_calls. All of the tests inherit from AuroraClientCommandTest, where I moved it. On March 21, 2014, 2:44 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/jobs.py, line 317 https://reviews.apache.org/r/19466/diff/1/?file=529926#file529926line317 I hear your point. However, it would be a departure from other places where we use batching (considering the default of max_total_failures=0). I can't find any strong reasons against it apart from consistency reasons, so would be curious what others say. Hmm would it be better if I added the max_total_failures option, and used that to determine whether a batched kill succeeds? - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38154 --- On March 20, 2014, 11:42 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/ --- (Updated March 20, 2014, 11:42 a.m.) Review request for Aurora, Maxim Khutornenko and Brian Wickman. Bugs: aurora-283 https://issues.apache.org/jira/browse/aurora-283 Repository: aurora Description --- Add batching to the kill and killall commands. (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/) Diffs - src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1 src/main/python/apache/aurora/client/cli/options.py 0e0bd45f9506e5dc729a24cd68b04b49650605b6 src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196 src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa src/test/python/apache/aurora/client/cli/test_restart.py aa23d5bfe81361243d82aadf9dc574608e28d953 src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8 Diff: https://reviews.apache.org/r/19466/diff/ Testing --- [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.37 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.47 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.43 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . === 1 passed in 0.40 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. === 6 passed in 0.35 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... = 47 passed, 1 skipped in 3.57 seconds = = test session starts == platform darwin -- Python
Re: Review Request 19396: Implement client command logging with a unique token.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19396/#review38160 --- src/main/python/apache/aurora/client/cli/__init__.py https://reviews.apache.org/r/19396/#comment70132 Honestly, I don't remember why I made print_out and print_err abstract. In terms of which to use, I think that I might have a philosophical difference from some people: I see logs as being fundamentally different from other outputs. Sending output to stdout or stderr is (IMHMO) done for the user: you're communicating with the user about what they asked you to do. Logs are primarily for developers. They're there not so much to communicate with the user, but to provide information about what the system was doing for the people who build/maintain it. If you think of it that way, I think it's clear when to use which. - Mark Chu-Carroll On March 19, 2014, 9:20 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19396/ --- (Updated March 19, 2014, 9:20 a.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-276 https://issues.apache.org/jira/browse/aurora-276 Repository: aurora Description --- Adding a centralized logger interface for clientv2. For the aurora analytics work, we need some hooks for logging. We'd like all client logging to go through a common interface, and for client logs that might be sent to the centralized logging service to be tagged with identifiers and userids. This change implements a simple minimal logging function that's used by clientv2 logging calls, and which attaches a universally unique client identifier to each log message. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 4a6a7eef7b781be79a3d40776a3bd6f0c6e8c4c0 src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1 src/test/python/apache/aurora/client/cli/BUILD a48284c8cffa64b56760f8e0c587506caf1289a6 src/test/python/apache/aurora/client/cli/test_logging.py PRE-CREATION Diff: https://reviews.apache.org/r/19396/diff/ Testing --- = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.37 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.46 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.45 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . === 1 passed in 0.39 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. === 6 passed in 0.36 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... = 47 passed, 1 skipped in 3.59 seconds = = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py == 20 passed in 0.25 seconds === = test
Re: Review Request 19431: Add instance specifier syntax to clientv2
. SUCCESS
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
[sun-wukong incubator-aurora (instance-syntax)]$
[sun-wukong incubator-aurora (instance-syntax)]$ grep INSTANCES_OPTION
src/main/python/apache/aurora/client/cli/*.py
src/main/python/apache/aurora/client/cli/options.py:INSTANCES_OPTION =
CommandOption('--instances', type=parse_instances, dest='instances',
src/main/python/apache/aurora/client/cli/task.py:INSTANCES_OPTION,
[sun-wukong incubator-aurora (instance-syntax)]$ ./pants
src/test/python/apache/aurora/client/cli:all
Build operating on targets:
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items
src/test/python/apache/aurora/client/cli/test_bridge.py
=== 4 passed in 0.02 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items
src/test/python/apache/aurora/client/cli/test_help.py .
=== 5 passed in 0.47 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items
src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...
== 27 passed in 1.65 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/cli/test_plugins.py ..
=== 2 passed in 0.51 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 3 items
src/test/python/apache/aurora/client/cli/test_quota.py ...
=== 3 passed in 0.49 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items
src/test/python/apache/aurora/client/cli/test_sla.py .
=== 5 passed in 0.53 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/cli/test_task_run.py ..
=== 2 passed in 0.53 seconds ===
src.test.python.apache.aurora.client.cli.bridge
. SUCCESS
src.test.python.apache.aurora.client.cli.help
. SUCCESS
src.test.python.apache.aurora.client.cli.job
. SUCCESS
src.test.python.apache.aurora.client.cli.plugins
. SUCCESS
src.test.python.apache.aurora.client.cli.quota
. SUCCESS
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38205 --- Ship it! Ship It! - Mark Chu-Carroll On March 20, 2014, 10:39 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/ --- (Updated March 20, 2014, 10:39 p.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman. Bugs: AURORA-246 https://issues.apache.org/jira/browse/AURORA-246 Repository: aurora Description --- Updated the client to consume the new getQuota API which contains nonProdConsumption(resources consumed by non-prod tasks) information also. Currently, the mocked calls can't detect renamed and missing thrift structs. Added tests to look for expected fields in GetQuotaResult and ResourceAggregate structs. Refactored tests in test_quota to remove duplicated code and added a missing test. Diffs - src/main/python/apache/aurora/client/cli/quota.py d06f21a80575058aefa3dffc72b365805d7a5ce2 src/main/python/apache/aurora/client/commands/core.py 9977c725528086d3e8cf58de294adee542570411 src/test/python/apache/aurora/client/cli/test_quota.py 44afd74aa5b11296951f45fe7edca8cb58b0ec18 Diff: https://reviews.apache.org/r/19509/diff/ Testing --- ./pants src/test/python:all -vxs Works for all quota related test. src.test.python.apache.thermos.bin.test_thermos fails on my laptop because of build issues. Sending out a code review since it is an un-related issue. Will look into this tomorrow, if it's a blocker. Found all the code to update by running the following query. ? git:(mansu/AURORA-246_getQuotaAPI) ag getQuotaResult -G '.py' ~/workspace/incubator-aurora src/main/python/apache/aurora/client/api/quota_check.py 90:allocated = CapacityRequest(resp.result.getQuotaResult.quota) 91:consumed = CapacityRequest(resp.result.getQuotaResult.prodConsumption) src/main/python/apache/aurora/client/cli/quota.py 65: return serialize(quota_resp.result.getQuotaResult, 69: result += get_quota_str(quota_resp.result.getQuotaResult.quota) 70: if quota_resp.result.getQuotaResult.prodConsumption: 72:result += get_quota_str(quota_resp.result.getQuotaResult.prodConsumption) 73: if quota_resp.result.getQuotaResult.nonProdConsumption: 75:result += get_quota_str(quota_resp.result.getQuotaResult.nonProdConsumption) src/main/python/apache/aurora/client/commands/admin.py 199: quota = resp.result.getQuotaResult.quota src/main/python/apache/aurora/client/commands/core.py 632: print_quota(resp.result.getQuotaResult.quota, 'Total allocated quota', role) 634: if resp.result.getQuotaResult.prodConsumption: 635:print_quota(resp.result.getQuotaResult.prodConsumption, 639: if resp.result.getQuotaResult.nonProdConsumption: 640:print_quota(resp.result.getQuotaResult.nonProdConsumption, src/test/python/apache/aurora/client/api/test_quota_check.py 49:getQuotaResult=GetQuotaResult( src/test/python/apache/aurora/client/cli/test_quota.py 35:response.result.getQuotaResult = GetQuotaResult() 36:response.result.getQuotaResult.quota = ResourceAggregate() 37:response.result.getQuotaResult.quota.numCpus = 5 38:response.result.getQuotaResult.quota.ramMb = 20480 39:response.result.getQuotaResult.quota.diskMb = 40960 40:response.result.getQuotaResult.consumed = None 47:response.result.getQuotaResult = GetQuotaResult() 48:response.result.getQuotaResult.quota = ResourceAggregate() 49:response.result.getQuotaResult.quota.numCpus = 5 50:response.result.getQuotaResult.quota.ramMb = 20480 51:response.result.getQuotaResult.quota.diskMb = 40960 52:response.result.getQuotaResult.prodConsumption = ResourceAggregate() 53:response.result.getQuotaResult.prodConsumption.numCpus = 1 54:response.result.getQuotaResult.prodConsumption.ramMb = 1024 55:response.result.getQuotaResult.prodConsumption.diskMb = 2048 56:response.result.getQuotaResult.nonProdConsumption = ResourceAggregate() 57:response.result.getQuotaResult.nonProdConsumption.numCpus = 1 58:response.result.getQuotaResult.nonProdConsumption.ramMb = 1024 59:response.result.getQuotaResult.nonProdConsumption.diskMb = 2048 ? git:(mansu/AURORA-246_getQuotaAPI) ~/workspace/incubator-aurora Thanks, Suman Karumuri
