---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45408
---
Ship it!
cool, lgtm other than ~nits
On June 11, 2014, 6:47 p.m., Joe Smith wrote:
src/main/python/apache/aurora/admin/admin_util.py, line 111
https://reviews.apache.org/r/22167/diff/6/?file=607111#file607111line111
parse_hostnames
Done.
On June 11, 2014, 6:47 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/
---
(Updated June 11, 2014, 7:43 p.m.)
Review request for Aurora, Joe Smith, Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45109
---
src/main/python/apache/aurora/admin/admin_util.py
On June 9, 2014, 7:17 p.m., Mark Chu-Carroll wrote:
src/main/python/apache/aurora/admin/admin_util.py, line 14
https://reviews.apache.org/r/22167/diff/3/?file=603310#file603310line14
Are you sure you uploaded the correct diff? In your reply to the
review, you said you'd added
On June 9, 2014, 8:43 p.m., Mark Chu-Carroll wrote:
src/main/python/apache/aurora/admin/admin_util.py, line 88
https://reviews.apache.org/r/22167/diff/3/?file=603310#file603310line88
You've got parse_hosts, parst_host_file, parse_hosts_optional,
and parse_host_list. I have no
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/
---
(Updated June 9, 2014, 10:08 p.m.)
Review request for Aurora, Joe Smith, Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45164
---
Ship it!
Ship It!
- Mark Chu-Carroll
On June 9, 2014, 6:08
On June 9, 2014, 4:43 p.m., Mark Chu-Carroll wrote:
src/main/python/apache/aurora/client/commands/maintenance.py, line 72
https://reviews.apache.org/r/22167/diff/3/?file=603316#file603316line72
This help line is unclear: what does time interval for the percentage
of up tasks
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/
---
(Updated June 9, 2014, 11:10 p.m.)
Review request for Aurora, Joe Smith, Mark
On June 9, 2014, 8:43 p.m., Mark Chu-Carroll wrote:
src/main/python/apache/aurora/client/commands/maintenance.py, line 72
https://reviews.apache.org/r/22167/diff/3/?file=603316#file603316line72
This help line is unclear: what does time interval for the percentage
of up tasks
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45175
---
Ping, Brian/Joe.
- Maxim Khutornenko
On June 9, 2014, 11:10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review44684
---
src/main/python/apache/aurora/admin/admin_util.py
On June 4, 2014, 1:37 a.m., Mark Chu-Carroll wrote:
src/main/python/apache/aurora/admin/admin_util.py, line 14
https://reviews.apache.org/r/22167/diff/2/?file=602083#file602083line14
This really needs some doc comments. I can figure out what individual
functions do, but I have no
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/
---
(Updated June 4, 2014, 1:46 a.m.)
Review request for Aurora, Joe Smith, Mark
15 matches
Mail list logo
