Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/ --- (Updated June 11, 2014, 7:43 p.m.) Review request for Aurora, Joe Smith, Mark C

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

> On June 11, 2014, 6:47 p.m., Joe Smith wrote: > > src/main/python/apache/aurora/admin/admin_util.py, line 111 > > > > > > parse_hostnames Done. > On June 11, 2014, 6:47 p.m., Joe Smith wrote: > > src/main/python/a

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/#review45408 --- Ship it! cool, lgtm other than ~nits src/main/python/apache/auror

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/ --- (Updated June 11, 2014, 5:04 p.m.) Review request for Aurora, Joe Smith, Mark C

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/#review45175 --- Ping, Brian/Joe. - Maxim Khutornenko On June 9, 2014, 11:10 p.m.,

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

> On June 9, 2014, 8:43 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/commands/maintenance.py, line 72 > > > > > > This help line is unclear: what does "time interval for the percentage > > of

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/ --- (Updated June 9, 2014, 11:10 p.m.) Review request for Aurora, Joe Smith, Mark C

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/#review45164 --- Ship it! Ship It! - Mark Chu-Carroll On June 9, 2014, 6:08 p.m.,

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

> On June 9, 2014, 4:43 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/commands/maintenance.py, line 72 > > > > > > This help line is unclear: what does "time interval for the percentage > > of

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/ --- (Updated June 9, 2014, 10:08 p.m.) Review request for Aurora, Joe Smith, Mark C

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

> On June 9, 2014, 8:43 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/admin/admin_util.py, line 88 > > > > > > You've got "parse_hosts", "parst_host_file", "parse_hosts_optional", > > and "parse_host_

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/#review45131 --- src/main/python/apache/aurora/admin/admin_util.py

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

> On June 9, 2014, 7:17 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/admin/admin_util.py, line 14 > > > > > > Are you sure you uploaded the correct diff? In your reply to the > > review, you said you

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/#review45109 --- src/main/python/apache/aurora/admin/admin_util.py

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/#review45082 --- Ping. - Maxim Khutornenko On June 4, 2014, 1:46 a.m., Maxim Khuto

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/ --- (Updated June 4, 2014, 1:46 a.m.) Review request for Aurora, Joe Smith, Mark Ch

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

> On June 4, 2014, 1:37 a.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/admin/admin_util.py, line 14 > > > > > > This really needs some doc comments. I can figure out what individual > > functions do, b

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/#review44684 --- src/main/python/apache/aurora/admin/admin_util.py