---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/#review58299
---
Does it make sense to use the ReviewBoard Python client from
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/#review58301
---
Ship it!
build-support/jenkins/review_feedback.py
On Oct. 24, 2014, 5:57 p.m., Joshua Cohen wrote:
Does it make sense to use the ReviewBoard Python client from rbtools?
https://www.reviewboard.org/docs/rbtools/0.5/api/overview/
What is the plan to actually run this script? Is it safe to assume that it
will be executed from an up
On Oct. 24, 2014, 5:57 p.m., Joshua Cohen wrote:
Does it make sense to use the ReviewBoard Python client from rbtools?
https://www.reviewboard.org/docs/rbtools/0.5/api/overview/
What is the plan to actually run this script? Is it safe to assume that it
will be executed from an up
On Oct. 24, 2014, 8:06 p.m., Kevin Sweeney wrote:
build-support/jenkins/review_feedback.py, line 39
https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line39
Use print() as a function, here and throughout
Done.
On Oct. 24, 2014, 8:06 p.m., Kevin Sweeney wrote:
On Oct. 24, 2014, 8:57 p.m., Maxim Khutornenko wrote:
build-support/jenkins/review_feedback.py, lines 37-38
https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line37
replace with ternary?
Done.
On Oct. 24, 2014, 8:57 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/
---
(Updated Oct. 24, 2014, 9:42 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/#review58391
---
Ship it!
Can you document your exit codes somewhere?
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/#review58392
---
+1: Master (5be667f) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/#review58396
---
Ship it!
Ship It!
- Joshua Cohen
On Oct. 24, 2014, 9:42 p.m.,
On Oct. 24, 2014, 2:49 p.m., Zameer Manji wrote:
Can you document your exit codes somewhere?
Bill Farner wrote:
Is that worthwhile? If it means documenting, i'd rather not vary them at
all. I don't think this is something that should be scripted against.
I asumed you varried them
On Oct. 24, 2014, 9:49 p.m., Zameer Manji wrote:
Can you document your exit codes somewhere?
Bill Farner wrote:
Is that worthwhile? If it means documenting, i'd rather not vary them at
all. I don't think this is something that should be scripted against.
Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/
---
(Updated Oct. 24, 2014, 10:42 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/#review58423
---
+1: Master (f98bec7) is green with this patch.
14 matches
Mail list logo
