Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-13 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/ --- (Updated Nov. 13, 2014, 7:32 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-13 Thread David McLaughlin
On Nov. 13, 2014, 4:14 a.m., Kevin Sweeney wrote: src/test/python/apache/aurora/client/cli/test_restart.py, line 16 https://reviews.apache.org/r/27848/diff/3-5/?file=757413#file757413line16 strange place for an import - should be in the 3rdparty section. did you run isort-run?

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-13 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/#review61304 --- @ReviewBot retry - David McLaughlin On Nov. 13, 2014, 7:32 p.m.,

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/#review61320 --- Ship it! Master (f8040b9) is green with this patch.

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-12 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/#review61120 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-12 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/ --- (Updated Nov. 13, 2014, 1:48 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-12 Thread David McLaughlin
On Nov. 13, 2014, 12:36 a.m., Kevin Sweeney wrote: src/main/python/apache/aurora/client/cli/jobs.py, line 331 https://reviews.apache.org/r/27848/diff/3/?file=757409#file757409line331 weird wrapping - consider wrapping the whole statement in parens so there is one condition per

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/#review61175 --- This patch does not apply cleanly on master (6950d50), do you need

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-12 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/ --- (Updated Nov. 13, 2014, 1:45 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-12 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/#review61201 --- Ship it! lgtm once bot agrees, please follow-up with a ticket for

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/#review60892 --- Ship it! src/main/python/apache/aurora/client/cli/context.py

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-11 Thread David McLaughlin
On Nov. 12, 2014, 1:28 a.m., Bill Farner wrote: src/main/python/apache/aurora/client/cli/context.py, line 152 https://reviews.apache.org/r/27848/diff/3/?file=757408#file757408line152 Is this going to produce some redundant output? See reply below, not sure why it didn't reply

Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-10 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-885

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-10 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/ --- (Updated Nov. 11, 2014, 12:29 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/#review60723 --- Master (01958b1) is red with this patch.

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-10 Thread David McLaughlin
On Nov. 11, 2014, 12:43 a.m., Aurora ReviewBot wrote: Master (01958b1) is red with this patch. ./build-support/jenkins/build.sh Skipping installation of

Re: Review Request 27848: Add friendly error message to the client when lock is held.

2014-11-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/#review60728 --- Ship it! Master (01958b1) is green with this patch.