Re: Review Request 29117: Adding thrift API changes document.

2015-02-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/ --- (Updated Feb. 13, 2015, 12:35 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 29117: Adding thrift API changes document.

2015-02-12 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/#review72291 --- docs/thrift-deprecation.md

Re: Review Request 29117: Adding thrift API changes document.

2015-02-12 Thread Maxim Khutornenko
On Feb. 13, 2015, 12:41 a.m., David McLaughlin wrote: docs/thrift-deprecation.md, line 20 https://reviews.apache.org/r/29117/diff/4/?file=862696#file862696line20 Sorry I missed this first review, but AFAIK this isn't true for dynamic languages (incl. our own scheduler UI)? Can

Re: Review Request 29117: Adding thrift API changes document.

2015-02-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/#review72295 --- Ship it! Master (b62ec61) is green with this patch.

Re: Review Request 29117: Adding thrift API changes document.

2015-02-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/#review70652 --- Ship it! Ship It! - Bill Farner On Jan. 21, 2015, 10:59 p.m.,

Re: Review Request 29117: Adding thrift API changes document.

2015-01-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/#review69071 --- This patch does not apply cleanly on master (116ee2d), do you need

Re: Review Request 29117: Adding thrift API changes document.

2015-01-21 Thread Bill Farner
On Jan. 9, 2015, 6:44 p.m., Bill Farner wrote: docs/thrift-deprecation.md, line 31 https://reviews.apache.org/r/29117/diff/2/?file=793344#file793344line31 There should be an item about logging and signaling in API responses when deprecated fields are used. Maxim Khutornenko

Re: Review Request 29117: Adding thrift API changes document.

2015-01-21 Thread Maxim Khutornenko
On Jan. 9, 2015, 6:44 p.m., Bill Farner wrote: docs/developing-aurora-client.md, line 124 https://reviews.apache.org/r/29117/diff/2/?file=793342#file793342line124 s/thrift/Thrift/ Uppercased everywhere. On Jan. 9, 2015, 6:44 p.m., Bill Farner wrote: docs/thrift-deprecation.md,

Re: Review Request 29117: Adding thrift API changes document.

2015-01-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/ --- (Updated Jan. 21, 2015, 10:59 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 29117: Adding thrift API changes document.

2015-01-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/#review67471 --- docs/developing-aurora-client.md

Re: Review Request 29117: Adding thrift API changes document.

2015-01-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/ --- (Updated Jan. 6, 2015, 11:30 p.m.) Review request for Aurora, Kevin Sweeney

Review Request 29117: Adding thrift API changes document.

2014-12-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-973

Re: Review Request 29117: Adding thrift API changes document.

2014-12-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/ --- (Updated Dec. 16, 2014, 10:29 p.m.) Review request for Aurora and Kevin

Re: Review Request 29117: Adding thrift API changes document.

2014-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/#review65255 --- Ship it! Master (95ad0fa) is green with this patch.