---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52465
---
Ship it!
awesome joe. thanks for doing this.
- Brian Wickman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/
---
(Updated Sept. 5, 2014, 9:32 a.m.)
Review request for Aurora, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52318
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 4, 2014, 3:50 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52332
---
Discussed offline but it probably makes sense to not do any status
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/
---
(Updated Sept. 4, 2014, 5:24 p.m.)
Review request for Aurora, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52387
---
src/test/python/apache/aurora/executor/test_thermos_executor.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/
---
(Updated Sept. 4, 2014, 5:43 p.m.)
Review request for Aurora, David
On Sept. 4, 2014, 5:39 p.m., Zameer Manji wrote:
src/test/python/apache/aurora/executor/test_thermos_executor.py, line 395
https://reviews.apache.org/r/25337/diff/2/?file=679158#file679158line395
I don't think this is supposed to be here.
whew, still pass.
- Joe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52389
---
\m/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52393
---
Ship it!
LGTM mod HttpSignaler mocking.
- Maxim Khutornenko
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/
---
(Updated Sept. 4, 2014, 6:20 p.m.)
Review request for Aurora, David
On Sept. 4, 2014, 5:50 p.m., Brian Wickman wrote:
src/main/python/apache/aurora/executor/common/health_checker.py, lines
131-132
https://reviews.apache.org/r/25337/diff/2/?file=679153#file679153line131
make _healthy and _reason non-private
done
On Sept. 4, 2014, 5:50 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52395
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52397
---
Ship it!
lgtm.
- David McLaughlin
On Sept. 5, 2014, 1:20 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/
---
(Updated Sept. 4, 2014, 8 p.m.)
Review request for Aurora, David McLaughlin,
On Sept. 4, 2014, 6:23 p.m., David Robinson wrote:
src/test/python/apache/aurora/executor/common/test_health_checker.py, line
60
https://reviews.apache.org/r/25337/diff/3/?file=679164#file679164line60
Why do you need to cast num_calls?
leftover from the previous test (I
16 matches
Mail list logo
