On Jan. 15, 2015, 10:07 p.m., Bill Farner wrote:
src/main/python/apache/aurora/client/cli/context.py, line 218
https://reviews.apache.org/r/29873/diff/2/?file=822909#file822909line218
why convert an empty list to `None`?
Blind following to the above pattern. No reason, dropped.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29873/
---
(Updated Jan. 15, 2015, 7:44 p.m.)
Review request for Aurora and Bill Farner.
On Jan. 14, 2015, 7:27 p.m., Bill Farner wrote:
src/test/python/apache/aurora/client/cli/test_kill.py, line 146
https://reviews.apache.org/r/29873/diff/1/?file=820323#file820323line146
While you're in here, can you take a stab at renaming
`create_mock_task` to `create_task`, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29873/#review68344
---
Ship it!
Master (1acb428) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29873/#review68329
---
Ship it!
src/main/python/apache/aurora/client/cli/context.py
On Jan. 14, 2015, 7:26 p.m., Bill Farner wrote:
Also, dropped active instance validation from both updater calls as it
was hiding a legitimate feature: add new job instances with instance_spec.
I may have missed it - do unit tests verify this new behavior?
The updater.py tests do.
On Jan. 14, 2015, 7:27 p.m., Bill Farner wrote:
src/test/python/apache/aurora/client/cli/test_kill.py, line 146
https://reviews.apache.org/r/29873/diff/1/?file=820323#file820323line146
While you're in here, can you take a stab at renaming
`create_mock_task` to `create_task`, and
On Jan. 14, 2015, 7:21 p.m., Bill Farner wrote:
src/main/python/apache/aurora/client/cli/context.py, line 214
https://reviews.apache.org/r/29873/diff/1/?file=820320#file820320line214
Seems like it would make sense for this to be the default behavior of
`get_job_status`. I can't
On Jan. 14, 2015, 7:21 p.m., Bill Farner wrote:
src/main/python/apache/aurora/client/cli/context.py, line 214
https://reviews.apache.org/r/29873/diff/1/?file=820320#file820320line214
Seems like it would make sense for this to be the default behavior of
`get_job_status`. I can't
On Jan. 14, 2015, 7:26 p.m., Bill Farner wrote:
Also, dropped active instance validation from both updater calls as it
was hiding a legitimate feature: add new job instances with instance_spec.
I may have missed it - do unit tests verify this new behavior?
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29873/
---
Review request for Aurora and Bill Farner.
Bugs: AURORA-996
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29873/#review68008
---
Master (a350982) is red with this patch.
12 matches
Mail list logo