Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-30 Thread Florian Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/ --- (Updated Jan. 30, 2015, 7:18 nachm.) Review request for Aurora, Bill Farner

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review70422 --- Ship it! Master (4f04a34) is green with this patch.

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review70407 --- Ship it! Ship It! - Zameer Manji On Jan. 30, 2015, 11:18 a.m.,

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review70384 --- Florian, can you remove the two empty lines Bill has pointed out?

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69852 --- Ship it! Thanks, this looks great! LGTM once two rogue newlines

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69854 --- @ReviewBot retry - Bill Farner On Jan. 27, 2015, 1:08 a.m.,

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69945 --- Ship it! Master (46a0466) is green with this patch.

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-26 Thread Bill Farner
On Jan. 26, 2015, 10:14 a.m., Aurora ReviewBot wrote: Master (7ba6226) is red with this patch. ./build-support/jenkins/build.sh :assemble :compileJmhJavawarning: Supported source version 'RELEASE_6' from annotation processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-26 Thread Florian Pfeiffer
On Jan. 26, 2015, 11:19 nachm., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java, line 413 https://reviews.apache.org/r/30010/diff/6/?file=833613#file833613line413 s/public // Feeling kind of stupid here, I somehow thought this

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69724 --- Master (0cb40d1) is red with this patch.

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-26 Thread Florian Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/ --- (Updated Jan. 27, 2015, 1:08 vorm.) Review request for Aurora, Bill Farner and

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69594 --- Master (7ba6226) is red with this patch.

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69688 --- Looks great to me, thanks for retaining the legacy behavior! I'm

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69573 --- This patch does not apply cleanly on master (7ba6226), do you need

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-23 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69508 ---

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-23 Thread Florian Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/ --- (Updated Jan. 23, 2015, 9:20 vorm.) Review request for Aurora, Bill Farner and

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69375 --- Ship it! Master (3fa004b) is green with this patch.

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-22 Thread Florian Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/ --- (Updated Jan. 23, 2015, 2:55 vorm.) Review request for Aurora, Bill Farner and

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69346 --- Master (3fa004b) is red with this patch.

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-21 Thread Bill Farner
On Jan. 21, 2015, 6:53 p.m., Zameer Manji wrote: I talked with Florian offline and the next step for this patch is to add CLI flags so this legacy behaviour can be enabled. This way we don't break backwards compatability and users who rely on this behaviour don't get a nasty surprise

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-21 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review68963 --- I talked with Florian offline and the next step for this patch is

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-21 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review68962 ---

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-20 Thread Florian Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/ --- (Updated Jan. 20, 2015, 9:46 nachm.) Review request for Aurora, Bill Farner

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-20 Thread Florian Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review68785 --- @ReviewBot retry - Florian Pfeiffer On Jan. 20, 2015, 9:46

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review68792 --- Ship it! Master (c37de9a) is green with this patch.

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-20 Thread Florian Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/ --- (Updated Jan. 20, 2015, 7:20 nachm.) Review request for Aurora and Zameer

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-20 Thread Florian Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/ --- (Updated Jan. 20, 2015, 7:21 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-17 Thread Florian Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/ --- (Updated Jan. 18, 2015, 4:06 vorm.) Review request for Aurora and Zameer

Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-17 Thread Florian Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/ --- Review request for Aurora. Repository: aurora Description ---