Re: Review Request 30818: Support separate routes for job controller tabs.

2015-03-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30818/#review76737 --- Update or discard? - Bill Farner On Feb. 10, 2015, 6:01 a.m.,

Re: Review Request 30818: Support separate routes for job controller tabs.

2015-02-11 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30818/#review71999 --- src/main/resources/scheduler/assets/js/controllers.js

Re: Review Request 30818: Support separate routes for job controller tabs.

2015-02-11 Thread David McLaughlin
On Feb. 11, 2015, 6:58 p.m., David McLaughlin wrote: src/main/resources/scheduler/assets/js/controllers.js, line 338 https://reviews.apache.org/r/30818/diff/2/?file=859882#file859882line338 You should never have to do this with routes in Angular. I think this is a code smell from

Re: Review Request 30818: Support separate routes for job controller tabs.

2015-02-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30818/#review71760 --- Master (68aa285) is red with this patch.

Review Request 30818: Support separate routes for job controller tabs.

2015-02-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30818/ --- Review request for Aurora and David McLaughlin. Bugs: AURORA-696

Re: Review Request 30818: Support separate routes for job controller tabs.

2015-02-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30818/#review71762 --- Master (68aa285) is green with this patch.

Re: Review Request 30818: Support separate routes for job controller tabs.

2015-02-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30818/ --- (Updated Feb. 10, 2015, 6:01 a.m.) Review request for Aurora and David

Re: Review Request 30818: Support separate routes for job controller tabs.

2015-02-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30818/ --- (Updated Feb. 10, 2015, 6:01 a.m.) Review request for Aurora and David