Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32141/ --- (Updated March 17, 2015, 11:55 a.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32141/#review76774 --- Ship it!

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32141/ --- (Updated March 17, 2015, 12:18 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32141/#review76787 --- Ship it!

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Joshua Cohen
On March 17, 2015, 7:56 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java, line 39 https://reviews.apache.org/r/32141/diff/5/?file=898006#file898006line39 Can you add a corresponding comment to api.thrift that any new methods

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32141/ --- (Updated March 17, 2015, 12:16 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Kevin Sweeney
On March 17, 2015, 12:56 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java, line 39 https://reviews.apache.org/r/32141/diff/5/?file=898006#file898006line39 Can you add a corresponding comment to api.thrift that any new

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32141/ --- (Updated March 17, 2015, 1:03 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32141/#review76790 --- Ship it! Master (38d0a6c) is green with this patch.

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32141/ --- (Updated March 17, 2015, 12:41 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32141/#review76783 --- Master (38d0a6c) is red with this patch.

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32141/#review76735 --- Ship it! LGTM mod nits below and satisfying the build bot.

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32141/#review76741 ---

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32141/#review76692 --- Master (2f99106) is red with this patch.

Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32141/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1187