[GitHub] bahir issue #48: [BAHIR-122] [PubSub] Make "ServiceAccountCredentials" reall...

2017-07-26 Thread ire7715
Github user ire7715 commented on the issue: https://github.com/apache/bahir/pull/48 Thanks @ckadner for reviewing 😄 ### Re: not-force pushing Since it is preferable to push changes as other commit, and the PR will be squashed when merging. I had recovered the origin

[GitHub] bahir issue #48: [BAHIR-122] [PubSub] Make "ServiceAccountCredentials" reall...

2017-07-26 Thread ApacheBahir
Github user ApacheBahir commented on the issue: https://github.com/apache/bahir/pull/48 Build successful --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] bahir issue #48: [BAHIR-122] [PubSub] Make "ServiceAccountCredentials" reall...

2017-07-26 Thread ApacheBahir
Github user ApacheBahir commented on the issue: https://github.com/apache/bahir/pull/48 thanks @ire7715 -- I have a few remarks regarding your latest comment: --- > Don't know if the force push would bother you when reviewing Thanks for not force-pushing :+1: