[GitHub] [helix] pkuwm commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

pkuwm commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338382028 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java ##

[GitHub] [helix] pkuwm opened a new pull request #531: Make log clearer after finishing calculateAssignment.

pkuwm opened a new pull request #531: Make log clearer after finishing calculateAssignment. URL: https://github.com/apache/helix/pull/531 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: Fix #530 . ### Description

[GitHub] [helix] narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338369641 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338370184 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] pkuwm commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

pkuwm commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338345352 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java ##

[GitHub] [helix] pkuwm commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

pkuwm commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338341178 ## File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/TestWagedRebalancerMetrics.java

[GitHub] [helix] pkuwm commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

pkuwm commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338340059 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java ##

[GitHub] [helix] pkuwm commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

pkuwm commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338339330 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/WagedRebalancer.java ##

[GitHub] [helix] jiajunwang commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

jiajunwang commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338324820 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/WagedRebalancer.java

[GitHub] [helix] jiajunwang commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

jiajunwang commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338325578 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] jiajunwang commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

jiajunwang commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338325325 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] jiajunwang commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

jiajunwang commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338331379 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338328987 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338329076 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/metrics/implementation/RebalanceCounter.java

[GitHub] [helix] narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338328593 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338328841 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java

[GitHub] [helix] narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338329667 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338327999 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/WagedRebalancer.java

[GitHub] [helix] narendly opened a new issue #529: Make AssignmentMetadataStore static

narendly opened a new issue #529: Make AssignmentMetadataStore static URL: https://github.com/apache/helix/issues/529 ZKBucketDataAccessor has a GC logic, but this is only valid if the ZkClient inside it is active and not closed. Currently, WAGED rebalancer generates an instance of

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r338310530 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] pkuwm commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

pkuwm commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338306583 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java ##

[GitHub] [helix] pkuwm commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

pkuwm commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r338302950 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java ##

[GitHub] [helix] openrefactory opened a new pull request #528: Suggested fixes by iCR, OpenRefactory, Inc.

openrefactory opened a new pull request #528: Suggested fixes by iCR, OpenRefactory, Inc. URL: https://github.com/apache/helix/pull/528 OpenRefactory introduces fixers, that automatically fix safety, security, reliability and compliance issues. We ran OpenRefactory's Intelligent Code

[GitHub] [helix] jiajunwang commented on issue #519: Refine the rebalance scope calculating logic in the WAGED rebalancer.

jiajunwang commented on issue #519: Refine the rebalance scope calculating logic in the WAGED rebalancer. URL: https://github.com/apache/helix/pull/519#issuecomment-545335649 > I know this is nitpicky, but it really helps if I know what's going on clearly :) @narendly No worry,

[GitHub] [helix] jiajunwang commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer.

jiajunwang commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer. URL: https://github.com/apache/helix/pull/519#discussion_r337876600 ## File path:

[GitHub] [helix] pkuwm commented on issue #484: Fix RoutingDataCache always requiring full refresh for current state.

pkuwm commented on issue #484: Fix RoutingDataCache always requiring full refresh for current state. URL: https://github.com/apache/helix/pull/484#issuecomment-545294973 > @pkuwm Any update on this PR? :) I am on track. Will complete a unit test for this after metrics work is done.

[GitHub] [helix] pkuwm closed issue #503: Null returned for instance stoppable check when connection refused

pkuwm closed issue #503: Null returned for instance stoppable check when connection refused URL: https://github.com/apache/helix/issues/503 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] jiajunwang commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer.

jiajunwang commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer. URL: https://github.com/apache/helix/pull/519#discussion_r337870167 ## File path:

[GitHub] [helix] narendly commented on issue #484: Fix RoutingDataCache always requiring full refresh for current state.

narendly commented on issue #484: Fix RoutingDataCache always requiring full refresh for current state. URL: https://github.com/apache/helix/pull/484#issuecomment-545289868 @pkuwm Any update on this PR? :) This is an

[GitHub] [helix] narendly merged pull request #504: Fix null response for instance stoppable check when connection refused.

narendly merged pull request #504: Fix null response for instance stoppable check when connection refused. URL: https://github.com/apache/helix/pull/504 This is an automated message from the Apache Git Service. To respond

[GitHub] [helix] jiajunwang commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer.

jiajunwang commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer. URL: https://github.com/apache/helix/pull/519#discussion_r337868386 ## File path:

[GitHub] [helix] narendly commented on issue #520: Refactoring soft constraints to simply the algorithm and fix potential issues.

narendly commented on issue #520: Refactoring soft constraints to simply the algorithm and fix potential issues. URL: https://github.com/apache/helix/pull/520#issuecomment-545289039 @jiajunwang Okay. I understand the difficulty around separating things. Let's sync up offline. I

[GitHub] [helix] jiajunwang commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer.

jiajunwang commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer. URL: https://github.com/apache/helix/pull/519#discussion_r337867981 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer.

narendly commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer. URL: https://github.com/apache/helix/pull/519#discussion_r337867348 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer.

narendly commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer. URL: https://github.com/apache/helix/pull/519#discussion_r337865871 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer.

narendly commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer. URL: https://github.com/apache/helix/pull/519#discussion_r337866674 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer.

narendly commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer. URL: https://github.com/apache/helix/pull/519#discussion_r337866205 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer.

narendly commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer. URL: https://github.com/apache/helix/pull/519#discussion_r337865434 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer.

narendly commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer. URL: https://github.com/apache/helix/pull/519#discussion_r337865665 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer.

narendly commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer. URL: https://github.com/apache/helix/pull/519#discussion_r337864806 ## File path:

[GitHub] [helix] narendly commented on issue #527: NIT: `CHANGE_TYPES_REQUIRING_GLOBAL_REBALANCE` would be correct technically.

narendly commented on issue #527: NIT: `CHANGE_TYPES_REQUIRING_GLOBAL_REBALANCE` would be correct technically. URL: https://github.com/apache/helix/issues/527#issuecomment-545286320 In WagedRebalaner.java. This is an

[GitHub] [helix] jiajunwang commented on issue #520: Refactoring soft constraints to simply the algorithm and fix potential issues.

jiajunwang commented on issue #520: Refactoring soft constraints to simply the algorithm and fix potential issues. URL: https://github.com/apache/helix/pull/520#issuecomment-545285793 > @jiajunwang Also from now on, please try to keep PRs separate. Structural changes could go in one PR,

[GitHub] [helix] narendly commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer.

narendly commented on a change in pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer. URL: https://github.com/apache/helix/pull/519#discussion_r337798058 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r337864084 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/metrics/model/RatioMetric.java ## @@

[GitHub] [helix] narendly commented on issue #526: Need a better way to verify (wait) if the partition assignment converged or not.

narendly commented on issue #526: Need a better way to verify (wait) if the partition assignment converged or not. URL: https://github.com/apache/helix/issues/526#issuecomment-545284553 +1. Thanks for creating an issue for this.

[GitHub] [helix] narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics URL: https://github.com/apache/helix/pull/525#discussion_r337863774 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #520: Refactoring soft constraints to simply the algorithm and fix potential issues.

jiajunwang commented on a change in pull request #520: Refactoring soft constraints to simply the algorithm and fix potential issues. URL: https://github.com/apache/helix/pull/520#discussion_r337862089 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #520: Refactoring soft constraints to simply the algorithm and fix potential issues.

jiajunwang commented on a change in pull request #520: Refactoring soft constraints to simply the algorithm and fix potential issues. URL: https://github.com/apache/helix/pull/520#discussion_r337862002 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #520: Refactoring soft constraints to simply the algorithm and fix potential issues.

jiajunwang commented on a change in pull request #520: Refactoring soft constraints to simply the algorithm and fix potential issues. URL: https://github.com/apache/helix/pull/520#discussion_r337861514 ## File path: