[GitHub] [helix] alirezazamani commented on a change in pull request #589: Add CloudConfig operations

2019-11-15 Thread GitBox
alirezazamani commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r347059744 ## File path: helix-core/src/main/java/org/apache/helix/model/CloudConfig.java ## @@ -0,0 +1,120 @@ +package

[GitHub] [helix] alirezazamani commented on a change in pull request #589: Add CloudConfig operations

2019-11-15 Thread GitBox
alirezazamani commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r347059617 ## File path: helix-core/src/main/java/org/apache/helix/ConfigAccessor.java ## @@ -562,6 +563,30 @@ public

[GitHub] [helix] alirezazamani commented on a change in pull request #589: Add CloudConfig operations

2019-11-15 Thread GitBox
alirezazamani commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r347059668 ## File path: helix-core/src/main/java/org/apache/helix/model/CloudConfig.java ## @@ -0,0 +1,120 @@ +package

[GitHub] [helix] alirezazamani commented on a change in pull request #589: Add CloudConfig operations

2019-11-15 Thread GitBox
alirezazamani commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r347059644 ## File path: helix-core/src/test/java/org/apache/helix/model/cloud/TestCloudConfig.java ## @@ -0,0 +1,61 @@ +package

[GitHub] [helix] alirezazamani commented on a change in pull request #589: Add CloudConfig operations

2019-11-15 Thread GitBox
alirezazamani commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r347059401 ## File path: helix-core/src/main/java/org/apache/helix/ConfigAccessor.java ## @@ -562,6 +563,30 @@ public

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-15 Thread GitBox
i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r347039654 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/ServerContext.java ## @@ -117,9 +121,20

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-15 Thread GitBox
i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r347038187 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/AbstractResource.java ## @@

[GitHub] [helix] alirezazamani commented on a change in pull request #589: Add CloudConfig operations

2019-11-15 Thread GitBox
alirezazamani commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r347037997 ## File path: helix-core/src/test/java/org/apache/helix/model/cloud/TestCloudConfig.java ## @@ -0,0 +1,61 @@ +package

[GitHub] [helix] zhangmeng916 commented on a change in pull request #589: Add CloudConfig operations

2019-11-15 Thread GitBox
zhangmeng916 commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r347036321 ## File path: helix-core/src/test/java/org/apache/helix/model/cloud/TestCloudConfig.java ## @@ -0,0 +1,61 @@ +package

[GitHub] [helix] alirezazamani commented on issue #608: Stabilize the TestAlertingRebalancerFailure test

2019-11-15 Thread GitBox
alirezazamani commented on issue #608: Stabilize the TestAlertingRebalancerFailure test URL: https://github.com/apache/helix/pull/608#issuecomment-554548381 This PR is ready to be merged, approved by @jiajunwang. This is an

[GitHub] [helix] jiajunwang commented on a change in pull request #608: Stabilize the TestAlertingRebalancerFailure test

2019-11-15 Thread GitBox
jiajunwang commented on a change in pull request #608: Stabilize the TestAlertingRebalancerFailure test URL: https://github.com/apache/helix/pull/608#discussion_r347030521 ## File path: helix-core/src/test/java/org/apache/helix/integration/TestAlertingRebalancerFailure.java

[GitHub] [helix] zhangmeng916 commented on a change in pull request #589: Add CloudConfig operations

2019-11-15 Thread GitBox
zhangmeng916 commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r347030377 ## File path: helix-core/src/main/java/org/apache/helix/model/CloudConfig.java ## @@ -0,0 +1,120 @@ +package

[GitHub] [helix] alirezazamani opened a new pull request #608: Stabilize the TestAlertingRebalancerFailure test

2019-11-15 Thread GitBox
alirezazamani opened a new pull request #608: Stabilize the TestAlertingRebalancerFailure test URL: https://github.com/apache/helix/pull/608 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: Fixes #607 ### Description - [x]

[GitHub] [helix] narendly commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-15 Thread GitBox
narendly commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r347018606 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/AbstractResource.java ## @@

[GitHub] [helix] narendly commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-15 Thread GitBox
narendly commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r346954466 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/ServerContext.java ## @@ -46,9 +48,9 @@

[GitHub] [helix] narendly commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-15 Thread GitBox
narendly commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r347018225 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/ServerContext.java ## @@ -117,9 +121,20

[GitHub] [helix] pkuwm commented on a change in pull request #589: Add CloudConfig operations

2019-11-15 Thread GitBox
pkuwm commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r346943150 ## File path: helix-core/src/main/java/org/apache/helix/ConfigAccessor.java ## @@ -562,6 +563,30 @@ public ClusterConfig

[GitHub] [helix] alirezazamani opened a new issue #607: TestAlertingRebalancerFailure has been unstable for some time

2019-11-15 Thread GitBox
alirezazamani opened a new issue #607: TestAlertingRebalancerFailure has been unstable for some time URL: https://github.com/apache/helix/issues/607 TestAlertingRebalancerFailure is among the tests that is unstable and fails frequently. We should stabilize the test.

[GitHub] [helix] narendly commented on a change in pull request #592: Add a ZkAddress-based constructor for ConfigAccessor

2019-11-15 Thread GitBox
narendly commented on a change in pull request #592: Add a ZkAddress-based constructor for ConfigAccessor URL: https://github.com/apache/helix/pull/592#discussion_r346959768 ## File path: helix-core/src/main/java/org/apache/helix/ConfigAccessor.java ## @@ -67,14 +68,31 @@

[GitHub] [helix] pkuwm commented on issue #580: Fix NullPointerException in TestBatchMessage.

2019-11-15 Thread GitBox
pkuwm commented on issue #580: Fix NullPointerException in TestBatchMessage. URL: https://github.com/apache/helix/pull/580#issuecomment-554478876 This PR is ready to be merged, approved by @jiajunwang @narendly Commit: ``` NullPointerException in TestBatchMessage when

[GitHub] [helix] lei-xia commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-15 Thread GitBox
lei-xia commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r346956000 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] pkuwm commented on a change in pull request #589: Add CloudConfig operations

2019-11-15 Thread GitBox
pkuwm commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r346946022 ## File path: helix-core/src/main/java/org/apache/helix/model/CloudConfig.java ## @@ -0,0 +1,120 @@ +package

[GitHub] [helix] pkuwm commented on a change in pull request #589: Add CloudConfig operations

2019-11-15 Thread GitBox
pkuwm commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r346942532 ## File path: helix-core/src/main/java/org/apache/helix/ConfigAccessor.java ## @@ -562,6 +563,30 @@ public ClusterConfig

[GitHub] [helix] pkuwm commented on a change in pull request #589: Add CloudConfig operations

2019-11-15 Thread GitBox
pkuwm commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r346948791 ## File path: helix-core/src/test/java/org/apache/helix/model/cloud/TestCloudConfig.java ## @@ -0,0 +1,61 @@ +package

[GitHub] [helix] pkuwm commented on a change in pull request #589: Add CloudConfig operations

2019-11-15 Thread GitBox
pkuwm commented on a change in pull request #589: Add CloudConfig operations URL: https://github.com/apache/helix/pull/589#discussion_r346943150 ## File path: helix-core/src/main/java/org/apache/helix/ConfigAccessor.java ## @@ -562,6 +563,30 @@ public ClusterConfig

[GitHub] [helix] pkuwm commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

2019-11-15 Thread GitBox
pkuwm commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#discussion_r346103137 ## File path: helix-core/pom.xml ## @@ -159,6 +159,12 @@ under the License.

[GitHub] [helix] pkuwm commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

2019-11-15 Thread GitBox
pkuwm commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#discussion_r346939527 ## File path: helix-core/src/main/java/org/apache/helix/cloud/azure/AzureInstanceMetadataParser.java

[GitHub] [helix] narendly commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

2019-11-15 Thread GitBox
narendly commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#discussion_r346935293 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java ##

[GitHub] [helix] narendly commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

2019-11-15 Thread GitBox
narendly commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#discussion_r346931342 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

2019-11-15 Thread GitBox
narendly commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#discussion_r346931552 ## File path: