[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2017-12-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-14 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-4664: Unexpected string conversion in Shell .. Patch Set 15: (2 comments)

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-14 Thread Kim Jin Chul (Code Review)
Hello John Russell, Andre Araujo, Zoltan Borok-Nagy, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8762 to look at the new patch set (#14). Change subject: IMPALA-4664: Unexpected string conversion in Shell

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-14 Thread Kim Jin Chul (Code Review)
Hello John Russell, Andre Araujo, Zoltan Borok-Nagy, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8762 to look at the new patch set (#13). Change subject: IMPALA-4664: Unexpected string conversion in Shell

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 14: (6 comments) Thanks for updating the interface.

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. IMPALA-6300: Fix decimal modulo overflow In order to compute the modulo

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-14 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-4664: Unexpected string conversion in Shell .. Patch Set 12: Code-Review-1 Let me take a look at the failure and

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-4664: Unexpected string conversion in Shell .. Patch Set 12: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time.

2017-12-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time. .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2017-12-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Standardize column alias behavior .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-6114: Require type equality for NumericLiteral::localEquals().

2017-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8448 ) Change subject: IMPALA-6114: Require type equality for NumericLiteral::localEquals(). .. IMPALA-6114: Require type

[Impala-ASF-CR] IMPALA-6114: Require type equality for NumericLiteral::localEquals().

2017-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8448 ) Change subject: IMPALA-6114: Require type equality for NumericLiteral::localEquals(). .. Patch Set 6: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 4: (1 comment) The code and tests look

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 12: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-3942: Fix unexpected conversion of string literal in front-end

2017-12-14 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix unexpected conversion of string literal in front-end .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 10: (5 comments)

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. IMPALA-6284: Mark the intermediate decimal avg

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. Patch Set 15: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 12: Code-Review+1 Thank you for making all the

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-4664: Unexpected string conversion in Shell .. Patch Set 11: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 ) Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. Patch Set 10: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-6222: Add details to error msg on failure to get min reservation

2017-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8781 ) Change subject: IMPALA-6222: Add details to error msg on failure to get min reservation .. Patch Set 4: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6222: Add details to error msg on failure to get min reservation

2017-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8781 ) Change subject: IMPALA-6222: Add details to error msg on failure to get min reservation .. IMPALA-6222: Add details to

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time.

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time. .. Patch Set 3: (14 comments)

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time.

2017-12-14 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8814 to look at the new patch set (#4). Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time. ..

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 11: (3 comments)

[Impala-ASF-CR] IMPALA-6114: Require type equality of NumericLiteral::localEquals().

2017-12-14 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8448 ) Change subject: IMPALA-6114: Require type equality of NumericLiteral::localEquals(). .. Patch Set 5: Thanks for the comments. Please

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 11: (3 comments)

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 14: Code-Review+1 Thanks for sharing your view,

[Impala-ASF-CR] IMPALA-3887: Wait for HDFS replication in data loading

2017-12-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8846 ) Change subject: IMPALA-3887: Wait for HDFS replication in data loading .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3887: Wait for HDFS replication in data loading

2017-12-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8846 Change subject: IMPALA-3887: Wait for HDFS replication in data loading .. IMPALA-3887: Wait for HDFS replication in data loading When the

[Impala-ASF-CR] IMPALA-6222: Add details to error msg on failure to get min reservation

2017-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8781 ) Change subject: IMPALA-6222: Add details to error msg on failure to get min reservation .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6222: Add details to error msg on failure to get min reservation

2017-12-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8781 ) Change subject: IMPALA-6222: Add details to error msg on failure to get min reservation .. Patch Set 4: Code-Review+2 carrying over

[Impala-ASF-CR] IMPALA-6222: Add details to error msg on failure to get min reservation

2017-12-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8781 ) Change subject: IMPALA-6222: Add details to error msg on failure to get min reservation .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6222: Add details to error msg on failure to get min reservation

2017-12-14 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8781 to look at the new patch set (#4). Change subject: IMPALA-6222: Add details to error msg on failure to get min reservation

[Impala-ASF-CR] IMPALA-5948: Change Kudu RPC port to 27000

2017-12-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8841 ) Change subject: IMPALA-5948: Change Kudu RPC port to 27000 .. Patch Set 1: You may want to update it here too:

[Impala-ASF-CR] IMPALA-5948: Change Kudu RPC port to 27000

2017-12-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8841 ) Change subject: IMPALA-5948: Change Kudu RPC port to 27000 .. Patch Set 1: Code-Review+1 I confirmed that port 27000 is not used by

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. Patch Set 1: UBSAN might also be able to detect

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-12-14 Thread Pranay Singh (Code Review)
Hello Taras Bobrovytsky, Joe McDonnell, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8034 to look at the new patch set (#19). Change subject: IMPALA-5522:Use tracked memory for DictDecoder and

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. Patch Set 1: I'm not really sure what a new

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5948: Change Kudu RPC port to 27000

2017-12-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8841 Change subject: IMPALA-5948: Change Kudu RPC port to 27000 .. IMPALA-5948: Change Kudu RPC port to 27000 The current default for

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. Patch Set 1: Test? -- To view, visit

[Impala-ASF-CR] IMPALA-5310: Part 3: Use SAMPLED NDV() in COMPUTE STATS.

2017-12-14 Thread Alex Behm (Code Review)
Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8840 Change subject: IMPALA-5310: Part 3: Use SAMPLED_NDV() in COMPUTE STATS. .. IMPALA-5310: Part 3: Use SAMPLED_NDV() in COMPUTE STATS.

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2017-12-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Taras Bobrovytsky, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8801 to look at the new patch set (#6). Change subject: IMPALA-5191: Standardize column alias behavior

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-6319: Fix alloc/free mismatch.

2017-12-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8838 ) Change subject: IMPALA-6319: Fix alloc/free mismatch. .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 10: (11 comments) Thank you very much!

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Gabor Kaszab, Philip Zeyliger, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8621 to look at the new patch set (#11). Change subject: IMPALA-3703: Store query context in thread-local variables