[Impala-ASF-CR] IMPALA-6477: Fix flakiness with thrift-server-test

2018-02-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9247 ) Change subject: IMPALA-6477: Fix flakiness with thrift-server-test .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6477: Fix flakiness with thrift-server-test

2018-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9247 ) Change subject: IMPALA-6477: Fix flakiness with thrift-server-test .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9251 ) Change subject: IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams .. Patch Set 1: yes, that's what the Compact protocol

[Impala-ASF-CR] IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams

2018-02-07 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9251 ) Change subject: IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams .. Patch Set 1: The hammer here is to compress all

[Impala-ASF-CR] IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9251 Change subject: IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams .. IMPALA-4475: part 1, reduce size of

[Impala-ASF-CR] IMPALA-5690: Upgrade thrift to 0.9.3-p3

2018-02-07 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Upgrade thrift to 0.9.3-p3 .. IMPALA-5690: Upgrade thrift to 0.9.3-p3 Dependency changes: - BE and python use

[Impala-ASF-CR] IMPALA-5801: [draft] Clean up codegen GetType() interface

2018-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: [draft] Clean up codegen GetType() interface .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 8: (9 comments)

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 12: Code-Review+2 rebased and

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-07 Thread Bikramjeet Vig (Code Review)
Hello Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8971 to look at the new patch set (#12). Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

[Impala-ASF-CR] IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9123 ) Change subject: IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates .. Patch Set 15: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9239 ) Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows .. Patch Set 1: (4 comments) Looks good.

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9202 ) Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9238 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 1: I'll run tests on CentOS 6 just to verify :)

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8949 ) Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. IMPALA-6075: Add Impala daemon metric for

[Impala-ASF-CR] IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart

2018-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9232 ) Change subject: IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart

2018-02-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/9232 ) Change subject: IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-07 Thread Michael Ho (Code Review)
Hello Lars Volker, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9202 to look at the new patch set (#3). Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's

[Impala-ASF-CR] IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart

2018-02-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9232 ) Change subject: IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart .. Patch Set 1: My understanding is that the

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 ) Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. Patch Set 10: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9232 ) Change subject: IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart .. Patch Set 1: quick comment here... is there any

[Impala-ASF-CR] IMPALA-6477: Fix flakiness with thrift-server-test

2018-02-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9247 ) Change subject: IMPALA-6477: Fix flakiness with thrift-server-test .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart

2018-02-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9232 ) Change subject: IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6477: Fix flakiness with thrift-server-test

2018-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9247 ) Change subject: IMPALA-6477: Fix flakiness with thrift-server-test .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-02-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 2: (7 comments)

[Impala-ASF-CR](2.x) IMPALA-6228: Control stats extrapolation via tbl prop.

2018-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9231 ) Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. IMPALA-6228: Control stats extrapolation via

[Impala-ASF-CR](2.x) IMPALA-6228: Control stats extrapolation via tbl prop.

2018-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9231 ) Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6477: Fix flakiness with thrift-server-test

2018-02-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9247 ) Change subject: IMPALA-6477: Fix flakiness with thrift-server-test .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 11: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 10: (3 comments)

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-07 Thread Bikramjeet Vig (Code Review)
Hello Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8971 to look at the new patch set (#11). Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6478: Remove garbage NativeAddPendingTopicItem log from catalog

2018-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9228 ) Change subject: IMPALA-6478: Remove garbage NativeAddPendingTopicItem log from catalog .. IMPALA-6478: Remove garbage

[Impala-ASF-CR] IMPALA-6478: Remove garbage NativeAddPendingTopicItem log from catalog

2018-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9228 ) Change subject: IMPALA-6478: Remove garbage NativeAddPendingTopicItem log from catalog .. Patch Set 1: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6477: Fix flakiness with thrift-server-test

2018-02-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9247 Change subject: IMPALA-6477: Fix flakiness with thrift-server-test .. IMPALA-6477: Fix flakiness with thrift-server-test THe

[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."

2018-02-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9244 ) Change subject: Revert "IMPALA-6215: Removes race when using LibCache." .. Revert "IMPALA-6215: Removes race when

[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."

2018-02-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9244 ) Change subject: Revert "IMPALA-6215: Removes race when using LibCache." .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] Revert 'IMPALA-6338: Fix flaky test profile fragment instances'

2018-02-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9243 ) Change subject: Revert 'IMPALA-6338: Fix flaky test_profile_fragment_instances' .. Revert 'IMPALA-6338: Fix flaky

[Impala-ASF-CR] Revert 'IMPALA-6338: Fix flaky test profile fragment instances'

2018-02-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9243 ) Change subject: Revert 'IMPALA-6338: Fix flaky test_profile_fragment_instances' .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags

2018-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 ) Change subject: IMPALA-3271: organise and warn on removed startup flags .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9244 ) Change subject: Revert "IMPALA-6215: Removes race when using LibCache." .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."

2018-02-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9244 ) Change subject: Revert "IMPALA-6215: Removes race when using LibCache." .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."

2018-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9244 ) Change subject: Revert "IMPALA-6215: Removes race when using LibCache." .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2018-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9225 ) Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. Patch Set 1: Verified-1 Build

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2018-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9225 ) Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. Patch Set 1: Cancelling, since this depends

[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9244 Change subject: Revert "IMPALA-6215: Removes race when using LibCache." .. Revert "IMPALA-6215: Removes race when using LibCache." This

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has abandoned this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/8890 To unsubscribe,

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 5: decided to assert that all plans should be the same on all

[Impala-ASF-CR] Revert 'IMPALA-6338: Fix flaky test profile fragment instances'

2018-02-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9243 ) Change subject: Revert 'IMPALA-6338: Fix flaky test_profile_fragment_instances' .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Revert 'IMPALA-6338: Fix flaky test profile fragment instances'

2018-02-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9243 Change subject: Revert 'IMPALA-6338: Fix flaky test_profile_fragment_instances' .. Revert 'IMPALA-6338: Fix flaky

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 ) Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 ) Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. Patch Set 9: I was waiting for the GVO issues to quiet

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 ) Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-02-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 5: What's the consensus on this one? If we're not

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 ) Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. Patch Set 9: What's the status with this one?

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 10: (3 comments)

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. Patch Set 11: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6228: Control stats extrapolation via tbl prop.

2018-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9231 ) Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6077: remove Parquet BIT PACKED def level support

2018-02-07 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9241 to look at the new patch set (#2). Change subject: IMPALA-6077: remove Parquet BIT_PACKED def level support ..

[Impala-ASF-CR] IMPALA-6077: remove Parquet BIT PACKED def level support

2018-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9241 Change subject: IMPALA-6077: remove Parquet BIT_PACKED def level support .. IMPALA-6077: remove Parquet BIT_PACKED def level support

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9053 ) Change subject: IMPALA-6416: extend Thread::Create to track instance id .. Patch Set 3: (4 comments) Mostly looks good to me, had a few

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9202 ) Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6478: Remove garbage NativeAddPendingTopicItem log from catalog

2018-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9228 ) Change subject: IMPALA-6478: Remove garbage NativeAddPendingTopicItem log from catalog .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2018-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9225 ) Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9239 Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows .. IMPALA-6258: Uninitialized tuple pointers

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-02-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 11: (6 comments)

[Impala-ASF-CR] IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9123 ) Change subject: IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates .. Patch Set 15: I discovered that henry

[Impala-ASF-CR] IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-07 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Dimitris Tsirogiannis, Alex Behm, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9123 to look at the new patch set (#15). Change subject: IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-02-07 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#13). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags

2018-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 ) Change subject: IMPALA-3271: organise and warn on removed startup flags .. Patch Set 4: Code-Review+2 Rebase, carry +2 -- To view,

[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags

2018-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 ) Change subject: IMPALA-3271: organise and warn on removed startup flags .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags

2018-02-07 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9173 to look at the new patch set (#4). Change subject: IMPALA-3271: organise and warn on removed startup flags

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-02-07 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#12). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-02-07 Thread Xianda Ke (Code Review)
Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9238 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 1: @Tim, I've fixed the compiling error on centos 6.4.

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-02-07 Thread Xianda Ke (Code Review)
Xianda Ke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9238 Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. IMPALA-6219: Use AES-GCM for spill-to-disk encryption AES-GCM can

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags

2018-02-07 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 ) Change subject: IMPALA-3271: organise and warn on removed startup flags .. Patch Set 3: Code-Review+2 LGTM. -- To view, visit

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-07 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 7: Rebased. Running

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-07 Thread Philip Zeyliger (Code Review)
Hello Jim Apple, Dimitris Tsirogiannis, Alex Behm, Zach Amsden, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9192 to look at the new patch set (#7). Change subject: IMPALA-6204: Remove external DataSource