[Impala-ASF-CR] IMPALA-6941: load more text scanner compression plugins

2018-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10165 ) Change subject: IMPALA-6941: load more text scanner compression plugins .. Patch Set 11: The last PS includes a non-trivial change,

[Impala-ASF-CR] IMPALA-6941: load more text scanner compression plugins

2018-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10165 ) Change subject: IMPALA-6941: load more text scanner compression plugins .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-6957: calc thread resource requirement in planner

2018-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10256 ) Change subject: IMPALA-6957: calc thread resource requirement in planner .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-7010: don't run memory usage tests on non-HDFS

2018-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10370 Change subject: IMPALA-7010: don't run memory usage tests on non-HDFS .. IMPALA-7010: don't run memory usage tests on non-HDFS Moved a

[Impala-ASF-CR] IMPALA-6957: calc thread resource requirement in planner

2018-05-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10256 ) Change subject: IMPALA-6957: calc thread resource requirement in planner .. Patch Set 6: (2 comments) FE and explain changes look good

[Impala-ASF-CR] IMPALA-6941: load more text scanner compression plugins

2018-05-10 Thread Tim Armstrong (Code Review)
Hello Zoltan Borok-Nagy, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10165 to look at the new patch set (#11). Change subject: IMPALA-6941: load more text scanner compression plugins

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10158 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 19: (1 comment)

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-10 Thread Dan Hecht (Code Review)
Hello Michael Ho, Sailesh Mukil, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10158 to look at the new patch set (#19). Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-05-10 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 13: > Patch Set 12: > > (1 comment) > > > Yeah I think it's

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-05-10 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. IMPALA-6337: Fix infinite loop in Impala shell This patch fixes a bug

[Impala-ASF-CR] IMPALA-6941: load more text scanner compression plugins

2018-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10165 ) Change subject: IMPALA-6941: load more text scanner compression plugins .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-6941: load more text scanner compression plugins

2018-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10165 ) Change subject: IMPALA-6941: load more text scanner compression plugins .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required

2018-05-10 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 ) Change subject: IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required .. Patch Set 2: The newly generated google doc is

[Impala-ASF-CR] IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required

2018-05-10 Thread Alex Rodoni (Code Review)
Hello Balazs Jeszenszky, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10339 to look at the new patch set (#2). Change subject: IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required

[Impala-ASF-CR] IMPALA-7003: Deflake erasure coding data loading

2018-05-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10362 ) Change subject: IMPALA-7003: Deflake erasure coding data loading .. Patch Set 1: (1 comment) Did you test data loading on a Jenkins

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10292 ) Change subject: IMPALA-6966: sort table memory by size in catalogd web UI .. IMPALA-6966: sort table memory by size in

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10292 ) Change subject: IMPALA-6966: sort table memory by size in catalogd web UI .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 7: (8 comments) I think these are my final comments for

[Impala-ASF-CR] IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded()

2018-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10364 ) Change subject: IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded() .. Patch Set 1: (1 comment)

[Impala-ASF-CR](2.x) IMPALA-6972: Disable parallel dataload on MINICLUSTER PROFILE=2

2018-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10367 ) Change subject: IMPALA-6972: Disable parallel dataload on MINICLUSTER_PROFILE=2 .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6972: Disable parallel dataload on MINICLUSTER PROFILE=2

2018-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10367 ) Change subject: IMPALA-6972: Disable parallel dataload on MINICLUSTER_PROFILE=2 .. IMPALA-6972: Disable parallel

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-10 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Dimitris Tsirogiannis, Alex Behm, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#12). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 11: (1 comment) getting back to this change...

[Impala-ASF-CR] IMPALA-7000: [DOCS] Correct info about dedicated executors

2018-05-10 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10357 ) Change subject: IMPALA-7000: [DOCS] Correct info about dedicated executors .. Patch Set 1: Hi Juan, Do you have any comment on this

[Impala-ASF-CR] test-with-docker: work with git worktree

2018-05-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10335 ) Change subject: test-with-docker: work with git worktree .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6999: Upgrade to sqlparse-0.1.19 for Impala shell

2018-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10354 ) Change subject: IMPALA-6999: Upgrade to sqlparse-0.1.19 for Impala shell .. IMPALA-6999: Upgrade to sqlparse-0.1.19

[Impala-ASF-CR] IMPALA-6999: Upgrade to sqlparse-0.1.19 for Impala shell

2018-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10354 ) Change subject: IMPALA-6999: Upgrade to sqlparse-0.1.19 for Impala shell .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/10292 ) Change subject: IMPALA-6966: sort table memory by size in catalogd web UI .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10292 ) Change subject: IMPALA-6966: sort table memory by size in catalogd web UI .. Patch Set 5: Build started:

[Impala-ASF-CR] Update version to 3.1.0-SNAPSHOT

2018-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10360 ) Change subject: Update version to 3.1.0-SNAPSHOT .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] Update version to 3.1.0-SNAPSHOT

2018-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10360 ) Change subject: Update version to 3.1.0-SNAPSHOT .. Update version to 3.1.0-SNAPSHOT Change-Id:

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 5: (19 comments) Thanks for dealing with my previous

[Impala-ASF-CR] IMPALA-6035: Add query options to limit reserved threads

2018-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10365 ) Change subject: IMPALA-6035: Add query options to limit reserved threads .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6035: Add query options to limit reserved threads

2018-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10365 Change subject: IMPALA-6035: Add query options to limit reserved threads .. IMPALA-6035: Add query options to limit reserved threads

[Impala-ASF-CR](2.x) IMPALA-6972: Disable parallel dataload on MINICLUSTER PROFILE=2

2018-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10367 ) Change subject: IMPALA-6972: Disable parallel dataload on MINICLUSTER_PROFILE=2 .. Patch Set 1: Build started:

[Impala-ASF-CR](2.x) IMPALA-6972: Disable parallel dataload on MINICLUSTER PROFILE=2

2018-05-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10367 ) Change subject: IMPALA-6972: Disable parallel dataload on MINICLUSTER_PROFILE=2 .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 7: (5 comments) Will have some more comments but wanted

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10158 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 18: Code-Review+1 Thanks for the

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-10 Thread Dan Hecht (Code Review)
Hello Michael Ho, Sailesh Mukil, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10158 to look at the new patch set (#17). Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10158 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 14: (3 comments)

[Impala-ASF-CR](2.x) IMPALA-6972: Disable parallel dataload on MINICLUSTER PROFILE=2

2018-05-10 Thread Joe McDonnell (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10367 to review the following change. Change subject: IMPALA-6972: Disable parallel dataload on MINICLUSTER_PROFILE=2

[Impala-ASF-CR] IMPALA-6998: test bloom wait time fails due to late arrival of filters on Isilon

2018-05-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10366 Change subject: IMPALA-6998: test_bloom_wait_time fails due to late arrival of filters on Isilon .. IMPALA-6998: test_bloom_wait_time

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 10: Code-Review+1 Sorry, some of the

[Impala-ASF-CR] IMPALA-6999: Upgrade to sqlparse-0.1.19 for Impala shell

2018-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10354 ) Change subject: IMPALA-6999: Upgrade to sqlparse-0.1.19 for Impala shell .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6999: Upgrade to sqlparse-0.1.19 for Impala shell

2018-05-10 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10354 ) Change subject: IMPALA-6999: Upgrade to sqlparse-0.1.19 for Impala shell .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Update version to 3.1.0-SNAPSHOT

2018-05-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10360 ) Change subject: Update version to 3.1.0-SNAPSHOT .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-10 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-10 Thread Attila Jeges (Code Review)
Hello Gabor Kaszab, Zoltan Borok-Nagy, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9986 to look at the new patch set (#5). Change subject: IMPALA-3307: Add support for IANA time-zone db

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-10 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10116 to look at the new patch set (#10). Change subject: IMPALA-6131: Track time of last statistics update in metadata

[Impala-ASF-CR] Fix diagnostics path to not include the parent dir structure

2018-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10347 ) Change subject: Fix diagnostics path to not include the parent dir structure .. Fix diagnostics path to not include

[Impala-ASF-CR] Fix diagnostics path to not include the parent dir structure

2018-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10347 ) Change subject: Fix diagnostics path to not include the parent dir structure .. Patch Set 3: Verified+1 -- To view, visit