[Impala-ASF-CR] IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15527 ) Change subject: IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt .. Patch Set 14: Build started: https://jenkins.imp

[Impala-ASF-CR] IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt

2020-04-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15527 ) Change subject: IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt .. Patch Set 14: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-9545 Decide cacheline size of aarch64

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/1 ) Change subject: IMPALA-9545 Decide cacheline size of aarch64 .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-9545 Decide cacheline size of aarch64

2020-04-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/1 ) Change subject: IMPALA-9545 Decide cacheline size of aarch64 .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking

2020-04-06 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/15654 ) Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking .. Patch Set 3: Code-Review+1 Couple of comments

[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking

2020-04-06 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/15654 ) Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking .. Patch Set 3: (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 5: Build Failed https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-9565 Remove unused included file mm malloc.h on ARM

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15586 ) Change subject: IMPALA-9565 Remove unused included file mm_malloc.h on ARM .. Patch Set 6: Build Failed https://jenkins.impal

[Impala-ASF-CR] IMPALA-9590 Resolve error when build tsan and ubsan on arm64

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15630 ) Change subject: IMPALA-9590 Resolve error when build tsan and ubsan on arm64 .. Patch Set 3: Build Failed https://jenkins.imp

[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking

2020-04-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15654 ) Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking .. Patch Set 3: (2 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-06 Thread David Knupp (Code Review)
Hello Sahil Takiar, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15642 to look at the new patch set (#5). Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 ..

[Impala-ASF-CR] IMPALA-9563 Replace Intel's pcmpestri and pcmpestrm instructions

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15588 ) Change subject: IMPALA-9563 Replace Intel's pcmpestri and pcmpestrm instructions .. Patch Set 6: Build Failed https://jenkins

[Impala-ASF-CR] IMPALA-9562 Replace Intel's popcntq instruction with ARM's

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15587 ) Change subject: IMPALA-9562 Replace Intel's popcntq instruction with ARM's .. Patch Set 6: Build Failed https://jenkins.impal

[Impala-ASF-CR] IMPALA-9565 Remove unused included file mm malloc.h on ARM

2020-04-06 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15586 Change subject: IMPALA-9565 Remove unused included file mm_malloc.h on ARM .. IMPALA-9565 Remove unused included file mm_malloc

[Impala-ASF-CR] IMPALA-9564 Replace Intel's crc32 instructions

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15585 ) Change subject: IMPALA-9564 Replace Intel's crc32 instructions .. Patch Set 6: Build Failed https://jenkins.impala.io/job/ger

[Impala-ASF-CR] IMPALA-9545 Decide cacheline size of aarch64

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/1 ) Change subject: IMPALA-9545 Decide cacheline size of aarch64 .. Patch Set 8: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15527 ) Change subject: IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt .. Patch Set 14: Build Successful https://jenkins.

[Impala-ASF-CR] IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15531 ) Change subject: IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions .. Patch Set 13: Build Failed http

[Impala-ASF-CR] IMPALA-9590 Resolve error when build tsan and ubsan on arm64

2020-04-06 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15630 Change subject: IMPALA-9590 Resolve error when build tsan and ubsan on arm64 .. IMPALA-9590 Resolve error when build tsan and u

[Impala-ASF-CR] IMPALA-9563 Replace Intel's pcmpestri and pcmpestrm instructions

2020-04-06 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15588 Change subject: IMPALA-9563 Replace Intel's pcmpestri and pcmpestrm instructions .. IMPALA-9563 Replace Intel's pcmpestri and p

[Impala-ASF-CR] IMPALA-9562 Replace Intel's popcntq instruction with ARM's

2020-04-06 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15587 Change subject: IMPALA-9562 Replace Intel's popcntq instruction with ARM's .. IMPALA-9562 Replace Intel's popcntq instruction w

[Impala-ASF-CR] IMPALA-9545 Decide cacheline size of aarch64

2020-04-06 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/1 ) Change subject: IMPALA-9545 Decide cacheline size of aarch64 .. Patch Set 8: Hi, Tim, this has been modified as your request.

[Impala-ASF-CR] IMPALA-9545 Decide cacheline size of aarch64

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/1 ) Change subject: IMPALA-9545 Decide cacheline size of aarch64 .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-9564 Replace Intel's crc32 instructions

2020-04-06 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15585 Change subject: IMPALA-9564 Replace Intel's crc32 instructions .. IMPALA-9564 Replace Intel's crc32 instructions Replace Intel

[Impala-ASF-CR] IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15531 ) Change subject: IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions .. Patch Set 13: (39 comments) htt

[Impala-ASF-CR] IMPALA-9545 Decide cacheline size of aarch64

2020-04-06 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/1 ) Change subject: IMPALA-9545 Decide cacheline size of aarch64 .. IMPALA-9545 Decide cacheline size of aarch64 ARM64's L3 cacheli

[Impala-ASF-CR] IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions

2020-04-06 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15531 Change subject: IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions .. IMPALA-9544 Replace Intel's SSE i

[Impala-ASF-CR] IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt

2020-04-06 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/15527 ) Change subject: IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt .. IMPALA-9543 Reduce duplicate code in thrift CMake

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 4: Build Failed https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 3: Build Failed https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 4: Build started: https://jenkins.impala.io/job/ger

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-06 Thread David Knupp (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15642 to look at the new patch set (#4). Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. IMPALA

[Impala-ASF-CR] WIP - IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-06 Thread David Knupp (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15642 to look at the new patch set (#3). Change subject: WIP - IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 ..

[Impala-ASF-CR] IMPALA-9602: Fix case-sensitivity for local catalog

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15653 ) Change subject: IMPALA-9602: Fix case-sensitivity for local catalog .. Patch Set 3: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-9602: Fix case-sensitivity for local catalog

2020-04-06 Thread Aman Sinha (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15653 to look at the new patch set (#3). Change subject: IMPALA-9602: Fix case-sensitivity for local catalog ..

[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking

2020-04-06 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/15654 ) Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking .. Patch Set 3: (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15654 ) Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking .. Patch Set 3: Build Successful http

[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking

2020-04-06 Thread Quanlong Huang (Code Review)
Hello Fang-Yu Rao, Vihang Karajgaonkar, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15654 to look at the new patch set (#3). Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking .

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 2506706

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15668 ) Change subject: Bump up CDP_BUILD_NUMBER to 2506706 .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-re

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 2506706

2020-04-06 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15668 Change subject: Bump up CDP_BUILD_NUMBER to 2506706 .. Bump up CDP_BUILD_NUMBER to 2506706 This change bumps up the CDP_BUILD_NUM

[Impala-ASF-CR] IMPALA-5746: Test case for remote fragments releasing memory

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15666 ) Change subject: IMPALA-5746: Test case for remote fragments releasing memory .. Patch Set 1: Build Successful https://jenkins

[Impala-ASF-CR] IMPALA-5746: Test case for remote fragments releasing memory

2020-04-06 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15666 Change subject: IMPALA-5746: Test case for remote fragments releasing memory .. IMPALA-5746: Test case for remote fragments releasing mem

[Impala-ASF-CR] IMPALA-9422: Re-visit and improve join node and builder's counters

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15663 ) Change subject: IMPALA-9422: Re-visit and improve join node and builder's counters .. Patch Set 1: Build Successful https://

[Impala-ASF-CR] IMPALA-9422: Re-visit and improve join node and builder's counters

2020-04-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15663 Change subject: IMPALA-9422: Re-visit and improve join node and builder's counters .. IMPALA-9422: Re-visit and improve join node and

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. Patch Set 6: I need to take another pass ove

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-06 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. Patch Set 6: (4 comments) http://gerrit.clou

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-04-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 11: Patch Set 11 add improvement for insertion into Robi

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 11: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-04-06 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15511 to look at the new patch set (#11). Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .

[Impala-ASF-CR] IMPALA-9398: Fix shell history duplication when cmdloop breaks

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15345 ) Change subject: IMPALA-9398: Fix shell history duplication when cmdloop breaks .. Patch Set 4: Verified+1 -- To view, visit h

[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15654 ) Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking .. Patch Set 2: Build Successful http

[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking

2020-04-06 Thread Quanlong Huang (Code Review)
Hello Fang-Yu Rao, Vihang Karajgaonkar, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15654 to look at the new patch set (#2). Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking .

[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking

2020-04-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15654 ) Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking .. Patch Set 1: (2 comments) Thanks for your

[Impala-ASF-CR] IMPALA-9398: Fix shell history duplication when cmdloop breaks

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15345 ) Change subject: IMPALA-9398: Fix shell history duplication when cmdloop breaks .. Patch Set 4: Build started: https://jenkins.

[Impala-ASF-CR] IMPALA-9398: Fix shell history duplication when cmdloop breaks

2020-04-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15345 ) Change subject: IMPALA-9398: Fix shell history duplication when cmdloop breaks .. Patch Set 4: Build Successful https://jenki

[Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking

2020-04-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15654 ) Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking .. Patch Set 1: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-9398: Fix shell history duplication when cmdloop breaks

2020-04-06 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15345 ) Change subject: IMPALA-9398: Fix shell history duplication when cmdloop breaks .. IMPALA-9398: Fix shell history duplication when cmdloop br