[Impala-ASF-CR] IMPALA-9663: Fix for NPE in fire listener events

2020-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15745 ) Change subject: IMPALA-9663: Fix for NPE in fire listener events .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 9: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

[Impala-ASF-CR] IMPALA-9663: Fix for NPE in fire listener events

2020-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15745 ) Change subject: IMPALA-9663: Fix for NPE in fire listener events .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-9663: Fix for NPE in fire listener events

2020-04-16 Thread Xiaomeng Zhang (Code Review)
Xiaomeng Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15745 ) Change subject: IMPALA-9663: Fix for NPE in fire listener events .. Patch Set 2: Code-Review+1 Thanks Vihang, LGTM -- To view,

[Impala-ASF-CR] IMPALA-9663: Fix for NPE in fire listener events

2020-04-16 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15745 ) Change subject: IMPALA-9663: Fix for NPE in fire listener events .. Patch Set 2: Code-Review+1 (1 comment) Thanks for the

[Impala-ASF-CR] IMPALA-9663: Fix for NPE in fire listener events

2020-04-16 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15745 ) Change subject: IMPALA-9663: Fix for NPE in fire listener events .. Patch Set 2: Thanks. -- To view, visit

[Impala-ASF-CR] IMPALA-9663: Fix for NPE in fire listener events

2020-04-16 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15745 ) Change subject: IMPALA-9663: Fix for NPE in fire listener events .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9663: Fix for NPE in fire listener events

2020-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15745 ) Change subject: IMPALA-9663: Fix for NPE in fire listener events .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-9663: Fix for NPE in fire listener events

2020-04-16 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15745 Change subject: IMPALA-9663: Fix for NPE in fire listener events .. IMPALA-9663: Fix for NPE in fire listener events IMPALA-8632

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 8: Code-Review+2 Carrying +2 after clean rebase -- To

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. Patch Set 7: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download

2020-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 ) Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download .. Patch Set 4: Verified+1

[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download

2020-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15720 ) Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download .. IMPALA-9649:

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-16 Thread David Knupp (Code Review)
Hello Abhishek Rawat, Sahil Takiar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15524 to look at the new patch set (#7). Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. Patch Set 7: > Patch Set 6: > > (1 comment) >

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download

2020-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 ) Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download .. Patch Set 4: Build

[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download

2020-04-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 ) Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download .. Patch Set 4: Failures were

[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download

2020-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 ) Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download .. Patch Set 4: Code-Review+2

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

2020-04-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15700 ) Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node .. IMPALA-9596: deflake test_tpch_mem_limit_single_node

[Impala-ASF-CR] IMPALA-9469: ORC scanner vectorization for collection types

2020-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15730 ) Change subject: IMPALA-9469: ORC scanner vectorization for collection types .. Patch Set 2: Build Successful

[Impala-ASF-CR] Asynchronous code generation

2020-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: Asynchronous code generation .. Patch Set 33: Build Successful

[Impala-ASF-CR] IMPALA-9469: ORC scanner vectorization for collection types

2020-04-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15730 ) Change subject: IMPALA-9469: ORC scanner vectorization for collection types .. Patch Set 2: (11 comments) Thanks for the

[Impala-ASF-CR] IMPALA-9469: ORC scanner vectorization for collection types

2020-04-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Norbert Luksa, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15730 to look at the new patch set (#2). Change subject: IMPALA-9469: ORC scanner vectorization for collection types

[Impala-ASF-CR] Asynchronous code generation

2020-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: Asynchronous code generation .. Patch Set 33: (1 comment)

[Impala-ASF-CR] Asynchronous code generation

2020-04-16 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#33). ( http://gerrit.cloudera.org:8080/15105 ) Change subject: Asynchronous code generation .. Asynchronous code generation This commit introduces optional asynchronous code

[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs

2020-04-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15737 ) Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs .. Patch Set 1: (1

[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs

2020-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15737 ) Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs .. Patch Set 2:

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

2020-04-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 ) Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs

2020-04-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15737 ) Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs .. Patch Set 1: (2

[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs

2020-04-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15737 to look at the new patch set (#2). Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs