[Impala-ASF-CR] IMPALA-10183: Fix hitting DCHECK when cancelling a query with result spooling

2020-09-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16489 ) Change subject: IMPALA-10183: Fix hitting DCHECK when cancelling a query with result spooling .. Patch Set 2: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 15: (6 comments)

[Impala-ASF-CR] IMPALA-10183: Fix hitting DCHECK when cancelling a query with result spooling

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16489 ) Change subject: IMPALA-10183: Fix hitting DCHECK when cancelling a query with result spooling .. Patch Set 2: Build

[Impala-ASF-CR] IMPALA-10183: Fix hitting DCHECK when cancelling a query with result spooling

2020-09-22 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16489 ) Change subject: IMPALA-10183: Fix hitting DCHECK when cancelling a query with result spooling .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10183: Fix hitting DCHECK when cancelling a query with result spooling

2020-09-22 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16489 to look at the new patch set (#2). Change subject: IMPALA-10183: Fix hitting DCHECK when cancelling a query with result spooling

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. Patch Set 5: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-9664: Support hive replication

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16439 ) Change subject: IMPALA-9664: Support hive replication .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-9180 (part 1): Remove legacy ImpalaInternalService

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16291 ) Change subject: IMPALA-9180 (part 1): Remove legacy ImpalaInternalService .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-9180 (part 1): Remove legacy ImpalaInternalService

2020-09-22 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/16291 ) Change subject: IMPALA-9180 (part 1): Remove legacy ImpalaInternalService .. IMPALA-9180 (part 1): Remove legacy ImpalaInternalService

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Sahil Takiar (Code Review)
Sahil Takiar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. IMPALA-9046: Profile counter that

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. Patch Set 5: Verified+1 Code-Review+2 Carrying

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. Patch Set 4: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-9180 (part 1): Remove legacy ImpalaInternalService

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16291 ) Change subject: IMPALA-9180 (part 1): Remove legacy ImpalaInternalService .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-5022 part 1: Implement core functions of outer join simplification

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1: Implement core functions of outer join simplification .. IMPALA-5022 part 1:

[Impala-ASF-CR] IMPALA-5022 part 1: Implement core functions of outer join simplification

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1: Implement core functions of outer join simplification .. Patch Set 23: Verified+1 -- To

[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 15: Build Successful

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-22 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. IMPALA-10178 Run-time profile shall report skews This fix addresses

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9664: Support hive replication

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16439 ) Change subject: IMPALA-9664: Support hive replication .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Sahil Takiar (Code Review)
Hello Tamas Mate, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16414 to look at the new patch set (#5). Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred

[Impala-ASF-CR] IMPALA-9664: Support hive replication

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16439 ) Change subject: IMPALA-9664: Support hive replication .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-9664: Support hive replication

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16439 ) Change subject: IMPALA-9664: Support hive replication .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-9664: Support hive replication

2020-09-22 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16439 ) Change subject: IMPALA-9664: Support hive replication .. IMPALA-9664: Support hive replication This patch makes some improvements

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. Patch Set 7: I also can't reproduce it locally, but I poked

[Impala-ASF-CR] IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16473 ) Change subject: IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 9: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. Patch Set 7: Build Failed

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. Patch Set 7: The issue was in compiling impala-ir.cc, so I

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. Patch Set 4: > This makes sense to me. My one

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16414 to look at the new patch set (#4). Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 14: Build Successful

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. Patch Set 7: I see

[Impala-ASF-CR] IMPALA-10183: Fix hitting DCHECK when cancelling a query with result spooling

2020-09-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16489 ) Change subject: IMPALA-10183: Fix hitting DCHECK when cancelling a query with result spooling .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-22 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. IMPALA-10178 Run-time profile shall report skews This fix addresses

[Impala-ASF-CR] IMPALA-9792: Add ability to split kudu scan ranges

2020-09-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16385 ) Change subject: IMPALA-9792: Add ability to split kudu scan ranges .. Patch Set 4: Code-Review+2 (1 comment) I think it would be

[Impala-ASF-CR] IMPALA-5022 part 1: Implement core functions of outer join simplification

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1: Implement core functions of outer join simplification .. Patch Set 23: Code-Review+2 --

[Impala-ASF-CR] IMPALA-5022 part 1: Implement core functions of outer join simplification

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1: Implement core functions of outer join simplification .. Patch Set 23: Build started:

[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. Patch Set 7: Build Failed

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. Patch Set 7: Code-Review+2 +2, though I have no idea why the

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 8: Code-Review+2 (2 comments) Thx for your

[Impala-ASF-CR] IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16473 ) Change subject: IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-10096: Use the original ordinal if the group by ordinal reference is a constant int

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16353 ) Change subject: IMPALA-10096: Use the original ordinal if the group by ordinal reference is a constant int ..

[Impala-ASF-CR] IMPALA-10096: Use the original ordinal if the group by ordinal reference is a constant int

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16353 ) Change subject: IMPALA-10096: Use the original ordinal if the group by ordinal reference is a constant int .. Patch Set 7:

[Impala-ASF-CR] IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16473 ) Change subject: IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE

2020-09-22 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16473 to look at the new patch set (#7). Change subject: IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 8: Code-Review+1 Thanks for applying the

[Impala-ASF-CR] IMPALA-10183: Fix hitting DCHECK when cancelling a query with result spooling

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16489 ) Change subject: IMPALA-10183: Fix hitting DCHECK when cancelling a query with result spooling .. Patch Set 1: Build

[Impala-ASF-CR] IMPALA-10183: Fix hitting DCHECK when cancelling a query with result spooling

2020-09-22 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16489 Change subject: IMPALA-10183: Fix hitting DCHECK when cancelling a query with result spooling .. IMPALA-10183: Fix hitting DCHECK

[Impala-ASF-CR] IMPALA-5022 part 1: Implement core functions of outer join simplification

2020-09-22 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1: Implement core functions of outer join simplification .. Patch Set 22: Code-Review+1 Xianqing,

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-22 Thread wangsheng (Code Review)
wangsheng has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. IMPALA-10164: Supporting HadoopCatalog for Iceberg table This

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. Patch Set 7: Build Failed

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-22 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. IMPALA-10078: Proper codegen for KuduPartitionExpr Implementing

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-22 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. Patch Set 6: Interesting errors... For example is not found,

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. Patch Set 6: Build Failed

[Impala-ASF-CR] IMPALA-10096: Use the original ordinal if the group by ordinal reference is a constant int

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16353 ) Change subject: IMPALA-10096: Use the original ordinal if the group by ordinal reference is a constant int .. Patch Set 7:

[Impala-ASF-CR] IMPALA-10096: Use the original ordinal if the group by ordinal reference is a constant int

2020-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16353 ) Change subject: IMPALA-10096: Use the original ordinal if the group by ordinal reference is a constant int .. Patch Set 7:

[Impala-ASF-CR] IMPALA-10096: Use the original ordinal if the group by ordinal reference is a constant int

2020-09-22 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16353 ) Change subject: IMPALA-10096: Use the original ordinal if the group by ordinal reference is a constant int .. Patch Set 6:

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-22 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-22 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. IMPALA-10078: Proper codegen for KuduPartitionExpr Implementing