Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 )
Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/16419/5/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/16419/5/tests/query_test/test_kudu.py@570 PS5, Line 570: : table_name = "partitioning" : table_full_name = unique_database + ".partitioning" : cursor.execute("""CREATE TABLE %s (a INT PRIMARY KEY) : PARTITION BY HASH(a) PARTITI > I had the same thought, that we could create a managed kudu table instead. Done http://gerrit.cloudera.org:8080/#/c/16419/5/tests/query_test/test_kudu.py@598 PS5, Line 598: > optional: This could be moved to common code, e.g. near https://github.com/ I'm not sure this algorithm is general enough. It doesn't deal with indentation so doesn't handle sections robustly, and within each section it can only find at most one row. I think it is quite specialised to this use case. -- To view, visit http://gerrit.cloudera.org:8080/16419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcae34f71b407837e2c5f1b97aa230e490a268df Gerrit-Change-Number: 16419 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 22 Sep 2020 08:17:12 +0000 Gerrit-HasComments: Yes
