[Impala-ASF-CR] IMPALA-9864: Produce a minidump when TestValidateMetrics fails

2020-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16690 ) Change subject: IMPALA-9864: Produce a minidump when TestValidateMetrics fails .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-02 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 4: Code-Review+1 (1 comment) Thanks for

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-9355: TestExchangeMemUsage.test exchange mem usage scaling doesn't hit the memory limit

2020-11-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16676 ) Change subject: IMPALA-9355: TestExchangeMemUsage.test_exchange_mem_usage_scaling doesn't hit the memory limit .. Patch Set 2: (1

[Impala-ASF-CR] IMPALA-10283: Fix IllegalStateException in applying incremental partition updates

2020-11-02 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16649 ) Change subject: IMPALA-10283: Fix IllegalStateException in applying incremental partition updates .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10283: Fix IllegalStateException in applying incremental partition updates

2020-11-02 Thread Quanlong Huang (Code Review)
Hello Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16649 to look at the new patch set (#3). Change subject: IMPALA-10283: Fix IllegalStateException in applying incremental partition updates

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-02 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-02 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. IMPALA-3816: Codegen perf critical loops in Sorter This fix added

[Impala-ASF-CR] IMPALA-10058: Use commit hash as version for Kudu java artifacts

2020-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16686 ) Change subject: IMPALA-10058: Use commit hash as version for Kudu java artifacts .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-9180 (part 3): Remove legacy backend port

2020-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16533 ) Change subject: IMPALA-9180 (part 3): Remove legacy backend port .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9180 (part 3): Remove legacy backend port

2020-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16533 ) Change subject: IMPALA-9180 (part 3): Remove legacy backend port .. IMPALA-9180 (part 3): Remove legacy backend port

[Impala-ASF-CR] IMPALA-9864: Produce a minidump when TestValidateMetrics fails

2020-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16690 ) Change subject: IMPALA-9864: Produce a minidump when TestValidateMetrics fails .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-9864: Produce a minidump when TestValidateMetrics fails

2020-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16690 ) Change subject: IMPALA-9864: Produce a minidump when TestValidateMetrics fails .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-9864: Produce a minidump when TestValidateMetrics fails

2020-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16690 ) Change subject: IMPALA-9864: Produce a minidump when TestValidateMetrics fails .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9864: Produce a minidump when TestValidateMetrics fails

2020-11-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16690 ) Change subject: IMPALA-9864: Produce a minidump when TestValidateMetrics fails .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9864: Produce a minidump when TestValidateMetrics fails

2020-11-02 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16690 to look at the new patch set (#2). Change subject: IMPALA-9864: Produce a minidump when TestValidateMetrics fails

[Impala-ASF-CR] IMPALA-9864: Produce a minidump when TestValidateMetrics fails

2020-11-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16690 Change subject: IMPALA-9864: Produce a minidump when TestValidateMetrics fails .. IMPALA-9864: Produce a minidump when

[Impala-ASF-CR] IMPALA-9864: Produce a minidump when TestValidateMetrics fails

2020-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16690 ) Change subject: IMPALA-9864: Produce a minidump when TestValidateMetrics fails .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10058: Use commit hash as version for Kudu java artifacts

2020-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16686 ) Change subject: IMPALA-10058: Use commit hash as version for Kudu java artifacts .. Patch Set 1: Build started:

[native-toolchain-CR] IMPALA-10058: Use commit hash as version for Kudu java artifacts

2020-11-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16685 ) Change subject: IMPALA-10058: Use commit hash as version for Kudu java artifacts .. Patch Set 1: This is the corresponding change to

[Impala-ASF-CR] WIP IMPALA-10305: Sync Kudu security code change for FIPS

2020-11-02 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16684 ) Change subject: WIP IMPALA-10305: Sync Kudu security code change for FIPS .. Patch Set 2: Yes, it's still WIP since not all patches are

[Impala-ASF-CR] Replace some TODOs with specific JIRA references

2020-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/11392 ) Change subject: Replace some TODOs with specific JIRA references .. Abandoned Cleaning up some old CRs -- To view, visit

[Impala-ASF-CR] IMPALA-3825: Distribute Runtime Filtering Aggregation

2020-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/11055 ) Change subject: IMPALA-3825: Distribute Runtime Filtering Aggregation .. Abandoned Cleaning up some old CRs -- To view, visit

[Impala-ASF-CR] WIP IMPALA-10305: Sync Kudu security code change for FIPS

2020-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16684 ) Change subject: WIP IMPALA-10305: Sync Kudu security code change for FIPS .. Patch Set 2: Is this still a WIP? I can review once it's

[Impala-ASF-CR] IMPALA-10185 Use bool stats for selectivity calculations.

2020-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16462 ) Change subject: IMPALA-10185 Use bool stats for selectivity calculations. .. Patch Set 2: I'm ready to +2 after the minor code

[Impala-ASF-CR] IMPALA-9180 (part 3): Remove legacy backend port

2020-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16533 ) Change subject: IMPALA-9180 (part 3): Remove legacy backend port .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-9180 (part 3): Remove legacy backend port

2020-11-02 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16533 ) Change subject: IMPALA-9180 (part 3): Remove legacy backend port .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9180 (part 3): Remove legacy backend port

2020-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16533 ) Change subject: IMPALA-9180 (part 3): Remove legacy backend port .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-9180 (part 3): Remove legacy backend port

2020-11-02 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16533 ) Change subject: IMPALA-9180 (part 3): Remove legacy backend port .. IMPALA-9180 (part 3): Remove legacy backend port The legacy Thrift

[Impala-ASF-CR] IMPALA-9180 (part 3): Remove legacy backend port

2020-11-02 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16533 ) Change subject: IMPALA-9180 (part 3): Remove legacy backend port .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-10283: Fix IllegalStateException in applying incremental partition updates

2020-11-02 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16649 ) Change subject: IMPALA-10283: Fix IllegalStateException in applying incremental partition updates .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10252: fix invalid runtime filters for outer joins

2020-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16622 ) Change subject: IMPALA-10252: fix invalid runtime filters for outer joins .. Patch Set 5: Updated the commit message as requested.

[Impala-ASF-CR] IMPALA-10252: fix invalid runtime filters for outer joins

2020-11-02 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16622 to look at the new patch set (#6). Change subject: IMPALA-10252: fix invalid runtime filters for outer joins

[Impala-ASF-CR] IMPALA-10306: [DOCS] add note about TZ offset

2020-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 ) Change subject: IMPALA-10306: [DOCS] add note about TZ offset .. Patch Set 1: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-10306: [DOCS] add note about TZ offset

2020-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 ) Change subject: IMPALA-10306: [DOCS] add note about TZ offset .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-10306: [DOCS] add note about TZ offset

2020-11-02 Thread Shajini Thayasingh (Code Review)
Shajini Thayasingh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16689 Change subject: IMPALA-10306: [DOCS] add note about TZ offset .. IMPALA-10306: [DOCS] add note about TZ offset added a note that

[Impala-ASF-CR] IMPALA-10234: Add support for cookie authentication to impala-shell

2020-11-02 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16660 ) Change subject: IMPALA-10234: Add support for cookie authentication to impala-shell .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-9180 (part 3): Remove legacy backend port

2020-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16533 ) Change subject: IMPALA-9180 (part 3): Remove legacy backend port .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-9180 (part 3): Remove legacy backend port

2020-11-02 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16533 ) Change subject: IMPALA-9180 (part 3): Remove legacy backend port .. IMPALA-9180 (part 3): Remove legacy backend port The legacy Thrift

[native-toolchain-CR] IMPALA-10145,IMPALA-10299: Apply unicode decoding bug fixes to thrift-0.11.0

2020-11-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16688 ) Change subject: IMPALA-10145,IMPALA-10299: Apply unicode decoding bug fixes to thrift-0.11.0 .. Patch Set 1: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 4: (2 comments) PS4 is a rebase with master

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-02 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, wangsheng, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16599 to look at the new patch set (#4). Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables