[Impala-ASF-CR] IMPALA-11469: (Addendum) Lazy initialize tmp dir list for tests

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18828 ) Change subject: IMPALA-11469: (Addendum) Lazy initialize tmp dir list for tests .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-11469: (Addendum) Lazy initialize tmp dir list for tests

2022-08-09 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18828 ) Change subject: IMPALA-11469: (Addendum) Lazy initialize tmp dir list for tests .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 ) Change subject: IMPALA-11458: Update zlib and zstd .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd

2022-08-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18816 ) Change subject: IMPALA-11458: Update zlib and zstd .. IMPALA-11458: Update zlib and zstd Updates zlib to 1.2.12 and zstd to

[native-toolchain-CR] IMPALA-11458: Update zlib and zstd

2022-08-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18795 ) Change subject: IMPALA-11458: Update zlib and zstd .. IMPALA-11458: Update zlib and zstd Update compression libraries zlib

[native-toolchain-CR] IMPALA-11458: Update zlib and zstd

2022-08-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18795 ) Change subject: IMPALA-11458: Update zlib and zstd .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd

2022-08-09 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 ) Change subject: IMPALA-11458: Update zlib and zstd .. Patch Set 5: Did a rebase. I guess that'll need a re-run. -- To view, visit

[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd

2022-08-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 ) Change subject: IMPALA-11458: Update zlib and zstd .. Patch Set 5: Verified+1 Code-Review+2 Carry +1 verified from last precommit run

[Impala-ASF-CR] IMPALA-10791 Add batch reading for remote temporary files

2022-08-09 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17979 ) Change subject: IMPALA-10791 Add batch reading for remote temporary files .. Patch Set 15: (9 comments) Looks good to me. Some

[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd

2022-08-09 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 ) Change subject: IMPALA-11458: Update zlib and zstd .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd

2022-08-09 Thread Michael Smith (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18816 to look at the new patch set (#5). Change subject: IMPALA-11458: Update zlib and zstd ..

[native-toolchain-CR] IMPALA-11458: Update zlib and zstd

2022-08-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18795 ) Change subject: IMPALA-11458: Update zlib and zstd .. Patch Set 5: Thanks for putting this together, this looks good. When we are

[native-toolchain-CR] IMPALA-11458: Update zlib and zstd

2022-08-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18795 ) Change subject: IMPALA-11458: Update zlib and zstd .. Patch Set 5: Code-Review+2 This looks great -- To view, visit

[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd

2022-08-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 ) Change subject: IMPALA-11458: Update zlib and zstd .. Patch Set 4: Code-Review+1 (1 comment) Thanks for putting this together Small

[Impala-ASF-CR] IMPALA-11469: (Addendum) Lazy initialize tmp dir list for tests

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18828 ) Change subject: IMPALA-11469: (Addendum) Lazy initialize tmp dir list for tests .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-11469: (Addendum) Lazy initialize tmp dir list for tests

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18828 ) Change subject: IMPALA-11469: (Addendum) Lazy initialize tmp dir list for tests .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-11469: (Addendum) Lazy initialize tmp dir list for tests

2022-08-09 Thread Michael Smith (Code Review)
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18828 Change subject: IMPALA-11469: (Addendum) Lazy initialize tmp dir list for tests .. IMPALA-11469: (Addendum) Lazy initialize tmp dir

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 10: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 ) Change subject: IMPALA-11458: Update zlib and zstd .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11489: Fix int overflow in >2GB ORC files

2022-08-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18827 ) Change subject: IMPALA-11489: Fix int overflow in >2GB ORC files .. Patch Set 1: Code-Review+2 Thank you for catching this, Csaba!

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 10: (3 comments)

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-09 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18704 to look at the new patch set (#10). Change subject: IMPALA-11350: Add virtual column FILE__POSITION

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 10: (9 comments) Thanks for the

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 9: (3 comments)

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-09 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18704 to look at the new patch set (#9). Change subject: IMPALA-11350: Add virtual column FILE__POSITION for

[Impala-ASF-CR] PROTOTYPE: IMPALA-11207: Use hadoop-cloud-storage for Cloud dependencies

2022-08-09 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18817 ) Change subject: PROTOTYPE: IMPALA-11207: Use hadoop-cloud-storage for Cloud dependencies .. Patch Set 1: Ran an S3 test suite. Hit a

[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd

2022-08-09 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 ) Change subject: IMPALA-11458: Update zlib and zstd .. Patch Set 4: Tests hit IMPALA-11160, IMPALA-11352. Rebuilding. -- To view,

[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 ) Change subject: IMPALA-11458: Update zlib and zstd .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-11489: Fix int overflow in >2GB ORC files

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18827 ) Change subject: IMPALA-11489: Fix int overflow in >2GB ORC files .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-11489: Fix int overflow in >2GB ORC files

2022-08-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18827 Change subject: IMPALA-11489: Fix int overflow in >2GB ORC files .. IMPALA-11489: Fix int overflow in >2GB ORC files This can lead

[Impala-ASF-CR] IMPALA-11362: Add expire snapshots functionality for Iceberg tables

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18688 ) Change subject: IMPALA-11362: Add expire snapshots functionality for Iceberg tables .. IMPALA-11362: Add expire

[Impala-ASF-CR] IMPALA-11362: Add expire snapshots functionality for Iceberg tables

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18688 ) Change subject: IMPALA-11362: Add expire snapshots functionality for Iceberg tables .. Patch Set 10: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-11362: Add expire snapshots functionality for Iceberg tables

2022-08-09 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/18688 ) Change subject: IMPALA-11362: Add expire snapshots functionality for Iceberg tables .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-09 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 8: (10 comments)

[Impala-ASF-CR] IMPALA-11362: Add expire snapshots functionality for Iceberg tables

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18688 ) Change subject: IMPALA-11362: Add expire snapshots functionality for Iceberg tables .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-11362: Add expire snapshots functionality for Iceberg tables

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18688 ) Change subject: IMPALA-11362: Add expire snapshots functionality for Iceberg tables .. Patch Set 10: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-11362: Add expire snapshots functionality for Iceberg tables

2022-08-09 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18688 ) Change subject: IMPALA-11362: Add expire snapshots functionality for Iceberg tables .. Patch Set 9: Verify job failure caused by

[Impala-ASF-CR] IMPALA-11362: Add expire snapshots functionality for Iceberg tables

2022-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18688 ) Change subject: IMPALA-11362: Add expire snapshots functionality for Iceberg tables .. Patch Set 9: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

2022-08-09 Thread Riza Suminto (Code Review)
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18804 ) Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0 .. IMPALA-11385: Upgrade JAVA thrift components

[Impala-ASF-CR] IMPALA-11465, IMPALA-11466: Bump CDP BUILD NUMBER to 30010248

2022-08-09 Thread Riza Suminto (Code Review)
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18803 ) Change subject: IMPALA-11465, IMPALA-11466: Bump CDP_BUILD_NUMBER to 30010248 .. IMPALA-11465, IMPALA-11466: Bump

[Impala-ASF-CR] IMPALA-11465, IMPALA-11466: Bump CDP BUILD NUMBER to 30010248

2022-08-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18803 ) Change subject: IMPALA-11465, IMPALA-11466: Bump CDP_BUILD_NUMBER to 30010248 .. Patch Set 3: Verified+1 Carry chain head's vote. --