[Impala-ASF-CR] WIP IMPALA-11809: Support non unique primary key for Kudu

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19383 ) Change subject: WIP IMPALA-11809: Support non unique primary key for Kudu .. Patch Set 10: Build Failed

[Impala-ASF-CR] WIP IMPALA-11809: Support non unique primary key for Kudu

2023-01-16 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/19383 ) Change subject: WIP IMPALA-11809: Support non unique primary key for Kudu .. WIP IMPALA-11809: Support non unique primary key for Kudu

[Impala-ASF-CR] WIP IMPALA-11809: Support non unique primary key for Kudu

2023-01-16 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19383 ) Change subject: WIP IMPALA-11809: Support non unique primary key for Kudu .. Patch Set 9: (16 comments) Thanks Qifan for your review.

[Impala-ASF-CR] IMPALA-11843: Fix IndexOutOfBoundsException in analytic limit pushdown

2023-01-16 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19422 ) Change subject: IMPALA-11843: Fix IndexOutOfBoundsException in analytic limit pushdown .. Patch Set 1: Thank Aman! Merging this.

[Impala-ASF-CR] IMPALA-11843: Fix IndexOutOfBoundsException in analytic limit pushdown

2023-01-16 Thread Quanlong Huang (Code Review)
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19422 ) Change subject: IMPALA-11843: Fix IndexOutOfBoundsException in analytic limit pushdown .. IMPALA-11843: Fix

[Impala-ASF-CR] IMPALA-11843: Fix IndexOutOfBoundsException in analytic limit pushdown

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19422 ) Change subject: IMPALA-11843: Fix IndexOutOfBoundsException in analytic limit pushdown .. Patch Set 1: Verified+1 -- To

[Impala-ASF-CR] IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19419 ) Change subject: IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates .. Patch Set 3:

[Impala-ASF-CR] IMPALA-11843: Fix IndexOutOfBoundsException in analytic limit pushdown

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19422 ) Change subject: IMPALA-11843: Fix IndexOutOfBoundsException in analytic limit pushdown .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-11843: Fix IndexOutOfBoundsException in analytic limit pushdown

2023-01-16 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/19422 ) Change subject: IMPALA-11843: Fix IndexOutOfBoundsException in analytic limit pushdown .. Patch Set 1: Code-Review+2 LGTM. Thanks for

[Impala-ASF-CR] IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables

2023-01-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19416 ) Change subject: IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables .. Patch Set 1:

[Impala-ASF-CR] IMPALA-11658: Implement Iceberg manifest caching config for Impala

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19423 ) Change subject: IMPALA-11658: Implement Iceberg manifest caching config for Impala .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19419 ) Change subject: IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates .. Patch Set 3:

[Impala-ASF-CR] IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates

2023-01-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19419 ) Change subject: IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates .. Patch Set 3: (13

[Impala-ASF-CR] IMPALA-11658: Implement Iceberg manifest caching config for Impala

2023-01-16 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19423 Change subject: IMPALA-11658: Implement Iceberg manifest caching config for Impala .. IMPALA-11658: Implement Iceberg manifest caching

[Impala-ASF-CR] IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates

2023-01-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Andrew Sherman, Tamas Mate, lipeng...@apache.org, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19419 to look at the new patch set (#3). Change subject: IMPALA-11826: Avoid calling planFiles() on Iceberg V2

[Impala-ASF-CR] IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19419 ) Change subject: IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates .. Patch Set 3:

[Impala-ASF-CR] IMPALA-11833: Fixed manifest length in snapshot files

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19409 ) Change subject: IMPALA-11833: Fixed manifest_length in snapshot files .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11833: Fixed manifest length in snapshot files

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19409 ) Change subject: IMPALA-11833: Fixed manifest_length in snapshot files .. IMPALA-11833: Fixed manifest_length in

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. Patch Set 10:

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. Patch Set 9: Build

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Code Review
Gergely Fürnstáhl has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. IMPALA-11821: Adjusting

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. Patch Set 7: (2

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Code Review
Gergely Fürnstáhl has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. IMPALA-11821: Adjusting

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. Patch Set 7: (1

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. Patch Set 7: (3

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2023-01-16 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. IMPALA-9551: Allow mixed complex types in select list

[Impala-ASF-CR] IMPALA-11843: Fix IndexOutOfBoundsException in analytic limit pushdown

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19422 ) Change subject: IMPALA-11843: Fix IndexOutOfBoundsException in analytic limit pushdown .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-11843: Fix IndexOutOfBoundsException in analytic limit pushdown

2023-01-16 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19422 Change subject: IMPALA-11843: Fix IndexOutOfBoundsException in analytic limit pushdown .. IMPALA-11843: Fix IndexOutOfBoundsException

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. Patch Set 7: Build

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Code Review
Gergely Fürnstáhl has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. IMPALA-11821: Adjusting

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. Patch Set 6: Build

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. Patch Set 5: Build

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Code Review
Gergely Fürnstáhl has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. IMPALA-11821: Adjusting

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. Patch Set 4: Build

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Code Review
Gergely Fürnstáhl has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. IMPALA-11821: Adjusting

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. Patch Set 5: (6

[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. IMPALA-10986 (Addendum): Add and refactor

[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 10: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. Patch Set 4: (2

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. Patch Set 1: (1

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Code Review
Gergely Fürnstáhl has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. IMPALA-11821: Adjusting

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. Patch Set 4: (6

[Impala-ASF-CR] IMPALA-11833: Fixed manifest length in snapshot files

2023-01-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19409 ) Change subject: IMPALA-11833: Fixed manifest_length in snapshot files .. Patch Set 5: Code-Review+2 Thanks for fixing this! --

[Impala-ASF-CR] IMPALA-11833: Fixed manifest length in snapshot files

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19409 ) Change subject: IMPALA-11833: Fixed manifest_length in snapshot files .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-11833: Fixed manifest length in snapshot files

2023-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19409 ) Change subject: IMPALA-11833: Fixed manifest_length in snapshot files .. Patch Set 6: Code-Review+2 -- To view, visit