[Impala-ASF-CR] IMPALA-12433: Share buffers among channels in KrpcDataStreamSender

2024-02-01 Thread Zihao Ye (Code Review)
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20719 ) Change subject: IMPALA-12433: Share buffers among channels in KrpcDataStreamSender .. Patch Set 12: Code-Review+1 (2 comments) Looks

[Impala-ASF-CR] IMPALA-12718: Provides UTF-8 support for the trim functions

2024-02-01 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20926 ) Change subject: IMPALA-12718: Provides UTF-8 support for the trim functions .. Patch Set 12: Code-Review+2 Carry Riza's +1. -- To

[Impala-ASF-CR] IMPALA-12718: Provides UTF-8 support for the trim functions

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20926 ) Change subject: IMPALA-12718: Provides UTF-8 support for the trim functions .. Patch Set 13: Build started:

[Impala-ASF-CR] IMPALA-12718: Provides UTF-8 support for the trim functions

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20926 ) Change subject: IMPALA-12718: Provides UTF-8 support for the trim functions .. Patch Set 13: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12718: Provides UTF-8 support for the trim functions

2024-02-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20926 ) Change subject: IMPALA-12718: Provides UTF-8 support for the trim functions .. Patch Set 12: Code-Review+1 (1 comment) Thank you!

[Impala-ASF-CR] IMPALA-12780: Only show non-default options in the catalog operations page

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20985 ) Change subject: IMPALA-12780: Only show non-default options in the catalog operations page .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12780: Only show non-default options in the catalog operations page

2024-02-01 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20985 Change subject: IMPALA-12780: Only show non-default options in the catalog operations page .. IMPALA-12780: Only show non-default

[Impala-ASF-CR] IMPALA-12718: Provides UTF-8 support for the trim functions

2024-02-01 Thread Zihao Ye (Code Review)
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20926 ) Change subject: IMPALA-12718: Provides UTF-8 support for the trim functions .. Patch Set 11: (1 comment) Thank you for the code review!

[Impala-ASF-CR] IMPALA-12778: Fix time strings in catalog operations page

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20983 ) Change subject: IMPALA-12778: Fix time strings in catalog operations page .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-12718: Provides UTF-8 support for the trim functions

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20926 ) Change subject: IMPALA-12718: Provides UTF-8 support for the trim functions .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-12770: Fix infinite loop for nested Case expressions

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20982 ) Change subject: IMPALA-12770: Fix infinite loop for nested Case expressions .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-12778: Fix time strings in catalog operations page

2024-02-01 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20983 ) Change subject: IMPALA-12778: Fix time strings in catalog operations page .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12718: Provides UTF-8 support for the trim functions

2024-02-01 Thread Zihao Ye (Code Review)
Hello Quanlong Huang, Riza Suminto, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20926 to look at the new patch set (#12). Change subject: IMPALA-12718: Provides UTF-8 support for the trim functions

[Impala-ASF-CR] IMPALA-12778: Fix time strings in catalog operations page

2024-02-01 Thread Zihao Ye (Code Review)
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20983 ) Change subject: IMPALA-12778: Fix time strings in catalog operations page .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12770: Fix infinite loop for nested Case expressions

2024-02-01 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20982 ) Change subject: IMPALA-12770: Fix infinite loop for nested Case expressions .. IMPALA-12770: Fix infinite loop for nested Case expressions

[Impala-ASF-CR] IMPALA-12778: Fix time strings in catalog operations page

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20983 ) Change subject: IMPALA-12778: Fix time strings in catalog operations page .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12770: Fix infinite loop for nested Case expressions

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20982 ) Change subject: IMPALA-12770: Fix infinite loop for nested Case expressions .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12778: Fix time strings in catalog operations page

2024-02-01 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20983 Change subject: IMPALA-12778: Fix time strings in catalog operations page .. IMPALA-12778: Fix time strings in catalog operations page

[Impala-ASF-CR] IMPALA-12770: Fix infinite loop for nested Case expressions

2024-02-01 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20982 Change subject: IMPALA-12770: Fix infinite loop for nested Case expressions .. IMPALA-12770: Fix infinite loop for nested Case

[Impala-ASF-CR] IMPALA-12607: Bump the GBN and fetch events specific to the db/table from the metastore

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20979 ) Change subject: IMPALA-12607: Bump the GBN and fetch events specific to the db/table from the metastore .. Patch Set 1:

[Impala-ASF-CR] IMPALA-12607: Bump the GBN and fetch events specific to the db/table from the metastore

2024-02-01 Thread Sai Hemanth Gantasala (Code Review)
Sai Hemanth Gantasala has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20979 Change subject: IMPALA-12607: Bump the GBN and fetch events specific to the db/table from the metastore .. IMPALA-12607: Bump

[Impala-ASF-CR] IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20204 ) Change subject: IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile .. Patch Set 11: Verified-1

[Impala-ASF-CR] IMPALA-12718: Provides UTF-8 support for the trim functions

2024-02-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20926 ) Change subject: IMPALA-12718: Provides UTF-8 support for the trim functions .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-12503: Support date data type for predicates for external data source table

2024-02-01 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20915 ) Change subject: IMPALA-12503: Support date data type for predicates for external data source table .. Patch Set 13: (3 comments)

[Impala-ASF-CR] IMPALA-12503: Support date data type for predicates for external data source table

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20915 ) Change subject: IMPALA-12503: Support date data type for predicates for external data source table .. Patch Set 13: Build

[Impala-ASF-CR] IMPALA-12503: Support date data type for predicates for external data source table

2024-02-01 Thread gaurav singh (Code Review)
gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/20915 ) Change subject: IMPALA-12503: Support date data type for predicates for external data source table .. Patch Set 13: (4 comments)

[Impala-ASF-CR] IMPALA-12503: Support date data type for predicates for external data source table

2024-02-01 Thread gaurav singh (Code Review)
Hello Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20915 to look at the new patch set (#13). Change subject: IMPALA-12503: Support date data type for predicates for external data source table

[Impala-ASF-CR] IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile

2024-02-01 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20204 ) Change subject: IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile .. Patch Set 11: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest

2024-02-01 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20922 ) Change subject: IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest .. Patch Set 6: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest

2024-02-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20922 ) Change subject: IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest

2024-02-01 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20922 to look at the new patch set (#6). Change subject: IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest

[Impala-ASF-CR] IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest

2024-02-01 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20922 ) Change subject: IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest .. Patch Set 5: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20204 ) Change subject: IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile .. Patch Set 11: Build

[Impala-ASF-CR] IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest

2024-02-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20922 ) Change subject: IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20922 ) Change subject: IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-12503: Support date data type for predicates for external data source table

2024-02-01 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20915 ) Change subject: IMPALA-12503: Support date data type for predicates for external data source table .. Patch Set 12: (6 comments)

[Impala-ASF-CR] IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20204 ) Change subject: IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile .. Patch Set 10: Build Failed

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 ) Change subject: IMPALA-12426: Query History Table .. Patch Set 17: Build Failed

[Impala-ASF-CR] IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile

2024-02-01 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded a new patch set (#11) to the change originally created by Gergely Fürnstáhl. ( http://gerrit.cloudera.org:8080/20204 ) Change subject: IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile

[Impala-ASF-CR] IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20204 ) Change subject: IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest

2024-02-01 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20922 to look at the new patch set (#5). Change subject: IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest

[Impala-ASF-CR] IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20204 ) Change subject: IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile

2024-02-01 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded a new patch set (#10) to the change originally created by Gergely Fürnstáhl. ( http://gerrit.cloudera.org:8080/20204 ) Change subject: IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile

[Impala-ASF-CR] IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile

2024-02-01 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20204 ) Change subject: IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile .. Patch Set 9: (3 comments) Thanks

[Impala-ASF-CR] IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest

2024-02-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20922 ) Change subject: IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-02-01 Thread Jason Fehr (Code Review)
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 ) Change subject: IMPALA-12426: Query History Table .. Patch Set 16: (1 comment)

[Impala-ASF-CR] IMPALA-12426: Query History Table

2024-02-01 Thread Jason Fehr (Code Review)
Hello Andrew Sherman, Riza Suminto, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20770 to look at the new patch set (#17). Change subject: IMPALA-12426: Query History Table

[Impala-ASF-CR] IMPALA-12503: Support date data type for predicates for external data source table

2024-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20915 ) Change subject: IMPALA-12503: Support date data type for predicates for external data source table .. Patch Set 12: Build

[Impala-ASF-CR] IMPALA-12503: Support date data type for predicates for external data source table

2024-02-01 Thread gaurav singh (Code Review)
gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/20915 ) Change subject: IMPALA-12503: Support date data type for predicates for external data source table .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-12503: Support date data type for predicates for external data source table

2024-02-01 Thread gaurav singh (Code Review)
gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/20915 ) Change subject: IMPALA-12503: Support date data type for predicates for external data source table .. Patch Set 12: (2 comments)

[Impala-ASF-CR] IMPALA-12503: Support date data type for predicates for external data source table

2024-02-01 Thread gaurav singh (Code Review)
Hello Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20915 to look at the new patch set (#12). Change subject: IMPALA-12503: Support date data type for predicates for external data source table

[Impala-ASF-CR] IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile

2024-02-01 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20204 ) Change subject: IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile .. Patch Set 9: (3 comments) Thanks for