[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-18 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Lars Volker, David Rorke, Sahil Takiar, Todd Lipcon, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12987 to look at the new patch set (#4). Change subject: IMPALA-8341: Data

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-18 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Lars Volker, David Rorke, Sahil Takiar, Todd Lipcon, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12987 to look at the new patch set (#3). Change subject: IMPALA-8341: Data

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 3: (8 comments)

[Impala-ASF-CR] IMPALA-8138: Remove FAULT INJECTION RPC DELAY

2019-04-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13060 ) Change subject: IMPALA-8138: Remove FAULT_INJECTION_RPC_DELAY .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8414: Skip header when parsing /proc/net/dev

2019-04-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13016 ) Change subject: IMPALA-8414: Skip header when parsing /proc/net/dev .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 2: TODO: - add a test to rotate the files in data-cache-test.cc -

[Impala-ASF-CR] XXX

2019-04-16 Thread Michael Ho (Code Review)
Michael Ho has abandoned this change. ( http://gerrit.cloudera.org:8080/13026 ) Change subject: XXX .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/13026 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-16 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Lars Volker, David Rorke, Sahil Takiar, Todd Lipcon, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12987 to look at the new patch set (#2). Change subject: IMPALA-8341: Data

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: (71 comments) This new patch changes the configuration string

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-04-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12297 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 1: (6 comments) Thanks for working on this patch. My

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: (3 comments) > Another option would be to do a global

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 9: (11 comments)

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 2: Code-Review+1 (4 comments)

[Impala-ASF-CR] IMPALA-7981: Add host disk statistics to profile

2019-04-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 ) Change subject: IMPALA-7981: Add host disk statistics to profile .. Patch Set 6: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-10 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12987 Change subject: IMPALA-8341: Data cache for remote reads .. IMPALA-8341: Data cache for remote reads This is a patch based on PhilZ's

[Impala-ASF-CR] IMPALA-8395: Parse older formats of /proc/net/dev correctly

2019-04-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12954 ) Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7981: Add host disk statistics to profile

2019-04-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 ) Change subject: IMPALA-7981: Add host disk statistics to profile .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-8395: Parse older formats of /proc/net/dev correctly

2019-04-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12954 ) Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7981: Add host disk usage to profile

2019-04-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 ) Change subject: IMPALA-7981: Add host disk usage to profile .. Patch Set 2: (10 comments)

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 7: (5 comments)

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-04-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12299 ) Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .. Patch Set 7: (6 comments)

[Impala-ASF-CR] IMPALA-7800: Time out new connections after --fe service threads

2019-03-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Time out new connections after --fe_service_threads .. Patch Set 13: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 2: (19 comments)

[Impala-ASF-CR] IMPALA-7800: Time out new connections after --fe service threads

2019-03-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Time out new connections after --fe_service_threads .. Patch Set 11: (2 comments) Looking good. Please

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 10: (9 comments) LGTM. Mostly nits.

[Impala-ASF-CR] Add extra TRACE calls for cancellation code path

2019-03-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12832 ) Change subject: Add extra TRACE calls for cancellation code path .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-8277: support ranges in CPU lists

2019-03-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12755 ) Change subject: IMPALA-8277: support ranges in CPU lists .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8299: Fix crash in GroupingAggregator on uninited hash table

2019-03-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12746 ) Change subject: IMPALA-8299: Fix crash in GroupingAggregator on uninited hash table .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-03-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 6: (6 comments) Looking good. Please see

[Impala-ASF-CR] IMPALA-8097: mt dop for all queries via hidden flag

2019-03-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12257 ) Change subject: IMPALA-8097: mt_dop for all queries via hidden flag .. Patch Set 8: Code-Review+1 (2 comments) Sorry again for the

[Impala-ASF-CR] [DOCS] Add HADOOP-15720 to the list of Known Issues

2019-03-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12631 ) Change subject: [DOCS] Add HADOOP-15720 to the list of Known Issues .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc

2019-03-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10679 ) Change subject: IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8097: mt dop for all queries via hidden flag

2019-03-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12257 ) Change subject: IMPALA-8097: mt_dop for all queries via hidden flag .. Patch Set 8: Sorry, will get back to it this week. -- To view,

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-03-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12624 ) Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. Patch Set 5: Code-Review+2 Rebase. Carry

[Impala-ASF-CR] IMPALA-8274: Fix iteration of profiles in ApplyExecStatusReport()

2019-03-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12651 ) Change subject: IMPALA-8274: Fix iteration of profiles in ApplyExecStatusReport() .. Patch Set 2: Waiting for

[Impala-ASF-CR] IMPALA-8274: Fix iteration of profiles in ApplyExecStatusReport()

2019-03-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12651 ) Change subject: IMPALA-8274: Fix iteration of profiles in ApplyExecStatusReport() .. Patch Set 2: Code-Review+2 Added a line of

[Impala-ASF-CR] IMPALA-8274: Fix iteration of profiles in ApplyExecStatusReport()

2019-03-04 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12651 to look at the new patch set (#2). Change subject: IMPALA-8274: Fix iteration of profiles in ApplyExecStatusReport()

[Impala-ASF-CR] IMPALA-8274: Fix iteration of profiles in ApplyExecStatusReport()

2019-03-04 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12651 Change subject: IMPALA-8274: Fix iteration of profiles in ApplyExecStatusReport() .. IMPALA-8274: Fix iteration of profiles in

[Impala-ASF-CR] [DOCS] Add HADOOP-15720 to the list of Known Issues

2019-03-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12631 ) Change subject: [DOCS] Add HADOOP-15720 to the list of Known Issues .. Patch Set 4: (2 comments) LGTM. Please fix the other two usages

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-03-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 5: (5 comments)

[Impala-ASF-CR] [DOCS] Add HADOOP-15720 to the list of Known Issues

2019-03-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12631 ) Change subject: [DOCS] Add HADOOP-15720 to the list of Known Issues .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-03-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12624 ) Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-02-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12624 ) Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-02-28 Thread Michael Ho (Code Review)
Hello Andrew Sherman, Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12624 to look at the new patch set (#3). Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

[Impala-ASF-CR] IMPALA-8264: Fix overflow in SystemStateInfo::ComputeCpuRatios

2019-02-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12638 ) Change subject: IMPALA-8264: Fix overflow in SystemStateInfo::ComputeCpuRatios .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-02-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12579 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 3: (10 comments)

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-02-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12624 ) Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-02-27 Thread Michael Ho (Code Review)
Hello Andrew Sherman, Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12624 to look at the new patch set (#2). Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-02-27 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12624 Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. IMPALA-8256: Better error message for

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-02-27 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12623 Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. IMPALA-8256: Better error message for

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-02-27 Thread Michael Ho (Code Review)
Michael Ho has abandoned this change. ( http://gerrit.cloudera.org:8080/12623 ) Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. Abandoned -- To view, visit

[Impala-ASF-CR] IMPALA-4568: Cache parquet footer

2019-02-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12622 ) Change subject: IMPALA-4568: Cache parquet footer .. Patch Set 1: Sorry, pushing the wrong branch. This is WIP. Definitely not meant for

[Impala-ASF-CR] IMPALA-4568: Cache parquet footer

2019-02-27 Thread Michael Ho (Code Review)
Michael Ho has abandoned this change. ( http://gerrit.cloudera.org:8080/12622 ) Change subject: IMPALA-4568: Cache parquet footer .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/12622 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4568: Cache parquet footer

2019-02-27 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12622 Change subject: IMPALA-4568: Cache parquet footer .. IMPALA-4568: Cache parquet footer Change-Id:

[Impala-ASF-CR] IMPALA-8251: Run test exchange deferred batches in dev builds only

2019-02-26 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12610 Change subject: IMPALA-8251: Run test_exchange_deferred_batches in dev builds only .. IMPALA-8251: Run test_exchange_deferred_batches in

[Impala-ASF-CR] IMPALA-8251: Run test exchange deferred batches in dev builds only

2019-02-26 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12610 to look at the new patch set (#2). Change subject: IMPALA-8251: Run test_exchange_deferred_batches in dev builds only

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-02-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12299 ) Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .. Patch Set 2: (1 comment)

[Impala-ASF-CR] [DOCS] Noted IMPALA-8154 as fixed in Known Issues doc

2019-02-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12551 ) Change subject: [DOCS] Noted IMPALA-8154 as fixed in Known Issues doc .. Patch Set 1: Sorry for the delay. +2'ed -- To view, visit

[Impala-ASF-CR] [DOCS] Noted IMPALA-8154 as fixed in Known Issues doc

2019-02-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12551 ) Change subject: [DOCS] Noted IMPALA-8154 as fixed in Known Issues doc .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-02-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12297 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 1: Any update ? -- To view, visit

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-02-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12299 ) Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .. Patch Set 2: Any update ? -- To view, visit

[Impala-ASF-CR] IMPALA-8239: Fix handling of failed deserialization of row batch

2019-02-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12567 ) Change subject: IMPALA-8239: Fix handling of failed deserialization of row batch .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-8239: Fix handling of failed deserialization of row batch

2019-02-25 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12567 to look at the new patch set (#3). Change subject: IMPALA-8239: Fix handling of failed deserialization of row batch

[Impala-ASF-CR] IMPALA-8239: Fix handling of failed deserialization of row batch

2019-02-25 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12567 to look at the new patch set (#4). Change subject: IMPALA-8239: Fix handling of failed deserialization of row batch

[Impala-ASF-CR] IMPALA-8239: Fix handling of failed deserialization of row batch

2019-02-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12567 ) Change subject: IMPALA-8239: Fix handling of failed deserialization of row batch .. Patch Set 2: Code-Review+1 Carry Lars' +1 -- To

[Impala-ASF-CR] IMPALA-8239: Fix handling of failed deserialization of row batch

2019-02-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12567 ) Change subject: IMPALA-8239: Fix handling of failed deserialization of row batch .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-8239: Fix handling of failed deserialization of row batch

2019-02-25 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12567 to look at the new patch set (#2). Change subject: IMPALA-8239: Fix handling of failed deserialization of row batch

[Impala-ASF-CR] IMPALA-8239: Fix handling of failed deserialization of row batch

2019-02-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12567 ) Change subject: IMPALA-8239: Fix handling of failed deserialization of row batch .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8239: Fix handling of failed deserialization of row batch

2019-02-23 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12567 Change subject: IMPALA-8239: Fix handling of failed deserialization of row batch .. IMPALA-8239: Fix handling of failed deserialization of

[Impala-ASF-CR] IMPALA-8212 / KUDU-2706: Work around the lack of thread safety in krb5 parse name()

2019-02-21 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12553 ) Change subject: IMPALA-8212 / KUDU-2706: Work around the lack of thread safety in krb5_parse_name() .. Removed reviewer Kudu

[Impala-ASF-CR] IMPALA-8239 / KUDU-2706: Work around the lack of thread safety in krb5 parse name()

2019-02-21 Thread Michael Ho (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12553 to review the following change. Change subject: IMPALA-8239 / KUDU-2706: Work around the lack of thread safety in krb5_parse_name()

[Impala-ASF-CR] IMPALA-8239 / KUDU-2706: Work around the lack of thread safety in krb5 parse name()

2019-02-21 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12553 ) Change subject: IMPALA-8239 / KUDU-2706: Work around the lack of thread safety in krb5_parse_name() .. Removed reviewer Kudu

[Impala-ASF-CR] IMPALA-8235: avoid TIME MS in runtime profile

2019-02-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12544 ) Change subject: IMPALA-8235: avoid TIME_MS in runtime profile .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8235: avoid TIME MS in runtime profile

2019-02-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12544 ) Change subject: IMPALA-8235: avoid TIME_MS in runtime profile .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8235: avoid TIME MS in runtime profile

2019-02-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12544 ) Change subject: IMPALA-8235: avoid TIME_MS in runtime profile .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-8187: UDF samples hide symbols by default

2019-02-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12451 ) Change subject: IMPALA-8187: UDF samples hide symbols by default .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8187: UDF samples hide symbols by default

2019-02-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12451 ) Change subject: IMPALA-8187: UDF samples hide symbols by default .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8187: UDF samples hide symbols by default

2019-02-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12451 ) Change subject: IMPALA-8187: UDF samples hide symbols by default .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8187: UDF samples hide symbols by default

2019-02-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12451 ) Change subject: IMPALA-8187: UDF samples hide symbols by default .. Patch Set 3: Zoram, can you please also take a look ? -- To view,

[Impala-ASF-CR] IMPALA-8187: UDF samples hide symbols by default

2019-02-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12451 ) Change subject: IMPALA-8187: UDF samples hide symbols by default .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8183: fix test reportexecstatus retry flakiness

2019-02-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12461 ) Change subject: IMPALA-8183: fix test_reportexecstatus_retry flakiness .. Patch Set 1: Code-Review+2 (2 comments)

[Impala-ASF-CR] Add support for compiling using OpenSSL 1.1

2019-02-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12420 ) Change subject: Add support for compiling using OpenSSL 1.1 .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] Add support for compiling using OpenSSL 1.1

2019-02-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12420 ) Change subject: Add support for compiling using OpenSSL 1.1 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Add support for compiling using OpenSSL 1.1

2019-02-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12420 ) Change subject: Add support for compiling using OpenSSL 1.1 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Add support for compiling using OpenSSL 1.1

2019-02-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12420 ) Change subject: Add support for compiling using OpenSSL 1.1 .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8154: Disable Kerberos auth to local setting

2019-02-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12405 ) Change subject: IMPALA-8154: Disable Kerberos auth_to_local setting .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8170: [DOCS] Added a section on load balancing proxy with TLS

2019-02-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12388 ) Change subject: IMPALA-8170: [DOCS] Added a section on load balancing proxy with TLS .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8064: Improve observability of wait times for runtime filters

2019-02-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12401 ) Change subject: IMPALA-8064: Improve observability of wait times for runtime filters .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-8154: Disable Kerberos auth to local setting

2019-02-07 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12405 Change subject: IMPALA-8154: Disable Kerberos auth_to_local setting .. IMPALA-8154: Disable Kerberos auth_to_local setting Before KRPC,

[Impala-ASF-CR] IMPALA-8170: [DOCS] Added a section on load balancing proxy with TLS

2019-02-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12388 ) Change subject: IMPALA-8170: [DOCS] Added a section on load balancing proxy with TLS .. Patch Set 2: Will do. -- To view, visit

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-02-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-02-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 7: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-02-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 5: Code-Review+2 (7 comments) LGTM. Please

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 4: (9 comments)

[Impala-ASF-CR] IMPALA-7565: Set TAcceptQueueServer connection setup pool to be multi-threaded by default

2019-02-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12249 ) Change subject: IMPALA-7565: Set TAcceptQueueServer connection_setup_pool to be multi-threaded by default .. Patch Set 2: Code-Review+2

<    1   2   3   4   5   6   7   8   9   10   >