[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-07 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19328 to look at the new patch set (#2). Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19328 Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used ..

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 13: Code-Review+2 LGTM! -- To

[Impala-ASF-CR] IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState

2022-12-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19289 ) Change subject: IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState .. Patch Set 3:

[Impala-ASF-CR] IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState

2022-12-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19289 ) Change subject: IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState .. Patch Set 2:

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 10: (5 comments) Left some minor

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-11-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 7: Code-Review+2 LGTM! -- To

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-11-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 6: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState

2022-11-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19289 ) Change subject: IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState .. Patch Set 1: (4

[Impala-ASF-CR] IMPALA-11753: CatalogD OOMkilled due to natively allocated memory

2022-11-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19282 ) Change subject: IMPALA-11753: CatalogD OOMkilled due to natively allocated memory .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-11753: CatalogD OOMkilled due to natively allocated memory

2022-11-29 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Laszlo Gaal, Gergely Fürnstáhl, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19282 to look at the new patch set (#2). Change subject: IMPALA-11753: CatalogD OOMkilled due to natively allocated

[Impala-ASF-CR] IMPALA-11753: CatalogD OOMkilled due to natively allocated memory

2022-11-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19282 Change subject: IMPALA-11753: CatalogD OOMkilled due to natively allocated memory .. IMPALA-11753: CatalogD OOMkilled due to

[Impala-ASF-CR] IMPALA-11739: Skip pushing down BinaryPredicate with NullLiteral for Iceberg tables

2022-11-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19270 ) Change subject: IMPALA-11739: Skip pushing down BinaryPredicate with NullLiteral for Iceberg tables .. Patch Set 5: Code-Review+2

[Impala-ASF-CR] IMPALA-11739: Skip pushing down BinaryPredicate with NullLiteral for Iceberg tables

2022-11-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19270 ) Change subject: IMPALA-11739: Skip pushing down BinaryPredicate with NullLiteral for Iceberg tables .. IMPALA-11739: Skip

[Impala-ASF-CR] IMPALA-11740: Incorrect results for partitioned Iceberg V2 tables when runtime filters are applied

2022-11-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19274 ) Change subject: IMPALA-11740: Incorrect results for partitioned Iceberg V2 tables when runtime filters are applied .. Patch Set

[Impala-ASF-CR] IMPALA-11740: Incorrect results for partitioned Iceberg V2 tables when runtime filters are applied

2022-11-24 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19274 to look at the new patch set (#2). Change subject: IMPALA-11740: Incorrect results for partitioned Iceberg V2 tables when runtime

[Impala-ASF-CR] IMPALA-11740: Incorrect results for partitioned Iceberg V2 tables when runtime filters are applied

2022-11-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19274 Change subject: IMPALA-11740: Incorrect results for partitioned Iceberg V2 tables when runtime filters are applied ..

[Impala-ASF-CR] IMPALA-11734: TestIcebergTable.test compute stats fails in RELEASE builds

2022-11-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19260 ) Change subject: IMPALA-11734: TestIcebergTable.test_compute_stats fails in RELEASE builds .. Patch Set 2: Code-Review+2 Thanks

[Impala-ASF-CR] IMPALA-11676: Prettify asf-site docs

2022-11-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19242 ) Change subject: IMPALA-11676: Prettify asf-site docs .. Patch Set 2: Code-Review+2 Thanks for this work! -- To view, visit

[Impala-ASF-CR] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement

2022-11-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19145 ) Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement .. Patch Set 3: (7 comments) Thanks for working on this.

[Impala-ASF-CR] IMPALA-11721: Impala query keep being retried over frequently updated iceberg table

2022-11-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19234 ) Change subject: IMPALA-11721: Impala query keep being retried over frequently updated iceberg table .. Patch Set 3: Code-Review+2

[Impala-ASF-CR] IMPALA-11721: Impala query keep being retried over frequently updated iceberg table

2022-11-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Qifan Chen, Riza Suminto, lipeng...@sensorsdata.cn, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19234 to look at the new patch set (#3). Change subject: IMPALA-11721: Impala query keep being retried over

[Impala-ASF-CR] IMPALA-11676: Prettify asf-site docs

2022-11-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19242 ) Change subject: IMPALA-11676: Prettify asf-site docs .. Patch Set 1: Code-Review+1 (1 comment) Thanks for working on this! The

[Impala-ASF-CR] IMPALA-11721: Impala query keep being retried over frequently updated iceberg table

2022-11-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19234 ) Change subject: IMPALA-11721: Impala query keep being retried over frequently updated iceberg table .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-11721: Impala query keep being retried over frequently updated iceberg table

2022-11-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Qifan Chen, Riza Suminto, lipeng...@sensorsdata.cn, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19234 to look at the new patch set (#2). Change subject: IMPALA-11721: Impala query keep being retried over

[Impala-ASF-CR] IMPALA-11721: Impala query keep being retried over frequently updated iceberg table

2022-11-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19234 Change subject: IMPALA-11721: Impala query keep being retried over frequently updated iceberg table .. IMPALA-11721: Impala query

[Impala-ASF-CR] IMPALA-11711: Virtual columns should be skipped in 'FileMetadataUtils::AddIcebergColumns'

2022-11-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19223 ) Change subject: IMPALA-11711: Virtual columns should be skipped in 'FileMetadataUtils::AddIcebergColumns' .. Patch Set 1:

[Impala-ASF-CR] IMPALA-9488: Add metrics for EC reads

2022-11-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19178 ) Change subject: IMPALA-9488: Add metrics for EC reads .. Patch Set 15: Code-Review+2 Thanks for adding these metrics, LGTM! --

[Impala-ASF-CR] IMPALA-11681: Set table stats for the Iceberg table by it's partition stats

2022-11-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19168 ) Change subject: IMPALA-11681: Set table stats for the Iceberg table by it's partition stats .. Patch Set 10: Code-Review+2 --

[Impala-ASF-CR] IMPALA-9488: Add metrics for EC reads

2022-11-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19178 ) Change subject: IMPALA-9488: Add metrics for EC reads .. Patch Set 13: Code-Review+1 (2 comments) Thanks for working on this,

[Impala-ASF-CR] IMPALA-11681: Set table stats for the Iceberg table by it's partition stats

2022-11-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19168 ) Change subject: IMPALA-11681: Set table stats for the Iceberg table by it's partition stats .. Patch Set 8: Code-Review+2 Thanks

[Impala-ASF-CR] IMPALA-11681: Set table stats for the Iceberg table by it's partition stats

2022-11-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19168 ) Change subject: IMPALA-11681: Set table stats for the Iceberg table by it's partition stats .. Patch Set 6: (2 comments) Thanks

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-11-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 ) Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. Patch Set 9: Thanks everyone for the review! -- To

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-11-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 ) Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. Patch Set 7: (4 comments) Thanks for the comments!

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-11-02 Thread Zoltan Borok-Nagy (Code Review)
Hello Andrew Sherman, Tamas Mate, lipeng...@sensorsdata.cn, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19043 to look at the new patch set (#8). Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables

[Impala-ASF-CR] IMPALA-11680: Fix test krpc datastream sender shuffle

2022-10-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19161 ) Change subject: IMPALA-11680: Fix test_krpc_datastream_sender_shuffle .. Patch Set 2: Code-Review+2 Thanks for fixing this! --

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-10-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 ) Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. Patch Set 6: I struggled reproducing the issue in

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-10-27 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19043 to look at the new patch set (#6). Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-10-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 ) Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. Patch Set 5: PS4 fixes the failing tests. PS5 is a

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-10-25 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19043 to look at the new patch set (#5). Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-10-25 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19043 to look at the new patch set (#4). Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables

[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-10-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19164 ) Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID tables .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-11607: Support for TPC-H and TPC-DS test datasets stored as Iceberg tables

2022-10-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19114 ) Change subject: IMPALA-11607: Support for TPC-H and TPC-DS test datasets stored as Iceberg tables .. Patch Set 11: Code-Review+2

[Impala-ASF-CR] IMPALA-11608: Fix SHOW TABLE STATS iceberg tbl shows wrong number of files

2022-10-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19150 ) Change subject: IMPALA-11608: Fix SHOW TABLE STATS iceberg_tbl shows wrong number of files .. Patch Set 3: Code-Review+2 Thanks

[Impala-ASF-CR] IMPALA-11608: Fix SHOW TABLE STATS iceberg tbl shows wrong number of files

2022-10-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19150 ) Change subject: IMPALA-11608: Fix SHOW TABLE STATS iceberg_tbl shows wrong number of files .. Patch Set 2: Code-Review+1 (2

[Impala-ASF-CR] IMPALA-11607: Support for TPC-H and TPC-DS test datasets stored as Iceberg tables

2022-10-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19114 ) Change subject: IMPALA-11607: Support for TPC-H and TPC-DS test datasets stored as Iceberg tables .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-11666: Modify the warning message when table statistics may be corrupt

2022-10-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19148 ) Change subject: IMPALA-11666: Modify the warning message when table statistics may be corrupt .. Patch Set 4: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-11674: Fix timeout detection for TSSLSocket

2022-10-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19157 ) Change subject: IMPALA-11674: Fix timeout detection for TSSLSocket .. Patch Set 4: Code-Review+2 Thanks for fixing this! The

[Impala-ASF-CR] IMPALA-11607: Support for TPC-H and TPC-DS test datasets stored as Iceberg tables

2022-10-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19114 ) Change subject: IMPALA-11607: Support for TPC-H and TPC-DS test datasets stored as Iceberg tables .. Patch Set 8: (3 comments)

[Impala-ASF-CR] IMPALA-11608: Fix SHOW TABLE STATS iceberg tbl shows wrong number of files

2022-10-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19150 ) Change subject: IMPALA-11608: Fix SHOW TABLE STATS iceberg_tbl shows wrong number of files .. Patch Set 1: (3 comments) Thanks

[Impala-ASF-CR] IMPALA-11581: ALTER TABLE RENAME TO doesn't update transient lastDdlTime

2022-10-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19137 ) Change subject: IMPALA-11581: ALTER TABLE RENAME TO doesn't update transient_lastDdlTime .. Patch Set 3: Code-Review+2 Thanks

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-10-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 ) Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. Patch Set 3: (7 comments) Thanks for the comments!

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-10-17 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19043 to look at the new patch set (#3). Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

2022-10-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19138 ) Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default .. Patch Set 2: (3 comments) Thanks for

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

2022-10-17 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Riza Suminto, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19138 to look at the new patch set (#2). Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default

[Impala-ASF-CR] IMPALA-10715: test decimal min max filters failed in exhaustive run

2022-10-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19132 ) Change subject: IMPALA-10715: test decimal min max filters failed in exhaustive run .. Patch Set 3: Code-Review+2 LGTM! -- To

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

2022-10-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19138 Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default .. IMPALA-11655: Impala should set write

[Impala-ASF-CR] IMPALA-11562: Revert support for o3fs as default filesystem

2022-09-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19001 ) Change subject: IMPALA-11562: Revert support for o3fs as default filesystem .. Patch Set 8: (2 comments) LGTM!

[Impala-ASF-CR] IMPALA-11562: Revert support for o3fs as default filesystem

2022-09-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19001 ) Change subject: IMPALA-11562: Revert support for o3fs as default filesystem .. Patch Set 8: Code-Review+1 (2 comments) Thanks

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-09-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 ) Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-11438, IMPALA-11594: update test for non-HDFS

2022-09-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19037 ) Change subject: IMPALA-11438, IMPALA-11594: update test for non-HDFS .. Patch Set 3: Code-Review+2 LGTM! -- To view, visit

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-09-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19043 Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. IMPALA-11591: Avoid calling planFiles() on Iceberg

[Impala-ASF-CR] IMPALA-11582: Implement table sampling for Iceberg tables

2022-09-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18989 ) Change subject: IMPALA-11582: Implement table sampling for Iceberg tables .. Patch Set 5: Code-Review+2 (1 comment) Test failed

[Impala-ASF-CR] IMPALA-11582: Implement table sampling for Iceberg tables

2022-09-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Andrew Sherman, Tamas Mate, Daniel Becker, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18989 to look at the new patch set (#5). Change subject: IMPALA-11582: Implement table

[Impala-ASF-CR] IMPALA-11582: Implement table sampling for Iceberg tables

2022-09-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18989 ) Change subject: IMPALA-11582: Implement table sampling for Iceberg tables .. Patch Set 4: (6 comments) Thanks for the comments.

[Impala-ASF-CR] IMPALA-11582: Implement table sampling for Iceberg tables

2022-09-23 Thread Zoltan Borok-Nagy (Code Review)
Hello Andrew Sherman, Tamas Mate, Daniel Becker, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18989 to look at the new patch set (#4). Change subject: IMPALA-11582: Implement table

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-11508: Deflake test expire snapshots

2022-09-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19036 Change subject: IMPALA-11508: Deflake test_expire_snapshots .. IMPALA-11508: Deflake test_expire_snapshots Before this patch

[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt part 2

2022-09-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19035 Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt part 2 .. IMPALA-11572: deflake test_mt_dop_skew_lpt part 2 I suspect

[Impala-ASF-CR] IMPALA-11583: Use Iceberg API to update stats

2022-09-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18995 ) Change subject: IMPALA-11583: Use Iceberg API to update stats .. Patch Set 8: Fixed bug found by GVO: in old catalog mode COMPUTE

[Impala-ASF-CR] IMPALA-11583: Use Iceberg API to update stats

2022-09-22 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18995 to look at the new patch set (#8). Change subject: IMPALA-11583: Use Iceberg API to update stats

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. Patch Set 5: (6 comments) Looks great! Left a

[Impala-ASF-CR] IMPALA-11583: Use Iceberg API to update stats

2022-09-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18995 ) Change subject: IMPALA-11583: Use Iceberg API to update stats .. Patch Set 6: (3 comments) Thanks for the comments.

[Impala-ASF-CR] IMPALA-11583: Use Iceberg API to update stats

2022-09-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18995 to look at the new patch set (#6). Change subject: IMPALA-11583: Use Iceberg API to update stats

[Impala-ASF-CR] IMPALA-11583: Use Iceberg API to update stats

2022-09-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18995 to look at the new patch set (#5). Change subject: IMPALA-11583: Use Iceberg API to update stats

[Impala-ASF-CR] IMPALA-11582: Implement table sampling for Iceberg tables

2022-09-19 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18989 to look at the new patch set (#3). Change subject: IMPALA-11582: Implement table sampling for Iceberg tables

[Impala-ASF-CR] IMPALA-11583: Use Iceberg API to update stats

2022-09-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18995 ) Change subject: IMPALA-11583: Use Iceberg API to update stats .. Patch Set 1: (5 comments) Thanks for the comments!

[Impala-ASF-CR] IMPALA-11583: Use Iceberg API to update stats

2022-09-19 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18995 to look at the new patch set (#4). Change subject: IMPALA-11583: Use Iceberg API to update stats

[Impala-ASF-CR] IMPALA-11583: Use Iceberg API to update stats

2022-09-19 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18995 to look at the new patch set (#3). Change subject: IMPALA-11583: Use Iceberg API to update stats

[Impala-ASF-CR] IMPALA-11583: Use Iceberg API to update stats

2022-09-19 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18995 to look at the new patch set (#2). Change subject: IMPALA-11583: Use Iceberg API to update stats

[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt

2022-09-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18970 ) Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt .. Patch Set 3: The output when the test failed was: Intra-node bytes

[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt

2022-09-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18970 to look at the new patch set (#4). Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt

[Impala-ASF-CR] IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG

2022-09-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18969 ) Change subject: IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG .. Patch Set 2: Code-Review+2 Thanks for

[Impala-ASF-CR] IMPALA-11583: Use Iceberg API to update stats

2022-09-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18995 Change subject: IMPALA-11583: Use Iceberg API to update stats .. IMPALA-11583: Use Iceberg API to update stats Before this patch

[Impala-ASF-CR] IMPALA-11582: Implement table sampling for Iceberg tables

2022-09-15 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18989 to look at the new patch set (#2). Change subject: IMPALA-11582: Implement table sampling for Iceberg tables

[Impala-ASF-CR] IMPALA-11582: Implement table sampling for Iceberg tables

2022-09-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18989 Change subject: IMPALA-11582: Implement table sampling for Iceberg tables .. IMPALA-11582: Implement table sampling for Iceberg

[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt

2022-09-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18970 ) Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt

2022-09-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18970 ) Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt .. Patch Set 1: (3 comments) Thanks for the comments.

[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt

2022-09-13 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18970 to look at the new patch set (#2). Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt

[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt

2022-09-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18970 Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt .. IMPALA-11572: deflake test_mt_dop_skew_lpt test_mt_dop_skew_lpt was

[Impala-ASF-CR] IMPALA-10610: Support multiple file formats in a single Iceberg Table

2022-09-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18935 ) Change subject: IMPALA-10610: Support multiple file formats in a single Iceberg Table .. Patch Set 5: Code-Review+2 Thanks for

[Impala-ASF-CR] IMPALA-10610: Support multiple file formats in a single Iceberg Table

2022-09-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18935 ) Change subject: IMPALA-10610: Support multiple file formats in a single Iceberg Table .. Patch Set 4: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-11539: Mitigate intra-node skew of file scans with MT DOP

2022-09-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18929 ) Change subject: IMPALA-11539: Mitigate intra-node skew of file scans with MT_DOP .. Patch Set 8: (1 comment) Good to see you

[Impala-ASF-CR] IMPALA-11539: Mitigate intra-node skew of file scans with MT DOP

2022-09-07 Thread Zoltan Borok-Nagy (Code Review)
Hello Qifan Chen, Gergely Fürnstáhl, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18929 to look at the new patch set (#8). Change subject: IMPALA-11539: Mitigate intra-node skew of file scans with

[Impala-ASF-CR] IMPALA-11551: Bump CDP BUILD NUMBER to use Iceberg 0.14

2022-09-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18944 ) Change subject: IMPALA-11551: Bump CDP_BUILD_NUMBER to use Iceberg 0.14 .. IMPALA-11551: Bump CDP_BUILD_NUMBER to use

[Impala-ASF-CR] IMPALA-11551: Bump CDP BUILD NUMBER to use Iceberg 0.14

2022-09-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18944 Change subject: IMPALA-11551: Bump CDP_BUILD_NUMBER to use Iceberg 0.14 .. IMPALA-11551: Bump CDP_BUILD_NUMBER to use Iceberg 0.14

[Impala-ASF-CR] IMPALA-11507: Use absolute path when Iceberg data files are outside of the table location

2022-09-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18894 ) Change subject: IMPALA-11507: Use absolute_path when Iceberg data files are outside of the table location .. Patch Set 8:

<    2   3   4   5   6   7   8   9   10   11   >