[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 6: We could go ahead with this one I think, if

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed a vote on this change. Change subject: IMPALA-2751: Matching quotes are not required in comments .. Removed Code-Review-2 by Tim Armstrong -- To view, visit http://gerrit.cloudera.org:8080/10541 To

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 6: Rebased -- To view, visit

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. IMPALA-2751: Matching quotes are not required in comments

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 5: > Patch Set 5: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 5: Code-Review-2 Let's not merge for now. This

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. IMPALA-2751: Matching quotes are not required in comments

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 4: Un-revert

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. IMPALA-2751: Matching quotes are not required in comments

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. IMPALA-2751: Matching quotes are not required in comments

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-05-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 2: I ran all shell tests on both Python 2.6 and

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-05-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10541 Change subject: IMPALA-2751: Matching quotes are not required in comments .. IMPALA-2751: Matching quotes are not required in comments