[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-26 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Abandoned Abandoning this per reviewer requests. Will do a series of

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 5: (28 comments) My general comments: - We should

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-20 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 5: Rebased on master. This one is pure clean-up. A

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-20 Thread Paul Rogers (Code Review)
Paul Rogers has removed Anonymous Coward (168) from this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Removed reviewer null. -- To view, visit

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-20 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Anonymous Coward (168), Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11893 to look at the new patch set (#5). Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-18 Thread Anonymous Coward (Code Review)
Anonymous Coward (168) has removed a vote on this change. Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Removed Code-Review+1 by Anonymous Coward (168) -- To view, visit

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-18 Thread Anonymous Coward (Code Review)
Anonymous Coward (168) has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 4: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-15 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 4: Hello Anon, the general guideline is to

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-14 Thread Anonymous Coward (Code Review)
Anonymous Coward (168) has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 4: format CollectionStructTypeclass

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-14 Thread Anonymous Coward (Code Review)
Anonymous Coward (168) has uploaded a new patch set (#4) to the change originally created by Paul Rogers. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues ..

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-08 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11893 to look at the new patch set (#3). Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 1: (3 comments) Thanks Bharath for the review.

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-07 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11893 to look at the new patch set (#2). Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 1: (3 comments) Few nits. LGTM overall.

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 1: Dry-run tests passed:

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-07 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11893 Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. IMPALA-7823: Clean up Java warnings, fix minor issues Roll-up