[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-06-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services .. Patch Set 1: Some high level questions:

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-29 Thread Thomas Marshall (Code Review)
Hello Tim Armstrong, Alex Behm, Vuk Ercegovac, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10394 to look at the new patch set (#10). Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-29 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 10: Code-Review+2 clang-tidy failed due to

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-06-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services .. Patch Set 1: Thanks for taking a look.

[Impala-ASF-CR] IMPALA-6883: [DOCS] Refactor impala authorization doc

2018-06-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10786 ) Change subject: IMPALA-6883: [DOCS] Refactor impala_authorization doc .. Patch Set 3: Code-Review+2 (1 comment) Make sure to remove

[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

2018-06-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 ) Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER .. Patch Set 7: Code-Review+1 Rebased and moved the tests from the

[Impala-ASF-CR] IMPALA-6918: Implement COMMENT ON COLUMN

2018-06-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10754 ) Change subject: IMPALA-6918: Implement COMMENT ON COLUMN .. Patch Set 5: Rebased and moved the tests from the old AuthorizationTest to

[Impala-ASF-CR] IMPALA-6918: Implement COMMENT ON COLUMN

2018-06-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10754 ) Change subject: IMPALA-6918: Implement COMMENT ON COLUMN .. IMPALA-6918: Implement COMMENT ON COLUMN This patch implements updating

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 20: (1 comment) +2 for

[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

2018-06-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/10822 ) Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER .. IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER Alter the

[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10841 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. IMPALA-6802 (part 6): Clean up authorization

[Impala-ASF-CR] IMPALA-7102 (Part 1): Disable reading of erasure coding by default

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10646 ) Change subject: IMPALA-7102 (Part 1): Disable reading of erasure coding by default .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-06-29 Thread Sailesh Mukil (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10843 to look at the new patch set (#2). Change subject: IMPALA-4784: Remove InProcessStatestore .. IMPALA-4784: Remove

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-7185: low statestore custom cluster interval

2018-06-29 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10845 to look at the new patch set (#3). Change subject: IMPALA-7185: low statestore custom cluster interval ..

[Impala-ASF-CR] IMPALA-7185: low statestore custom cluster interval

2018-06-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10845 ) Change subject: IMPALA-7185: low statestore custom cluster interval .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7185: low statestore custom cluster interval

2018-06-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10845 ) Change subject: IMPALA-7185: low statestore custom cluster interval .. Patch Set 2: (1 comment) Thanks for putting this together.

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-7185: low statestore custom cluster interval

2018-06-29 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10845 to look at the new patch set (#2). Change subject: IMPALA-7185: low statestore custom cluster interval ..

[Impala-ASF-CR] IMPALA-7185: low statestore custom cluster interval

2018-06-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10845 Change subject: IMPALA-7185: low statestore custom cluster interval .. IMPALA-7185: low statestore custom cluster interval This

[Impala-ASF-CR] IMPALA-7224. Improve performance of UpdateCatalogMetrics

2018-06-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10846 ) Change subject: IMPALA-7224. Improve performance of UpdateCatalogMetrics .. Patch Set 1: Code-Review+2 yikes... thanks! -- To view,

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. IMPALA-4848: Add WIDTH_BUCKET() function Syntax :

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 22: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-06-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10843 Change subject: IMPALA-4784: Remove InProcessStatestore .. IMPALA-4784: Remove InProcessStatestore InProcessStatestore was only used

[Impala-ASF-CR] IMPALA-7224. Improve performance of UpdateCatalogMetrics

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10846 ) Change subject: IMPALA-7224. Improve performance of UpdateCatalogMetrics .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7102 (Part 1): Disable reading of erasure coding by default

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10646 ) Change subject: IMPALA-7102 (Part 1): Disable reading of erasure coding by default .. IMPALA-7102 (Part 1): Disable

[Impala-ASF-CR] IMPALA-7102 (Part 1): Disable reading of erasure coding by default

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10646 ) Change subject: IMPALA-7102 (Part 1): Disable reading of erasure coding by default .. Patch Set 5: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-29 Thread anujphadke (Code Review)
Hello Taras Bobrovytsky, Michael Brown, Tim Armstrong, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6023 to look at the new patch set (#21). Change subject: IMPALA-4848: Add WIDTH_BUCKET() function

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-06-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10843 ) Change subject: IMPALA-4784: Remove InProcessStatestore .. Patch Set 2: Code-Review-1 Found a bug. Will upload a new patchset

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-29 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 10: -Code-Review gvo failure was unrelated, I

[Impala-ASF-CR] IMPALA-7224. Improve performance of UpdateCatalogMetrics

2018-06-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10846 ) Change subject: IMPALA-7224. Improve performance of UpdateCatalogMetrics .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 3: (21 comments) I wasn't able to get

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 11: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-06-29 Thread Sailesh Mukil (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10843 to look at the new patch set (#3). Change subject: IMPALA-4784: Remove InProcessStatestore .. IMPALA-4784: Remove

[Impala-ASF-CR] IMPALA-7095: clean up scan node profiles

2018-06-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10810 ) Change subject: IMPALA-7095: clean up scan node profiles .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-7095: clean up scan node profiles

2018-06-29 Thread Tim Armstrong (Code Review)
Hello Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10810 to look at the new patch set (#7). Change subject: IMPALA-7095: clean up scan node profiles .. IMPALA-7095:

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-06-29 Thread Pranay Singh (Code Review)
Pranay Singh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10847 Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. IMPALA-6271: Impala daemon should log a

[Impala-ASF-CR] IMPALA-7224. Improve performance of UpdateCatalogMetrics

2018-06-29 Thread Todd Lipcon (Code Review)
Hello Tianyi Wang, Vuk Ercegovac, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10846 to review the following change. Change subject: IMPALA-7224. Improve performance of UpdateCatalogMetrics

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 22: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 22: Build started:

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 21: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7224. Improve performance of UpdateCatalogMetrics

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10846 ) Change subject: IMPALA-7224. Improve performance of UpdateCatalogMetrics .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10841 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7102 (Part 1): Disable reading of erasure coding by default

2018-06-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10646 ) Change subject: IMPALA-7102 (Part 1): Disable reading of erasure coding by default .. Patch Set 4: Code-Review+2 Fixed a typo in

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 10: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7102 (Part 1): Disable reading of erasure coding by default

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10646 ) Change subject: IMPALA-7102 (Part 1): Disable reading of erasure coding by default .. Patch Set 5: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests

2018-06-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10841 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7201. Support DDL with LocalCatalog enabled

2018-06-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10806 ) Change subject: IMPALA-7201. Support DDL with LocalCatalog enabled .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

2018-06-29 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 ) Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10841 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests

2018-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10841 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. Patch Set 6: Build started: