[Impala-ASF-CR] IMPALA-9093: Change ACID tests to upgrade external tables

2019-11-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14633 ) Change subject: IMPALA-9093: Change ACID tests to upgrade external tables .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2

2019-11-06 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14291 ) Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14291 ) Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 .. Patch Set 15: Build started:

[Impala-ASF-CR] IMPALA-9093: Change ACID tests to upgrade external tables

2019-11-06 Thread Gabor Kaszab (Code Review)
Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14633 to look at the new patch set (#2). Change subject: IMPALA-9093: Change ACID tests to upgrade external tables

[Impala-ASF-CR] IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14291 ) Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 .. Patch Set 15: Build Successful

[Impala-ASF-CR] IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14291 ) Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 .. Patch Set 15: (4 comments)

[Impala-ASF-CR] IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2

2019-11-06 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14291 to look at the new patch set (#15). Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2

[Impala-ASF-CR] IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2

2019-11-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14291 ) Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 .. Patch Set 15: (3 comments)

[Impala-ASF-CR] IMPALA-9093: Change ACID tests to upgrade external tables

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14633 ) Change subject: IMPALA-9093: Change ACID tests to upgrade external tables .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2

2019-11-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14291 ) Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-9093: Change ACID tests to upgrade external tables

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14633 ) Change subject: IMPALA-9093: Change ACID tests to upgrade external tables .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-9132: Explain statements should not cause nullptr in LogLineageRecord()

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14646 ) Change subject: IMPALA-9132: Explain statements should not cause nullptr in LogLineageRecord() .. Patch Set 2: Build

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-06 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. IMPALA-2112:

[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs

2019-11-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/1 ) Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs

2019-11-06 Thread Zoltan Borok-Nagy (Code Review)
Hello Norbert Luksa, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/1 to look at the new patch set (#5). Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs

[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/1 ) Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs

2019-11-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/1 ) Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14291 ) Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 .. Patch Set 15: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 6:

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-06 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. IMPALA-2112:

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-06 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 6:

[Impala-ASF-CR] IMPALA-9129: Add a test fixture that cleans up intentional core dumps

2019-11-06 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/14640 ) Change subject: IMPALA-9129: Add a test fixture that cleans up intentional core dumps .. Patch Set 5: I realized that my understanding

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 6:

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 4:

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 4:

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-06 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. IMPALA-2112:

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-06 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 5:

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 5:

[Impala-ASF-CR] IMPALA-9129: Add a test fixture that cleans up intentional core dumps

2019-11-06 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/14640 ) Change subject: IMPALA-9129: Add a test fixture that cleans up intentional core dumps .. IMPALA-9129: Add a test fixture that cleans up

[Impala-ASF-CR] IMPALA-9129: Add a test fixture that cleans up intentional core dumps

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14640 ) Change subject: IMPALA-9129: Add a test fixture that cleans up intentional core dumps .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-9132: Explain statements should not cause nullptr in LogLineageRecord()

2019-11-06 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14646 Change subject: IMPALA-9132: Explain statements should not cause nullptr in LogLineageRecord() .. IMPALA-9132: Explain

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-06 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-9132: Explain statements should not cause nullptr in LogLineageRecord()

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14646 ) Change subject: IMPALA-9132: Explain statements should not cause nullptr in LogLineageRecord() .. Patch Set 1: Build

[Impala-ASF-CR] IMPALA-9132: Explain statements should not cause nullptr in LogLineageRecord()

2019-11-06 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14646 ) Change subject: IMPALA-9132: Explain statements should not cause nullptr in LogLineageRecord() .. IMPALA-9132: Explain

[Impala-ASF-CR] IMPALA-9132: Explain statements should not cause nullptr in LogLineageRecord()

2019-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14646 ) Change subject: IMPALA-9132: Explain statements should not cause nullptr in LogLineageRecord() .. Patch Set 2: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-9132: Explain statements should not cause nullptr in LogLineageRecord()

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14646 ) Change subject: IMPALA-9132: Explain statements should not cause nullptr in LogLineageRecord() .. Patch Set 2: Build

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-06 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-06 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14635 to look at the new patch set (#2). Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 4:

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-06 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 4:

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 4:

[Impala-ASF-CR] IMPALA-7506: support global INVALIDATE METADATA in local catalog mode

2019-11-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14307 ) Change subject: IMPALA-7506: support global INVALIDATE METADATA in local catalog mode .. Patch Set 11: Passed exhaustive tests:

[Impala-ASF-CR] IMPALA-9129: Add a test fixture that cleans up intentional core dumps

2019-11-06 Thread David Knupp (Code Review)
David Knupp has removed a vote on this change. Change subject: IMPALA-9129: Add a test fixture that cleans up intentional core dumps .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-7506: support global INVALIDATE METADATA in local catalog mode

2019-11-06 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14307 ) Change subject: IMPALA-7506: support global INVALIDATE METADATA in local catalog mode .. Patch Set 8: (4 comments) The patch

[Impala-ASF-CR] IMPALA-9109: Add top-k metadata loading ranking on catalogd UI

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14600 ) Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-9109: Add top-k metadata loading ranking on catalogd UI

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14600 ) Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI .. Patch Set 10: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7506: support global INVALIDATE METADATA in local catalog mode

2019-11-06 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14307 ) Change subject: IMPALA-7506: support global INVALIDATE METADATA in local catalog mode .. Patch Set 11: Code-Review+1 Would be

[Impala-ASF-CR] IMPALA-9109: Add top-k metadata loading ranking on catalogd UI

2019-11-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14600 ) Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9132: Explain statements should not cause nullptr in LogLineageRecord()

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14646 ) Change subject: IMPALA-9132: Explain statements should not cause nullptr in LogLineageRecord() .. Patch Set 2: Verified+1

[Impala-ASF-CR] IMPALA-9132: Explain statements should not cause nullptr in LogLineageRecord()

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14646 ) Change subject: IMPALA-9132: Explain statements should not cause nullptr in LogLineageRecord() .. IMPALA-9132:

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 6: (1

[Impala-ASF-CR] IMPALA-9109: Add top-k metadata loading ranking on catalogd UI

2019-11-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14600 ) Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI .. Patch Set 10: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-06 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. IMPALA-2112:

[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.

2019-11-06 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 7: