[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 9: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3040: Remove cache directive before dropping a table

2018-06-28 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directive before dropping a table .. Patch Set 2: > Do you know what in test_caching_ddl() is

[Impala-ASF-CR] IMPALA-6883: [DOCS] Refactor impala authorization doc

2018-06-28 Thread Alex Rodoni (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10786 to look at the new patch set (#3). Change subject: IMPALA-6883: [DOCS] Refactor impala_authorization doc

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-28 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests

2018-06-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10841 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. IMPALA-6802 (part 6): Clean up authorization tests This is the

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-28 Thread anujphadke (Code Review)
Hello Taras Bobrovytsky, Michael Brown, Tim Armstrong, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6023 to look at the new patch set (#20). Change subject: IMPALA-4848: Add WIDTH_BUCKET() function

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-28 Thread anujphadke (Code Review)
Hello Taras Bobrovytsky, Michael Brown, Tim Armstrong, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6023 to look at the new patch set (#19). Change subject: IMPALA-4848: Add WIDTH_BUCKET() function

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-28 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-28 Thread Thomas Marshall (Code Review)
Hello Tim Armstrong, Alex Behm, Vuk Ercegovac, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10394 to look at the new patch set (#8). Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-06-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10842 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-28 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests

2018-06-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10841 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. Patch Set 4: (1 comment) Carry +1

[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests

2018-06-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10841 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. IMPALA-6802 (part 6): Clean up authorization tests This is the

[Impala-ASF-CR] IMPALA-6883: [DOCS] Refactor impala authorization doc

2018-06-28 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10786 ) Change subject: IMPALA-6883: [DOCS] Refactor impala_authorization doc .. Patch Set 1: Added CTAS to privilege table -- To view, visit

[Impala-ASF-CR] IMPALA-6883: [DOCS] Refactor impala authorization doc

2018-06-28 Thread Alex Rodoni (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10786 to look at the new patch set (#2). Change subject: IMPALA-6883: [DOCS] Refactor impala_authorization doc

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-28 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#3). Change subject: IMPALA-7163: Implement a state machine for the QueryState class

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 2: (13 comments)

[Impala-ASF-CR] [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls

2018-06-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10696 ) Change subject: [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls .. Patch Set 4: Working on rebasing this patch on

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 2: (1 comment)

[Impala-ASF-CR] [DOCS] Clarification on admission control and DDL statements

2018-06-28 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10829 ) Change subject: [DOCS] Clarification on admission control and DDL statements .. Patch Set 2: (6 comments) Removed the confusing

[Impala-ASF-CR] [DOCS] Clarification on admission control and DDL statements

2018-06-28 Thread Alex Rodoni (Code Review)
Hello Balazs Jeszenszky, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10829 to look at the new patch set (#3). Change subject: [DOCS] Clarification on admission control and DDL statements

[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests

2018-06-28 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10841 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10827 ) Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. IMPALA-7215: Implement a templatized

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10827 ) Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-06-28 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10842 Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. IMPALA-6086: Use of permanent function

[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests

2018-06-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10841 Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. IMPALA-6802 (part 6): Clean up authorization tests This is the

[Impala-ASF-CR] IMPALA-7140 (part 8): support views in LocalCatalog

2018-06-28 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10805 ) Change subject: IMPALA-7140 (part 8): support views in LocalCatalog .. Patch Set 1: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-6976: Parser to parse Impala query profiles

2018-06-28 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has abandoned this change. ( http://gerrit.cloudera.org:8080/10309 ) Change subject: IMPALA-6976: Parser to parse Impala query profiles .. Abandoned A decision has been made to not have this script here.

[Impala-ASF-CR] IMPALA-6976: Parser to parse Impala query profiles

2018-06-28 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10309 Change subject: IMPALA-6976: Parser to parse Impala query profiles .. IMPALA-6976: Parser to parse Impala query profiles Script

[Impala-ASF-CR] IMPALA-7140 (part 7): small fixes to enable most queries on HDFS tables

2018-06-28 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10798 ) Change subject: IMPALA-7140 (part 7): small fixes to enable most queries on HDFS tables .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7140 (part 6): fetch column stats for LocalTable

2018-06-28 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10797 ) Change subject: IMPALA-7140 (part 6): fetch column stats for LocalTable .. Patch Set 1: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10827 ) Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10827 ) Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. Patch Set 5: Code-Review+2 (4 comments) Thanks for the

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-28 Thread Sailesh Mukil (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10827 to look at the new patch set (#5). Change subject: IMPALA-7215: Implement a templatized CountingBarrier ..

[Impala-ASF-CR] IMPALA-5981: [DOCS] Documented SET=""

2018-06-28 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10816 ) Change subject: IMPALA-5981: [DOCS] Documented SET="" .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5981: [DOCS] Documented SET=""

2018-06-28 Thread Alex Rodoni (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10816 to look at the new patch set (#3). Change subject: IMPALA-5981: [DOCS] Documented SET=""

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10827 ) Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. Patch Set 4: Code-Review+2 (4 comments) Just a few more comment

[Impala-ASF-CR] IMPALA-7190: Remove unsupported format writer support

2018-06-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10823 ) Change subject: IMPALA-7190: Remove unsupported format writer support .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10827 ) Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-28 Thread Sailesh Mukil (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10827 to look at the new patch set (#4). Change subject: IMPALA-7215: Implement a templatized CountingBarrier ..

[Impala-ASF-CR] [DOCS] Corrected the supported values for parquet array resolution

2018-06-28 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10840 Change subject: [DOCS] Corrected the supported values for parquet_array_resolution .. [DOCS] Corrected the supported values for

[Impala-ASF-CR] IMPALA-7190: Remove unsupported format writer support

2018-06-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10823 ) Change subject: IMPALA-7190: Remove unsupported format writer support .. Patch Set 1: Code-Review+1 (1 comment) I agree with Csaba's

[Impala-ASF-CR] IMPALA-7095: clean up scan node profiles

2018-06-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10810 ) Change subject: IMPALA-7095: clean up scan node profiles .. Patch Set 6: Code-Review+1 (5 comments) Looks good, only had some

[Impala-ASF-CR] IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated

2018-06-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10815 ) Change subject: IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated .. Patch Set