[Impala-ASF-CR] IMPALA-8691: Query option to disable data cache
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14015 ) Change subject: IMPALA-8691: Query option to disable data cache .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4830/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39122ac38435cedf94b2b39145863764d0b5b6c8 Gerrit-Change-Number: 14015 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 22 Aug 2019 05:57:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7027: fix StringLiteral.localEquals()
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14096 ) Change subject: IMPALA-7027: fix StringLiteral.localEquals() .. IMPALA-7027: fix StringLiteral.localEquals() String literals with the same value but different types are not interchangeable. localEquals() should check the type, similar to a cast expression. Testing: - Added String literals tests. - Passed exhaustive tests. Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138 Reviewed-on: http://gerrit.cloudera.org:8080/14096 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/analysis/StringLiteral.java A testdata/workloads/functional-query/queries/QueryTest/string-literals.test M tests/query_test/test_chars.py 3 files changed, 46 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138 Gerrit-Change-Number: 14096 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Yongzhi Chen
[Impala-ASF-CR] IMPALA-7027: fix StringLiteral.localEquals()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14096 ) Change subject: IMPALA-7027: fix StringLiteral.localEquals() .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138 Gerrit-Change-Number: 14096 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Thu, 22 Aug 2019 05:03:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/14104 )
Change subject: IMPALA-8803: Coordinator should release admitted memory
per-backend
..
Patch Set 1:
(19 comments)
Took a pass over the code, havent looked at the tests yet.
Looks good, mostly nits
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.h
File be/src/runtime/coordinator-backend-state.h:
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.h@63
PS1, Line 63: const BackendExecParams& exec_params);
nit: we can get the query_id and BackendExecParams from the QuerySchedule
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.h@403
PS1, Line 403: UNRELEASED
> Will "IN_USE" be slightly clear ?
+1
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.h@413
PS1, Line 413: are considered to
nit: transition to?
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.h@469
PS1, Line 469: BackendFinished
nit: MarkBackendFinished
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.h@470
PS1, Line 470: std::vector* releasable_backend_states
nit: I usually try to avoid (input,output) type params if possible. Maybe
consider adding a GetReleasableBackends() method.
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.h@474
PS1, Line 474: released_backend_states
nit: how about backends_to_release?
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.h@474
PS1, Line 474: BackendsReleased
nit: how about ReleaseBackends?
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.h@477
PS1, Line 477: Close
nit: how about call this CloseAndGetUnreleasedBackends() then return the
unreleased_backend_states instead of having an output param.
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.h@492
PS1, Line 492: enum ResourceState { UNRELEASED, PENDING, RELEASABLE,
RELEASED};
nit: space
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.cc
File be/src/runtime/coordinator-backend-state.cc:
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.cc@827
PS1, Line 827: backend_states_.size()
nit: use num_backends_ here and below
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.cc@827
PS1, Line 827: last_backend
nit: how about is_last_unrelease_backend
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.cc@831
PS1, Line 831: coordinator_last_backend
nit: how about is_coord_the_last_unreleased_backend
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.cc@836
PS1, Line 836: released_timer_.ElapsedTime() > RELEASE_BACKEND_STATES_DELAY /
100
should be released_timer_.ElapsedTime() > RELEASE_BACKEND_STATES_DELAY * 100
since released_timer_.ElapsedTime() is nano-sec and
RELEASE_BACKEND_STATES_DELAY is milli-sec
Alternatively we can store RELEASE_BACKEND_STATES_DELAY in nano-sec to avoid
the multiplication everytime.
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.cc@865
PS1, Line 865: are
nit: as
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator.h
File be/src/runtime/coordinator.h:
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator.h@530
PS1, Line 530:
nit: needs comment
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator.cc@764
PS1, Line 764: vector releasable_backends;
: backend_resource_state_->BackendFinished(backend_state,
_backends);
: if (!releasable_backends.empty()) {
:
ReleaseBackendAdmissionControlResources(releasable_backends);
:
backend_resource_state_->BackendsReleased(releasable_backends);
: }
is it possible that both this thread and a cancellation thread call
ReleaseBackendAdmissionControlResources on the same backend?
eg. BackendFinished() returns a set of releasable_backends here and the query
got cancelled so that thread called Close() and got a set of all unrelease
backends, then both called ReleaseBackendAdmissionControlResources()
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:
http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/scheduling/admission-controller.cc@367
PS1, Line 367: for (auto host_addr : host_addrs) {
: auto backend_exec_params =
schedule.per_backend_exec_params().find(host_addr);
:
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 ) Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1 .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4328/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7 Gerrit-Change-Number: 14119 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 22 Aug 2019 01:37:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7027: fix StringLiteral.localEquals()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14096 ) Change subject: IMPALA-7027: fix StringLiteral.localEquals() .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138 Gerrit-Change-Number: 14096 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Thu, 22 Aug 2019 00:57:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7027: fix StringLiteral.localEquals()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14096 ) Change subject: IMPALA-7027: fix StringLiteral.localEquals() .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4829/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138 Gerrit-Change-Number: 14096 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Thu, 22 Aug 2019 00:57:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7027: fix StringLiteral.localEquals()
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14096 ) Change subject: IMPALA-7027: fix StringLiteral.localEquals() .. Patch Set 3: Looks like a flaky test that should be fixed by https://gerrit.cloudera.org/#/c/14117/ -- To view, visit http://gerrit.cloudera.org:8080/14096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138 Gerrit-Change-Number: 14096 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Thu, 22 Aug 2019 00:57:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14119 to look at the new patch set (#4). Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1 .. IMPALA-8879: upgrade bootstrap for debug page to 4.3.1 Also upgrade DataTables to 1.10.18 at the same time.. They were obtained from https://datatables.net/download/ and https://getbootstrap.com/docs/4.3/getting-started/download/. Included the version number in the css and js filenames to avoid potential issues with stale versions being cached (I got tripped up by this). I had to do some additional work to get the UI to look right after the upgrade: * added additional style classes to HTML elements for nav and breadcrumb styles - these are required in bootstrap 4. * added styling for plan visualisation graph for it to appear similar to the old graph. * Added styling for to get box around text. Testing: Manually clicked through the web UI to see if anything looked wrong or didn't function correctly. Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7 --- M .gitattributes M bin/rat_exclude_files.txt D www/DataTables-1.10.12/css/dataTables.bootstrap.min.css D www/DataTables-1.10.12/css/dataTables.foundation.min.css D www/DataTables-1.10.12/css/dataTables.jqueryui.min.css D www/DataTables-1.10.12/css/jquery.dataTables.min.css D www/DataTables-1.10.12/css/jquery.dataTables_themeroller.css D www/DataTables-1.10.12/js/dataTables.foundation.min.js D www/DataTables-1.10.12/js/jquery.dataTables.min.js R www/DataTables-1.10.18/css/dataTables.bootstrap.css A www/DataTables-1.10.18/css/dataTables.bootstrap.min.css C www/DataTables-1.10.18/css/dataTables.bootstrap4.css A www/DataTables-1.10.18/css/dataTables.bootstrap4.min.css R www/DataTables-1.10.18/css/dataTables.foundation.css A www/DataTables-1.10.18/css/dataTables.foundation.min.css R www/DataTables-1.10.18/css/dataTables.jqueryui.css A www/DataTables-1.10.18/css/dataTables.jqueryui.min.css A www/DataTables-1.10.18/css/dataTables.semanticui.css A www/DataTables-1.10.18/css/dataTables.semanticui.min.css R www/DataTables-1.10.18/css/jquery.dataTables.css A www/DataTables-1.10.18/css/jquery.dataTables.min.css R www/DataTables-1.10.18/images/sort_asc.png R www/DataTables-1.10.18/images/sort_asc_disabled.png R www/DataTables-1.10.18/images/sort_both.png R www/DataTables-1.10.18/images/sort_desc.png R www/DataTables-1.10.18/images/sort_desc_disabled.png R www/DataTables-1.10.18/js/dataTables.bootstrap.js R www/DataTables-1.10.18/js/dataTables.bootstrap.min.js C www/DataTables-1.10.18/js/dataTables.bootstrap4.js A www/DataTables-1.10.18/js/dataTables.bootstrap4.min.js R www/DataTables-1.10.18/js/dataTables.foundation.js A www/DataTables-1.10.18/js/dataTables.foundation.min.js R www/DataTables-1.10.18/js/dataTables.jqueryui.js R www/DataTables-1.10.18/js/dataTables.jqueryui.min.js C www/DataTables-1.10.18/js/dataTables.semanticui.js A www/DataTables-1.10.18/js/dataTables.semanticui.min.js R www/DataTables-1.10.18/js/jquery.dataTables.js A www/DataTables-1.10.18/js/jquery.dataTables.min.js M www/all_child_groups.tmpl A www/bootstrap/css/bootstrap-4.3.1.min.css D www/bootstrap/css/bootstrap-theme.css D www/bootstrap/css/bootstrap-theme.css.map D www/bootstrap/css/bootstrap-theme.min.css D www/bootstrap/css/bootstrap-theme.min.css.map M www/bootstrap/css/bootstrap.css M www/bootstrap/css/bootstrap.css.map M www/bootstrap/css/bootstrap.min.css M www/bootstrap/css/bootstrap.min.css.map D www/bootstrap/fonts/glyphicons-halflings-regular.eot D www/bootstrap/fonts/glyphicons-halflings-regular.svg D www/bootstrap/fonts/glyphicons-halflings-regular.ttf D www/bootstrap/fonts/glyphicons-halflings-regular.woff D www/bootstrap/fonts/glyphicons-halflings-regular.woff2 A www/bootstrap/js/bootstrap-4.3.1.min.js M www/bootstrap/js/bootstrap.js M www/bootstrap/js/bootstrap.min.js M www/catalog.tmpl M www/common-header.tmpl R www/datatables-1.10.18.css C www/datatables-1.10.18.js A www/datatables-1.10.18.min.css A www/datatables-1.10.18.min.js D www/datatables.js D www/datatables.min.css D www/datatables.min.js M www/metrics.tmpl M www/query_detail_tabs.tmpl M www/query_plan.tmpl M www/query_stmt.tmpl M www/threadz_tabs.tmpl 70 files changed, 15,446 insertions(+), 37,422 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/14119/4 -- To view, visit http://gerrit.cloudera.org:8080/14119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7 Gerrit-Change-Number: 14119 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14119/3/www/common-header.tmpl
File www/common-header.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/3/www/common-header.tmpl@52
PS3, Line 52: {{title}}
> The current font-size is larger than before that the nav bar become two lin
I explicitly set the body font size to 14px, that should get it closer to
before.
http://gerrit.cloudera.org:8080/#/c/14119/3/www/query_stmt.tmpl
File www/query_stmt.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/3/www/query_stmt.tmpl@33
PS3, Line 33: {{?stmt}}{{stmt}}{{/stmt}}
> We lost the syntax highlight without this. Why do we remove it? Is it incom
Ah right. The padding was a weird colour. I didn't think about syntax
highlighting. I added the tags back in. I think we can live with the
padding.
http://gerrit.cloudera.org:8080/#/c/14119/3/www/threadz_tabs.tmpl
File www/threadz_tabs.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/3/www/threadz_tabs.tmpl@22
PS3, Line 22:
> Tabs here are not displayed as usual. Need changes too.
Done
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Thu, 22 Aug 2019 00:56:19 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7027: fix StringLiteral.localEquals()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14096 ) Change subject: IMPALA-7027: fix StringLiteral.localEquals() .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4828/ -- To view, visit http://gerrit.cloudera.org:8080/14096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138 Gerrit-Change-Number: 14096 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Thu, 22 Aug 2019 00:30:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Quanlong Huang has posted comments on this change. (
http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
..
Patch Set 3:
(3 comments)
Add some comments at first glance and play around. Beside those, the table in
the session page is too wide than before. It'd be better to fix it too.
http://gerrit.cloudera.org:8080/#/c/14119/3/www/common-header.tmpl
File www/common-header.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/3/www/common-header.tmpl@52
PS3, Line 52: {{title}}
The current font-size is larger than before that the nav bar become two lines.
In my browser, it's 1rem now. Previously, it's 14px. Maybe we need to
explicitly set it.
http://gerrit.cloudera.org:8080/#/c/14119/3/www/query_stmt.tmpl
File www/query_stmt.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/3/www/query_stmt.tmpl@33
PS3, Line 33: {{?stmt}}{{stmt}}{{/stmt}}
We lost the syntax highlight without this. Why do we remove it? Is it
incompatible with bootstrap 4?
http://gerrit.cloudera.org:8080/#/c/14119/3/www/threadz_tabs.tmpl
File www/threadz_tabs.tmpl:
http://gerrit.cloudera.org:8080/#/c/14119/3/www/threadz_tabs.tmpl@22
PS3, Line 22:
Tabs here are not displayed as usual. Need changes too.
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Comment-Date: Thu, 22 Aug 2019 00:18:04 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 ) Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1 .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4327/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7 Gerrit-Change-Number: 14119 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 21 Aug 2019 23:39:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14119 to look at the new patch set (#3). Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1 .. IMPALA-8879: upgrade bootstrap for debug page to 4.3.1 Also upgrade DataTables to 1.10.18 at the same time.. They were obtained from https://datatables.net/download/ and https://getbootstrap.com/docs/4.3/getting-started/download/. Included the version number in the css and js filenames to avoid potential issues with stale versions being cached (I got tripped up by this). I had to do some additional work to get the UI to look right after the upgrade: * added additional style classes to HTML elements for nav and breadcrumb styles - these are required in bootstrap 4. * added styling for plan visualisation graph for it to appear similar to the old graph. * Added styling for to get box around text. Testing: Manually clicked through the web UI to see if anything looked wrong or didn't function correctly. Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7 --- M .gitattributes M bin/rat_exclude_files.txt D www/DataTables-1.10.12/css/dataTables.bootstrap.min.css D www/DataTables-1.10.12/css/dataTables.foundation.min.css D www/DataTables-1.10.12/css/dataTables.jqueryui.min.css D www/DataTables-1.10.12/css/jquery.dataTables.min.css D www/DataTables-1.10.12/css/jquery.dataTables_themeroller.css D www/DataTables-1.10.12/js/dataTables.foundation.min.js D www/DataTables-1.10.12/js/jquery.dataTables.min.js R www/DataTables-1.10.18/css/dataTables.bootstrap.css A www/DataTables-1.10.18/css/dataTables.bootstrap.min.css C www/DataTables-1.10.18/css/dataTables.bootstrap4.css A www/DataTables-1.10.18/css/dataTables.bootstrap4.min.css R www/DataTables-1.10.18/css/dataTables.foundation.css A www/DataTables-1.10.18/css/dataTables.foundation.min.css R www/DataTables-1.10.18/css/dataTables.jqueryui.css A www/DataTables-1.10.18/css/dataTables.jqueryui.min.css A www/DataTables-1.10.18/css/dataTables.semanticui.css A www/DataTables-1.10.18/css/dataTables.semanticui.min.css R www/DataTables-1.10.18/css/jquery.dataTables.css A www/DataTables-1.10.18/css/jquery.dataTables.min.css R www/DataTables-1.10.18/images/sort_asc.png R www/DataTables-1.10.18/images/sort_asc_disabled.png R www/DataTables-1.10.18/images/sort_both.png R www/DataTables-1.10.18/images/sort_desc.png R www/DataTables-1.10.18/images/sort_desc_disabled.png R www/DataTables-1.10.18/js/dataTables.bootstrap.js R www/DataTables-1.10.18/js/dataTables.bootstrap.min.js C www/DataTables-1.10.18/js/dataTables.bootstrap4.js A www/DataTables-1.10.18/js/dataTables.bootstrap4.min.js R www/DataTables-1.10.18/js/dataTables.foundation.js A www/DataTables-1.10.18/js/dataTables.foundation.min.js R www/DataTables-1.10.18/js/dataTables.jqueryui.js R www/DataTables-1.10.18/js/dataTables.jqueryui.min.js C www/DataTables-1.10.18/js/dataTables.semanticui.js A www/DataTables-1.10.18/js/dataTables.semanticui.min.js R www/DataTables-1.10.18/js/jquery.dataTables.js A www/DataTables-1.10.18/js/jquery.dataTables.min.js M www/all_child_groups.tmpl A www/bootstrap/css/bootstrap-4.3.1.min.css D www/bootstrap/css/bootstrap-theme.css D www/bootstrap/css/bootstrap-theme.css.map D www/bootstrap/css/bootstrap-theme.min.css D www/bootstrap/css/bootstrap-theme.min.css.map M www/bootstrap/css/bootstrap.css M www/bootstrap/css/bootstrap.css.map M www/bootstrap/css/bootstrap.min.css M www/bootstrap/css/bootstrap.min.css.map D www/bootstrap/fonts/glyphicons-halflings-regular.eot D www/bootstrap/fonts/glyphicons-halflings-regular.svg D www/bootstrap/fonts/glyphicons-halflings-regular.ttf D www/bootstrap/fonts/glyphicons-halflings-regular.woff D www/bootstrap/fonts/glyphicons-halflings-regular.woff2 A www/bootstrap/js/bootstrap-4.3.1.min.js M www/bootstrap/js/bootstrap.js M www/bootstrap/js/bootstrap.min.js M www/catalog.tmpl M www/common-header.tmpl R www/datatables-1.10.18.css C www/datatables-1.10.18.js A www/datatables-1.10.18.min.css A www/datatables-1.10.18.min.js D www/datatables.js D www/datatables.min.css D www/datatables.min.js M www/metrics.tmpl M www/query_detail_tabs.tmpl M www/query_plan.tmpl M www/query_stmt.tmpl 69 files changed, 15,430 insertions(+), 37,420 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/14119/3 -- To view, visit http://gerrit.cloudera.org:8080/14119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7 Gerrit-Change-Number: 14119 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8818: Replace deque with spillable queue in BufferedPRS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14039 ) Change subject: IMPALA-8818: Replace deque with spillable queue in BufferedPRS .. Patch Set 10: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4326/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10f9e72374cdf9501c0e5e2c5b39c13688ae65a9 Gerrit-Change-Number: 14039 Gerrit-PatchSet: 10 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Aug 2019 22:04:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8880: Disable EventsProcessorStressTest
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14117 ) Change subject: IMPALA-8880: Disable EventsProcessorStressTest .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14117 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0be247e01d5047dbd74702fb43d4d038d8ccf758 Gerrit-Change-Number: 14117 Gerrit-PatchSet: 3 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Aug 2019 21:35:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8880: Disable EventsProcessorStressTest
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14117 ) Change subject: IMPALA-8880: Disable EventsProcessorStressTest .. IMPALA-8880: Disable EventsProcessorStressTest EventsProcessorStressTest is flaky. The root-cause of this is MAPREDUCE-6441 which is unavailable in the component builds we use in the minicluster. The test will be renabled once we port MAPREDUCE-6441 to Hive-3 and Hive-2 minicluster Testing: 1. Ran the test on hive-2 and confirmed its being ignored Change-Id: I0be247e01d5047dbd74702fb43d4d038d8ccf758 Reviewed-on: http://gerrit.cloudera.org:8080/14117 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/test/java/org/apache/impala/catalog/events/EventsProcessorStressTest.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14117 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0be247e01d5047dbd74702fb43d4d038d8ccf758 Gerrit-Change-Number: 14117 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8864: Ignore fe http transport tests on older python versions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14116 ) Change subject: IMPALA-8864: Ignore fe http transport tests on older python versions .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7 Gerrit-Change-Number: 14116 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 21 Aug 2019 21:33:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8818: Replace deque with spillable queue in BufferedPRS
Hello Michael Ho, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14039 to look at the new patch set (#10). Change subject: IMPALA-8818: Replace deque with spillable queue in BufferedPRS .. IMPALA-8818: Replace deque with spillable queue in BufferedPRS Replaces DequeRowBatchQueue with SpillableRowBatchQueue in BufferedPlanRootSink. A few changes to BufferedPlanRootSink were necessary for it to work with the spillable queue, however, all the synchronization logic is the same. SpillableRowBatchQueue is a wrapper around a BufferedTupleStream and a ReservationManager. It takes in a TBackendResourceProfile that specifies the max / min memory reservation the BufferedTupleStream can use to buffer rows. The 'max_unpinned_bytes' parameter limits the max number of bytes that can be unpinned in the BufferedTupleStream. The limit is a 'soft' limit because calls to AddBatch may push the amount of unpinned memory over the limit. The queue is non-blocking and not thread safe. It provides AddBatch and GetBatch methods. Calls to AddBatch spill if the BufferedTupleStream does not have enough reservation to fit the entire RowBatch. Adds two new query options: 'MAX_PINNED_RESULT_SPOOLING_MEMORY' and 'MAX_UNPINNED_RESULT_SPOOLING_MEMORY', which bound the amount of pinned and unpinned memory that a query can use for spooling, respectively. MAX_PINNED_RESULT_SPOOLING_MEMORY must be <= MAX_UNPINNED_RESULT_SPOOLING_MEMORY in order to allow all the pinned data in the BufferedTupleStream to be unpinned. This is enforced in a new method in QueryOptions called 'ValidateQueryOptions'. Planner Changes: PlanRootSink.java now computes a full ResourceProfile if result spooling is enabled. The min mem reservation is bounded by the size of the read and write pages used by the BufferedTupleStream. The max mem reservation is bounded by 'MAX_PINNED_RESULT_SPOOLING_MEMORY'. The mem estimate is computed by estimating the size of the result set using stats. BufferedTupleStream Re-Factoring: For the most part, using a BufferedTupleStream outside an ExecNode works properly. However, some changes were necessary: * The message for the MAX_ROW_SIZE error is ExecNode specific. In order to fix this, this patch introduces the concept of an ExecNode 'label' which is a more generic version of an ExecNode 'id'. * The definition of TBackendResourceProfile lived in PlanNodes.thrift, it was moved to its own file so it can be used by DataSinks.thrift. * Modified BufferedTupleStream so it internally tracks how many bytes are unpinned (necessary for 'MAX_UNPINNED_RESULT_SPOOLING_MEMORY'). Metrics: * Added a few of the metrics mentioned in IMPALA-8825 to BufferedPlanRootSink. Specifically, added timers to track how much time is spent waiting in the BufferedPlanRootSink 'Send' and 'GetNext' methods. * The BufferedTupleStream in the SpillableRowBatchQueue exposes several BufferPool metrics such as number of reserved and unpinned bytes. Bug Fixes: * Fixed a bug in BufferedPlanRootSink where the MemPool used by the expression evaluators was not being cleared incrementally. * Fixed a bug where the inactive timer was not being properly updated in BufferedPlanRootSink. * Fixed a bug where RowBatch memory was not freed if BufferedPlanRootSink::GetNext terminated early because it could not handle requests where num_results < BATCH_SIZE. Testing: * Added new tests to test_result_spooling.py. * Updated errors thrown in spilling-large-rows.test. * Ran exhaustive tests. Change-Id: I10f9e72374cdf9501c0e5e2c5b39c13688ae65a9 --- M be/generated-sources/gen-cpp/CMakeLists.txt M be/src/exec/analytic-eval-node.cc M be/src/exec/blocking-plan-root-sink.cc M be/src/exec/blocking-plan-root-sink.h M be/src/exec/buffered-plan-root-sink.cc M be/src/exec/buffered-plan-root-sink.h M be/src/exec/data-sink.cc M be/src/exec/exec-node.cc M be/src/exec/exec-node.h M be/src/exec/grouping-aggregator-partition.cc M be/src/exec/grouping-aggregator.cc M be/src/exec/partial-sort-node.cc M be/src/exec/partitioned-hash-join-builder.cc M be/src/exec/partitioned-hash-join-builder.h M be/src/exec/partitioned-hash-join-node.cc M be/src/exec/plan-root-sink.h M be/src/exec/sort-node.cc M be/src/runtime/CMakeLists.txt M be/src/runtime/buffered-tuple-stream-test.cc M be/src/runtime/buffered-tuple-stream.cc M be/src/runtime/buffered-tuple-stream.h D be/src/runtime/deque-row-batch-queue.cc D be/src/runtime/deque-row-batch-queue.h M be/src/runtime/sorter.cc M be/src/runtime/sorter.h A be/src/runtime/spillable-row-batch-queue.cc A be/src/runtime/spillable-row-batch-queue.h M be/src/service/impala-beeswax-server.cc M be/src/service/impala-server.cc M be/src/service/query-options-test.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/CMakeLists.txt M common/thrift/DataSinks.thrift M
[Impala-ASF-CR] IMPALA-8858: Add observability of idle executor groups
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add observability of idle executor groups .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4325/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58cde8699c33af8b87273437e9d8bf6371a34539 Gerrit-Change-Number: 14103 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Wed, 21 Aug 2019 21:05:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 ) Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1 .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/4324/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/14119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7 Gerrit-Change-Number: 14119 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 21 Aug 2019 20:49:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8864: Ignore fe http transport tests on older python versions
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14116 ) Change subject: IMPALA-8864: Ignore fe http transport tests on older python versions .. Patch Set 1: Code-Review-2 Thanks for the quick review. I'm temporarily marking this as a -2 until my private CentOs6 build finishes. Want to be sure that this fix works as intended. -- To view, visit http://gerrit.cloudera.org:8080/14116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7 Gerrit-Change-Number: 14116 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 21 Aug 2019 20:48:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8858: Add observability of idle executor groups
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add observability of idle executor groups .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14103/1/be/src/scheduling/cluster-membership-mgr.h File be/src/scheduling/cluster-membership-mgr.h: http://gerrit.cloudera.org:8080/#/c/14103/1/be/src/scheduling/cluster-membership-mgr.h@43 PS1, Line 43: /// The ClusterMembershipMgr manages the local backend's membership in the cluster. It has > I think there's a case for making it admission-controller.executor-groups.t Done -- To view, visit http://gerrit.cloudera.org:8080/14103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58cde8699c33af8b87273437e9d8bf6371a34539 Gerrit-Change-Number: 14103 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Wed, 21 Aug 2019 20:48:10 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8858: Add observability of idle executor groups
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#3). Change subject: IMPALA-8858: Add observability of idle executor groups .. IMPALA-8858: Add observability of idle executor groups This patch adds a metric that displays a comma seperated list of executor group names that are in a healthy state and are idle according to the coordinator (no queries admitted locally by the coordinator are running on them). It gets updated when either the cluster membership changes or a query gets admitted or released by the admission controller. Testing: Added a custom cluster test. Change-Id: I58cde8699c33af8b87273437e9d8bf6371a34539 --- M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M be/src/scheduling/cluster-membership-mgr.cc M be/src/scheduling/cluster-membership-mgr.h M common/thrift/metrics.json M tests/custom_cluster/test_executor_groups.py 6 files changed, 155 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/14103/3 -- To view, visit http://gerrit.cloudera.org:8080/14103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I58cde8699c33af8b87273437e9d8bf6371a34539 Gerrit-Change-Number: 14103 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14119 to look at the new patch set (#2). Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1 .. IMPALA-8879: upgrade bootstrap for debug page to 4.3.1 Also upgrade DataTables to 1.10.18 at the same time.. They were obtained from https://datatables.net/download/ and https://getbootstrap.com/docs/4.3/getting-started/download/. Included the version number in the css and js filenames to avoid potential issues with stale versions being cached (I got tripped up by this). I had to do some additional work to get the UI to look right after the upgrade: * added additional style classes to HTML elements for nav and breadcrumb styles - these are required in bootstrap 4. * added styling for plan visualisation graph for it to appear similar to the old graph. * Added styling for to get box around text. Testing: Manually clicked through the web UI to see if anything looked wrong or didn't function correctly. Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7 --- M .gitattributes M bin/rat_exclude_files.txt D www/DataTables-1.10.12/css/dataTables.bootstrap.min.css D www/DataTables-1.10.12/css/dataTables.foundation.min.css D www/DataTables-1.10.12/css/dataTables.jqueryui.min.css D www/DataTables-1.10.12/css/jquery.dataTables.min.css D www/DataTables-1.10.12/css/jquery.dataTables_themeroller.css D www/DataTables-1.10.12/js/dataTables.foundation.min.js D www/DataTables-1.10.12/js/jquery.dataTables.min.js R www/DataTables-1.10.18/css/dataTables.bootstrap.css A www/DataTables-1.10.18/css/dataTables.bootstrap.min.css C www/DataTables-1.10.18/css/dataTables.bootstrap4.css A www/DataTables-1.10.18/css/dataTables.bootstrap4.min.css R www/DataTables-1.10.18/css/dataTables.foundation.css A www/DataTables-1.10.18/css/dataTables.foundation.min.css R www/DataTables-1.10.18/css/dataTables.jqueryui.css A www/DataTables-1.10.18/css/dataTables.jqueryui.min.css A www/DataTables-1.10.18/css/dataTables.semanticui.css A www/DataTables-1.10.18/css/dataTables.semanticui.min.css R www/DataTables-1.10.18/css/jquery.dataTables.css A www/DataTables-1.10.18/css/jquery.dataTables.min.css R www/DataTables-1.10.18/images/sort_asc.png R www/DataTables-1.10.18/images/sort_asc_disabled.png R www/DataTables-1.10.18/images/sort_both.png R www/DataTables-1.10.18/images/sort_desc.png R www/DataTables-1.10.18/images/sort_desc_disabled.png R www/DataTables-1.10.18/js/dataTables.bootstrap.js R www/DataTables-1.10.18/js/dataTables.bootstrap.min.js C www/DataTables-1.10.18/js/dataTables.bootstrap4.js A www/DataTables-1.10.18/js/dataTables.bootstrap4.min.js R www/DataTables-1.10.18/js/dataTables.foundation.js A www/DataTables-1.10.18/js/dataTables.foundation.min.js R www/DataTables-1.10.18/js/dataTables.jqueryui.js R www/DataTables-1.10.18/js/dataTables.jqueryui.min.js C www/DataTables-1.10.18/js/dataTables.semanticui.js A www/DataTables-1.10.18/js/dataTables.semanticui.min.js R www/DataTables-1.10.18/js/jquery.dataTables.js A www/DataTables-1.10.18/js/jquery.dataTables.min.js M www/all_child_groups.tmpl A www/bootstrap/css/bootstrap-4.3.1.min.css D www/bootstrap/css/bootstrap-theme.css D www/bootstrap/css/bootstrap-theme.css.map D www/bootstrap/css/bootstrap-theme.min.css D www/bootstrap/css/bootstrap-theme.min.css.map M www/bootstrap/css/bootstrap.css M www/bootstrap/css/bootstrap.css.map M www/bootstrap/css/bootstrap.min.css M www/bootstrap/css/bootstrap.min.css.map D www/bootstrap/fonts/glyphicons-halflings-regular.eot D www/bootstrap/fonts/glyphicons-halflings-regular.svg D www/bootstrap/fonts/glyphicons-halflings-regular.ttf D www/bootstrap/fonts/glyphicons-halflings-regular.woff D www/bootstrap/fonts/glyphicons-halflings-regular.woff2 A www/bootstrap/js/bootstrap-4.3.1.min.js M www/bootstrap/js/bootstrap.js M www/bootstrap/js/bootstrap.min.js M www/catalog.tmpl M www/common-header.tmpl R www/datatables-1.10.18.css C www/datatables-1.10.18.js A www/datatables-1.10.18.min.css A www/datatables-1.10.18.min.js D www/datatables.js D www/datatables.min.css D www/datatables.min.js M www/metrics.tmpl M www/query_detail_tabs.tmpl M www/query_plan.tmpl M www/query_stmt.tmpl 69 files changed, 15,429 insertions(+), 37,419 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/14119/2 -- To view, visit http://gerrit.cloudera.org:8080/14119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7 Gerrit-Change-Number: 14119 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7027: fix StringLiteral.localEquals()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14096 ) Change subject: IMPALA-7027: fix StringLiteral.localEquals() .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4828/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138 Gerrit-Change-Number: 14096 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Wed, 21 Aug 2019 20:22:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7027: fix StringLiteral.localEquals()
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14096 ) Change subject: IMPALA-7027: fix StringLiteral.localEquals() .. Patch Set 3: Thanks for the fix, tests look good. -- To view, visit http://gerrit.cloudera.org:8080/14096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138 Gerrit-Change-Number: 14096 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Wed, 21 Aug 2019 20:22:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7027: fix StringLiteral.localEquals()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14096 ) Change subject: IMPALA-7027: fix StringLiteral.localEquals() .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138 Gerrit-Change-Number: 14096 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Wed, 21 Aug 2019 20:22:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7027: fix StringLiteral.localEquals()
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14096 ) Change subject: IMPALA-7027: fix StringLiteral.localEquals() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138 Gerrit-Change-Number: 14096 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Wed, 21 Aug 2019 20:22:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14119 Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1 .. IMPALA-8879: upgrade bootstrap for debug page to 4.3.1 Also upgrade DataTables to 1.10.18 at the same time.. They were obtained from https://datatables.net/download/ and https://getbootstrap.com/docs/4.3/getting-started/download/. Included the version number in the css and js filenames to avoid potential issues with stale versions being cached (I got tripped up by this). I had to do some additional work to get the UI to look right after the upgrade: * added additional style classes to HTML elements for nav and breadcrumb styles - these are required in bootstrap 4. * added styling for plan visualisation graph for it to appear similar to the old graph. * Added styling for to get box around text. Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7 --- M .gitattributes M bin/rat_exclude_files.txt D www/DataTables-1.10.12/css/dataTables.bootstrap.min.css D www/DataTables-1.10.12/css/dataTables.foundation.min.css D www/DataTables-1.10.12/css/dataTables.jqueryui.min.css D www/DataTables-1.10.12/css/jquery.dataTables.min.css D www/DataTables-1.10.12/css/jquery.dataTables_themeroller.css D www/DataTables-1.10.12/js/dataTables.foundation.min.js D www/DataTables-1.10.12/js/jquery.dataTables.min.js R www/DataTables-1.10.18/css/dataTables.bootstrap.css A www/DataTables-1.10.18/css/dataTables.bootstrap.min.css C www/DataTables-1.10.18/css/dataTables.bootstrap4.css A www/DataTables-1.10.18/css/dataTables.bootstrap4.min.css R www/DataTables-1.10.18/css/dataTables.foundation.css A www/DataTables-1.10.18/css/dataTables.foundation.min.css R www/DataTables-1.10.18/css/dataTables.jqueryui.css A www/DataTables-1.10.18/css/dataTables.jqueryui.min.css A www/DataTables-1.10.18/css/dataTables.semanticui.css A www/DataTables-1.10.18/css/dataTables.semanticui.min.css R www/DataTables-1.10.18/css/jquery.dataTables.css A www/DataTables-1.10.18/css/jquery.dataTables.min.css R www/DataTables-1.10.18/images/sort_asc.png R www/DataTables-1.10.18/images/sort_asc_disabled.png R www/DataTables-1.10.18/images/sort_both.png R www/DataTables-1.10.18/images/sort_desc.png R www/DataTables-1.10.18/images/sort_desc_disabled.png R www/DataTables-1.10.18/js/dataTables.bootstrap.js R www/DataTables-1.10.18/js/dataTables.bootstrap.min.js C www/DataTables-1.10.18/js/dataTables.bootstrap4.js A www/DataTables-1.10.18/js/dataTables.bootstrap4.min.js R www/DataTables-1.10.18/js/dataTables.foundation.js A www/DataTables-1.10.18/js/dataTables.foundation.min.js R www/DataTables-1.10.18/js/dataTables.jqueryui.js R www/DataTables-1.10.18/js/dataTables.jqueryui.min.js C www/DataTables-1.10.18/js/dataTables.semanticui.js A www/DataTables-1.10.18/js/dataTables.semanticui.min.js R www/DataTables-1.10.18/js/jquery.dataTables.js A www/DataTables-1.10.18/js/jquery.dataTables.min.js M www/all_child_groups.tmpl A www/bootstrap/css/bootstrap-4.3.1.min.css D www/bootstrap/css/bootstrap-theme.css D www/bootstrap/css/bootstrap-theme.css.map D www/bootstrap/css/bootstrap-theme.min.css D www/bootstrap/css/bootstrap-theme.min.css.map M www/bootstrap/css/bootstrap.css M www/bootstrap/css/bootstrap.css.map M www/bootstrap/css/bootstrap.min.css M www/bootstrap/css/bootstrap.min.css.map D www/bootstrap/fonts/glyphicons-halflings-regular.eot D www/bootstrap/fonts/glyphicons-halflings-regular.svg D www/bootstrap/fonts/glyphicons-halflings-regular.ttf D www/bootstrap/fonts/glyphicons-halflings-regular.woff D www/bootstrap/fonts/glyphicons-halflings-regular.woff2 A www/bootstrap/js/bootstrap-4.3.1.min.js M www/bootstrap/js/bootstrap.js M www/bootstrap/js/bootstrap.min.js M www/catalog.tmpl M www/common-header.tmpl R www/datatables-1.10.18.css C www/datatables-1.10.18.js A www/datatables-1.10.18.min.css A www/datatables-1.10.18.min.js D www/datatables.js D www/datatables.min.css D www/datatables.min.js M www/metrics.tmpl M www/query_detail_tabs.tmpl M www/query_plan.tmpl M www/query_stmt.tmpl 69 files changed, 15,429 insertions(+), 37,419 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/14119/1 -- To view, visit http://gerrit.cloudera.org:8080/14119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7 Gerrit-Change-Number: 14119 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] IMPALA-8864: Ignore fe http transport tests on older python versions
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14116 ) Change subject: IMPALA-8864: Ignore fe http transport tests on older python versions .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7 Gerrit-Change-Number: 14116 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 21 Aug 2019 19:42:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8818: Replace deque with spillable queue in BufferedPRS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14039 ) Change subject: IMPALA-8818: Replace deque with spillable queue in BufferedPRS .. Patch Set 9: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/4323/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/14039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10f9e72374cdf9501c0e5e2c5b39c13688ae65a9 Gerrit-Change-Number: 14039 Gerrit-PatchSet: 9 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Aug 2019 19:29:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 ) Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state.cc@846 PS1, Line 846: last_backend || coordinator_last_backend > It seems a bit ad-hoc to detect these cases here in this function. I wonder My understanding of this part of the code is a bit murky, so correct me if I am wrong. I thought that the Coordinator's 'backend_states_' tracks all executing Backends, include the Coordinator Backend (e.g. you can detect if a Backend is running the Coordinator fragment using 'backend->exec_params()->is_coord_backend') (this is the same logic used below to update 'released_coordinator_'), right? ALL_ROWS_PRODUCED wouldn't be a terminal state since it could transition to ERROR, CANCELLED, or RETURNED_RESULTS, so would it make sense to call SetNonErrorTerminalState()? HandleExecStateTransition() also seems to be specific to terminal states - it calls ReleaseExecResources() (maybe calling this early is okay once all results are spooled). The other reason I wanted to add these checks here is to centralize all the logic that decides when admission control resources are released for each backend. -- To view, visit http://gerrit.cloudera.org:8080/14104 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88bb11e0ede7574568020e0277dd8ac8d2586dc9 Gerrit-Change-Number: 14104 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Aug 2019 19:19:23 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14101 ) Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/14101/2/tests/custom_cluster/test_exchange_eos.py File tests/custom_cluster/test_exchange_eos.py: http://gerrit.cloudera.org:8080/#/c/14101/2/tests/custom_cluster/test_exchange_eos.py@57 PS2, Line 57: results = client.fetch(query, handle) > Done need to close the query handle? otherwise it will leak, probably not a big deal in tests, but good practice -- To view, visit http://gerrit.cloudera.org:8080/14101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10c805e9d63ed8af9f458bf71e8ef5ea9376b939 Gerrit-Change-Number: 14101 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Wed, 21 Aug 2019 18:54:09 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8818: Replace deque with spillable queue in BufferedPRS
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14039 ) Change subject: IMPALA-8818: Replace deque with spillable queue in BufferedPRS .. Patch Set 9: (7 comments) http://gerrit.cloudera.org:8080/#/c/14039/8/be/src/runtime/spillable-row-batch-queue.cc File be/src/runtime/spillable-row-batch-queue.cc: http://gerrit.cloudera.org:8080/#/c/14039/8/be/src/runtime/spillable-row-batch-queue.cc@80 PS8, Line 80: RETURN_IF_ERROR(state_->StartSpilling(mem_tracker_)); > Add something to the profile to indicate it spilled? The Buffer Pool already seems to include some metrics to indicate that spilling occurred, do you think that is enough? PLAN_ROOT_SINK:(Total: 4s471ms, non-child: 4s471ms, % non-child: 100.00%) - PeakMemoryUsage: 40.00 KB (40960) - RowBatchGetWaitTime: 0.000ns - RowBatchSendWaitTime: 0.000ns Buffer pool: - AllocTime: 0.000ns - CumulativeAllocationBytes: 136.00 KB (139264) - CumulativeAllocations: 17 (17) - PeakReservation: 32.00 KB (32768) - PeakUnpinnedBytes: 128.00 KB (131072) - PeakUsedReservation: 32.00 KB (32768) - ReadIoBytes: 0 - ReadIoOps: 0 (0) - ReadIoWaitTime: 0.000ns - ReservationLimit: 32.00 KB (32768) - SystemAllocTime: 0.000ns - WriteIoBytes: 128.00 KB (131072) - WriteIoOps: 16 (16) - WriteIoWaitTime: 0.000ns http://gerrit.cloudera.org:8080/#/c/14039/8/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/14039/8/be/src/service/query-options.cc@907 PS8, Line 907: int64_t max_mem = query_options->max_result_spooling_mem; > I'd suggest just making this max_result_spooling_mem or max_result_spooling Changed to 'max_result_spooling_mem' and 'max_spilled_result_spooling_mem' http://gerrit.cloudera.org:8080/#/c/14039/8/be/src/service/query-options.cc@911 PS8, Line 911: max_spilled_result_spooling_mem mus > We should use "spilled" instead of "unpinned" in user-facing terminology to Done http://gerrit.cloudera.org:8080/#/c/14039/8/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java File fe/src/main/java/org/apache/impala/planner/PlanRootSink.java: http://gerrit.cloudera.org:8080/#/c/14039/8/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java@84 PS8, Line 84: memEstimateBytes = (long) Math.ceil(inputCardinality * inputNode.getAvgRowSize()); > There will only ever be one instance of PLAN_ROOT_SINK, so we can remote th Done http://gerrit.cloudera.org:8080/#/c/14039/8/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java@87 PS8, Line 87: > We should cap this at the max result spooling memory, otherwise it could be Moved the cap logic from the ResourceProfile constructor to this method. http://gerrit.cloudera.org:8080/#/c/14039/8/fe/src/main/java/org/apache/impala/planner/ResourceProfile.java File fe/src/main/java/org/apache/impala/planner/ResourceProfile.java: http://gerrit.cloudera.org:8080/#/c/14039/8/fe/src/main/java/org/apache/impala/planner/ResourceProfile.java@76 PS8, Line 76: minMemReservationBytes_ = minMemReservationBytes; > This isn't generally correct for all plan nodes, the memory estimate can in Done http://gerrit.cloudera.org:8080/#/c/14039/8/fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java File fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java: http://gerrit.cloudera.org:8080/#/c/14039/8/fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java@78 PS8, Line 78: Preconditions.checkState(memEstimateBytes_ >= 0, "Mem estimate must be set"); > Maybe check that maxMemReservationBytes_ >= minMemReservationBytes_ I added that check to the ResourceProfile constructor, should I add it here as well, or move it? -- To view, visit http://gerrit.cloudera.org:8080/14039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10f9e72374cdf9501c0e5e2c5b39c13688ae65a9 Gerrit-Change-Number: 14039 Gerrit-PatchSet: 9 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Aug 2019 18:51:36 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8818: Replace deque with spillable queue in BufferedPRS
Hello Michael Ho, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14039 to look at the new patch set (#9). Change subject: IMPALA-8818: Replace deque with spillable queue in BufferedPRS .. IMPALA-8818: Replace deque with spillable queue in BufferedPRS Replaces DequeRowBatchQueue with SpillableRowBatchQueue in BufferedPlanRootSink. A few changes to BufferedPlanRootSink were necessary for it to work with the spillable queue, however, all the synchronization logic is the same. SpillableRowBatchQueue is a wrapper around a BufferedTupleStream and a ReservationManager. It takes in a TBackendResourceProfile that specifies the max / min memory reservation the BufferedTupleStream can use to buffer rows. The 'max_unpinned_bytes' parameter limits the max number of bytes that can be unpinned in the BufferedTupleStream. The limit is a 'soft' limit because calls to AddBatch may push the amount of unpinned memory over the limit. The queue is non-blocking and not thread safe. It provides AddBatch and GetBatch methods. Calls to AddBatch spill if the BufferedTupleStream does not have enough reservation to fit the entire RowBatch. Adds two new query options: 'MAX_PINNED_RESULT_SPOOLING_MEMORY' and 'MAX_UNPINNED_RESULT_SPOOLING_MEMORY', which bound the amount of pinned and unpinned memory that a query can use for spooling, respectively. MAX_PINNED_RESULT_SPOOLING_MEMORY must be <= MAX_UNPINNED_RESULT_SPOOLING_MEMORY in order to allow all the pinned data in the BufferedTupleStream to be unpinned. This is enforced in a new method in QueryOptions called 'ValidateQueryOptions'. Planner Changes: PlanRootSink.java now computes a full ResourceProfile if result spooling is enabled. The min mem reservation is bounded by the size of the read and write pages used by the BufferedTupleStream. The max mem reservation is bounded by 'MAX_PINNED_RESULT_SPOOLING_MEMORY'. The mem estimate is computed by estimating the size of the result set using stats. BufferedTupleStream Re-Factoring: For the most part, using a BufferedTupleStream outside an ExecNode works properly. However, some changes were necessary: * The message for the MAX_ROW_SIZE error is ExecNode specific. In order to fix this, this patch introduces the concept of an ExecNode 'label' which is a more generic version of an ExecNode 'id'. * The definition of TBackendResourceProfile lived in PlanNodes.thrift, it was moved to its own file so it can be used by DataSinks.thrift. * Modified BufferedTupleStream so it internally tracks how many bytes are unpinned (necessary for 'MAX_UNPINNED_RESULT_SPOOLING_MEMORY'). Metrics: * Added a few of the metrics mentioned in IMPALA-8825 to BufferedPlanRootSink. Specifically, added timers to track how much time is spent waiting in the BufferedPlanRootSink 'Send' and 'GetNext' methods. * The BufferedTupleStream in the SpillableRowBatchQueue exposes several BufferPool metrics such as number of reserved and unpinned bytes. Bug Fixes: * Fixed a bug in BufferedPlanRootSink where the MemPool used by the expression evaluators was not being cleared incrementally. * Fixed a bug where the inactive timer was not being properly updated in BufferedPlanRootSink. * Fixed a bug where RowBatch memory was not freed if BufferedPlanRootSink::GetNext terminated early because it could not handle requests where num_results < BATCH_SIZE. Testing: * Added new tests to test_result_spooling.py. * Updated errors thrown in spilling-large-rows.test. * Ran exhaustive tests. Change-Id: I10f9e72374cdf9501c0e5e2c5b39c13688ae65a9 --- M be/generated-sources/gen-cpp/CMakeLists.txt M be/src/exec/analytic-eval-node.cc M be/src/exec/blocking-plan-root-sink.cc M be/src/exec/blocking-plan-root-sink.h M be/src/exec/buffered-plan-root-sink.cc M be/src/exec/buffered-plan-root-sink.h M be/src/exec/data-sink.cc M be/src/exec/exec-node.cc M be/src/exec/exec-node.h M be/src/exec/grouping-aggregator-partition.cc M be/src/exec/grouping-aggregator.cc M be/src/exec/partial-sort-node.cc M be/src/exec/partitioned-hash-join-builder.cc M be/src/exec/partitioned-hash-join-builder.h M be/src/exec/partitioned-hash-join-node.cc M be/src/exec/plan-root-sink.h M be/src/exec/sort-node.cc M be/src/runtime/CMakeLists.txt M be/src/runtime/buffered-tuple-stream-test.cc M be/src/runtime/buffered-tuple-stream.cc M be/src/runtime/buffered-tuple-stream.h D be/src/runtime/deque-row-batch-queue.cc D be/src/runtime/deque-row-batch-queue.h M be/src/runtime/sorter.cc M be/src/runtime/sorter.h A be/src/runtime/spillable-row-batch-queue.cc A be/src/runtime/spillable-row-batch-queue.h M be/src/service/impala-beeswax-server.cc M be/src/service/impala-server.cc M be/src/service/query-options-test.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/CMakeLists.txt M common/thrift/DataSinks.thrift M
[Impala-ASF-CR] [DOCS] Corrected a typo in impala new features.xml for the 3.3 release
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14118 ) Change subject: [DOCS] Corrected a typo in impala_new_features.xml for the 3.3 release .. [DOCS] Corrected a typo in impala_new_features.xml for the 3.3 release Change-Id: I138eefcbcf63a51e567d4387b9c7490da276f8ec Reviewed-on: http://gerrit.cloudera.org:8080/14118 Reviewed-by: Alex Rodoni Tested-by: Impala Public Jenkins --- M docs/topics/impala_new_features.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alex Rodoni: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/14118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I138eefcbcf63a51e567d4387b9c7490da276f8ec Gerrit-Change-Number: 14118 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] [DOCS] Corrected a typo in impala new features.xml for the 3.3 release
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14118 ) Change subject: [DOCS] Corrected a typo in impala_new_features.xml for the 3.3 release .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/469/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I138eefcbcf63a51e567d4387b9c7490da276f8ec Gerrit-Change-Number: 14118 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 21 Aug 2019 18:36:44 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) [DOCS] Impala 3.3 docs to be published
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14115 ) Change subject: [DOCS] Impala 3.3 docs to be published .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I34427a8766ab8989f6bcb57e06ee2fc493e00f77 Gerrit-Change-Number: 14115 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Aug 2019 18:39:27 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) [DOCS] Impala 3.3 docs to be published
Alex Rodoni has removed a vote on this change. Change subject: [DOCS] Impala 3.3 docs to be published .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/14115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: deleteVote Gerrit-Change-Id: I34427a8766ab8989f6bcb57e06ee2fc493e00f77 Gerrit-Change-Number: 14115 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR](asf-site) [DOCS] Impala 3.3 docs to be published
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14115 ) Change subject: [DOCS] Impala 3.3 docs to be published .. Patch Set 3: Verified-1 Build Failed https://jenkins.impala.io/job/gerrit-docs-auto-test/470/ : Doc tests failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/14115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I34427a8766ab8989f6bcb57e06ee2fc493e00f77 Gerrit-Change-Number: 14115 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Aug 2019 18:38:08 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) [DOCS] Impala 3.3 docs to be published
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14115 ) Change subject: [DOCS] Impala 3.3 docs to be published .. Patch Set 3: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/470/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I34427a8766ab8989f6bcb57e06ee2fc493e00f77 Gerrit-Change-Number: 14115 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Aug 2019 18:30:07 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) [DOCS] Impala 3.3 docs to be published
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14115 to look at the new patch set (#3). Change subject: [DOCS] Impala 3.3 docs to be published .. [DOCS] Impala 3.3 docs to be published - Add Impala docs from branch master, commit hash 623e923cc6e190e1cbcb991cb3eadc3e349556b4 Change-Id: I34427a8766ab8989f6bcb57e06ee2fc493e00f77 --- M docs/build/html/commonltr.css M docs/build/html/commonrtl.css M docs/build/html/index.html M docs/build/html/topics/impala_abort_on_error.html M docs/build/html/topics/impala_adls.html M docs/build/html/topics/impala_admin.html M docs/build/html/topics/impala_admission.html M docs/build/html/topics/impala_admission_config.html M docs/build/html/topics/impala_aggregate_functions.html M docs/build/html/topics/impala_aliases.html M docs/build/html/topics/impala_allow_erasure_coded_files.html M docs/build/html/topics/impala_allow_unsupported_formats.html M docs/build/html/topics/impala_alter_database.html M docs/build/html/topics/impala_alter_table.html M docs/build/html/topics/impala_alter_view.html M docs/build/html/topics/impala_analytic_functions.html M docs/build/html/topics/impala_appx_count_distinct.html M docs/build/html/topics/impala_appx_median.html M docs/build/html/topics/impala_array.html M docs/build/html/topics/impala_auditing.html M docs/build/html/topics/impala_authentication.html M docs/build/html/topics/impala_authorization.html M docs/build/html/topics/impala_avg.html M docs/build/html/topics/impala_avro.html M docs/build/html/topics/impala_batch_size.html M docs/build/html/topics/impala_bigint.html M docs/build/html/topics/impala_bit_functions.html M docs/build/html/topics/impala_boolean.html M docs/build/html/topics/impala_breakpad.html M docs/build/html/topics/impala_buffer_pool_limit.html M docs/build/html/topics/impala_char.html A docs/build/html/topics/impala_client.html M docs/build/html/topics/impala_comment.html M docs/build/html/topics/impala_comments.html M docs/build/html/topics/impala_complex_types.html M docs/build/html/topics/impala_components.html M docs/build/html/topics/impala_compression_codec.html M docs/build/html/topics/impala_compute_stats.html M docs/build/html/topics/impala_compute_stats_min_sample_size.html M docs/build/html/topics/impala_concepts.html M docs/build/html/topics/impala_conditional_functions.html M docs/build/html/topics/impala_config.html M docs/build/html/topics/impala_config_options.html M docs/build/html/topics/impala_config_performance.html M docs/build/html/topics/impala_connecting.html M docs/build/html/topics/impala_conversion_functions.html M docs/build/html/topics/impala_count.html M docs/build/html/topics/impala_create_database.html M docs/build/html/topics/impala_create_function.html M docs/build/html/topics/impala_create_role.html M docs/build/html/topics/impala_create_table.html M docs/build/html/topics/impala_create_view.html M docs/build/html/topics/impala_custom_timezones.html A docs/build/html/topics/impala_data_cache.html M docs/build/html/topics/impala_databases.html M docs/build/html/topics/impala_datatypes.html A docs/build/html/topics/impala_date.html M docs/build/html/topics/impala_datetime_functions.html M docs/build/html/topics/impala_ddl.html M docs/build/html/topics/impala_debug_action.html M docs/build/html/topics/impala_decimal.html M docs/build/html/topics/impala_decimal_v2.html M docs/build/html/topics/impala_dedicated_coordinator.html M docs/build/html/topics/impala_default_file_format.html A docs/build/html/topics/impala_default_hints_insert_statement.html M docs/build/html/topics/impala_default_join_distribution_mode.html M docs/build/html/topics/impala_default_spillable_buffer_size.html A docs/build/html/topics/impala_default_transactional_type.html M docs/build/html/topics/impala_delegation.html M docs/build/html/topics/impala_delete.html M docs/build/html/topics/impala_describe.html M docs/build/html/topics/impala_development.html M docs/build/html/topics/impala_disable_codegen.html M docs/build/html/topics/impala_disable_codegen_rows_threshold.html M docs/build/html/topics/impala_disable_row_runtime_filtering.html M docs/build/html/topics/impala_disable_streaming_preaggregations.html M docs/build/html/topics/impala_disable_unsafe_spills.html M docs/build/html/topics/impala_disk_space.html M docs/build/html/topics/impala_distinct.html M docs/build/html/topics/impala_dml.html M docs/build/html/topics/impala_double.html M docs/build/html/topics/impala_drop_database.html M docs/build/html/topics/impala_drop_function.html M docs/build/html/topics/impala_drop_role.html M docs/build/html/topics/impala_drop_stats.html M docs/build/html/topics/impala_drop_table.html M docs/build/html/topics/impala_drop_view.html M docs/build/html/topics/impala_enable_expr_rewrites.html M docs/build/html/topics/impala_exec_single_node_rows_threshold.html M
[Impala-ASF-CR](asf-site) [DOCS] Impala 3.3 docs to be published
Alex Rodoni has removed a vote on this change. Change subject: [DOCS] Impala 3.3 docs to be published .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/14115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: deleteVote Gerrit-Change-Id: I34427a8766ab8989f6bcb57e06ee2fc493e00f77 Gerrit-Change-Number: 14115 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR](asf-site) [DOCS] Impala 3.3 docs to be published
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14115 ) Change subject: [DOCS] Impala 3.3 docs to be published .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I34427a8766ab8989f6bcb57e06ee2fc493e00f77 Gerrit-Change-Number: 14115 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Aug 2019 17:49:16 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Corrected a typo in impala new features.xml for the 3.3 release
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14118 ) Change subject: [DOCS] Corrected a typo in impala_new_features.xml for the 3.3 release .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I138eefcbcf63a51e567d4387b9c7490da276f8ec Gerrit-Change-Number: 14118 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 21 Aug 2019 18:24:47 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Corrected a typo in impala new features.xml for the 3.3 release
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14118 ) Change subject: [DOCS] Corrected a typo in impala_new_features.xml for the 3.3 release .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/469/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I138eefcbcf63a51e567d4387b9c7490da276f8ec Gerrit-Change-Number: 14118 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 21 Aug 2019 18:24:27 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Corrected a typo in impala new features.xml for the 3.3 release
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14118 Change subject: [DOCS] Corrected a typo in impala_new_features.xml for the 3.3 release .. [DOCS] Corrected a typo in impala_new_features.xml for the 3.3 release Change-Id: I138eefcbcf63a51e567d4387b9c7490da276f8ec --- M docs/topics/impala_new_features.xml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/14118/1 -- To view, visit http://gerrit.cloudera.org:8080/14118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I138eefcbcf63a51e567d4387b9c7490da276f8ec Gerrit-Change-Number: 14118 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR](asf-site) [DOCS] Impala 3.3 docs to be published
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14115 ) Change subject: [DOCS] Impala 3.3 docs to be published .. Patch Set 2: Verified-1 Build Failed https://jenkins.impala.io/job/gerrit-docs-auto-test/468/ : Doc tests failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/14115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I34427a8766ab8989f6bcb57e06ee2fc493e00f77 Gerrit-Change-Number: 14115 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Aug 2019 18:22:50 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) [DOCS] Impala 3.3 docs to be published
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14115 ) Change subject: [DOCS] Impala 3.3 docs to be published .. Patch Set 1: Verified-1 Build Failed https://jenkins.impala.io/job/gerrit-docs-auto-test/467/ : Doc tests failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/14115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I34427a8766ab8989f6bcb57e06ee2fc493e00f77 Gerrit-Change-Number: 14115 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Aug 2019 17:39:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8880: Disable EventsProcessorStressTest
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14117 ) Change subject: IMPALA-8880: Disable EventsProcessorStressTest .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4827/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14117 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0be247e01d5047dbd74702fb43d4d038d8ccf758 Gerrit-Change-Number: 14117 Gerrit-PatchSet: 3 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Aug 2019 17:38:42 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) [DOCS] Impala 3.3 docs to be published
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14115 ) Change subject: [DOCS] Impala 3.3 docs to be published .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/468/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I34427a8766ab8989f6bcb57e06ee2fc493e00f77 Gerrit-Change-Number: 14115 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Aug 2019 17:56:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8880: Disable EventsProcessorStressTest
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14117 ) Change subject: IMPALA-8880: Disable EventsProcessorStressTest .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4322/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14117 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0be247e01d5047dbd74702fb43d4d038d8ccf758 Gerrit-Change-Number: 14117 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Aug 2019 18:07:46 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) [DOCS] Impala 3.3 docs to be published
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14115 to look at the new patch set (#2). Change subject: [DOCS] Impala 3.3 docs to be published .. [DOCS] Impala 3.3 docs to be published - Add Impala docs from branch master, commit hash 623e923cc6e190e1cbcb991cb3eadc3e349556b4 Change-Id: I34427a8766ab8989f6bcb57e06ee2fc493e00f77 --- M docs/build/html/commonltr.css M docs/build/html/commonrtl.css M docs/build/html/index.html M docs/build/html/topics/impala_abort_on_error.html M docs/build/html/topics/impala_adls.html M docs/build/html/topics/impala_admin.html M docs/build/html/topics/impala_admission.html M docs/build/html/topics/impala_admission_config.html M docs/build/html/topics/impala_aggregate_functions.html M docs/build/html/topics/impala_aliases.html M docs/build/html/topics/impala_allow_erasure_coded_files.html M docs/build/html/topics/impala_allow_unsupported_formats.html M docs/build/html/topics/impala_alter_database.html M docs/build/html/topics/impala_alter_table.html M docs/build/html/topics/impala_alter_view.html M docs/build/html/topics/impala_analytic_functions.html M docs/build/html/topics/impala_appx_count_distinct.html M docs/build/html/topics/impala_appx_median.html M docs/build/html/topics/impala_array.html M docs/build/html/topics/impala_auditing.html M docs/build/html/topics/impala_authentication.html M docs/build/html/topics/impala_authorization.html M docs/build/html/topics/impala_avg.html M docs/build/html/topics/impala_avro.html M docs/build/html/topics/impala_batch_size.html M docs/build/html/topics/impala_bigint.html M docs/build/html/topics/impala_bit_functions.html M docs/build/html/topics/impala_boolean.html M docs/build/html/topics/impala_breakpad.html M docs/build/html/topics/impala_buffer_pool_limit.html M docs/build/html/topics/impala_char.html A docs/build/html/topics/impala_client.html M docs/build/html/topics/impala_comment.html M docs/build/html/topics/impala_comments.html M docs/build/html/topics/impala_complex_types.html M docs/build/html/topics/impala_components.html M docs/build/html/topics/impala_compression_codec.html M docs/build/html/topics/impala_compute_stats.html M docs/build/html/topics/impala_compute_stats_min_sample_size.html M docs/build/html/topics/impala_concepts.html M docs/build/html/topics/impala_conditional_functions.html M docs/build/html/topics/impala_config.html M docs/build/html/topics/impala_config_options.html M docs/build/html/topics/impala_config_performance.html M docs/build/html/topics/impala_connecting.html M docs/build/html/topics/impala_conversion_functions.html M docs/build/html/topics/impala_count.html M docs/build/html/topics/impala_create_database.html M docs/build/html/topics/impala_create_function.html M docs/build/html/topics/impala_create_role.html M docs/build/html/topics/impala_create_table.html M docs/build/html/topics/impala_create_view.html M docs/build/html/topics/impala_custom_timezones.html A docs/build/html/topics/impala_data_cache.html M docs/build/html/topics/impala_databases.html M docs/build/html/topics/impala_datatypes.html A docs/build/html/topics/impala_date.html M docs/build/html/topics/impala_datetime_functions.html M docs/build/html/topics/impala_ddl.html M docs/build/html/topics/impala_debug_action.html M docs/build/html/topics/impala_decimal.html M docs/build/html/topics/impala_decimal_v2.html M docs/build/html/topics/impala_dedicated_coordinator.html M docs/build/html/topics/impala_default_file_format.html A docs/build/html/topics/impala_default_hints_insert_statement.html M docs/build/html/topics/impala_default_join_distribution_mode.html M docs/build/html/topics/impala_default_spillable_buffer_size.html A docs/build/html/topics/impala_default_transactional_type.html M docs/build/html/topics/impala_delegation.html M docs/build/html/topics/impala_delete.html M docs/build/html/topics/impala_describe.html M docs/build/html/topics/impala_development.html M docs/build/html/topics/impala_disable_codegen.html M docs/build/html/topics/impala_disable_codegen_rows_threshold.html M docs/build/html/topics/impala_disable_row_runtime_filtering.html M docs/build/html/topics/impala_disable_streaming_preaggregations.html M docs/build/html/topics/impala_disable_unsafe_spills.html M docs/build/html/topics/impala_disk_space.html M docs/build/html/topics/impala_distinct.html M docs/build/html/topics/impala_dml.html M docs/build/html/topics/impala_double.html M docs/build/html/topics/impala_drop_database.html M docs/build/html/topics/impala_drop_function.html M docs/build/html/topics/impala_drop_role.html M docs/build/html/topics/impala_drop_stats.html M docs/build/html/topics/impala_drop_table.html M docs/build/html/topics/impala_drop_view.html M docs/build/html/topics/impala_enable_expr_rewrites.html M docs/build/html/topics/impala_exec_single_node_rows_threshold.html M
[Impala-ASF-CR] IMPALA-8880: Disable EventsProcessorStressTest
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14117 ) Change subject: IMPALA-8880: Disable EventsProcessorStressTest .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14117 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0be247e01d5047dbd74702fb43d4d038d8ccf758 Gerrit-Change-Number: 14117 Gerrit-PatchSet: 3 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Aug 2019 17:38:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8880: Disable EventsProcessorStressTest
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14117 ) Change subject: IMPALA-8880: Disable EventsProcessorStressTest .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14117 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0be247e01d5047dbd74702fb43d4d038d8ccf758 Gerrit-Change-Number: 14117 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 21 Aug 2019 17:36:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8864: Ignore fe http transport tests on older python versions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14116 ) Change subject: IMPALA-8864: Ignore fe http transport tests on older python versions .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4321/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7 Gerrit-Change-Number: 14116 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 21 Aug 2019 18:02:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8864: Ignore fe http transport tests on older python versions
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14116 ) Change subject: IMPALA-8864: Ignore fe http transport tests on older python versions .. Patch Set 1: I'm running a private build on centos6. Also kicking off a GVO. -- To view, visit http://gerrit.cloudera.org:8080/14116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7 Gerrit-Change-Number: 14116 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 21 Aug 2019 17:28:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8864: Ignore fe http transport tests on older python versions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14116 ) Change subject: IMPALA-8864: Ignore fe http transport tests on older python versions .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4826/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7 Gerrit-Change-Number: 14116 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 21 Aug 2019 17:28:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8880: Disable EventsProcessorStressTest
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14117 Change subject: IMPALA-8880: Disable EventsProcessorStressTest .. IMPALA-8880: Disable EventsProcessorStressTest EventsProcessorStressTest is flaky. The root-cause of this is MAPREDUCE-6441 which is unavailable in the component builds we use in the minicluster. The test will be renabled once we port MAPREDUCE-6441 to Hive-3 and Hive-2 minicluster Testing: 1. Ran the test on hive-2 and confirmed its being ignored Change-Id: I0be247e01d5047dbd74702fb43d4d038d8ccf758 --- M fe/src/test/java/org/apache/impala/catalog/events/EventsProcessorStressTest.java 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/14117/2 -- To view, visit http://gerrit.cloudera.org:8080/14117 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0be247e01d5047dbd74702fb43d4d038d8ccf758 Gerrit-Change-Number: 14117 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8864: Ignore fe http transport tests on older python versions
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14116 Change subject: IMPALA-8864: Ignore fe http transport tests on older python versions .. IMPALA-8864: Ignore fe http transport tests on older python versions A follow up commit on IMPALA-8864. A couple of fe junit tests also run shell hs2-http tests that are failing on older python versions. This patch identifies such older python versions and skips the problematic tests. Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7 --- M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java 1 file changed, 28 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/14116/1 -- To view, visit http://gerrit.cloudera.org:8080/14116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1449965ba6eb1bca0e64c56065c453ed8c7c46a7 Gerrit-Change-Number: 14116 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada
[Impala-ASF-CR](asf-site) [DOCS] Impala 3.3 docs to be published
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14115 ) Change subject: [DOCS] Impala 3.3 docs to be published .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/467/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I34427a8766ab8989f6bcb57e06ee2fc493e00f77 Gerrit-Change-Number: 14115 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 21 Aug 2019 17:17:57 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) [DOCS] Impala 3.3 docs to be published
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14115 Change subject: [DOCS] Impala 3.3 docs to be published .. [DOCS] Impala 3.3 docs to be published - Add Impala docs from branch master, commit hash 623e923cc6e190e1cbcb991cb3eadc3e349556b4 Change-Id: I34427a8766ab8989f6bcb57e06ee2fc493e00f77 --- M docs/build/html/commonltr.css M docs/build/html/commonrtl.css M docs/build/html/index.html M docs/build/html/topics/impala_abort_on_error.html M docs/build/html/topics/impala_adls.html M docs/build/html/topics/impala_admin.html M docs/build/html/topics/impala_admission.html M docs/build/html/topics/impala_admission_config.html M docs/build/html/topics/impala_aggregate_functions.html M docs/build/html/topics/impala_aliases.html M docs/build/html/topics/impala_allow_erasure_coded_files.html M docs/build/html/topics/impala_allow_unsupported_formats.html M docs/build/html/topics/impala_alter_database.html M docs/build/html/topics/impala_alter_table.html M docs/build/html/topics/impala_alter_view.html M docs/build/html/topics/impala_analytic_functions.html M docs/build/html/topics/impala_appx_count_distinct.html M docs/build/html/topics/impala_appx_median.html M docs/build/html/topics/impala_array.html M docs/build/html/topics/impala_auditing.html M docs/build/html/topics/impala_authentication.html M docs/build/html/topics/impala_authorization.html M docs/build/html/topics/impala_avg.html M docs/build/html/topics/impala_avro.html M docs/build/html/topics/impala_batch_size.html M docs/build/html/topics/impala_bigint.html M docs/build/html/topics/impala_bit_functions.html M docs/build/html/topics/impala_boolean.html M docs/build/html/topics/impala_breakpad.html M docs/build/html/topics/impala_buffer_pool_limit.html M docs/build/html/topics/impala_char.html A docs/build/html/topics/impala_client.html M docs/build/html/topics/impala_comment.html M docs/build/html/topics/impala_comments.html M docs/build/html/topics/impala_complex_types.html M docs/build/html/topics/impala_components.html M docs/build/html/topics/impala_compression_codec.html M docs/build/html/topics/impala_compute_stats.html M docs/build/html/topics/impala_compute_stats_min_sample_size.html M docs/build/html/topics/impala_concepts.html M docs/build/html/topics/impala_conditional_functions.html M docs/build/html/topics/impala_config.html M docs/build/html/topics/impala_config_options.html M docs/build/html/topics/impala_config_performance.html M docs/build/html/topics/impala_connecting.html M docs/build/html/topics/impala_conversion_functions.html M docs/build/html/topics/impala_count.html M docs/build/html/topics/impala_create_database.html M docs/build/html/topics/impala_create_function.html M docs/build/html/topics/impala_create_role.html M docs/build/html/topics/impala_create_table.html M docs/build/html/topics/impala_create_view.html M docs/build/html/topics/impala_custom_timezones.html A docs/build/html/topics/impala_data_cache.html M docs/build/html/topics/impala_databases.html M docs/build/html/topics/impala_datatypes.html A docs/build/html/topics/impala_date.html M docs/build/html/topics/impala_datetime_functions.html M docs/build/html/topics/impala_ddl.html M docs/build/html/topics/impala_debug_action.html M docs/build/html/topics/impala_decimal.html M docs/build/html/topics/impala_decimal_v2.html M docs/build/html/topics/impala_dedicated_coordinator.html M docs/build/html/topics/impala_default_file_format.html A docs/build/html/topics/impala_default_hints_insert_statement.html M docs/build/html/topics/impala_default_join_distribution_mode.html M docs/build/html/topics/impala_default_spillable_buffer_size.html A docs/build/html/topics/impala_default_transactional_type.html M docs/build/html/topics/impala_delegation.html M docs/build/html/topics/impala_delete.html M docs/build/html/topics/impala_describe.html M docs/build/html/topics/impala_development.html M docs/build/html/topics/impala_disable_codegen.html M docs/build/html/topics/impala_disable_codegen_rows_threshold.html M docs/build/html/topics/impala_disable_row_runtime_filtering.html M docs/build/html/topics/impala_disable_streaming_preaggregations.html M docs/build/html/topics/impala_disable_unsafe_spills.html M docs/build/html/topics/impala_disk_space.html M docs/build/html/topics/impala_distinct.html M docs/build/html/topics/impala_dml.html M docs/build/html/topics/impala_double.html M docs/build/html/topics/impala_drop_database.html M docs/build/html/topics/impala_drop_function.html M docs/build/html/topics/impala_drop_role.html M docs/build/html/topics/impala_drop_stats.html M docs/build/html/topics/impala_drop_table.html M docs/build/html/topics/impala_drop_view.html M docs/build/html/topics/impala_enable_expr_rewrites.html M docs/build/html/topics/impala_exec_single_node_rows_threshold.html M docs/build/html/topics/impala_exec_time_limit_s.html M
[Impala-ASF-CR](asf-site) Add 3.3.0 change log
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14112 ) Change subject: Add 3.3.0 change log .. Add 3.3.0 change log Change-Id: If76ae03abbe1482af8c88ac1517ecf263038a252 Reviewed-on: http://gerrit.cloudera.org:8080/14112 Reviewed-by: Alex Rodoni Tested-by: Alex Rodoni --- A docs/changelog-3.3.html M impala-docs.html 2 files changed, 764 insertions(+), 5 deletions(-) Approvals: Alex Rodoni: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: merged Gerrit-Change-Id: If76ae03abbe1482af8c88ac1517ecf263038a252 Gerrit-Change-Number: 14112 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR](asf-site) Add 3.3.0 change log
Tim Armstrong has removed a vote on this change. Change subject: Add 3.3.0 change log .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/14112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: deleteVote Gerrit-Change-Id: If76ae03abbe1482af8c88ac1517ecf263038a252 Gerrit-Change-Number: 14112 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR](asf-site) Add 3.3.0 change log
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14112 ) Change subject: Add 3.3.0 change log .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: If76ae03abbe1482af8c88ac1517ecf263038a252 Gerrit-Change-Number: 14112 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 21 Aug 2019 16:28:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6663 Expose current DDL metrics on WebUI
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/13806 ) Change subject: IMPALA-6663 Expose current DDL metrics on WebUI .. Patch Set 7: (1 comment) I have started adding the table names to this change, will need some additional time to finish. http://gerrit.cloudera.org:8080/#/c/13806/7/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOpRequestCounter.java File fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOpRequestCounter.java: http://gerrit.cloudera.org:8080/#/c/13806/7/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOpRequestCounter.java@41 PS7, Line 41: private AtomicLong resetMetadataCounter_; : : private AtomicLong dmlOperationCounter_; : : private AtomicLong syncDdlOperationCounter_; > Can you add a one line comment on each of these counters as to what do they DML in this context is when an INSERT/CTAS is being finalized, it is triggered here: https://github.com/apache/impala/blob/branch-3.3.0/be/src/service/client-request-state.cc#L1071 The current name is not very descriptive. -- To view, visit http://gerrit.cloudera.org:8080/13806 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ed76f134bad6d3b3d4dce132365a53a01e9512a Gerrit-Change-Number: 13806 Gerrit-PatchSet: 7 Gerrit-Owner: Tamas Mate Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 21 Aug 2019 16:20:32 + Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) Add 3.3.0 change log
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14112 ) Change subject: Add 3.3.0 change log .. Patch Set 1: Verified-1 Build Failed https://jenkins.impala.io/job/gerrit-docs-auto-test/466/ : Doc tests failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/14112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: If76ae03abbe1482af8c88ac1517ecf263038a252 Gerrit-Change-Number: 14112 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 21 Aug 2019 16:20:10 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Add 3.3.0 change log
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14112 ) Change subject: Add 3.3.0 change log .. Patch Set 1: -Verified Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/466/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: If76ae03abbe1482af8c88ac1517ecf263038a252 Gerrit-Change-Number: 14112 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 21 Aug 2019 16:09:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8858: Add observability of idle executor groups
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add observability of idle executor groups .. Patch Set 2: (1 comment) A thing I thought of last night http://gerrit.cloudera.org:8080/#/c/14103/2/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/14103/2/be/src/scheduling/cluster-membership-mgr.cc@606 PS2, Line 606: idle_groups_->SetValue(idle_groups_str); I think this means that when there are no idle groups then this will be "" empty string? I'm worried that in all the stages we have to go through, impala->metrics_prometheus->prometheus->autoscaler that somewhere we will lose a metric with value "". Would it be horrible to have the value be "none" in this case? -- To view, visit http://gerrit.cloudera.org:8080/14103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58cde8699c33af8b87273437e9d8bf6371a34539 Gerrit-Change-Number: 14103 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Wed, 21 Aug 2019 15:50:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) Add 3.3.0 change log
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14112 ) Change subject: Add 3.3.0 change log .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/14112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: If76ae03abbe1482af8c88ac1517ecf263038a252 Gerrit-Change-Number: 14112 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 21 Aug 2019 15:28:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7027: fix StringLiteral.localEquals()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14096 ) Change subject: IMPALA-7027: fix StringLiteral.localEquals() .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4320/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138 Gerrit-Change-Number: 14096 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Wed, 21 Aug 2019 14:35:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7027: fix StringLiteral.localEquals()
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14096 ) Change subject: IMPALA-7027: fix StringLiteral.localEquals() .. Patch Set 1: Ran all exhaustive tests: https://master-02.jenkins.cloudera.com/job/impala-private-parameterized/5623/ -- To view, visit http://gerrit.cloudera.org:8080/14096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138 Gerrit-Change-Number: 14096 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Wed, 21 Aug 2019 13:56:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7027: fix StringLiteral.localEquals()
Yongzhi Chen has uploaded a new patch set (#2) to the change originally created by Tim Armstrong. ( http://gerrit.cloudera.org:8080/14096 ) Change subject: IMPALA-7027: fix StringLiteral.localEquals() .. IMPALA-7027: fix StringLiteral.localEquals() String literals with the same value but different types are not interchangeable. localEquals() should check the type, similar to a cast expression. Testing: - Added String literals tests. - Passed exhaustive tests. Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138 --- M fe/src/main/java/org/apache/impala/analysis/StringLiteral.java A testdata/workloads/functional-query/queries/QueryTest/string-literals.test M tests/query_test/test_chars.py 3 files changed, 46 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/14096/2 -- To view, visit http://gerrit.cloudera.org:8080/14096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138 Gerrit-Change-Number: 14096 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen
[Impala-ASF-CR](asf-site) Add 3.3.0 change log
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14112 ) Change subject: Add 3.3.0 change log .. Patch Set 1: Verified-1 Build Failed https://jenkins.impala.io/job/gerrit-docs-auto-test/464/ : Doc tests failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/14112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: If76ae03abbe1482af8c88ac1517ecf263038a252 Gerrit-Change-Number: 14112 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 21 Aug 2019 10:08:41 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Add 3.3.0 change log
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14112 ) Change subject: Add 3.3.0 change log .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/464/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: If76ae03abbe1482af8c88ac1517ecf263038a252 Gerrit-Change-Number: 14112 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 21 Aug 2019 09:48:50 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Updated download links for release 3.3.0
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14113 Change subject: Updated download links for release 3.3.0 .. Updated download links for release 3.3.0 Change-Id: I78c81146003841e0757f012a39d7826a2f116156 --- M downloads.html 1 file changed, 14 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/14113/1 -- To view, visit http://gerrit.cloudera.org:8080/14113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: newchange Gerrit-Change-Id: I78c81146003841e0757f012a39d7826a2f116156 Gerrit-Change-Number: 14113 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang
[Impala-ASF-CR](asf-site) Add 3.3.0 change log
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14112 Change subject: Add 3.3.0 change log .. Add 3.3.0 change log Change-Id: If76ae03abbe1482af8c88ac1517ecf263038a252 --- A docs/changelog-3.3.html M impala-docs.html 2 files changed, 764 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/14112/1 -- To view, visit http://gerrit.cloudera.org:8080/14112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: newchange Gerrit-Change-Id: If76ae03abbe1482af8c88ac1517ecf263038a252 Gerrit-Change-Number: 14112 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang
