[Impala-ASF-CR] IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

2019-09-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14214 ) Change subject: IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

2019-09-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14214 ) Change subject: IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-17 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14246 to look at the new patch set (#3). Change subject: IMPALA-8634: Catalog client should retry RPCs

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-17 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-17 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14246 to look at the new patch set (#2). Change subject: IMPALA-8634: Catalog client should retry RPCs

[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14249 ) Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions .. Patch Set 2: Verified+1 Build Successful

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 7: (2 comments) Overall, this makes sense to me.

[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14249 ) Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions .. Patch Set 2: Build Started

[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-17 Thread Alex Rodoni (Code Review)
Hello Greg Rahn, Norbert Luksa, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14249 to look at the new patch set (#2). Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-17 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14249 ) Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-17 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/14249 ) Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14249 ) Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions .. Patch Set 1: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-17 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14249 Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions .. IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler

[Impala-ASF-CR] IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14249 ) Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-7984: Port runtime filter from Thrift RPC to KRPC

2019-09-17 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 ) Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC .. Patch Set 19: (26 comments)

[Impala-ASF-CR] IMPALA-8948: [DOCS] Impala cannot write to compressed text file

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14237 ) Change subject: IMPALA-8948: [DOCS] Impala cannot write to compressed text file .. Patch Set 3: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8948: [DOCS] Impala cannot write to compressed text file

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14237 ) Change subject: IMPALA-8948: [DOCS] Impala cannot write to compressed text file .. Patch Set 3: Build Started

[Impala-ASF-CR] IMPALA-8948: [DOCS] Impala cannot write to compressed text file

2019-09-17 Thread Alex Rodoni (Code Review)
Hello Vincent Tran, xiaom...@cloudera.com, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14237 to look at the new patch set (#3). Change subject: IMPALA-8948: [DOCS] Impala cannot write to compressed text file

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-17 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14248 Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. IMPALA-8944: Update and re-enable S3PlannerTest Addresses several

[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile

2019-09-17 Thread Sahil Takiar (Code Review)
Sahil Takiar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13786 ) Change subject: IMPALA-7322: Add storage wait time to profile .. IMPALA-7322: Add storage wait time to profile Add metrics to

[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile

2019-09-17 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13786 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 7: Code-Review+2 Carrying +2 -- To view, visit

[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13786 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 16: Build Successful

[Impala-ASF-CR] IMPALA-8755: Frontend support for Z-ordering

2019-09-17 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13955 ) Change subject: IMPALA-8755: Frontend support for Z-ordering .. Patch Set 12: Code-Review+1 (1 comment) Good work Norbert. In

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 15: Build Successful

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 14: Build Successful

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 16: Code-Review+1 (2

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-17 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#16). Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 15: (2 comments)

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 15: Code-Review+1 Rebased and

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-17 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#15). Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 14: (2 comments)

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-17 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#14). Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 13: Code-Review+1 (2

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8942: Set file format specific split sizes on non-block stores

2019-09-17 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14247 Change subject: IMPALA-8942: Set file format specific split sizes on non-block stores .. IMPALA-8942: Set file format specific split

[Impala-ASF-CR] IMPALA-8903: [DOCS] TRUNCATE is supported for Insert-only transactional tables

2019-09-17 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14235 ) Change subject: IMPALA-8903: [DOCS] TRUNCATE is supported for Insert-only transactional tables .. IMPALA-8903: [DOCS] TRUNCATE

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-17 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14246 Change subject: IMPALA-8634: Catalog client should retry RPCs .. IMPALA-8634: Catalog client should retry RPCs Add retries to catalogd

[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13786 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13786 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-8703: ISO:SQL:2016 datetime patterns - Milestone 1

2019-09-17 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/13722 ) Change subject: IMPALA-8703: ISO:SQL:2016 datetime patterns - Milestone 1 .. Patch Set 20: (9 comments)

[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile

2019-09-17 Thread Yongzhi Chen (Code Review)
Hello Bharath Vissapragada, Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13786 to look at the new patch set (#6). Change subject: IMPALA-7322: Add storage wait time to profile

[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile

2019-09-17 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13786 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 6: patch 6 fix the test: because of the name change of the

[Impala-ASF-CR] IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader

2019-09-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13329 ) Change subject: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. Patch Set 19: Build Successful

[Impala-ASF-CR] IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader

2019-09-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#19). ( http://gerrit.cloudera.org:8080/13329 ) Change subject: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. IMPALA-6433: Part 1: Extract page

[Impala-ASF-CR] IMPALA-8903: [DOCS] TRUNCATE is supported for Insert-only transactional tables

2019-09-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14235 ) Change subject: IMPALA-8903: [DOCS] TRUNCATE is supported for Insert-only transactional tables .. Patch Set 1: Code-Review+2 --