[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5168/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id03d8d4d41a2ac1b15e7060e2a013e334d044ee7 Gerrit-Change-Number: 14592 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Sat, 02 Nov 2019 04:11:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9023: Fix IllegalStateException in SimplifyConditionalsRule
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14540 ) Change subject: IMPALA-9023: Fix IllegalStateException in SimplifyConditionalsRule .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5167/ -- To view, visit http://gerrit.cloudera.org:8080/14540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I640d577200e76121c72685e4aaba1ef312a2d8b4 Gerrit-Change-Number: 14540 Gerrit-PatchSet: 3 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Alice Fan Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 02 Nov 2019 03:12:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5166/ -- To view, visit http://gerrit.cloudera.org:8080/14592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id03d8d4d41a2ac1b15e7060e2a013e334d044ee7 Gerrit-Change-Number: 14592 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Sat, 02 Nov 2019 02:18:46 + Gerrit-HasComments: No
***UNCHECKED*** [Impala-ASF-CR] IMPALA-8525: Bump CDH BUILD NUMBER to 1582079
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14612 ) Change subject: IMPALA-8525: Bump CDH_BUILD_NUMBER to 1582079 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6055d8ab6ea1101a911eaf07807482d66ef94a7d Gerrit-Change-Number: 14612 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sat, 02 Nov 2019 01:08:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8525: Bump CDH BUILD NUMBER to 1582079
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14612 ) Change subject: IMPALA-8525: Bump CDH_BUILD_NUMBER to 1582079 .. IMPALA-8525: Bump CDH_BUILD_NUMBER to 1582079 This pulls in some changes to libhdfs that will help with Impala-on-S3 performance. Specifically, HDFS-14564: "Add libhdfs APIs for readFully; add readFully to ByteBufferPositionedReadable" Testing: * Ran core tests Change-Id: I6055d8ab6ea1101a911eaf07807482d66ef94a7d Reviewed-on: http://gerrit.cloudera.org:8080/14612 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M bin/impala-config.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6055d8ab6ea1101a911eaf07807482d66ef94a7d Gerrit-Change-Number: 14612 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-9047: Bump CDP BUILD NUMBER to 1471450
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14576 ) Change subject: IMPALA-9047: Bump CDP_BUILD_NUMBER to 1471450 .. IMPALA-9047: Bump CDP_BUILD_NUMBER to 1471450 This patch bumps CDP_BUILD_NUMBER to 1471450. The new GBN upgrades Ranger from 1.2 to 2.0, which includes the change to the default Ranger policies described in https://issues.apache.org/jira/browse/RANGER-2536. Some of the Ranger tests fail, because they assume the older behavior. To address this issue, this patch temporarily disables those affected Ranger tests. Specifically, the affected tests in the following test files are disabled for now. 1. test_authorized_proxy.py 2. test_ranger.py 3. AuthorizationStmtTest.java 4. RangerAuditLogTest.java IMPALA-8842 part 2: (Hive3) Use 'engine' field in HMS stat API The new CDP GBN includes the fix for HIVE-22046. HIVE-22046 added 'engine' column to TAB_COL_STATS and PART_COL_STATS HMS tables. The new column is used to differentiate among column stats computed by different engines. The related HMS API calls were changed accordingly. Part of this patch is Step 4 in a series of steps to coordinate the introduction of HMS API changes to Hive3 and Impala. For more information see IMPALA-8842 part 1. Step 4 replaces *V2 calls with *. The *V2 names were introduced temporarily and will be removed from the HMS API in the near future. Testing: - This patch passes the affected Ranger tests listed above on a local machine. - E2E tests were added to make sure that column statistics are differentiated by engine for partitioned and non-partitioned tables. The tests are executed for transactional and non-transactional tables. Change-Id: I962423cf202ad632b5817669500b3e3479f1a454 Reviewed-on: http://gerrit.cloudera.org:8080/14576 Reviewed-by: Joe McDonnell Tested-by: Impala Public Jenkins --- M bin/impala-config.sh M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java M fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java M fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java M tests/authorization/test_authorized_proxy.py M tests/authorization/test_ranger.py M tests/common/skip.py M tests/metadata/test_hms_integration.py 8 files changed, 227 insertions(+), 10 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/14576 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I962423cf202ad632b5817669500b3e3479f1a454 Gerrit-Change-Number: 14576 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-9047: Bump CDP BUILD NUMBER to 1471450
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14576 ) Change subject: IMPALA-9047: Bump CDP_BUILD_NUMBER to 1471450 .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14576 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I962423cf202ad632b5817669500b3e3479f1a454 Gerrit-Change-Number: 14576 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 02 Nov 2019 00:32:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 23: (1 comment) http://gerrit.cloudera.org:8080/#/c/10855/23/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/10855/23/be/src/runtime/query-state.cc@353 PS23, Line 353: unique_ptr sidecar_buf = make_unique(); : sidecar_buf->assign_copy(profile_buf, profile_len); : unique_ptr sidecar = RpcSidecar::FromFaststring(move(sidecar_buf)); Can't we use a slice here instead ? -- To view, visit http://gerrit.cloudera.org:8080/10855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7638583b433dcac066b87198e448743d90415ebe Gerrit-Change-Number: 10855 Gerrit-PatchSet: 23 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michal Ostrowski Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Sat, 02 Nov 2019 00:19:19 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 ) Change subject: IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4933/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a Gerrit-Change-Number: 14531 Gerrit-PatchSet: 7 Gerrit-Owner: Xiaomeng Zhang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Xiaomeng Zhang Gerrit-Comment-Date: Sat, 02 Nov 2019 00:20:49 + Gerrit-HasComments: No
***UNCHECKED*** [Impala-ASF-CR] IMPALA-7984: Port runtime filter from Thrift RPC to KRPC
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/13882 )
Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC
..
Patch Set 27: Code-Review+2
(19 comments)
LGTM. Please address the comments below.
http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/benchmarks/bloom-filter-benchmark.cc
File be/src/benchmarks/bloom-filter-benchmark.cc:
http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/benchmarks/bloom-filter-benchmark.cc@290
PS27, Line 290: std::shared_ptr
No need for shared_ptr
http://gerrit.cloudera.org:8080/#/c/13882/25/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:
http://gerrit.cloudera.org:8080/#/c/13882/25/be/src/runtime/coordinator.cc@1022
PS25, Line 1022: {
> Thanks for pointing this out.
Makes sense.
http://gerrit.cloudera.org:8080/#/c/13882/25/be/src/runtime/coordinator.cc@1072
PS25, Line 1072:
bloom_filter_directory.swap(state->bloom_filter_directory());
: DCHECK(rpc_params.bloom_filter().always_false()
> Thanks for the suggestion!
I guess it can simply be
*rpc_params.mutable_bloom_filter() = state->bloom_filter();
http://gerrit.cloudera.org:8080/#/c/13882/25/be/src/runtime/coordinator.cc@1074
PS25, Line 1074: || rpc_params.bloo
> Thanks for the suggestion.
Missed the part about the scope of state. Think it's fine to keep it as-is.
Thanks for the explanation.
http://gerrit.cloudera.org:8080/#/c/13882/25/be/src/runtime/coordinator.cc@1098
PS25, Line 1098:
> Since 'state' is defined inside of the critical section as mentioned above,
Makes sense.
http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:
http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/runtime/coordinator.cc@1096
PS27, Line 1096: reinterpret_cast(&(bloom_filter_directory[0])),
: static_cast(bloom_filter_directory.size())
Please see comments at BloomFilter::AddDirectorySidecar(). We can pass in the
string directly instead.
http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/runtime/runtime-filter-bank.cc
File be/src/runtime/runtime-filter-bank.cc:
http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/runtime/runtime-filter-bank.cc@187
PS27, Line 187: DCHECK(
nit: DCHECK_EQ
http://gerrit.cloudera.org:8080/#/c/13882/25/be/src/service/impala-server.h
File be/src/service/impala-server.h:
http://gerrit.cloudera.org:8080/#/c/13882/25/be/src/service/impala-server.h@35
PS25, Line 35: #include "gen-cpp/ImpalaInternalService.h"
> Thanks for this suggestion.
Looks like it's more involved than expected. Please feel free to defer it to
the follow-up patch which removes ImpalaInternalService altogether.
http://gerrit.cloudera.org:8080/#/c/13882/25/be/src/service/impala-server.h@70
PS25, Line 70: class TSessionState;
: class TQueryOptions;
> Thanks for pointing this out!
Sounds good.
http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/util/bloom-filter-test.cc
File be/src/util/bloom-filter-test.cc:
http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/util/bloom-filter-test.cc@a68
PS27, Line 68:
:
:
Why not keep most of this header comment which explains what this test does and
talks about the output arguments (e.g. success, protobuf, directory)
http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/util/bloom-filter-test.cc@103
PS27, Line 103: *success = directory_y.compare(directory_y2) == 0 ? true :
false;
*success = directory_y.compare(directory_y2) == 0;
http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/util/bloom-filter-test.cc@365
PS27, Line 365: std::shared_ptr<
No need for shared_ptr
http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/util/bloom-filter-test.cc@367
PS27, Line 367:
nit: unnecessary blank line
http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/util/bloom-filter-test.cc@395
PS27, Line 395: TBloomFilter
BloomFilterPB
http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/util/bloom-filter.h
File be/src/util/bloom-filter.h:
http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/util/bloom-filter.h@95
PS27, Line 95: const uint8_t* directory_in,
: size_t directory_in_size)
Can this interface take a string only instead for the directory ? Can we use
directory.size() to get the size in Init() or are there cases in which passing
a string won't work ?
http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/util/bloom-filter.cc
File be/src/util/bloom-filter.cc:
http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/util/bloom-filter.cc@79
PS27, Line 79: protobuf
rpc_params
http://gerrit.cloudera.org:8080/#/c/13882/27/be/src/util/bloom-filter.cc@80
PS27, Line 80: const char* directory,
: unsigned long directory_size
See comments below. This could be const string& directory. I believe
faststring::append() also has an interface for taking string as input.
[Impala-ASF-CR] IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
Xiaomeng Zhang has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/14531 ) Change subject: IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo .. IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo Before this change OsInfo::DebugString() would print two lines: - OS version: the long name of the Linux kernel from /proc/version - Clock: the type of clock used After this change OsInfo::DebugString() will print three lines: - OS version: the short name of the OS release. If Docker is being used this is the name of the Container OS - Kernel version: the long name of the Linux kernel from /proc/version. If Docker is being used this is the description of the Host Kernel. - Clock: the type of clock used. Tested locally, the displayed OS Info in Ubuntu16 dev box is: OS version: Ubuntu 16.04.6 LTS Kernel version: Linux version 4.15.0-65-generic (buildd@lcy01-amd64-017) (gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10)) Clock: clocksource: 'tsc', clockid_t: CLOCK_MONOTONIC Also tested with diff OS in docker: centos, redhat, ubuntu, oracle, debian. Each OS picked one version to test. Added new backend test os-info-test.cc. Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a --- M be/src/util/CMakeLists.txt A be/src/util/os-info-test.cc M be/src/util/os-info.cc M be/src/util/os-info.h 4 files changed, 75 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14531/7 -- To view, visit http://gerrit.cloudera.org:8080/14531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a Gerrit-Change-Number: 14531 Gerrit-PatchSet: 7 Gerrit-Owner: Xiaomeng Zhang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Xiaomeng Zhang
[Impala-ASF-CR] IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
Xiaomeng Zhang has posted comments on this change. (
http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Change the format OS version and Kernel version
dispalyed in OSInfo
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14531/6/be/src/util/os-info.cc
File be/src/util/os-info.cc:
http://gerrit.cloudera.org:8080/#/c/14531/6/be/src/util/os-info.cc@72
PS6, Line 72: if (fields[0].compare("PRETTY_NAME") == 0) {
> Will this work on Centos6?
Sorry, no, I'll update with fix.
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaomeng Zhang
Gerrit-Reviewer: Andrew Sherman
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Xiaomeng Zhang
Gerrit-Comment-Date: Fri, 01 Nov 2019 23:36:04 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9023: Fix IllegalStateException in SimplifyConditionalsRule
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14540 ) Change subject: IMPALA-9023: Fix IllegalStateException in SimplifyConditionalsRule .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5167/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I640d577200e76121c72685e4aaba1ef312a2d8b4 Gerrit-Change-Number: 14540 Gerrit-PatchSet: 3 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Alice Fan Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 01 Nov 2019 22:47:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9023: Fix IllegalStateException in SimplifyConditionalsRule
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14540 ) Change subject: IMPALA-9023: Fix IllegalStateException in SimplifyConditionalsRule .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I640d577200e76121c72685e4aaba1ef312a2d8b4 Gerrit-Change-Number: 14540 Gerrit-PatchSet: 3 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Alice Fan Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 01 Nov 2019 22:47:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9023: Fix IllegalStateException in SimplifyConditionalsRule
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14540 ) Change subject: IMPALA-9023: Fix IllegalStateException in SimplifyConditionalsRule .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I640d577200e76121c72685e4aaba1ef312a2d8b4 Gerrit-Change-Number: 14540 Gerrit-PatchSet: 2 Gerrit-Owner: Alice Fan Gerrit-Reviewer: Alice Fan Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 01 Nov 2019 22:47:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >d characters
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14614 ) Change subject: IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >=64 characters This adds a workaround for an upstream SASL bug which is triggered when the FQDN has more than 64 characters. In this case, SASL would truncate the FQDN and not be able to find the relevant keytab. The workaround simply uses our own code to determine the FQDN. Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a Reviewed-on: http://gerrit.cloudera.org:8080/14609 Reviewed-by: Anurag Mantripragada Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins Reviewed-on: http://gerrit.cloudera.org:8080/14614 Reviewed-by: Todd Lipcon Reviewed-by: Michael Ho Tested-by: Impala Public Jenkins --- M be/src/kudu/rpc/server_negotiation.cc 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Todd Lipcon: Looks good to me, approved Michael Ho: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/14614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a Gerrit-Change-Number: 14614 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >d characters
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14614 ) Change subject: IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a Gerrit-Change-Number: 14614 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 01 Nov 2019 21:51:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 ) Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5166/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id03d8d4d41a2ac1b15e7060e2a013e334d044ee7 Gerrit-Change-Number: 14592 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 01 Nov 2019 21:47:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8738: "show extended tables" to return more than the table name
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14422 ) Change subject: IMPALA-8738: "show extended tables" to return more than the table name .. Patch Set 8: Not a LocalCatalog expert, but when LocalCatalogMode is turned on, impalads will fetch a per-query copy of the metadata on demand. The tests are run with this mode on. In the test failure, the localCatalog for "show extended '*'; " is trying to load the metadata for all tables (*) and instantiate the table subclass. However, there is no subclass for datasource table, which means those tables cannot be instantiated this way. See: https://github.com/apache/impala/blob/28b1d53f9cb7581974dfc0b2dd75f2f015c1c6b9/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java#L98 In short, I think we should disable 'show extended tables '*' " or any similar tests that try to fetch metadata for "ALL" tables and re-run the tests. If not done already, It will good to test these codepaths with LocalCatalog mode on, you can do that using: bin/start-impala-cluster.py --impalad_args="--use_local_catalog=true" --catalogd_args="--catalog_topic_mode=minimal" -- To view, visit http://gerrit.cloudera.org:8080/14422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63057c9d2fc453f95c6890bdc90e11c61a98a419 Gerrit-Change-Number: 14422 Gerrit-PatchSet: 8 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Fri, 01 Nov 2019 19:14:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9073: fix test executor concurrency flakiness
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14606 ) Change subject: IMPALA-9073: fix test_executor_concurrency flakiness .. IMPALA-9073: fix test_executor_concurrency flakiness The test was checking the incorrect invariant - the slot mechanism only prevents more than than number of queries running on a backend. More queries can run on a cluster since the query's backends are freed up before the query itself finishes. It was a little tricky picking an appropriate metric since there is no strong consistency between the metrics, e.g. decrementing a metric after a backend finishes may race with admitting the next query. So I simply used the same metric used by the admission controller in making decisions, which should be strongly consistent w.r.t. admission control decissions. Also remove the concurrency limit on the coordinator, which seemed inconsistent with the purpose of the test, because we only want concurrency to be limited by the executors. Testing: Looped the test for a bit. Change-Id: I910028919f248a3bf5de345e9eade9dbc4353ebd Reviewed-on: http://gerrit.cloudera.org:8080/14606 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M tests/custom_cluster/test_executor_groups.py 1 file changed, 15 insertions(+), 8 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I910028919f248a3bf5de345e9eade9dbc4353ebd Gerrit-Change-Number: 14606 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar
[Impala-ASF-CR] IMPALA-9073: fix test executor concurrency flakiness
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14606 ) Change subject: IMPALA-9073: fix test_executor_concurrency flakiness .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I910028919f248a3bf5de345e9eade9dbc4353ebd Gerrit-Change-Number: 14606 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Fri, 01 Nov 2019 21:12:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9047: Bump CDP BUILD NUMBER to 1471450
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14576 ) Change subject: IMPALA-9047: Bump CDP_BUILD_NUMBER to 1471450 .. Patch Set 4: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/14576 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I962423cf202ad632b5817669500b3e3479f1a454 Gerrit-Change-Number: 14576 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 01 Nov 2019 20:07:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8525: Bump CDH BUILD NUMBER to 1582079
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14612 ) Change subject: IMPALA-8525: Bump CDH_BUILD_NUMBER to 1582079 .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5165/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6055d8ab6ea1101a911eaf07807482d66ef94a7d Gerrit-Change-Number: 14612 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 01 Nov 2019 20:38:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8525: Bump CDH BUILD NUMBER to 1582079
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14612 ) Change subject: IMPALA-8525: Bump CDH_BUILD_NUMBER to 1582079 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6055d8ab6ea1101a911eaf07807482d66ef94a7d Gerrit-Change-Number: 14612 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 01 Nov 2019 20:38:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8525: Bump CDH BUILD NUMBER to 1582079
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14612 ) Change subject: IMPALA-8525: Bump CDH_BUILD_NUMBER to 1582079 .. Patch Set 1: Code-Review+2 Good idea to bump this, it's been a while. -- To view, visit http://gerrit.cloudera.org:8080/14612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6055d8ab6ea1101a911eaf07807482d66ef94a7d Gerrit-Change-Number: 14612 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 01 Nov 2019 20:32:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9047: Bump CDP BUILD NUMBER to 1471450
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14576 ) Change subject: IMPALA-9047: Bump CDP_BUILD_NUMBER to 1471450 .. Patch Set 4: Running a gerrit-verify-dryrun-external to see if the issue reproduces. We haven't been able to reproduce locally. -- To view, visit http://gerrit.cloudera.org:8080/14576 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I962423cf202ad632b5817669500b3e3479f1a454 Gerrit-Change-Number: 14576 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 01 Nov 2019 20:07:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9047: Bump CDP BUILD NUMBER to 1471450
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14576 ) Change subject: IMPALA-9047: Bump CDP_BUILD_NUMBER to 1471450 .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5164/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14576 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I962423cf202ad632b5817669500b3e3479f1a454 Gerrit-Change-Number: 14576 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 01 Nov 2019 20:07:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9109: Add top-k metadata loading ranking on catalogd UI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14600 ) Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4932/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9305a867d7053cde9acc42dae6e47ee440f1a8bf Gerrit-Change-Number: 14600 Gerrit-PatchSet: 4 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jiawei Wang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Fri, 01 Nov 2019 19:00:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo
..
Patch Set 6:
(2 comments)
Still a few things to think about...
http://gerrit.cloudera.org:8080/#/c/14531/6//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14531/6//COMMIT_MSG@7
PS6, Line 7: IMPALA-8065 Edit OS version and Kernel version in OSInfo
Can you improve this one line description? Why is it Edit?
http://gerrit.cloudera.org:8080/#/c/14531/6/be/src/util/os-info.cc
File be/src/util/os-info.cc:
http://gerrit.cloudera.org:8080/#/c/14531/6/be/src/util/os-info.cc@72
PS6, Line 72: if (fields[0].compare("PRETTY_NAME") == 0) {
Will this work on Centos6?
https://www.liquidweb.com/kb/how-to-check-your-centos-version/
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaomeng Zhang
Gerrit-Reviewer: Andrew Sherman
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Xiaomeng Zhang
Gerrit-Comment-Date: Fri, 01 Nov 2019 18:08:07 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9109: Add top-k metadata loading ranking on catalogd UI
Jiawei Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14600 ) Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI .. Patch Set 4: (1 comment) Thanks for the feedbacks! http://gerrit.cloudera.org:8080/#/c/14600/3/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/14600/3/tests/webserver/test_web_pages.py@378 PS3, Line 378: loading_tables = response_json["longest_loading_tables"] > nit: Could you change the variable name? Done -- To view, visit http://gerrit.cloudera.org:8080/14600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9305a867d7053cde9acc42dae6e47ee440f1a8bf Gerrit-Change-Number: 14600 Gerrit-PatchSet: 4 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jiawei Wang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Fri, 01 Nov 2019 18:15:47 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9109: Add top-k metadata loading ranking on catalogd UI
Jiawei Wang has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14600 ) Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI .. IMPALA-9109: Add top-k metadata loading ranking on catalogd UI Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the longest metadata loading time. Add the sorted table in Catalog server web-ui. The loading time is cacualted by the median from load_duration metrics. Testing: - Add end-to-end test for webpage to verify the label and text exisit in catalog debug page. - Launch Impala and activate some tables to see the table loading time showed successfully on the catalog debug UI page. Change-Id: I9305a867d7053cde9acc42dae6e47ee440f1a8bf --- M be/src/catalog/catalog-server.cc M be/src/catalog/catalog-server.h M common/thrift/JniCatalog.thrift M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/Table.java M tests/webserver/test_web_pages.py M www/catalog.tmpl 9 files changed, 145 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/14600/4 -- To view, visit http://gerrit.cloudera.org:8080/14600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9305a867d7053cde9acc42dae6e47ee440f1a8bf Gerrit-Change-Number: 14600 Gerrit-PatchSet: 4 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jiawei Wang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Yongzhi Chen
[Impala-ASF-CR] IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >d characters
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14614 ) Change subject: IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5163/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a Gerrit-Change-Number: 14614 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 01 Nov 2019 17:22:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >d characters
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14614 ) Change subject: IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4931/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a Gerrit-Change-Number: 14614 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 01 Nov 2019 17:45:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >d characters
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14614 ) Change subject: IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a Gerrit-Change-Number: 14614 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 01 Nov 2019 17:17:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >d characters
Anurag Mantripragada has removed Adar Dembo from this change. ( http://gerrit.cloudera.org:8080/14614 ) Change subject: IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. Removed reviewer Adar Dembo. -- To view, visit http://gerrit.cloudera.org:8080/14614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a Gerrit-Change-Number: 14614 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >d characters
Anurag Mantripragada has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/14614 ) Change subject: IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. Removed reviewer Kudu Jenkins. -- To view, visit http://gerrit.cloudera.org:8080/14614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a Gerrit-Change-Number: 14614 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >d characters
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14614 ) Change subject: IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a Gerrit-Change-Number: 14614 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 01 Nov 2019 17:20:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9073: fix test executor concurrency flakiness
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14606 ) Change subject: IMPALA-9073: fix test_executor_concurrency flakiness .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I910028919f248a3bf5de345e9eade9dbc4353ebd Gerrit-Change-Number: 14606 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Fri, 01 Nov 2019 16:32:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 ) Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. Patch Set 2: Abandoning this change, cherry-picked KUDU's change here: https://gerrit.cloudera.org/#/c/14614/ -- To view, visit http://gerrit.cloudera.org:8080/14610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Gerrit-Change-Number: 14610 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 01 Nov 2019 17:02:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Anurag Mantripragada has abandoned this change. ( http://gerrit.cloudera.org:8080/14610 ) Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/14610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Gerrit-Change-Number: 14610 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >d characters
Anurag Mantripragada has removed Todd Lipcon from this change. ( http://gerrit.cloudera.org:8080/14614 ) Change subject: IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. Removed reviewer Todd Lipcon. -- To view, visit http://gerrit.cloudera.org:8080/14614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a Gerrit-Change-Number: 14614 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada
[Impala-ASF-CR] IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >d characters
Hello Kudu Jenkins, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14614 to review the following change. Change subject: IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >=64 characters This adds a workaround for an upstream SASL bug which is triggered when the FQDN has more than 64 characters. In this case, SASL would truncate the FQDN and not be able to find the relevant keytab. The workaround simply uses our own code to determine the FQDN. Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a Reviewed-on: http://gerrit.cloudera.org:8080/14609 Reviewed-by: Anurag Mantripragada Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins --- M be/src/kudu/rpc/server_negotiation.cc 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/14614/1 -- To view, visit http://gerrit.cloudera.org:8080/14614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a Gerrit-Change-Number: 14614 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] IMPALA-9073: fix test executor concurrency flakiness
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14606 ) Change subject: IMPALA-9073: fix test_executor_concurrency flakiness .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I910028919f248a3bf5de345e9eade9dbc4353ebd Gerrit-Change-Number: 14606 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Fri, 01 Nov 2019 16:51:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9073: fix test executor concurrency flakiness
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14606 ) Change subject: IMPALA-9073: fix test_executor_concurrency flakiness .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5162/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I910028919f248a3bf5de345e9eade9dbc4353ebd Gerrit-Change-Number: 14606 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Fri, 01 Nov 2019 16:51:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8525: Bump CDH BUILD NUMBER to 1582079
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14612 ) Change subject: IMPALA-8525: Bump CDH_BUILD_NUMBER to 1582079 .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4930/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6055d8ab6ea1101a911eaf07807482d66ef94a7d Gerrit-Change-Number: 14612 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 01 Nov 2019 16:05:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8525: Bump CDH BUILD NUMBER to 1582079
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14612 Change subject: IMPALA-8525: Bump CDH_BUILD_NUMBER to 1582079 .. IMPALA-8525: Bump CDH_BUILD_NUMBER to 1582079 This pulls in some changes to libhdfs that will help with Impala-on-S3 performance. Specifically, HDFS-14564: "Add libhdfs APIs for readFully; add readFully to ByteBufferPositionedReadable" Testing: * Ran core tests Change-Id: I6055d8ab6ea1101a911eaf07807482d66ef94a7d --- M bin/impala-config.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/14612/1 -- To view, visit http://gerrit.cloudera.org:8080/14612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6055d8ab6ea1101a911eaf07807482d66ef94a7d Gerrit-Change-Number: 14612 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar
[Impala-ASF-CR] IMPALA-9109: Add top-k metadata loading ranking on catalogd UI
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14600 ) Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI .. Patch Set 3: Code-Review+1 (1 comment) Except for one small issue, the change looks good http://gerrit.cloudera.org:8080/#/c/14600/3/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/14600/3/tests/webserver/test_web_pages.py@378 PS3, Line 378: high_filecount_tbls = response_json["longest_loading_tables"] nit: Could you change the variable name? -- To view, visit http://gerrit.cloudera.org:8080/14600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9305a867d7053cde9acc42dae6e47ee440f1a8bf Gerrit-Change-Number: 14600 Gerrit-PatchSet: 3 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jiawei Wang Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Fri, 01 Nov 2019 11:44:09 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9110: Add table loading time break-down metrics for HdfsTable
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14611 ) Change subject: IMPALA-9110: Add table loading time break-down metrics for HdfsTable .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4929/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5381f9316df588b2004876c6cd9fb7e674085b10 Gerrit-Change-Number: 14611 Gerrit-PatchSet: 1 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 01 Nov 2019 07:31:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 ) Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4928/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Gerrit-Change-Number: 14610 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 01 Nov 2019 06:57:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9110: Add table loading time break-down metrics for HdfsTable
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14611 ) Change subject: IMPALA-9110: Add table loading time break-down metrics for HdfsTable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14611/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/14611/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1238 PS1, Line 1238: if (nullColumnValue_ == null) nullColumnValue_ = FeFsTable.DEFAULT_NULL_COLUMN_VALUE; line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/14611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5381f9316df588b2004876c6cd9fb7e674085b10 Gerrit-Change-Number: 14611 Gerrit-PatchSet: 1 Gerrit-Owner: Jiawei Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 01 Nov 2019 06:47:54 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9110: Add table loading time break-down metrics for HdfsTable
Jiawei Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14611 Change subject: IMPALA-9110: Add table loading time break-down metrics for HdfsTable .. IMPALA-9110: Add table loading time break-down metrics for HdfsTable Catalog table loading currently only records the total loading time. We will need some break-down times, i.e. more detailed time recording on each loading function. We added "table-schema-load-duration", "all-column-stats-load -duration", "all-column-stats-load-duration". And we found that "storage-metadata-load-duration" has already represent partition and file metadata loading. So now we have a more detailed breakdown time for table loading info. Test: Will add test after the first round review. Change-Id: I5381f9316df588b2004876c6cd9fb7e674085b10 --- M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/Table.java 2 files changed, 60 insertions(+), 40 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/14611/1 -- To view, visit http://gerrit.cloudera.org:8080/14611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5381f9316df588b2004876c6cd9fb7e674085b10 Gerrit-Change-Number: 14611 Gerrit-PatchSet: 1 Gerrit-Owner: Jiawei Wang
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 ) Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. Patch Set 2: We usually cherry-pick the Kudu patch so it's easier to track the original change (including the gerrit link to the original Kudu change). I am okay with exception if this is super urgent. -- To view, visit http://gerrit.cloudera.org:8080/14610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Gerrit-Change-Number: 14610 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 01 Nov 2019 06:28:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 ) Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4927/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Gerrit-Change-Number: 14610 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 01 Nov 2019 06:35:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Anurag Mantripragada has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14610 ) Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. This adds a workaround for an upstream SASL bug which is triggered when the FQDN has more than 64 characters. In this case, SASL would truncate the FQDN and not be able to find the relevant keytab. After this change, we do not rely on SASL getting the FQDN but use our own implementation to get FQDN. Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 --- M be/src/kudu/rpc/server_negotiation.cc 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/14610/2 -- To view, visit http://gerrit.cloudera.org:8080/14610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Gerrit-Change-Number: 14610 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 ) Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. Patch Set 2: (1 comment) Kudu made the same change here: https://gerrit.cloudera.org/#/c/14609/. Since it was a small change, I cross-ported it. Shall I wait for the kudu change to get merged? http://gerrit.cloudera.org:8080/#/c/14610/1/be/src/kudu/rpc/server_negotiation.cc File be/src/kudu/rpc/server_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/14610/1/be/src/kudu/rpc/server_negotiation.cc@391 PS1, Line 391: (server_fqdn > nit: server_fqdn == nullptr Done -- To view, visit http://gerrit.cloudera.org:8080/14610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Gerrit-Change-Number: 14610 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 01 Nov 2019 06:13:51 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 ) Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. Patch Set 1: (1 comment) LGTM. Is the plan to do it on Impala side first and then backport it to Kudu ? We usually do changes the other way (i.e. from Kudu side first and then cherry-picked to Impala side). http://gerrit.cloudera.org:8080/#/c/14610/1/be/src/kudu/rpc/server_negotiation.cc File be/src/kudu/rpc/server_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/14610/1/be/src/kudu/rpc/server_negotiation.cc@391 PS1, Line 391: (!server_fqdn nit: server_fqdn == nullptr -- To view, visit http://gerrit.cloudera.org:8080/14610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Gerrit-Change-Number: 14610 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 01 Nov 2019 06:07:08 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14610 Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. This adds a workaround for an upstream SASL bug which is triggered when the FQDN has more than 64 characters. In this case, SASL would truncate the FQDN and not be able to find the relevant keytab. After this change, we do not rely on SASL getting the FQDN but use our own implementation to get FQDN. Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 --- M be/src/kudu/rpc/server_negotiation.cc 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/14610/1 -- To view, visit http://gerrit.cloudera.org:8080/14610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Gerrit-Change-Number: 14610 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada
