[Impala-ASF-CR] IMPALA-8732: Use a serialized descriptor table in TQueryCtx

2019-07-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13772 ) Change subject: IMPALA-8732: Use a serialized descriptor table in TQueryCtx .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8732: Use a serialized descriptor table in TQueryCtx

2019-07-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13772 ) Change subject: IMPALA-8732: Use a serialized descriptor table in TQueryCtx .. IMPALA-8732: Use a serialized descriptor table

[Impala-ASF-CR] WIP: IMPALA-8586: Support download URLs for CDP

2019-07-10 Thread Joe McDonnell (Code Review)
Hello Vihang Karajgaonkar, Fredy Wijaya, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13432 to look at the new patch set (#2). Change subject: WIP: IMPALA-8586: Support download URLs for CDP

[Impala-ASF-CR] IMPALA-8747: Fix string formatting on HS2 connection setup failure

2019-07-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13815 Change subject: IMPALA-8747: Fix string formatting on HS2 connection setup failure .. IMPALA-8747: Fix string formatting on HS2

[Impala-ASF-CR] IMPALA-8732: Use a serialized descriptor table in TQueryCtx

2019-07-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13772 ) Change subject: IMPALA-8732: Use a serialized descriptor table in TQueryCtx .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Revert "build: use thin static archives"

2019-07-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13798 ) Change subject: Revert "build: use thin static archives" .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Revert "build: use thin static archives"

2019-07-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13798 Change subject: Revert "build: use thin static archives" .. Revert "build: use thin static archives" This reverts commit

[Impala-ASF-CR] Revert "build: use thin static archives"

2019-07-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13798 ) Change subject: Revert "build: use thin static archives" .. Revert "build: use thin static archives" This reverts commit

[Impala-ASF-CR] Revert "build: use thin static archives"

2019-07-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13798 ) Change subject: Revert "build: use thin static archives" .. Patch Set 1: Verified+1 This is reverting a small CMake change that broke

[Impala-ASF-CR] IMPALA-8736: test hive parquet codec interop fails on S3

2019-07-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13781 ) Change subject: IMPALA-8736: test_hive_parquet_codec_interop fails on S3 .. Patch Set 2: Code-Review+2 Thanks for fixing this -- To

[Impala-ASF-CR] build: use thin static archives

2019-07-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13775 ) Change subject: build: use thin static archives .. Patch Set 1: I tried this out and I couldn't tell a difference when doing

[Impala-ASF-CR] build: use thin static archives

2019-07-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13775 ) Change subject: build: use thin static archives .. Patch Set 2: Code-Review+2 This makes sense to me. -- To view, visit

[Impala-ASF-CR] IMPALA-8732: Use a serialized descriptor table in TQueryCtx

2019-07-02 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13772 to look at the new patch set (#2). Change subject: IMPALA-8732: Use a serialized descriptor table in TQueryCtx

[Impala-ASF-CR] IMPALA-8732: Use a serialized descriptor table in TQueryCtx

2019-07-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13772 ) Change subject: IMPALA-8732: Use a serialized descriptor table in TQueryCtx .. Patch Set 1: (1 comment)

[Impala-ASF-CR] [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null

2019-07-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13773 ) Change subject: [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null .. Patch Set 2: Code-Review+2 I looked up the

[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 13: Code-Review+2 Rebased,

[Impala-ASF-CR] Remove references to the $IMPALA HOME/thirdparty directory

2019-04-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13092 ) Change subject: Remove references to the $IMPALA_HOME/thirdparty directory .. Patch Set 1: Test failure is a known flaky issue. --

[Impala-ASF-CR] IMPALA-8072: remove junk configs from containers

2019-04-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13104 ) Change subject: IMPALA-8072: remove junk configs from containers .. Patch Set 2: Code-Review+2 Makes sense -- To view, visit

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. IMPALA-8371: Return appropriate error

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12968 Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. IMPALA-8322: Add periodic dirty check of

[Impala-ASF-CR] IMPALA-8119: document how to set heap size in docker

2019-04-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13119 ) Change subject: IMPALA-8119: document how to set heap size in docker .. Patch Set 1: Code-Review+2 Good to get this cleaned up --

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-11 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12968 to look at the new patch set (#3). Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8392: fix parallel docker images build

2019-04-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13053 ) Change subject: IMPALA-8392: fix parallel docker_images build .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Remove references to the $IMPALA HOME/thirdparty directory

2019-04-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13092 Change subject: Remove references to the $IMPALA_HOME/thirdparty directory .. Remove references to the $IMPALA_HOME/thirdparty

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-04-22 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13020 to look at the new patch set (#2). Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard

[Impala-ASF-CR] IMPALA-8766: Change cloud dependencies to use hadoop-cloud-storage

2019-07-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13872 Change subject: IMPALA-8766: Change cloud dependencies to use hadoop-cloud-storage .. IMPALA-8766: Change cloud dependencies to use

[Impala-ASF-CR] [WIP] IMPALA-8732: Prototype for serialized descriptor table

2019-07-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13772 Change subject: [WIP] IMPALA-8732: Prototype for serialized descriptor table .. [WIP] IMPALA-8732: Prototype for serialized descriptor

[Impala-ASF-CR] [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null

2019-07-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13773 ) Change subject: [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null .. Patch Set 1: (3 comments) What is the

[Impala-ASF-CR] [WIP] IMPALA-8821: Use RECOVER PARTITIONS in dataload to get partition metadata

2019-08-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14060 Change subject: [WIP] IMPALA-8821: Use RECOVER PARTITIONS in dataload to get partition metadata .. [WIP] IMPALA-8821: Use RECOVER

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-13 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14026 to look at the new patch set (#6). Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14026 ) Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters .. Patch Set 6: Code-Review+1 Carry +1 -- To

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14026 ) Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-4551: Limit the size of SQL statements

2019-08-13 Thread Joe McDonnell (Code Review)
Hello Bharath Vissapragada, Michael Ho, Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14012 to look at the new patch set (#4). Change subject: IMPALA-4551: Limit the size of SQL statements

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14026 ) Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters .. Patch Set 7: Code-Review+1 Carry +1 -- To

[Impala-ASF-CR] IMPALA-4551: Limit the size of SQL statements

2019-08-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14012 ) Change subject: IMPALA-4551: Limit the size of SQL statements .. Patch Set 6: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4551: Limit the size of SQL statements

2019-08-13 Thread Joe McDonnell (Code Review)
Hello Bharath Vissapragada, Michael Ho, Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14012 to look at the new patch set (#6). Change subject: IMPALA-4551: Limit the size of SQL statements

[Impala-ASF-CR] IMPALA-4551: Limit the size of SQL statements

2019-08-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14012 ) Change subject: IMPALA-4551: Limit the size of SQL statements .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-13 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14026 to look at the new patch set (#8). Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14026 ) Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters .. Patch Set 7: (1 comment)

[Impala-ASF-CR] Revert "build: use thin static archives"

2019-08-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13798 ) Change subject: Revert "build: use thin static archives" .. Patch Set 2: > What was the rationale for this revert? I don't see a

[Impala-ASF-CR] [WIP] IMPALA-8821: Use RECOVER PARTITIONS in dataload to get partition metadata

2019-08-14 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14060 to look at the new patch set (#2). Change subject: [WIP] IMPALA-8821: Use RECOVER PARTITIONS in dataload to get partition metadata

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-13 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14026 to look at the new patch set (#4). Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14026 ) Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-4551: Limit the size of SQL statements

2019-08-12 Thread Joe McDonnell (Code Review)
Hello Bharath Vissapragada, Michael Ho, Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14012 to look at the new patch set (#3). Change subject: IMPALA-4551: Limit the size of SQL statements

[Impala-ASF-CR] IMPALA-4551: Limit the size of SQL statements

2019-08-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14012 ) Change subject: IMPALA-4551: Limit the size of SQL statements .. Patch Set 2: (11 comments)

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14026 ) Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters .. Patch Set 3: (3 comments) Working on a new

[Impala-ASF-CR] IMPALA-8766: Undo hadoop-cloud-storage + HWX Nexus

2019-08-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14024 ) Change subject: IMPALA-8766: Undo hadoop-cloud-storage + HWX Nexus .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8766: Undo hadoop-cloud-storage + HWX Nexus

2019-08-10 Thread Joe McDonnell (Code Review)
Hello Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14024 to look at the new patch set (#3). Change subject: IMPALA-8766: Undo hadoop-cloud-storage + HWX Nexus

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14026 ) Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters .. IMPALA-8685,IMPALA-8677: Use

[Impala-ASF-CR] [WIP] Exclude hive-shim-0.20

2019-08-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14065 Change subject: [WIP] Exclude hive-shim-0.20 .. [WIP] Exclude hive-shim-0.20 Change-Id: Iccecd279759a966551e4451e31a5382fd55baa48 ---

[Impala-ASF-CR] [WIP] Exclude hive-shim-0.20

2019-08-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14065 ) Change subject: [WIP] Exclude hive-shim-0.20 .. Patch Set 1: Not for review -- To view, visit http://gerrit.cloudera.org:8080/14065

[Impala-ASF-CR] IMPALA-8586: Support download URLs for CDP

2019-09-11 Thread Joe McDonnell (Code Review)
Hello Fredy Wijaya, Todd Lipcon, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13432 to look at the new patch set (#4). Change subject: IMPALA-8586: Support download URLs for CDP

[Impala-ASF-CR] IMPALA-8586: Support download URLs for CDP

2019-09-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13432 ) Change subject: IMPALA-8586: Support download URLs for CDP .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-8586: Support download URLs for CDP

2019-09-09 Thread Joe McDonnell (Code Review)
Hello Fredy Wijaya, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13432 to look at the new patch set (#3). Change subject: IMPALA-8586: Support download URLs for CDP

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 7: (2 comments) Overall, this makes sense to me.

[Impala-ASF-CR] IMPALA-8942: Set file format specific split sizes on non-block stores

2019-09-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14247 ) Change subject: IMPALA-8942: Set file format specific split sizes on non-block stores .. Patch Set 1: (1 comment) First pass, the

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 1: Code-Review+1 This makes sense to me. (I'm willing to

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 9: Code-Review+2 (3 comments) Couple nits, but

[Impala-ASF-CR] IMPALA-8586: Support download URLs for CDP

2019-09-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13432 ) Change subject: IMPALA-8586: Support download URLs for CDP .. IMPALA-8586: Support download URLs for CDP

[Impala-ASF-CR] IMPALA-8785: give debug docker images a different name

2019-07-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13905 ) Change subject: IMPALA-8785: give debug docker images a different name .. Patch Set 9: (3 comments) This makes sense. A couple small

[Impala-ASF-CR] IMPALA-8785: give debug docker images a different name

2019-07-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13905 ) Change subject: IMPALA-8785: give debug docker images a different name .. Patch Set 11: Code-Review+2 This looks good to me -- To

[Impala-ASF-CR] IMPALA-8516: Fix the sha512sum check for the Maven download

2019-07-31 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13876 ) Change subject: IMPALA-8516: Fix the sha512sum check for the Maven download .. Patch Set 1: This makes sense to me. Does this have

[Impala-ASF-CR] IMPALA-8820: fix start-impala-cluster catalogd startup

2019-07-31 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13971 ) Change subject: IMPALA-8820: fix start-impala-cluster catalogd startup .. Patch Set 2: Code-Review+2 This makes sense to me -- To

[Impala-ASF-CR] IMPALA-8816: reduce custom cluster test runtime in core

2019-08-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13967 ) Change subject: IMPALA-8816: reduce custom cluster test runtime in core .. Patch Set 8: (1 comment) One final nit

[Impala-ASF-CR] IMPALA-4551: Limit the size of SQL statements

2019-08-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14012 Change subject: IMPALA-4551: Limit the size of SQL statements .. IMPALA-4551: Limit the size of SQL statements Various BI tools

[Impala-ASF-CR] IMPALA-4551: Limit the size of SQL statements

2019-08-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14012 ) Change subject: IMPALA-4551: Limit the size of SQL statements .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14026 Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters .. IMPALA-8685,IMPALA-8677: Use consistent

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-06 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14026 to look at the new patch set (#2). Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14026 ) Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14026 ) Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters .. Patch Set 2: I'm still thinking through the

[Impala-ASF-CR] IMPALA-8766: Exorcise hadoop-cloud-storage + HWX Nexus

2019-08-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14024 Change subject: IMPALA-8766: Exorcise hadoop-cloud-storage + HWX Nexus .. IMPALA-8766: Exorcise hadoop-cloud-storage + HWX Nexus

[Impala-ASF-CR] IMPALA-8766: Undo hadoop-cloud-storage + HWX Nexus

2019-08-08 Thread Joe McDonnell (Code Review)
Hello Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14024 to look at the new patch set (#2). Change subject: IMPALA-8766: Undo hadoop-cloud-storage + HWX Nexus

[Impala-ASF-CR] IMPALA-4551: Limit the size of SQL statements

2019-08-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14012 ) Change subject: IMPALA-4551: Limit the size of SQL statements .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4551: Limit the size of SQL statements

2019-08-09 Thread Joe McDonnell (Code Review)
Hello Bharath Vissapragada, Michael Ho, Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14012 to look at the new patch set (#2). Change subject: IMPALA-4551: Limit the size of SQL statements

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-09 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14026 to look at the new patch set (#3). Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

[Impala-ASF-CR] IMPALA-8766: Change cloud dependencies to use hadoop-cloud-storage

2019-07-22 Thread Joe McDonnell (Code Review)
Hello Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13872 to look at the new patch set (#4). Change subject: IMPALA-8766: Change cloud dependencies to use hadoop-cloud-storage

[Impala-ASF-CR] IMPALA-8766: Change cloud dependencies to use hadoop-cloud-storage

2019-07-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13872 ) Change subject: IMPALA-8766: Change cloud dependencies to use hadoop-cloud-storage .. Patch Set 1: Investigating whether this works

[Impala-ASF-CR] IMPALA-8766: Change cloud dependencies to use hadoop-cloud-storage

2019-07-18 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13872 to look at the new patch set (#2). Change subject: IMPALA-8766: Change cloud dependencies to use hadoop-cloud-storage

[Impala-ASF-CR] IMPALA-8766: Change cloud dependencies to use hadoop-cloud-storage

2019-07-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13872 ) Change subject: IMPALA-8766: Change cloud dependencies to use hadoop-cloud-storage .. Patch Set 2: Nexus needs https. -- To view,

[Impala-ASF-CR] IMPALA-8176: Convert simple backend tests to the unified executable

2019-07-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/13515 ) Change subject: IMPALA-8176: Convert simple backend tests to the unified executable .. IMPALA-8176: Convert simple backend tests to the

[Impala-ASF-CR] IMPALA-8176: Convert simple backend tests to the unified executable

2019-07-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/13515 ) Change subject: IMPALA-8176: Convert simple backend tests to the unified executable .. IMPALA-8176: Convert simple backend tests to the

[Impala-ASF-CR] IMPALA-8176: Convert simple backend tests to the unified executable

2019-07-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13515 ) Change subject: IMPALA-8176: Convert simple backend tests to the unified executable .. Patch Set 6: (14 comments)

[Impala-ASF-CR] IMPALA-8176: Convert simple backend tests to the unified executable

2019-07-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13515 ) Change subject: IMPALA-8176: Convert simple backend tests to the unified executable .. Patch Set 6: This changes the *Tests

[Impala-ASF-CR] IMPALA-8176: Convert simple backend tests to the unified executable

2019-07-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13515 ) Change subject: IMPALA-8176: Convert simple backend tests to the unified executable .. IMPALA-8176: Convert simple backend

[Impala-ASF-CR] IMPALA-8766: Change cloud dependencies to use hadoop-cloud-storage

2019-07-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13872 ) Change subject: IMPALA-8766: Change cloud dependencies to use hadoop-cloud-storage .. Patch Set 3: The alternative to this is to add

[Impala-ASF-CR] IMPALA-8766: Change cloud dependencies to use hadoop-cloud-storage

2019-07-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13872 ) Change subject: IMPALA-8766: Change cloud dependencies to use hadoop-cloud-storage .. IMPALA-8766: Change cloud dependencies

[Impala-ASF-CR] IMPALA-8425: part 2: avoid chown when building containers

2019-07-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13699 ) Change subject: IMPALA-8425: part 2: avoid chown when building containers .. Patch Set 3: Code-Review+2 Thanks, this looks good --

[Impala-ASF-CR] IMPALA-8686: docker entrypoint script execs daemon

2019-07-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13682 ) Change subject: IMPALA-8686: docker entrypoint script execs daemon .. Patch Set 3: Code-Review+2 Looks good -- To view, visit

[Impala-ASF-CR] IMPALA-8785: give debug docker images a different name

2019-07-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13905 ) Change subject: IMPALA-8785: give debug docker images a different name .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8785: give debug docker images a different name

2019-07-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13905 ) Change subject: IMPALA-8785: give debug docker images a different name .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8766: Restrict hadoop-cloud-storage to USE CDP HIVE=true

2019-07-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13929 Change subject: IMPALA-8766: Restrict hadoop-cloud-storage to USE_CDP_HIVE=true .. IMPALA-8766: Restrict hadoop-cloud-storage to

[Impala-ASF-CR] IMPALA-8942: Set file format specific split sizes on non-block stores

2019-09-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14247 ) Change subject: IMPALA-8942: Set file format specific split sizes on non-block stores .. Patch Set 4: Code-Review+2 This looks good

[Impala-ASF-CR] IMPALA-3926: part 1: bump toolchain for rpath fixes

2019-09-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14274 ) Change subject: IMPALA-3926: part 1: bump toolchain for rpath fixes .. Patch Set 2: Code-Review+2 -- To view, visit

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 13: Code-Review+2 Looks good -- To view, visit

[Impala-ASF-CR] IMPALA-8942: Set file format specific split sizes on non-block stores

2019-09-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14247 ) Change subject: IMPALA-8942: Set file format specific split sizes on non-block stores .. Patch Set 3: Code-Review+1 (2 comments) I

[native-toolchain-CR] IMPALA-8977: Update version of maven used for building docker containers

2019-09-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14326 Change subject: IMPALA-8977: Update version of maven used for building docker containers .. IMPALA-8977: Update version of maven used

[Impala-ASF-CR] IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp

2019-09-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14311 ) Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Fix --webserver interface for remote cluster tests

2019-09-27 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14313 ) Change subject: Fix --webserver_interface for remote cluster tests .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8942: Set file format specific split sizes on non-block stores

2019-09-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14247 ) Change subject: IMPALA-8942: Set file format specific split sizes on non-block stores .. Patch Set 5: Code-Review+2 -- To view,

<    3   4   5   6   7   8   9   10   11   12   >