[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile

2019-03-27 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 ) Change subject: IMPALA-7982: Add host network usage to profile .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10551: Add result sink support for external frontends

2021-03-12 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17144 ) Change subject: IMPALA-10551: Add result sink support for external frontends .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-10551: Add result sink support for external frontends

2021-03-12 Thread John Sherman (Code Review)
Hello Aman Sinha, Thomas Tauber-Marshall, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17144 to look at the new patch set (#7). Change subject: IMPALA-10551: Add result sink support for external frontends

[Impala-ASF-CR] IMPALA-10552: External Frontend CTAS support

2021-03-14 Thread John Sherman (Code Review)
Hello Thomas Tauber-Marshall, Kurt Deschler, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17145 to look at the new patch set (#6). Change subject: IMPALA-10552: External Frontend CTAS support

[Impala-ASF-CR] IMPALA-10552: Support external frontends supplying timeline for profile

2021-03-14 Thread John Sherman (Code Review)
John Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17183 Change subject: IMPALA-10552: Support external frontends supplying timeline for profile .. IMPALA-10552: Support external frontends

[Impala-ASF-CR] IMPALA-10553: External Frontend CTAS support

2021-03-14 Thread John Sherman (Code Review)
Hello Thomas Tauber-Marshall, Kurt Deschler, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17145 to look at the new patch set (#7). Change subject: IMPALA-10553: External Frontend CTAS support

[Impala-ASF-CR] IMPALA-10553: External Frontend CTAS support

2021-03-14 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17145 ) Change subject: IMPALA-10553: External Frontend CTAS support .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-10551: Add result sink support for external frontends

2021-03-10 Thread John Sherman (Code Review)
Hello Aman Sinha, Thomas Tauber-Marshall, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17144 to look at the new patch set (#4). Change subject: IMPALA-10551: Add result sink support for external frontends

[Impala-ASF-CR] IMPALA-10551: Add result sink support for external frontends

2021-03-10 Thread John Sherman (Code Review)
Hello Aman Sinha, Thomas Tauber-Marshall, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17144 to look at the new patch set (#6). Change subject: IMPALA-10551: Add result sink support for external frontends

[Impala-ASF-CR] IMPALA-10551: Add result sink support for external frontends

2021-03-10 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17144 ) Change subject: IMPALA-10551: Add result sink support for external frontends .. Patch Set 6: (7 comments) Thanks Joe, I think the

[Impala-ASF-CR] IMPALA-10551: Add result sink support for external frontends

2021-03-10 Thread John Sherman (Code Review)
Hello Aman Sinha, Thomas Tauber-Marshall, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17144 to look at the new patch set (#5). Change subject: IMPALA-10551: Add result sink support for external frontends

[Impala-ASF-CR] IMPALA-10552: Support external frontends supplying timeline for profile

2021-03-19 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17183 ) Change subject: IMPALA-10552: Support external frontends supplying timeline for profile .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10552: Support external frontends supplying timeline for profile

2021-03-19 Thread John Sherman (Code Review)
Hello Thomas Tauber-Marshall, Kurt Deschler, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17183 to look at the new patch set (#2). Change subject: IMPALA-10552: Support external frontends supplying timeline for profile

[Impala-ASF-CR] IMPALA-10552: Support external frontends supplying timeline for profile

2021-03-15 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17183 ) Change subject: IMPALA-10552: Support external frontends supplying timeline for profile .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10551: Add result sink support for external frontends

2021-03-15 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17144 ) Change subject: IMPALA-10551: Add result sink support for external frontends .. Patch Set 7: > (1 comment) > > Apart from the

[Impala-ASF-CR] IMPALA-10553: External Frontend CTAS support

2021-03-15 Thread John Sherman (Code Review)
Hello Thomas Tauber-Marshall, Kurt Deschler, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17145 to look at the new patch set (#8). Change subject: IMPALA-10553: External Frontend CTAS support

[Impala-ASF-CR] IMPALA-10553: External Frontend CTAS support

2021-03-15 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17145 ) Change subject: IMPALA-10553: External Frontend CTAS support .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-10550: Add External Frontend service port

2021-02-26 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17125 ) Change subject: IMPALA-10550: Add External Frontend service port .. Patch Set 5: For clarity - for now it'll be the responsibility of

[Impala-ASF-CR] IMPALA-10550: Add External Frontend service port

2021-03-01 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17125 ) Change subject: IMPALA-10550: Add External Frontend service port .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-10550: Add External Frontend service port

2021-03-01 Thread John Sherman (Code Review)
Hello Aman Sinha, Thomas Tauber-Marshall, Kurt Deschler, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17125 to look at the new patch set (#6). Change subject: IMPALA-10550: Add External Frontend service port

[Impala-ASF-CR] IMPALA-10551: Add result sink support for external frontends

2021-03-01 Thread John Sherman (Code Review)
Hello Aman Sinha, Thomas Tauber-Marshall, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17144 to look at the new patch set (#2). Change subject: IMPALA-10551: Add result sink support for external frontends

[Impala-ASF-CR] IMPALA-10551: Add result sink support for external frontends

2021-03-01 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17144 ) Change subject: IMPALA-10551: Add result sink support for external frontends .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-10550: Add External Frontend service port

2021-03-02 Thread John Sherman (Code Review)
Hello Aman Sinha, Thomas Tauber-Marshall, Kurt Deschler, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17125 to look at the new patch set (#9). Change subject: IMPALA-10550: Add External Frontend service port

[Impala-ASF-CR] IMPALA-10550: Add External Frontend service port

2021-03-02 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17125 ) Change subject: IMPALA-10550: Add External Frontend service port .. Patch Set 8: I'll investigate the failure(s). Initial look was it

[Impala-ASF-CR] IMPALA-10552: External Frontend CTAS support

2021-03-08 Thread John Sherman (Code Review)
Hello Thomas Tauber-Marshall, Kurt Deschler, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17145 to look at the new patch set (#3). Change subject: IMPALA-10552: External Frontend CTAS support

[Impala-ASF-CR] IMPALA-10552: External Frontend CTAS support

2021-03-08 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17145 ) Change subject: IMPALA-10552: External Frontend CTAS support .. Patch Set 3: (11 comments)

[Impala-ASF-CR] IMPALA-10552: External Frontend CTAS support

2021-03-08 Thread John Sherman (Code Review)
Hello Thomas Tauber-Marshall, Kurt Deschler, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17145 to look at the new patch set (#4). Change subject: IMPALA-10552: External Frontend CTAS support

[Impala-ASF-CR] IMPALA-10552: External Frontend CTAS support

2021-03-08 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17145 ) Change subject: IMPALA-10552: External Frontend CTAS support .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10552: External Frontend CTAS support

2021-03-08 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17145 ) Change subject: IMPALA-10552: External Frontend CTAS support .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-10552: External Frontend CTAS support

2021-03-08 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17145 ) Change subject: IMPALA-10552: External Frontend CTAS support .. Patch Set 4: (3 comments) Thanks Joe for the feedback

[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive

2021-03-07 Thread John Sherman (Code Review)
John Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17094 ) Change subject: IMPALA-9218: Add support for locally compiled Hive .. IMPALA-9218: Add support for locally compiled Hive - Add

[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive

2021-03-07 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17094 ) Change subject: IMPALA-9218: Add support for locally compiled Hive .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive

2021-03-07 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17094 ) Change subject: IMPALA-9218: Add support for locally compiled Hive .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-10551: Add result sink support for external frontends

2021-03-07 Thread John Sherman (Code Review)
Hello Aman Sinha, Thomas Tauber-Marshall, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17144 to look at the new patch set (#3). Change subject: IMPALA-10551: Add result sink support for external frontends

[Impala-ASF-CR] IMPALA-10552: External Frontend CTAS support

2021-03-07 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17145 ) Change subject: IMPALA-10552: External Frontend CTAS support .. Patch Set 2: gerrit-verify-dryrun-external -- To view, visit

[Impala-ASF-CR] IMPALA-10551: Add result sink support for external frontends

2021-03-01 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17144 ) Change subject: IMPALA-10551: Add result sink support for external frontends .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10551: Add result sink support for external frontends

2021-03-01 Thread John Sherman (Code Review)
Hello Aman Sinha, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/17144 to review the following change. Change subject: IMPALA-10551: Add result sink support for external frontends ..

[Impala-ASF-CR] IMPALA-10552: External Frontend CTAS support

2021-03-01 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17145 ) Change subject: IMPALA-10552: External Frontend CTAS support .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10552: External Frontend CTAS support

2021-03-01 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17145 ) Change subject: IMPALA-10552: External Frontend CTAS support .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10552: External Frontend CTAS support

2021-03-01 Thread John Sherman (Code Review)
Hello Kurt Deschler, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/17145 to review the following change. Change subject: IMPALA-10552: External Frontend CTAS support .. IMPALA-10552:

[Impala-ASF-CR] IMPALA-10657: Remove accidental usage of shaded imports

2021-04-13 Thread John Sherman (Code Review)
John Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17314 Change subject: IMPALA-10657: Remove accidental usage of shaded imports .. IMPALA-10657: Remove accidental usage of shaded imports -

[Impala-ASF-CR] IMPALA-12414: Add scripts to run Trino in the dev environment

2023-08-31 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20444 ) Change subject: IMPALA-12414: Add scripts to run Trino in the dev environment .. Patch Set 1: Code-Review+1 (1 comment) my nit is

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

2023-03-06 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19537 ) Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

2023-03-06 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19537 ) Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

2023-03-06 Thread John Sherman (Code Review)
Hello Aman Sinha, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19537 to look at the new patch set (#3). Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

2023-02-27 Thread John Sherman (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19537 to look at the new patch set (#2). Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

2023-02-24 Thread John Sherman (Code Review)
John Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19537 Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend .. IMPALA-11946: Add Thrift HTTP support for external