[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-01-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 1: (9 comments)

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 6: ping. -- To view, visit

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-08 Thread Vuk Ercegovac (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, Lars Volker, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8890 to look at the new patch set (#3). Change subject: IMPALA-3526: update FE tests to pass on S3

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 2: For an explanation for the plan difference, pls have a look

[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators

2018-01-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8942 ) Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-3887: Wait for HDFS replication in data loading

2017-12-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8916 ) Change subject: IMPALA-3887: Wait for HDFS replication in data loading .. Patch Set 1: (1 comment) thanks for the fix-- I just have a

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2017-12-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 2: I thought about it, but since it was relatively localized,

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2017-12-21 Thread Vuk Ercegovac (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8890 to look at the new patch set (#2). Change subject: IMPALA-3526: update FE tests to pass on S3

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2017-12-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2017-12-20 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 3: all tests pass with s3 -- To view, visit

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2017-12-20 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] Revert "IMPALA-3887: Wait for HDFS replication in data loading"

2017-12-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has abandoned this change. ( http://gerrit.cloudera.org:8080/8879 ) Change subject: Revert "IMPALA-3887: Wait for HDFS replication in data loading" .. Abandoned going w/ dave's patch -- To view, visit

[Impala-ASF-CR] Revert "IMPALA-3887: Wait for HDFS replication in data loading"

2017-12-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8879 Change subject: Revert "IMPALA-3887: Wait for HDFS replication in data loading" .. Revert "IMPALA-3887: Wait for HDFS replication in

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 7: Code-Review+1 lgtm, thanks for the

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 6: (3 comments) several more follow-up

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 6: Code-Review+1 Carry +1 from Lars -- To view,

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-13 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#6). Change subject: IMPALA-4993: extend dictionary filtering to collections ..

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls (wip)

2017-12-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls (wip) .. IMPALA-5931: Generates scan ranges in planner for

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-13 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#5). Change subject: IMPALA-4993: extend dictionary filtering to collections ..

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 4: (8 comments)

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 4: (20 comments) thanks for the changes!

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 3: updating two more tests that core-tests found

[Impala-ASF-CR] IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT

2017-12-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT .. Patch Set 2: (4 comments) thanks for the updates!

[Impala-ASF-CR] [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI.

2017-12-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8529 ) Change subject: [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI. .. Patch Set 3: Code-Review+1 (6 comments) mostly

[Impala-ASF-CR] IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT

2017-12-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT .. Patch Set 1: (7 comments) Thanks for the change!

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-11 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#3). Change subject: IMPALA-4993: extend dictionary filtering to collections ..

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 3: planner tests: adds a test and updates where

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-11 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#2). Change subject: IMPALA-4993: extend dictionary filtering to collections ..

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 1: (19 comments) thx for the reviews.

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 7: Code-Review+1 (3 comments) thanks for the

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 6: (4 comments) I have some questions on the

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 1: (6 comments) still getting the hang of

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8775 Change subject: IMPALA-4993: extend dictionary filtering to collections .. IMPALA-4993: extend dictionary filtering to collections

[Impala-ASF-CR] IMPALA-6273: fixes subquery tests for functional hbase

2017-12-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8765 ) Change subject: IMPALA-6273: fixes subquery tests for functional_hbase .. Patch Set 3: reduced the number of tests that explicitly

[Impala-ASF-CR] IMPALA-6273: fixes subquery tests for functional hbase

2017-12-05 Thread Vuk Ercegovac (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8765 to look at the new patch set (#2). Change subject: IMPALA-6273: fixes subquery tests for functional_hbase ..

[Impala-ASF-CR] IMPALA-6273: fixes subquery tests for functional hbase

2017-12-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8765 ) Change subject: IMPALA-6273: fixes subquery tests for functional_hbase .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-1422: support a constant on LHS of IN predicates.

2017-12-01 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8322 to look at the new patch set (#13). Change subject: IMPALA-1422: support a constant on LHS of IN predicates.

[Impala-ASF-CR] IMPALA-1422: support a constant on LHS of IN predicates.

2017-12-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8322 ) Change subject: IMPALA-1422: support a constant on LHS of IN predicates. .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-1422: support a constant on LHS of IN predicates.

2017-12-01 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8322 to look at the new patch set (#12). Change subject: IMPALA-1422: support a constant on LHS of IN predicates.

[Impala-ASF-CR] IMPALA-1422: support a constant on LHS of IN predicates.

2017-12-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8322 ) Change subject: IMPALA-1422: support a constant on LHS of IN predicates. .. Patch Set 11: updates alias generation to use

[Impala-ASF-CR] IMPALA-1422: support a constant on LHS of IN predicates.

2017-11-30 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8322 to look at the new patch set (#10). Change subject: IMPALA-1422: support a constant on LHS of IN predicates.

[Impala-ASF-CR] IMPALA-1422: support a constant on LHS of IN predicates.

2017-11-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8322 ) Change subject: IMPALA-1422: support a constant on LHS of IN predicates. .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-1422: support a constant on LHS of IN predicates.

2017-11-30 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8322 to look at the new patch set (#9). Change subject: IMPALA-1422: support a constant on LHS of IN predicates.

[Impala-ASF-CR] IMPALA-1422: support a constant on LHS of IN predicates.

2017-11-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8322 ) Change subject: IMPALA-1422: support a constant on LHS of IN predicates. .. Patch Set 8: (24 comments)

[Impala-ASF-CR] IMPALA-6092: avoid drop/create function interactions in e2e tests

2017-11-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8593 ) Change subject: IMPALA-6092: avoid drop/create function interactions in e2e tests .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4985: use parquet stats of nested types for dynamic pruning

2017-11-21 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8480 to look at the new patch set (#7). Change subject: IMPALA-4985: use parquet stats of nested types for dynamic pruning

[Impala-ASF-CR] IMPALA-4985: use parquet stats of nested types for dynamic pruning

2017-11-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8480 ) Change subject: IMPALA-4985: use parquet stats of nested types for dynamic pruning .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-4985: use parquet stats of nested types for dynamic pruning

2017-11-21 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8480 to look at the new patch set (#6). Change subject: IMPALA-4985: use parquet stats of nested types for dynamic pruning

[Impala-ASF-CR] IMPALA-6092: avoid drop/create function interactions in e2e tests

2017-11-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8593 ) Change subject: IMPALA-6092: avoid drop/create function interactions in e2e tests .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6092: avoid drop/create function interactions in e2e tests

2017-11-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8593 ) Change subject: IMPALA-6092: avoid drop/create function interactions in e2e tests .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4985: use parquet stats of nested types for dynamic pruning

2017-11-20 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8480 to look at the new patch set (#5). Change subject: IMPALA-4985: use parquet stats of nested types for dynamic pruning

[Impala-ASF-CR] IMPALA-6092: avoid drop/create function interactions in e2e tests

2017-11-20 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8593 ) Change subject: IMPALA-6092: avoid drop/create function interactions in e2e tests .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6092: avoid drop/create function interactions in e2e tests

2017-11-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8593 Change subject: IMPALA-6092: avoid drop/create function interactions in e2e tests .. IMPALA-6092: avoid drop/create function

[Impala-ASF-CR] IMPALA-6198: marks a test as debug-only

2017-11-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8573 Change subject: IMPALA-6198: marks a test as debug-only .. IMPALA-6198: marks a test as debug-only The test_catalog_wait test uses

<    3   4   5   6   7   8